[GitHub] spark pull request #19100: [SPARK-21891] [SQL] Add TBLPROPERTIES to DDL stat...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19100: [SPARK-21891] [SQL] Add TBLPROPERTIES to DDL stat...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19100#discussion_r136607388
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuerySuite.scala
---
@@ -117,4 +117,12 @@ class OptimizeMetadataOnlyQuerySuite extends QueryTest
with SharedSQLContext {
"select partcol1, max(partcol2) from srcpart where partcol1 = 0 group
by rollup (partcol1)",
"select partcol2 from (select partcol2 from srcpart where partcol1 = 0
union all " +
"select partcol2 from srcpart where partcol1 = 1) t group by
partcol2")
+
+ test("SPARK-21884 Fix StackOverflowError on MetadataOnlyQuery") {
--- End diff --
+1 for preventing futhre regressino.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19100: [SPARK-21891] [SQL] Add TBLPROPERTIES to DDL stat...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19100#discussion_r136473016
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuerySuite.scala
---
@@ -117,4 +117,12 @@ class OptimizeMetadataOnlyQuerySuite extends QueryTest
with SharedSQLContext {
"select partcol1, max(partcol2) from srcpart where partcol1 = 0 group
by rollup (partcol1)",
"select partcol2 from (select partcol2 from srcpart where partcol1 = 0
union all " +
"select partcol2 from srcpart where partcol1 = 1) t group by
partcol2")
+
+ test("SPARK-21884 Fix StackOverflowError on MetadataOnlyQuery") {
--- End diff --
Here, just add a test case from https://github.com/apache/spark/pull/19094
for verifying the fix in https://github.com/apache/spark/pull/18686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19100: [SPARK-21891] [SQL] Add TBLPROPERTIES to DDL stat...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19100#discussion_r136472066 --- Diff: sql/core/src/test/resources/sql-tests/results/cross-join.sql.out --- @@ -128,6 +128,7 @@ two 2 two 2 one 1 two 2 two2 two 2 three 3 two 2 two2 two 2 two 2 two 2 + --- End diff -- This was automatically added by`SQLQueryTestSuite` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #19100: [SPARK-21891] [SQL] Add TBLPROPERTIES to DDL stat...
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19100 [SPARK-21891] [SQL] Add TBLPROPERTIES to DDL statement: CREATE TABLE USING ## What changes were proposed in this pull request? Add `TBLPROPERTIES` to the DDL statement `CREATE TABLE USING`. After this change, the DDL becomes ``` CREATE [TEMPORARY] TABLE [IF NOT EXISTS] [db_name.]table_name USING table_provider [OPTIONS table_property_list] [PARTITIONED BY (col_name, col_name, ...)] [CLUSTERED BY (col_name, col_name, ...) [SORTED BY (col_name [ASC|DESC], ...)] INTO num_buckets BUCKETS ] [LOCATION path] [COMMENT table_comment] [TBLPROPERTIES (property_name=property_value, ...)] [[AS] select_statement]; ``` ## How was this patch tested? Add a few tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/gatorsmile/spark addTablePropsToCreateTableUsing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/19100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19100 commit 4be45f77f879b76817e85c1bb7307aea6772b332 Author: gatorsmile Date: 2017-08-31T23:03:47Z fix. commit 7dbd81039a129276e75e51e4bf8cb7b7191e14e7 Author: gatorsmile Date: 2017-08-31T23:30:13Z fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
