[GitHub] spark pull request #20455: [SPARK-23284][SQL] Document the behavior of sever...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20455 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20455: [SPARK-23284][SQL] Document the behavior of sever...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20455#discussion_r165324640
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -1261,4 +1269,38 @@ class ColumnarBatchSuite extends SparkFunSuite {
batch.close()
allocator.close()
}
+
+ testVector("getDecimal should return null for null slot", 4,
DecimalType.IntDecimal) {
--- End diff --
shall we make it a normal test case for decimal type? we can follow the
other tests, e.g. create a decimal array, and check the value of column vector
at the same index.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20455: [SPARK-23284][SQL] Document the behavior of sever...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20455#discussion_r165300767
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -1261,4 +1261,140 @@ class ColumnarBatchSuite extends SparkFunSuite {
batch.close()
allocator.close()
}
+
+ testVector("getUTF8String should return null for null slot", 4,
StringType) {
--- End diff --
Seems we don't have individual tests for binary type and decimal type?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20455: [SPARK-23284][SQL] Document the behavior of sever...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20455#discussion_r165298199
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -1261,4 +1261,140 @@ class ColumnarBatchSuite extends SparkFunSuite {
batch.close()
allocator.close()
}
+
+ testVector("getUTF8String should return null for null slot", 4,
StringType) {
--- End diff --
That sounds ok to me. I'll commit the change by tonight.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20455: [SPARK-23284][SQL] Document the behavior of sever...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20455#discussion_r165292391
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -1261,4 +1261,140 @@ class ColumnarBatchSuite extends SparkFunSuite {
batch.close()
allocator.close()
}
+
+ testVector("getUTF8String should return null for null slot", 4,
StringType) {
--- End diff --
we already have test cases for each type, can we just change the existing
test cases a little to add this null check?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
