[GitHub] spark pull request #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22592 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI...
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22592#discussion_r221443587
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
---
@@ -206,11 +238,8 @@ private[ui] abstract class ExecutionTable(
}
def toNodeSeq(request: HttpServletRequest): Seq[Node] = {
-
- {tableName}
--- End diff --
> It's just a detail, but I was unclear why you don't need the table name
anymore.
Table name for running executions was 'Running Queries ({running.size})',
for completed executions was 'Completed Queries ({completed.size})' and for
failed executions was 'Failed Queries ({failed.size})'.
This is already there in the code, inside if condition.
```
Running Queries ({running.size})
```
So, the table name is no longer required in this case.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22592#discussion_r221440824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
---
@@ -206,11 +238,8 @@ private[ui] abstract class ExecutionTable(
}
def toNodeSeq(request: HttpServletRequest): Seq[Node] = {
-
- {tableName}
--- End diff --
It's just a detail, but I was unclear why you don't need the table name
anymore. It's because all other code paths already render the table name, and
`UIUtils.listingTable` does the rest?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI...
GitHub user shahidki31 opened a pull request:
https://github.com/apache/spark/pull/22592
[SPARK-25575][WEBUI][SQL] SQL tab in the spark UI support hide tables, to
make it consistent with other tabs.
## What changes were proposed in this pull request?
Currently, SQL tab in the WEBUI doesn't support hiding table. Other tabs in
the web ui like, Jobs, stages etc supports hiding table (refer SPARK-23024
https://github.com/apache/spark/pull/20216).
In this PR, added the support for hide table in the sql tab also.
## How was this patch tested?
bin/spark-shell
```
sql("create table a (id int)")
for(i <- 1 to 100) sql(s"insert into a values ($i)")
```
Open SQL tab in the web UI
**Before fix:**
**After fix:**
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shahidki31/spark SPARK-25575
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22592.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22592
commit ef40698e107090d69e06f41194eb68673791b6d8
Author: Shahid
Date: 2018-09-29T16:48:07Z
Spark SQL ui about the contents of the form need to have hidden and show
features, when the table records very much.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
