[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22838 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22838#discussion_r228494668
--- Diff:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
---
@@ -103,4 +104,4 @@ then
properties=( ${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS )
fi
-$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pkubernetes ${properties[@]}
+$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION
-Pkubernetes-integration-tests ${properties[@]}
--- End diff --
Yes it is needed since kubernetes is not a module of the tests profile. I
updated the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22838#discussion_r228363727
--- Diff:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
---
@@ -103,4 +104,4 @@ then
properties=( ${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS )
fi
-$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pkubernetes ${properties[@]}
+$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION
-Pkubernetes-integration-tests ${properties[@]}
--- End diff --
@skonto don't you need `-Pkubernetes` here too?
Otherwise, I don't even think we need to wait for another test. The exact
POM change above just passed in the other PR and this part won't be tested
anyway. I tested the SCALA_VERSION evaluation manually and it works.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228318094 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core + + + + + kubernetes-tests + + false --- End diff -- I modified the profile to `Pkubernetes-integration-tests` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228317925 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core + + + + + kubernetes-tests + + false --- End diff -- @srowen I just removed it... Yes I know they are just wanted to make it explicit, anyway. Let's merge both ;) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228316721 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core + + + + + kubernetes-tests + + false + --- End diff -- @srowen @dongjoon-hyun I will use `kubernetes-integration-tests` as the profile from the other pr. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228311880 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core + + + + + kubernetes-tests + + false --- End diff -- Ah right I had https://github.com/apache/spark/pull/22829 open; I can close it in favor of this. Nit: the indent is off here. But, you don't need this section at all. Profiles are not active by default. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228316418 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core + + + + + kubernetes-tests + + false + --- End diff -- No just keep this PR --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
