[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4
Sa Dez 11 2010 12:25:30 EST von IGnatius T Foobar @ Uncensored Betreff: Re: [SCM] citadel.org branch, master, updated. 4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4
have a look at that IG, its mostly what you did, plus wrap cunit around it...
I wasn't familiar with CUnit so it's going to take me some time to figure everything out, but it looks like you simply changed my assert() calls to CUnit's equivalents, so yes, that's fine. I will use test_stripallbut.c as a template if I write any more unit tests.
Yes, its pretty straight forward... test_stripallbut.c could rather bee test_stringtools, and add some more tests... stringbuf_test.c contains several tests hooked into one list if you want to have a look at it...
I like the idea of adding unit tests; perhaps in the future we can write some more that connect to citserver and do things like testing the IMAP service for accuracy etc.
I started using imaptest for that; for deeper tests it require us that syntax extension of {n chars of next line} to be implemented.
I started doing that for the nginx imap proxy...
in general imaptest offers a good set of tools to test imap stuff, plus the author idles in #imap and is pretty responsive to questions.
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4
>have a look at that IG, its mostly what you did, plus wrap cunit >around it... I wasn't familiar with CUnit so it's going to take me some time to figure everything out, but it looks like you simply changed my assert() calls to CUnit's equivalents, so yes, that's fine. I will use test_stripallbut.c as a template if I write any more unit tests. I like the idea of adding unit tests; perhaps in the future we can write some more that connect to citserver and do things like testing the IMAP service for accuracy etc.
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4
have a look at that IG, its mostly what you did, plus wrap cunit around it... probably it should be renamed and more tests to the functions from tools.c should be added... Sa Dez 11 2010 10:34:55 EST von "dothebart" Betreff: [SCM] citadel.org branch, master, updated. 4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4 Push to the project "citadel.org ": The branch, master has been updated via 4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4 (commit) from a70ac03ebc6c5de716f6ff71c1663fffe66c4fbe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4 commit 4ba859fe5bed361aa7aa3b5a8c0b7c57d8ada1f4 Author: Wilfried Goesgens Date: Sat Dec 11 16:36:07 2010 +0100 Integrate IGs tests - add to run_tests.sh - wrap c-unit around the test cases... --- Summary of changes: libcitadel/tests/run_tests.sh |2 + libcitadel/tests/stripallbut_test.c | 80 -- 2 files changed, 77 insertions(+), 5 deletions(-) hooks/post-receive -- citadel.org
