> Okay then, done and pushed. Now that I looked closer, I spotted (and
> fixed) a couple of more "issues": a tiny memleak from early
> rpmtsSetupTransactionPlugins() return and some further cosmetics (two
soft-tabs instead of one hard-tab, trailing whitespace etc), but nothing
dramatic.
Thank you! I will seriously try to improve my style. I am not using vim for
code edits, but I think I should probably reconsider it or get some kind of
editor that shows all symbols explicitly. Pain to read but I get it right at
the end :)
>Oh and one other thing I noticed just now that'll need further thought:
>currently the script setup hook only runs for external scripts, but not the
embedded Lua-scripts. Which are getting more and more common...
>They'll obviously need to be handled quite differently as they run within
the rpm process itself, ie fork() + exec() does not occur.
Yes, I don't currently have a very good idea how this case should be
handled. The idea of script hook is that it sets the needed security
context, but we obviously can't do this for lua case unless we want to drop
the whole rpm security context.
As a temporal and draconic measure we can compile rpm without lua support to
close this hole, but it is no-go in the future since it is getting more and
more usage. I guess this is one of the things that I need to think more
about.
> Cool. And thanks for all the work so far :)
I hope this is only the beginning, I am really interested in security part
of rpm!
Best Regards,
Elena.
smime.p7s
Description: S/MIME cryptographic signature
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
