Re: [Rpm-maint] FSM hooks for rpm plugin

[Panu Matilainen]

On 02/20/2013 11:01 AM, Reshetova, Elena wrote:


Hi,


Hi, sorry about the delay... the recent patch-flood on rpm-maint caught me by
surprise :)

Patch flood is always good, total silence is much worse :)


Heh, yup :)


I've cleaned it up somewhat now, for example the early return was just plain
wrong as it would've leaked resources all over the place. But then it also
was a case that could never be reached at all...
The code still looks suspicious in many places and wants further inspection
and sanitizing but achieving symmetrical behavior for the hooks might
actually be possible now. At least its *closer* to that target if not there
yet :)


I think it looks much better now and integrating hooks to it is a pleasure. I
am attaching the new version. Hope I didn't miss any strange case, but it
looked very easy now after your change!


I'm actually going to be mildly surprised if there aren't any strange 
cases we've missed wrt hard links or such :) Anyway, the patch looks as 
obviously-correct as it gets within fsm. Applied, thanks for the patch!


Also with this patch in place, I think all the required bits and pieces 
for moving the entire selinux support into a plugin are there now. Wohoo :)



- Panu -
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] FSM hooks for rpm plugin

[Reshetova, Elena]

I'm actually going to be mildly surprised if there aren't any strange cases 
we've missed wrt hard links or such :) Anyway, the patch looks as 
obviously-correct as it gets within fsm. Applied, thanks for the patch!

Yeah, but I guess we will hopefully find it out soon, when we will be using 
the hooks :)

Also with this patch in place, I think all the required bits and pieces for 
moving the entire selinux support into a plugin are there now. Wohoo :)

This is actually my next question: how should we proceed? There are still some 
hooks (like handling conflicts and policy enforcement on signatures) that I 
would like to be present in rpm (I think other systems like SELinux might 
benefit from them too), and also we were thinking about rearranging the plugin 
initialization and etc.  Or should we first try to move the SELinux to plugin 
to verify that the basic set of hooks works for it?

Best Regards,
Elena.


smime.p7s
Description: S/MIME cryptographic signature
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint