Re: [Rpm-maint] [rpm-software-management/rpm] Tags as an alternative to Groups (#632)
>nobody has stepped up to work out the finer details like a format that is >actually enforced That runs risk of designing something that may turn out bad in 2 years, and then we're stuck with it and go define _another_ field. The freedom of the Group field does not appear to have been a bad choice. Imagine if ewt back in the day had declared that RPM would only ever accept the 34-or-so groups of the time. (Did a small-ish UI program to check how long parsing today's rpmdb that way would take. https://github.com/jengelh/rpm-catalog ) >end up with useless typoed junk like it was with Group. I am not sure what you mean by "typoed junk". Typos (misspellings) happen, even so on tag-heavy systems like Stackoverflow/Freshcode. An approach would be to regularly build an overview and looking for common substrings so as to find and join/normalize e.g. "GPL-3.0" vs "GPLv3". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/632#issuecomment-527691764___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)
Corrected -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/828#issuecomment-527410044___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)
@pavlinamv pushed 1 commit. b2260fbae4087f55615219376906d066db7341ee Disable marker on multiline expression error messages -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/828/files/a4e4aa041761d5eb36a486d1f058989c3a864f59..b2260fbae4087f55615219376906d066db7341ee ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)
Really bothers you, huh?
These are more on the cosmetic side, but nevertheless:
- Use existing string functions (strchr() and friends) instead of manual loops
when possible
- Use short variable names for temporary local strings, such as "s" which is
used all over rpm codebase for such purposes.
- You're adding code, not ripping something out. "Disable marker on multiline
expression error messages" would be more like it (it also isn't limited to
%{expr:...})
- Multiline is typoed "mutiline" in the commit message
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/828#issuecomment-527379676___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)
If the expression after %{expr: is mutiline like:
%{expr: 0 || 0 ||
0 || 0 |o| 0 ||
0 || 0 || 0 }
then it is better not to support marker pointing to the exact
place of the error.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/828
-- Commit Summary --
* Rip the marker support for multiline %{expr:...} error messages
-- File Changes --
M rpmio/expression.c (8)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/828.patch
https://github.com/rpm-software-management/rpm/pull/828.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/828
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
