Re: [Rpm-maint] [rpm-software-management/rpm] Remove "support" for loading keyring from filesystem (#857)
(Except I think that code is still not used by dnf because it dates to the PackageKit C vs yum Python days?) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/857#issuecomment-535674087___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove "support" for loading keyring from filesystem (#857)
Also worth noting https://github.com/rpm-software-management/libdnf/issues/43 (libdnf auto-injects `/etc/pki/rpm-gpg`) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/857#issuecomment-535673882___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove "support" for loading keyring from filesystem (#857)
Ideally we don't want to have to carry a revert to gain the functionality back for the Yocto Project. Is there something else that can be done here other than to remove the code, such as an option with with in the configuration to allow it to continue to function as it does today? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/857#issuecomment-535666480___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Avoid modifying header on export (#870)
Conan-Kudo requested changes on this pull request.
> @@ -68,12 +68,6 @@ static const int typeSizes[16] = {
0
};
-enum headerSorted_e {
-HEADERSORT_NONE= 0,/* Not sorted */
-HEADERSORT_OFFSET = 1,/* Sorted by offset (on-disk format) */
-HEADERSORT_INDEX = 2,/* Sorted by index */
-};
Why are we getting rid of the enum? It seems we're still using the magic
values, shouldn't we keep the names so we know what they're for?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/870#pullrequestreview-293883494___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove "support" for loading keyring from filesystem (#857)
Yes this is actively used by the Yocto Project. It allows us to have a single location in the system that contains all of the software keys, and can be updated dynamically by authorized systems/components. Having to load keys (manually) into the rpm database, makes it very difficult to support devices that can't be serviced and have no console. Instead we can remove old keys and install new keys [passing appropriate selinux/ima/etc security methods] by updating files. It also allows developers to open up devices for user control by installing secondary keys for user-packages to 'unlock' an otherwise locked device. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/857#issuecomment-535605541___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improve "git am" support. (#854)
This looks very cool! I've not had a chance to look at it in-depth, but the first pass looks pretty good! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/854#issuecomment-535604623___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove "support" for loading keyring from filesystem (#857)
(cc: @mhatle @kanavin) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/857#issuecomment-535604121___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make "%patchlist -f patches" work. (#866)
Closed #866. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/866#event-2665980647___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make "%patchlist -f patches" work. (#866)
Don't pull this yet; once I added a test case I realized there's still something wrong with it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/866#issuecomment-535539048___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make "%patchlist -f patches" work. (#866)
@vathpela pushed 1 commit. 99f643c6b8d17ebe99d397f4fa91d2955deecc64 Make "%patchlist -f patches" work. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/866/files/9c4d96081a31acb2d1d06dd5c9f8bf34b2b56260..99f643c6b8d17ebe99d397f4fa91d2955deecc64 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Avoid modifying header on export (#870)
headerExport() is the only thing that needs offset sorting, theres no point messing up with the header itself for this when we can just sort a copy instead. No visible functional changes, but makes headerExport() a read-only operation to the header, as it should be. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/870 -- Commit Summary -- * Refactor the actual work from headerExport() to a helper function * Avoid modifying header on export -- File Changes -- M lib/header.c (63) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/870.patch https://github.com/rpm-software-management/rpm/pull/870.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/870 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add the marker to the appropriate expression error messages (#869)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/869 -- Commit Summary -- * Add the marker to the appropriate expression error messages -- File Changes -- M rpmio/expression.c (15) M tests/rpmmacro.at (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/869.patch https://github.com/rpm-software-management/rpm/pull/869.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/869 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] RPM 4.15.0 released!
After more than two years in development and half a year in testing,
RPM 4.15.0 is finally here!
Highlights include:
- Faster builds on SMP via parallelization
- Dynamic build dependencies
- Support for %elif, %elifos and %elifarch statements in spec
- Caret version operator (the opposite of tilde)
- New %patchlist and %sourcelist spec sections
- New %{expr:…} built-in macro for evaluating expressions
- New %dnl macro primitive for comments
- Support for non-privileged chroot operations (experimental)
- Native support for Lua 5.2-5.3 without compat defines in Lua
- String data is returned as surrogate-escaped utf-8 in Python 3 bindings
- Numerous bugfixes and other enhancements all over the place
For the g(l)ory details and download info, see the release notes at
https://rpm.org/wiki/Releases/4.15.0
On behalf of the rpm-team, thanks to all the people who contributed to
make this possible.
- Panu -
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Preparing for rpm 4.15.0 final (#867)
Merged #867 into rpm-4.15.x. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/867#event-2664615553___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support uncompressed/reconstructed payloads (#861)
I don't think deltarpm would be able to make use of this global source file hash. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/861#issuecomment-535419462___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Arch Specific runtime dependencies for sub package builds (#865)
I think this is a compose problem, not rpm problem: it'd be wrong for rpm to encode some arch-specific knowledge into that noarch package, when that arch-limitation could go away at any time (by that extra package becoming available on that arch). Another line of thought is what dnf did initially and simply hide packages with broken dependencies. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/865#issuecomment-535412556___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Parallel rpmfc thread-safety - libmagic may fork helpers (#756)
For the record, there have been some reports of builds hanging during classification on systems with large number of CPUs using file 5.36 which where fixed by updating to 5.37. Another workaround is to set %_smp_build_nthreads to a smaller number, ultimately 1 to make the whole classification run in serial as it always used to. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/756#issuecomment-535408645___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update CREDITS for last years new contributors (#868)
Merged #868 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/868#event-2664406306___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)
Merged #862 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/862#event-2664403059___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)
pmatilai approved this pull request. Thanks. The danger with including the command at all is that people will think the command failed, but considering I don't think anybody has ever *seen* this fail in the first place, maybe we can live with the "danger" :D -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/862#pullrequestreview-293566148___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Update CREDITS for last years new contributors (#868)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/868 -- Commit Summary -- * Update CREDITS for last years new contributors -- File Changes -- M CREDITS (16) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/868.patch https://github.com/rpm-software-management/rpm/pull/868.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/868 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Preparing for rpm 4.15.0 final (#867)
Actually scratch that, this needs a CREDITS update... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/867#issuecomment-535397533___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)
Commit message is corrected according to @pmatilai's comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/862#issuecomment-535395613___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)
@pavlinamv pushed 1 commit. 75ec68392ece1006f1543bd556f64199257b6b32 Add an error message when rpm fails to open a pipe for shell expansion -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/862/files/e2677384cde95e69e14979ccac8936874c376652..75ec68392ece1006f1543bd556f64199257b6b32 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Preparing for rpm 4.15.0 final (#867)
Pull updated translations from Zanata, bump version to final. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/867 -- Commit Summary -- * Preparing for rpm 4.15.0 final -- File Changes -- M configure.ac (2) M po/ar.po (17) M po/br.po (20) M po/ca.po (49) M po/cs.po (40) M po/da.po (37) M po/de.po (46) M po/eo.po (49) M po/es.po (46) M po/fi.po (37) M po/fr.po (46) M po/id.po (13) M po/is.po (14) M po/it.po (46) M po/ja.po (46) M po/ko.po (37) M po/nb.po (31) M po/nl.po (14) M po/pl.po (68) M po/pt_BR.po (43) M po/ru.po (37) M po/sk.po (46) M po/sl.po (8) M po/sv.po (49) M po/te.po (3) M po/tr.po (40) M po/uk.po (48) M po/vi.po (50) M po/zh_CN.po (49) M po/zh_TW.po (49) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/867.patch https://github.com/rpm-software-management/rpm/pull/867.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/867 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)
Right, I noticed but forgot to mention setting mb->error becoming redundant, thanks. As for the error message, if you grep around a bit you'll notice that the common pattern for these things is: :: ...where is a file name or similar, and in this case it'd be the macro, and is the strerror(errno) / %m. It might actually be the unexpanded macro that makes it easier to trace the origin, but not sure about that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/862#issuecomment-535378758___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)
@pavlinamv pushed 1 commit. e2677384cde95e69e14979ccac8936874c376652 Add an error message when rpm fails to open a pipe for shell expansion -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/862/files/d7a7479113e2e2ebf6a34d02a4aa07594915df8d..e2677384cde95e69e14979ccac8936874c376652 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support uncompressed/reconstructed payloads (#861)
On yet another related note, there a case or two for having a global hash for the individual files, with no payload induced foobar in it. One case is having a true "source id" calculated from all the files in an src.rpm, that would be also planted on any binaries built from these sources. This differs from the existing sourcepkgid (which is *build* specific) in that it would be arch-independent for properly written specs. This could be done as a hash of the existing hashes which is far cheaper than a hash of the actual contents, but then it'd be dependent on build-configuration which makes it less universal than a hardwired hash of algorithm X. Nothing says such a thing would have to be limited to source rpms, which is where we get back to the deltarpm case: I have no clue about deltarpm's inner workings, would such a thing be helpful/harmful/moo to the case? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/861#issuecomment-535370804___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)
Removed unnecessary "mb->error = 1;" line. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/862#issuecomment-535370536___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
