Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
`.*` is still broken with `!=`:
python-kubernetes:
python-10.0.1/requirements.txt
`websocket-client>=0.32.0,!=0.40.0,!=0.41.*,!=0.42.* `
`error: Illegal char '*' (0x2a) in: 0.42.*`
`.*` is still broken with `>=`:
python-fsleyes:
fsleyes-0.32.0/fsleyes.egg-info/requires.txt
`nibabel>=2.3.*`
`error: Illegal char '*' (0x2a) in: 2.3.*`
The code explicitly only work with `== ...*` but not other specs:
```python
elif spec[0] == '==' and spec[1].endswith('.*'):
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/951#issuecomment-576382832___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
I know, that's the general level problem that we need to sort out before we can proceed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-560275536___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
@pmatilai My main resistance to moving this out of rpm is that it makes it _very_ hard to get it to all the rpm distributions if it's not in the core. The introduction of the generator in rpm allowed it to spread from Mageia and Mandriva to Fedora, and now openSUSE. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-559805665___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
Merged #951 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#event-2840462873___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
> can we get this merged? If you say so. That said, the language specific dependency generators and brp-scripts would be the next targets for moving out of rpm to a better home, whatever that might be. I don't have anything like an actual plan for achieving that, just a vague idea. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-559676479___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
@pmatilai, @ffesti: can we get this merged? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-559232386___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
Thanks, @encukou If this PR looks good to you all, then let's merge and close it, and continue discussion in issues on the convert-440 project. Miro has a couple open now. If I get that code into a condition where we're happy with it, then I can add unit tests and then work on integrating it back into pythondistdeps. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-559129250___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
> https://github.com/gordonmessmer/convert-440/blob/master/convert-pep440.py Wow! That looks great! I started writing something similar, but ran into a lack of tests – I can't hold all the details in my head alone. > For example, I don't know what you have in mind when you say "strictly > standard-based implementation" Well, figure out how to map PEP 440 & 508 to RPM versioning/requires properly :) (For the record, the PEPs are relevant because they are linked from https://www.pypa.io/en/latest/specifications/ – on its own, an Active/Informational PEP is not an agreed-to standard.) For example, we're currently ignoring pre-releases. That's probably OK, but it should be a conscious/documented decision. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-559120414___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
@encukou I have no illusion that this change is pretty. :) I will say that if you have time to write an outline of what you'd like to see, I can put some time into further improvements. For example, I don't know what you have in mind when you say "strictly standard-based implementation" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-558694018___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
@gordonmessmer One last thing, could you prefix your commit messages with `scripts/pythondistdeps: ` so that we know what this is for? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-558684163___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#pullrequestreview-322938474___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
Thanks for the mention. I have nothing better to contribute now. I'm planning to submit a well-tested, strictly standard-based implementation, but It looks like I'll not get to complete it this year. (Please don't read that as an attack! This change is better than the status quo, and perfect is the enemy of good.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-558594224___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
Squashed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-558488170___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
cc @encukou -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#issuecomment-558068003___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
@gordonmessmer pushed 1 commit. 9f69722fa70c6a06bb15a090abfc89dba2d63e68 Import parse_version with other pkg_resources imports. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/951/files/c89c68a9eecc17d8e1db35e20a931af5199eccef..9f69722fa70c6a06bb15a090abfc89dba2d63e68 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
Conan-Kudo requested changes on this pull request. > @@ -16,6 +16,7 @@ from sys import argv, stdin, version from distutils.sysconfig import get_python_lib from warnings import warn +from pkg_resources import parse_version Please do not do this import at the top of the file. It massively slows down the execution of the script. Instead, add the `parse_version` import to the existing `from pkg_resources` line further down in the script. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951#pullrequestreview-322020614___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
This branch was intended to address issue #881 but I also handled #612 and some other fixes. Please let me know if youd prefer these commits in individual PRs. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/951 -- Commit Summary -- * Match python version if minor has multiple digits. * Use rich deps for semantically versioned dependencies * Remove extra parens. * Handle compatible-release operator. * Handle version ending with .* -- File Changes -- M scripts/pythondistdeps.py (28) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/951.patch https://github.com/rpm-software-management/rpm/pull/951.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/951 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
