Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-21 Thread Jun Aruga
@ignatenkobrain congratulations. Where is the RPM's URL in 
https://semaphoreci.com ?

https://semaphoreci.com/rpm-software-management/rpm is 404 not found.

Does Semaphoreci have the configuration file such as `.travis.yml` or 
`.circleci/config.yml`?
I want to see the logic to test `rpm` on 4 containers (Fedora 24, 25, 26, 
rawhide).

Shall we change current `README` to `README.md` or something to see build 
status easily?
like a Cockpit https://github.com/cockpit-project/cockpit/blob/master/README.md


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-317007720___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-21 Thread Igor Gnatenko
(I hope)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316997466___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-21 Thread Igor Gnatenko
So, now we have semaphoreci! Even it doesn't work on PRs (temporary).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316997426___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-20 Thread Igor Gnatenko
@markoa \o/ reaching out to you =)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316614406___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-20 Thread Marko Anastasov
  Hi folks, Semaphore cofounder here. We'd be support RPM with a free account 
that can run more parallel jobs. Please reach out to us at 
supp...@semaphoreci.com to discuss. :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316612878___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> +readline-devel \
+redhat-rpm-config \
+rpm-build \
+which \
+xz-devel \
+zlib-devel
+
+RUN dnf clean all
+
+RUN useradd -u $TEST_USER_ID tester
+
+WORKDIR /builddir
+
+COPY . .
+
+RUN chown -R 1000 .

Ah sorry 1000 is hard coded.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-51092701___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
Rebased!
https://travis-ci.org/junaruga/rpm/builds/255401154

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316498582___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000
+
+RUN dnf -y install \

> Also I would add dnf update as previous step

OK, just moment. I am going to add it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128346324___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@Conan-Kudo it seems that "Semaphore CI" is not for free to use 4 containers.
https://semaphoreci.com/pricing

Also it seems that the setting can be only edited from GUI operation. But it is 
good to manage the settings by configuration file, isn't it?

Cockpit project does not use docker for test? I am not sure.
https://github.com/cockpit-project/cockpit

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316478872___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@junaruga pushed 1 commit.

40f61d9  Update


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/1a8b8dcd811f2f18c2ed1187e4a3de8788ac7799..40f61d9c21077c0d36ec0eac9e5d0fe91dd968f5
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
> @junaruga What about Semaphore CI? I believe the Cockpit guys are already 
> using it with some good success.

OK, I am fine for that.
I have never used the CI, so let me check it.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316471531___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@ignatenkobrain Updated! How?

https://travis-ci.org/junaruga/rpm/builds/255363668

My concern is
if `language` is not specified, it looks running as `language: ruby`.
If we will set `language: generic`, it is displayed as "no language set" 
instead of "Ruby".
But I do not know that it is right way.

I did set `CONTAINER_IMAGE=registry.fedoraproject.org/fedora:24` with full path.
Because this is good to add CentOS container image as CI test in the future, if 
we need.

If you are fine for my modification, I can do squash from 2 commits to 1 commit 
before merging.
Or you can do it by yourself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316470510___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@junaruga pushed 1 commit.

a4a00b4  Update


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/f31ce2eefb58c19b9519d421535ae8cb7b978893..a4a00b418cd74163409ceed2a16524f50e464558
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread ニール・ゴンパ
@junaruga What about Semaphore CI? I believe the Cockpit guys are already using 
it with some good success.

Sadly, we can't use GitLab CI without having rpm hosted on GitLab.com...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316459719___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@junaruga pushed 1 commit.

c674791  Update


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/89f8f9ac75cdfced0c633b35c782cf610c2030fe..c6747912009a7f0c298635cb7307fb400ca56be9
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@junaruga pushed 1 commit.

89f8f9a  Update


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/378113d64863b5eaf39f835cd7cb855c9966c5d7..89f8f9ac75cdfced0c633b35c782cf610c2030fe
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@junaruga pushed 1 commit.

378113d  Update


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/6f7d088740018557c2adce877d134113e7dd2b05..378113d64863b5eaf39f835cd7cb855c9966c5d7
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@junaruga pushed 2 commits.

914080c  Fix for review.
6f7d088  Update


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261/files/25a8ba12d33f1d0bc521f2f7ebb5b01ef0a454d7..6f7d088740018557c2adce877d134113e7dd2b05
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000
+
+RUN dnf -y install \

OK. I will add the options.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289878___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> +sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+  - |
+docker build \
+-t rpm \
+.
+before_script:
+  - sudo chown -R 1000 .
+script:
+  - |
+DIR=$(pwd)
+docker run \
+-v "${DIR}:${DIR}" \
+-w "${DIR}" \
+-i \

Ah sorry obviously it is my mistake. I remove the `-i` option.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289790___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> +  - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+  - |
+docker build \
+-t rpm \
+.
+before_script:
+  - sudo chown -R 1000 .
+script:
+  - |
+DIR=$(pwd)
+docker run \
+-v "${DIR}:${DIR}" \

OK. let me try the way.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289331___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000

Because I wanted to use variable `TEST_USER_ID` in below lines in `Dockerfile`.
How do you think?

```
RUN useradd -u $TEST_USER_ID tester
...
USER $TEST_USER_ID
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128289057___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000
+
+RUN dnf -y install \

Also I would add dnf update as previous step

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128288921___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> +dist: trusty
+services:
+  - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+- CONTAINER_IMAGE=fedora:rawhide
+before_install:
+  - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:

OK. I will move the logic in `install` to `before_install`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128288441___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> @@ -0,0 +1,32 @@
+language: c

OK. I will remove this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128288263___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> @@ -0,0 +1,53 @@
+#!/bin/bash

I really think it should be part of travis.yml because it is needed *only* there

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50953821___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> +  - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+  - |
+docker build \
+-t rpm \
+.
+before_script:
+  - sudo chown -R 1000 .
+script:
+  - |
+DIR=$(pwd)
+docker run \
+-v "${DIR}:${DIR}" \

I think it's better to copy everything in container in the beginning, isn't it? 
(not sure)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50953114___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
junaruga commented on this pull request.



> +language: c
+sudo: required
+dist: trusty
+services:
+  - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+- CONTAINER_IMAGE=fedora:rawhide
+before_install:
+  - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile

Ah. Okay. I agree with you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#discussion_r128287593___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000
+
+RUN dnf -y install \

`--setopt=tsflags=nodocs --setopt=deltarpm=false` should be useful

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50953472___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> +sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:
+  - |
+docker build \
+-t rpm \
+.
+before_script:
+  - sudo chown -R 1000 .
+script:
+  - |
+DIR=$(pwd)
+docker run \
+-v "${DIR}:${DIR}" \
+-w "${DIR}" \
+-i \

don't think interactive mode is needed

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50953197___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> @@ -0,0 +1,49 @@
+FROM fedora
+
+ENV TEST_USER_ID 1000

why?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50952918___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> +dist: trusty
+services:
+  - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+- CONTAINER_IMAGE=fedora:rawhide
+before_install:
+  - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile
+fi
+install:

this should be before_install

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50952652___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> @@ -0,0 +1,32 @@
+language: c

we don't run tests directly, so we don't need this

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50952509___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> +language: c
+sudo: required
+dist: trusty
+services:
+  - docker
+env:
+# Fedora
+# https://hub.docker.com/r/_/fedora/
+- CONTAINER_IMAGE=fedora:24
+- CONTAINER_IMAGE=fedora:25
+- CONTAINER_IMAGE=fedora:26
+- CONTAINER_IMAGE=fedora:rawhide
+before_install:
+  - |
+if [ "${CONTAINER_IMAGE}" != '' ]; then
+sed -i "/^FROM / s|fedora|${CONTAINER_IMAGE}|" Dockerfile

we should be really using registry.fedoraproject.org as a registry.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50952247___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
ignatenkobrain commented on this pull request.



> @@ -0,0 +1,32 @@
+language: c
+sudo: required
+dist: trusty

is this really needed

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#pullrequestreview-50952448___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Jun Aruga
@ignatenkobrain in my understanding, on CircleCI (latest version 2.0 too), we 
can not use for free to use 4 containers (Feodra 24, 25, 26, rawhide).

>  I still don't think it is useful to build container every time.

Why do you think so?
The Travis running time is "3 min 20 sec".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316427958___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

2017-07-19 Thread Igor Gnatenko
well, I think better way is to use circleci, but I still don't think it is 
useful to build container every time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316425818___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint