[Bug 2081] wto - WebTv Orange standalone client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2081
Richard hobbes1...@gmail.com changed:
What|Removed |Added
CC||hobbes1...@gmail.com
--- Comment #1 from Richard hobbes1...@gmail.com 2011-12-09 16:25:21 CET ---
A couple of things:
1. Although it's obvious by looking in the spec, make sure you state why this
package isn't allowed in Fedora.
2. Make sure you read the comments in the spec file :)
%build
# Remove CFLAGS=... for noarch packages (unneeded)
CFLAGS=%{optflags} %{__python} setup.py build
Since this is a noarch package you can remove the CFLAGS:
%build
%{__python} setup.py build
Richard
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 2081] wto - WebTv Orange standalone client
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2081
--- Comment #2 from Richard hobbes1...@gmail.com 2011-12-09 17:05:43 CET ---
Ok, a couple of more things.
Currently only a single icon sized 100x100 is installed by the package. There's
two problems with this:
1. 100x100 isn't a very standard size and a 48x48 sized icon is currently
required indirectly by the Fedora guidelines via the Icon Theme Spec[1].
2. It's installed to the old /usr/share/pixmaps instead of /usr/share/icons.
The icon theme cache does not update this location as far as I know.
I've come up with one way to solve this problem but of course you're free to
solve it in any acceptable manner.
I added a BuildRequires: ImageMagick to use mogrify to resize the icons and
added this to your install section:
# Resize icon to more standard sizes and install
mkdir -p %{buildroot}%{_datadir}/icons/hicolor/96x96/apps \
%{buildroot}%{_datadir}/icons/hicolor/48x48/apps
mogrify -resize 96x96 -write
%{buildroot}%{_datadir}/icons/hicolor/96x96/apps/%{name}.png
%{buildroot}%{_datadir}/pixmaps/%{name}.png
mogrify -resize 48x48 -write
%{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{name}.png
%{buildroot}%{_datadir}/pixmaps/%{name}.png
rm %{buildroot}%{_datadir}/pixmaps/%{name}.png
Then of course update your %files section with:
%{_datadir}/icons/hicolor/*/apps/%{name}.png
Then you will need to add the appropriate sections from the guidelines[2] to
update the icon cache.
3. Unless I missed it, I did not see a way to change the language to english.
If this is French only, it should be stated in the description.
Richard
[1]
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
[2] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 440] Review request: vbam - Nintendo Gameboy, Gameboy Color, and Gameboy Advance Emulator
https://bugzilla.rpmfusion.org/show_bug.cgi?id=440 Richard hobbes1...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Blocks|2, 30 | Resolution||WONTFIX --- Comment #27 from Richard hobbes1...@gmail.com 2011-12-09 22:27:21 CET --- Closing since no one seems interested in pursuing it. If that changes, please reopen and block bug 2 and 30 as appropriate. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 30] Tracker : Sponsorship Request
https://bugzilla.rpmfusion.org/show_bug.cgi?id=30 Richard hobbes1...@gmail.com changed: What|Removed |Added Depends on|440 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 1991] Review request: zfs - ZFS File System Support for Linux
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1991 Richard hobbes1...@gmail.com changed: What|Removed |Added Blocks||2, 1990 Depends on|2 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
Richard hobbes1...@gmail.com changed:
What|Removed |Added
CC||hobbes1...@gmail.com
--- Comment #8 from Richard hobbes1...@gmail.com 2011-12-09 22:33:36 CET ---
(In reply to comment #6)
Ok, sorry I thought r666 was the latest trunk revision.
As you need to create a tarball anyway, is there a reason not to go with trunk
head ?
I'm confused. Since this is such a small script and upstream does not provide a
tarball, why bother compressing it?
Couldn't you just use the download link as the source?
Source0: http://winetricks.org/winetricks
Then just skip %setup and install it manually:
mkdir -p %{buildroot}%{_bindir}
install -pm 0755 %{SOURCE0} %{buildroot}%{_bindir}/
Richard
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 908] Review request: Mupen64Plus - Emulates the Nintendo 64 game console
https://bugzilla.rpmfusion.org/show_bug.cgi?id=908 Richard hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #6 from Richard hobbes1...@gmail.com 2011-12-09 22:39:13 CET --- Is there any interest in pursuing this review request? -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 939] Review request: tivo4tiny - Download shows from a networked Tivo to Linux and transcode
https://bugzilla.rpmfusion.org/show_bug.cgi?id=939 Richard hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #3 from Richard hobbes1...@gmail.com 2011-12-09 22:40:01 CET --- Is there any interest in pursuing this review request? -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 Richard hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #10 from Richard hobbes1...@gmail.com 2011-12-09 22:42:54 CET --- (In reply to comment #9) Spec URL: http://djj-consultants.com/rpms/sinthgunt.spec SRPM URL: http://djj-consultants.com/rpms/sinthgunt-2.0.3-1.fc14.src.rpm I updated the build to the new upstream version. Are you interested in pursing this review request? If so I'll review it for you. Also since you're sponsored in fedora make you you send a message to the list so Nicolas can clear you as a sponsor on RPM Fusion. Richard -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 1539] Review request: pithos - A Pandora client for the GNOME Desktop
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1539 --- Comment #13 from Richard hobbes1...@gmail.com 2011-12-09 22:44:11 CET --- Ping? -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 1566] Review Request : zekr - Open Source Quran study tool
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1566 Richard hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #5 from Richard hobbes1...@gmail.com 2011-12-09 22:47:28 CET --- (In reply to comment #1) dependencies in rhbz : https://bugzilla.redhat.com/show_bug.cgi?id=664615 (vorbisspi) https://bugzilla.redhat.com/show_bug.cgi?id=664619 (jspeex) https://bugzilla.redhat.com/show_bug.cgi?id=664826 (lucene3) It looks like you gave up on lucene3, does that mean this review request is dead? -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 1936] Review request: LiVES - Formerly Linux, but now just the Video Editing System
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 --- Comment #14 from Richard hobbes1...@gmail.com 2011-12-09 23:00:37 CET --- I did some searching for libweed on other distrobutions. Apparently both Debian, Suse, and Mandriva both package libweed separately. We should probably do the same. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036 Richard hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #4 from Richard hobbes1...@gmail.com 2011-12-09 23:07:23 CET --- Is it settled? This belongs in RPM Fusion? If so I'll review it. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036 --- Comment #5 from Alex Lancaster al...@users.sourceforge.net 2011-12-09 23:10:22 CET --- (In reply to comment #4) Is it settled? This belongs in RPM Fusion? Yep, seems ffmpeg is hard requirement, because decoding is required before the Fourier analysis of the audio data. If so I'll review it. Great! -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036
Richard hobbes1...@gmail.com changed:
What|Removed |Added
Blocks|2 |3
AssignedTo|rpmfusion-package-review@rp |hobbes1...@gmail.com
|mfusion.org |
--- Comment #6 from Richard hobbes1...@gmail.com 2011-12-09 23:20:32 CET ---
Ok, quick spec review first.
1. You don't need the -n chromaprint-tools since it's the name of the
package. You'll still need -n on %setup though since directory in the archive
doesn't include tools in the name.
Speaking of which, I noticed you're deleting a lot of stuff in the spec. Is
there a reason for this?
2. Don't use macro versions of basic shell tools, in this case rm. It's not
necessary and just hurts readability.
3. Unless you're going to build for EL5 (unlikely) you can get rid of:
BuildRoot:
%{__rm} -rf %{buildroot} in %install
%clean entirely
%defattr(-,root,root,-) in %files
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 1936] Review request: LiVES - Formerly Linux, but now just the Video Editing System
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 --- Comment #15 from salsaman salsa...@gmail.com 2011-12-09 23:38:57 CET --- Russian fedora is already packaging this: http://koji.russianfedora.ru/koji/packageinfo?packageID=185 you just need to mirror this maybe. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
Re: xine-lib-extras-freeworld-1.1.20-3.fc1[56] updates needing coordination
The Fedora 15 update: https://admin.fedoraproject.org/updates/xine-lib-1.1.20-1.fc15 is now queued for stable too. Kevin Kofler
[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1992 --- Comment #9 from T.C. Hollingsworth t...@tchol.org 2011-12-10 01:13:38 CET --- (In reply to comment #8) I'm confused. Since this is such a small script and upstream does not provide a tarball, why bother compressing it? Couldn't you just use the download link as the source? That's what I did originally, but Xavier suggested I use a tarball from SVN instead. I reverted it back to using the shell script download, bumped to the latest upstream release, and shamelessly stole an icon from Ubuntu. Spec: http://tchol.org/rpmfusion/winetricks.spec SRPM: http://tchol.org/rpmfusion/winetricks-2015-1.fc16.src.rpm $ rpmlint SPECS/winetricks.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/winetricks-2015-1.fc16.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036 --- Comment #7 from Alex Lancaster al...@users.sourceforge.net 2011-12-10 01:41:13 CET --- Does this Require or BuildRequire chromaprint from Fedora? If so, it should probably be added to the .spec. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036 Alex Lancaster al...@users.sourceforge.net changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #8 from Alex Lancaster al...@users.sourceforge.net 2011-12-10 01:42:11 CET --- Since this is in review, changing to ASSIGNED. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[Bug 1990] Review request: spl - Solaris Porting Layer
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1990 --- Comment #4 from Bill McGonigle bill-bugzilla.rpmfusion@bfccomputing.com 2011-12-10 02:35:47 CET --- :headdesk: OK, inability to comprehend English aside, I tried again to build these, but this time on CentOS 6, and it looks like the RPMFusion build tools aren't available there yet. I'll go ask on the list, so the only thing to report here now is that currently yum-builddep doesn't work on spl-kmod on CentOS 6. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1992 --- Comment #10 from Richard hobbes1...@gmail.com 2011-12-10 02:58:26 CET --- Yeah, I'm sure he had his reasoning, but IMHO, you should prefer upstream packaging over doing your own (in this case, that means no packaging) and prefer releases over SVN snapshots. Interesting. In looking at your spec I see you're creating a 48x48 icon from the scaleable icon. I did something similar in a package but I used mogrify from ImageMagick instead. I'll check for any additional issues, but I'm not yet a sponsor so I can't do your official review. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036
--- Comment #9 from Richard hobbes1...@gmail.com 2011-12-10 03:04:30 CET ---
hmm... I hate to say it, but if this is using the same source as the package in
Fedora then it should probably be treated like other projects like this. You'll
need to package it just like Fedora but use rpmdiff to generate a rpm diff file
that people can install. I've never done it before so I'm a little short on
details.
It's possible that's overkill since you're just adding a binary, but at a
minimum you'll need to keep to the same version as the Fedora release:
Requires: chromaprint == %{version}
or something like that.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
build tools for EL6?
Hi, everybody, What's needed to get build tools out for el6? I'm looking to help test the spl/zfs modules on CentOS 6. I found that kmodtool seems unchanged since f11, so I just pulled that from another repo, but: buildsys-build-rpmfusion (buildsys-build-rpmfusion-kerneldevpkgs-newest-x86_64) looks like it's tightly coupled to the kernel version, so using a different one isn't going to help here. Those are two I saw in this case, but in general a push of the build tools for el6 would be great. Thanks, -Bill -- Bill McGonigle, Owner BFC Computing, LLC http://bfccomputing.com/ Telephone: +1.855.SW.LIBRE Email, IM, VOIP: b...@bfccomputing.com VCard: http://bfccomputing.com/vcard/bill.vcf Social networks: bill_mcgonigle/bill.mcgonigle
[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036
--- Comment #10 from Kevin Kofler kevin.kof...@chello.at 2011-12-10 05:36:20
CET ---
hmm... I hate to say it, but if this is using the same source as the package
in
Fedora then it should probably be treated like other projects like this.
You'll
need to package it just like Fedora but use rpmdiff to generate a rpm diff
file
that people can install. I've never done it before so I'm a little short on
details.
Huh? No package in RPM Fusion is packaged as delta/patch RPMs, our toolset
doesn't even support them. What we do is that we package a -freeworld RPM in
RPM Fusion which contains only the files not in the Fedora RPM (by not building
them if possible, or deleting them in %install otherwise), or if that's not
possible, which overrides the files from the Fedora RPM without conflicting
with it.
This chromaprint-tools package is already following the recommended approach.
It's possible that's overkill since you're just adding a binary, but at a
minimum you'll need to keep to the same version as the Fedora release:
Requires: chromaprint == %{version}
or something like that.
Uhm, no, please only add '='-versioned dependencies on Fedora packages if
absolutely necessary (i.e. if the tools version x are not expected to work with
the library version y≠x)! '='-versioned dependencies mean the packages in
Fedora and RPM Fusion need to be pushed at exactly the same time, which in
practice can only be approximated, so there's always a window where the user
will not be able to update. Thus, please do not gratuitously add them when not
needed.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
