[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190 --- Comment #2 from Kevin Kofler 2012-02-23 00:41:16 CET --- As I understand it, MP4 metadata is not patent-encumbered, only the codecs are. So it should be possible to get this into Fedora. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
Re: To All Package maintainer ! - no F-17 builds at the moment.
2012/2/22 David Timms : > On 23/02/12 07:42, Nicolas Chauvet wrote: >> >> This stands for all packagers! >> >> Can you please update your spec in all branches when relevant ? >> This worth for devel AND F-17 ! (please update your checkout if not >> done already). > > I've done a cvs update in the top-level of my package eg > rpms/audacity-freeworld. Should that have received some changes ? To what > dirs/files ? I'm usually checkouting higher we don't have packages that much. There is specially a certain common dir that might be needed. >> That even if F-17 build target is currently disabled until further notice. > > So, do not build for F-17, but devel is OK ? devel is OK to build and need to be equal or higher of F-17 (and ffmpeg dependency is fixed) Thx for making the summary more clear. Nicolas (kwizart)
Re: To All Package maintainer ! - no F-17 builds at the moment.
On 23/02/12 07:42, Nicolas Chauvet wrote: This stands for all packagers! Can you please update your spec in all branches when relevant ? This worth for devel AND F-17 ! (please update your checkout if not done already). I've done a cvs update in the top-level of my package eg rpms/audacity-freeworld. Should that have received some changes ? To what dirs/files ? That even if F-17 build target is currently disabled until further notice. So, do not build for F-17, but devel is OK ?
To All Package maintainer ! rpms/openshot/F-15 openshot.spec, 1.7, 1.8
2012/2/22 Richard Shaw : > Author: hobbes1069 > > Update of /cvs/free/rpms/openshot/F-15 > In directory se02.es.rpmfusion.net:/tmp/cvs-serv14493 This stands for all packagers! Can you please update your spec in all branches when relevant ? This worth for devel AND F-17 ! (please update your checkout if not done already). That even if F-17 build target is currently disabled until further notice. Thx Nicolas (kwizart)
[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190
Alec Leamas changed:
What|Removed |Added
CC||leamas.a...@gmail.com
--- Comment #1 from Alec Leamas 2012-02-22 20:39:00 CET
---
Hi Avi!
I'm not a reviewer, but perhaps I can help you with some random remarks after a
quick check:
Dont use the %__rm, %__cp macros, use simple 'rm', 'cp' 'c++' instead
See http://fedoraproject.org/wiki/Packaging:Guidelines#Macros
The License: tag does not reflect the fact that some code is MIT/X11
licensed. See http://fedoraproject.org/wiki/Packaging:Guidelines#Licensing.
You can't add COPYING yourself, you must contact upstream about that. And
upstream has already a COPYING in place. Are you replacing it? This is not
possible either for legal reasons. After all, it's their code. If you have
problem with the fsf-address lint warning, just report to upstream, bring the
link (e. g., bugtracker ticket) in here and live with the warning.
Remove Buildroot:, %clean, %defattr. These are not used in Fedora.
The Source0 url is wrong, it just fetches a html page. See
http://fedoraproject.org/wiki/Packaging:SourceURL, note the sourceforge
chapter.
Rpmlint shows empty debug package. Probably related to that you remove the -g
option to g++. You should not do that, generate debug info and let rpmbuild
strip to the debug package instead. And run rpmlint on the debug package as
well.
You don't need to require c++, make etc.
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
Style is a matter of personal taste. However, you might consider to:
Line up the first section properly:
Summary: Command-Line Program to Read and Set iTunes-style Metadata Tags
URL: http://atomicparsley.sourceforge.net
Name: AtomicParsley
Version: 0.9.0
Release: 7%{?dist}
License: GPLv2
Write the sed code on one line (note there's only the last one left
when you're done)
sed -i -e 's/g++/$CXX/g' -e 's/-g//g' -e 's/-O2/$OPTFLAGS/g' build
Write the %doc list on one line:
%doc COPYING AP\ buglist.txt Using\ AtomicParsley.rtf
Still, formatting is personal and not review remarks.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
RPM Fusion (Fedora - nonfree) Package Build Report 2012-02-22
Packages built and released for RPM Fusion (Fedora - nonfree) 16: 1 sdlmame-data-0145-1.fc16 Packages built and released for RPM Fusion (Fedora - nonfree) testing/16: 3 catalyst-kmod-12.1-1.fc16.3 nvidia-kmod-290.10-1.fc16.15 wl-kmod-5.100.82.112-2.fc16.7 Packages built and released for RPM Fusion (Fedora - nonfree) 15: 1 sdlmame-data-0145-1.fc15 Packages built and released for RPM Fusion (Fedora - nonfree) testing/15: 4 catalyst-kmod-11.11-1.fc15.13 nvidia-173xx-kmod-173.14.31-1.fc15.20 nvidia-kmod-280.13-2.fc15.20 wl-kmod-5.100.82.112-1.fc15.7 Changes in RPM Fusion (Fedora - nonfree) 16: sdlmame-data-0145-1.fc16 * Tue Feb 21 2012 Julian Sikorski - 0145-1 - Updated to 0.145 - Junk paths when unzipping catveren.zip - Fix nplayers.txt end-of-line encoding * Thu Dec 22 2011 Julian Sikorski - 0144-1 - Updated everything except catver.ini to 0.144 - Updated catver.ini to 0.143u4 - Dropped obsolete Group, Buildroot, %clean and %defattr Changes in RPM Fusion (Fedora - nonfree) testing/16: catalyst-kmod-12.1-1.fc16.3 --- * Wed Feb 22 2012 Nicolas Chauvet - 12.1-1.3 - rebuild for updated kernel nvidia-kmod-290.10-1.fc16.15 * Wed Feb 22 2012 Nicolas Chauvet - 1:290.10-1.15 - rebuild for updated kernel wl-kmod-5.100.82.112-2.fc16.7 - * Wed Feb 22 2012 Nicolas Chauvet - 5.100.82.112-2.7 - rebuild for updated kernel Changes in RPM Fusion (Fedora - nonfree) 15: sdlmame-data-0145-1.fc15 * Tue Feb 21 2012 Julian Sikorski - 0145-1 - Updated to 0.145 - Junk paths when unzipping catveren.zip - Fix nplayers.txt end-of-line encoding * Thu Dec 22 2011 Julian Sikorski - 0144-1 - Updated everything except catver.ini to 0.144 - Updated catver.ini to 0.143u4 - Dropped obsolete Group, Buildroot, %clean and %defattr Changes in RPM Fusion (Fedora - nonfree) testing/15: catalyst-kmod-11.11-1.fc15.13 - * Wed Feb 22 2012 Nicolas Chauvet - 11.11-1.13 - rebuild for updated kernel nvidia-173xx-kmod-173.14.31-1.fc15.20 - * Wed Feb 22 2012 Nicolas Chauvet - 173.14.31-1.20 - rebuild for updated kernel nvidia-kmod-280.13-2.fc15.20 * Wed Feb 22 2012 Nicolas Chauvet - 1:280.13-2.20 - rebuild for updated kernel wl-kmod-5.100.82.112-1.fc15.7 - * Wed Feb 22 2012 Nicolas Chauvet - 5.100.82.112-1.7 - rebuild for updated kernel
RPM Fusion (Fedora - free) Package Build Report 2012-02-22
Packages built and released for RPM Fusion (Fedora - free) 16: 1 openshot-1.4.2-4.fc16 Packages built and released for RPM Fusion (Fedora - free) testing/16: 9 audacity-freeworld-2.0.0-0.3.rc3.fc16 buildsys-build-rpmfusion-16-24 ndiswrapper-kmod-1.57-1.fc16.8 openafs-kmod-1.6.1-0.pre2.fc16.4 staging-kmod-3.2.1-1.fc16.6 VirtualBox-OSE-kmod-4.1.8-1.fc16.11 west-chamber-kmod-0.0.1-7.20101017svn.fc16.21 xtables-addons-kmod-1.41-1.fc16.5 yabause-0.9.11.1-1.fc16 Packages built and released for RPM Fusion (Fedora - free) 15: 1 openshot-1.4.2-4.fc15 Packages built and released for RPM Fusion (Fedora - free) testing/15: 10 ndiswrapper-kmod-1.57-1.fc15.6 openafs-kmod-1.6.1-0.pre2.fc15.2 rt2860-kmod-2.4.0.0-2.fc15.25 rt2870-kmod-2.4.0.1-2.fc15.25 rt3070-kmod-2.3.0.4-2.fc15.25 staging-kmod-3.2.1-1.fc15.3 VirtualBox-OSE-kmod-4.1.8-1.fc15.4 west-chamber-kmod-0.0.1-6.20101017svn.fc15.24 xtables-addons-kmod-1.41-1.fc15.4 yabause-0.9.11.1-1.fc15 Changes in RPM Fusion (Fedora - free) 16: openshot-1.4.2-4.fc16 - * Mon Feb 20 2012 Richard Shaw - 1.4.2-4 - Fix small packaging bug with icon. * Wed Feb 08 2012 Nicolas Chauvet - 1.4.2-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild Changes in RPM Fusion (Fedora - free) testing/16: audacity-freeworld-2.0.0-0.3.rc3.fc16 - * Wed Feb 22 2012 David Timms - 2.0.0-0.3.rc3 - update to 2.0.0 release candidate 3 buildsys-build-rpmfusion-16-24 -- * Wed Feb 22 2012 Nicolas Chauvet - 10:16-24 - rebuild for kernel 3.2.7-1.fc16 ndiswrapper-kmod-1.57-1.fc16.8 -- * Wed Feb 22 2012 Nicolas Chauvet - 1.57-1.8 - rebuild for updated kernel openafs-kmod-1.6.1-0.pre2.fc16.4 * Wed Feb 22 2012 Nicolas Chauvet - 1.6.1-0.pre2.4 - rebuild for updated kernel staging-kmod-3.2.1-1.fc16.6 --- * Wed Feb 22 2012 Nicolas Chauvet - 3.2.1-1.6 - rebuild for updated kernel VirtualBox-OSE-kmod-4.1.8-1.fc16.11 --- * Wed Feb 22 2012 Nicolas Chauvet - 4.1.8-1.11 - rebuild for updated kernel west-chamber-kmod-0.0.1-7.20101017svn.fc16.21 - * Wed Feb 22 2012 Nicolas Chauvet - 0.0.1-7.20101017svn.21 - rebuild for updated kernel xtables-addons-kmod-1.41-1.fc16.5 - * Wed Feb 22 2012 Nicolas Chauvet - 1.41-1.5 - rebuild for updated kernel yabause-0.9.11.1-1.fc16 --- * Tue Feb 21 2012 Julian Sikorski - 0.9.11.1-1 - Updated to 0.9.11.1 - Dropped obsolete Group, Buildroot, %clean and %defattr - Updated scriptlets to the latest spec - Switched to cmake - Dropped the selinux patch * Wed Feb 08 2012 Nicolas Chauvet - 0.9.10-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild Changes in RPM Fusion (Fedora - free) 15: openshot-1.4.2-4.fc15 - * Mon Feb 20 2012 Richard Shaw - 1.4.2-4 - Fix small packaging bug with icon. * Wed Feb 08 2012 Nicolas Chauvet - 1.4.2-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild Changes in RPM Fusion (Fedora - free) testing/15: ndiswrapper-kmod-1.57-1.fc15.6 -- * Wed Feb 22 2012 Nicolas Chauvet - 1.57-1.6 - rebuild for updated kernel openafs-kmod-1.6.1-0.pre2.fc15.2 * Wed Feb 22 2012 Nicolas Chauvet - 1.6.1-0.pre2.2 - rebuild for updated kernel rt2860-kmod-2.4.0.0-2.fc15.25 - * Wed Feb 22 2012 Nicolas Chauvet - 2.4.0.0-2.25 - rebuild for updated kernel rt2870-kmod-2.4.0.1-2.fc15.25 - * Wed Feb 22 2012 Nicolas Chauvet - 2.4.0.1-2.25 - rebuild for updated kernel rt3070-kmod-2.3.0.4-2.fc15.25 - * Wed Feb 22 2012 Nicolas Chauvet - 2.3.0.4-2.25 - rebuild for updated kernel staging-kmod-3.2.1-1.fc15.3 --- * Wed Feb 22 2012 Nicolas Chauvet - 3.2.1-1.3 - rebuild for updated kernel VirtualBox-OSE-kmod-4.1.8-1.fc15.4 -- * Wed Feb 22 2012 Nicolas Chauvet - 4.1.8-1.4 - rebuild for updated kernel west-chamber-kmod-0.0.1-6.20101017svn.fc15.24 - * Wed Feb 2
Re: Please push new Openshot builds directly to stable
W dniu 22.02.2012 18:40, Nicolas Chauvet pisze: > 2012/2/22 Richard Shaw : >> On Wed, Feb 22, 2012 at 10:23 AM, Julian Sikorski wrote: >>> You probably mean F-17. And no, at least bug #2184 is not fixed yet and >>> builds will fail. > Please remind me on IRC tonight if needed. > > I expect to push sdlmame-data is it required for stable push also ?( > as the matching sdlmame is already in stable ?) > > > Nicolas (kwizart) > Yeah, please do. The likelihood of breakage is extremely low since there is no code being built in that package. Julian
Re: Please push new Openshot builds directly to stable
2012/2/22 Richard Shaw : > On Wed, Feb 22, 2012 at 10:23 AM, Julian Sikorski wrote: >> You probably mean F-17. And no, at least bug #2184 is not fixed yet and >> builds will fail. Please remind me on IRC tonight if needed. I expect to push sdlmame-data is it required for stable push also ?( as the matching sdlmame is already in stable ?) Nicolas (kwizart)
Re: Please push new Openshot builds directly to stable
On Wed, Feb 22, 2012 at 10:23 AM, Julian Sikorski wrote: > You probably mean F-17. And no, at least bug #2184 is not fixed yet and > builds will fail. Yes! Sorry. Thanks, Richard
Re: Please push new Openshot builds directly to stable
W dniu 22.02.2012 17:21, Richard Shaw pisze: > I had a scriptlet error causing the icons to not be displayed after > install. Please push these builds directly to stable. > > On a side note. I don't remember seeing lately if it's safe to build > for F-16 yet? > > Thanks, > Richard > You probably mean F-17. And no, at least bug #2184 is not fixed yet and builds will fail. Julian
Please push new Openshot builds directly to stable
I had a scriptlet error causing the icons to not be displayed after install. Please push these builds directly to stable. On a side note. I don't remember seeing lately if it's safe to build for F-16 yet? Thanks, Richard
Re: Build server can't find packages for rawhide?
Looks like it's fixed! Richard
[Bug 1065] Review request: aqualung - Music Player for GNU/Linux
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1065 --- Comment #5 from Akio Idehara 2012-02-22 14:25:19 CET --- Sorry, I'm already not interested. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
RPM Fusion (Fedora - nonfree) Package Build Report 2012-02-22
Packages built and released for RPM Fusion (Fedora - nonfree) testing/16: 3 mame-0.145u1-1.fc16 rpmfusion-nonfree-release-16-2.1 sdlmame-data-0145-1.fc16 Packages built and released for RPM Fusion (Fedora - nonfree) testing/15: 1 sdlmame-data-0145-1.fc15 Changes in RPM Fusion (Fedora - nonfree) testing/16: mame-0.145u1-1.fc16 --- * Sun Feb 19 2012 Julian Sikorski - 0.145u1-1 - Updated to 0.145u1 - Added artwork/* and hlsl/* to the installed files - Fixed the line ending fix to spare all the *.png files - Added bundled(libjpeg) and bundled(lzma-sdk) Provides - Temporarily disabled ldresample and ldverify rpmfusion-nonfree-release-16-2.1 * Mon Feb 20 2012 Nicolas Chauvet - 16-2.1 - Fix errors on nonfree .repo sdlmame-data-0145-1.fc16 * Tue Feb 21 2012 Julian Sikorski - 0145-1 - Updated to 0.145 - Junk paths when unzipping catveren.zip - Fix nplayers.txt end-of-line encoding * Thu Dec 22 2011 Julian Sikorski - 0144-1 - Updated everything except catver.ini to 0.144 - Updated catver.ini to 0.143u4 - Dropped obsolete Group, Buildroot, %clean and %defattr Changes in RPM Fusion (Fedora - nonfree) testing/15: sdlmame-data-0145-1.fc15 * Tue Feb 21 2012 Julian Sikorski - 0145-1 - Updated to 0.145 - Junk paths when unzipping catveren.zip - Fix nplayers.txt end-of-line encoding * Thu Dec 22 2011 Julian Sikorski - 0144-1 - Updated everything except catver.ini to 0.144 - Updated catver.ini to 0.143u4 - Dropped obsolete Group, Buildroot, %clean and %defattr
RPM Fusion (Fedora - free) Package Build Report 2012-02-22
Packages built and released for RPM Fusion (Fedora - free) testing/15: 1 buildsys-build-rpmfusion-15-29 Changes in RPM Fusion (Fedora - free) testing/15: buildsys-build-rpmfusion-15-29 -- * Wed Feb 22 2012 Nicolas Chauvet - 10:15-29 - rebuild for kernel 2.6.42.7-1.fc15
[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098
--- Comment #26 from Alec Leamas 2012-02-22 09:28:43
CET ---
Woke up, had a bad feeling about these bundled headers.
First, hci.h and l2cap.h is possibly just the tip of the iceberg. If you run
script below, you will find a list of candidates. There are plenty of false
positives, but also some files to take care about. Note that the script
requires relevant -devel packages installed, but I guess you have :)
Secondly, symlinking was a bad idea. What you should do is to just remove these
files in %prep and setup compiler flags so the system headers are used instead.
A long time since I used cmake, but I *think* something like this could work:
export CFLAGS="-I/usr/include/ffmpeg -I/usr/include/bluetooth ..."
%cmake ...
Find headers hack:
#!/bin/bash
for header in $(find Source -name \*.h); do
basename=$( basename $header );
sys_headers=$( find /usr/include -name $basename)
test -n "$sys_headers" && {
echo "$header"
for sh in $( echo $sys_headers ); do
echo "$sh"
done
}
done
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
