[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190

Nicolas Chauvet  changed:

   What|Removed |Added

 Blocks|2   |


Referenced Bugs:

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190

Richard hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||hobbes1...@gmail.com
 Resolution||WONTFIX

--- Comment #5 from Richard hobbes1...@gmail.com 2015-01-14 22:57:06 CET ---
Closing due to inactivity, please reopen if you're interested in pursuing this
review request and the package is not allowed in Fedora.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190

--- Comment #4 from Alec Leamas leamas.a...@gmail.com 2012-03-05 11:51:16 CET 
---
Since it seems clear from comment #2 that this could (and thus should) be
submitted to main fedora, I suggest that you close this bug and issue a new
request to bugzilla.redhat.com. However, since we started a kind a review here
I enclose some comments.

Cheers,

alec


(In reply to comment #3)
 (In reply to comment #1)
[cut]

  The License: tag does not reflect the fact that some code is MIT/X11
  licensed. See http://fedoraproject.org/wiki/Packaging:Guidelines#Licensing.
 
 Couldn't find a nothing on the source that says MIT/X11 license.

In the package rpmdev-tools there's a tool called licensecheck. If you apply it
 to the source it will reveal that some files related to iconv are MIT/X11

It will also reveal that some source files have the wrong fsf address. You
should inform upstream about this. If you want, you can patch it as well. 

  You can't add COPYING yourself, you must contact upstream about that. And
  upstream has already a COPYING in place. Are you replacing it? This is not
  possible either for legal reasons.  After all, it's their code. If you have
  problem with the fsf-address lint warning, just report to upstream, bring 
  the
  link (e. g., bugtracker  ticket) in here and live with the warning.
 
 This is old code, there is no upstream. GNU office has moved to another 
 address
 but the license file included reflects the old address and rpmlint is
 complaining. I'm just overwriting with the new file because of this small
 problem.

There's definitely an upstream at sourceforge where you can report.

We can just agree on that we disagree. However,  I would not appprove anything
like this, and I doubt anyone else will. I'm sorry not to have an authorative
link on this (it really should be in Common rpmlint issues!), but a simple
google search for the rpmlint warning will show you how this is handled.

  Rpmlint shows empty debug package. Probably related to that you remove the 
  -g
  option to g++. You should not do that, generate debug info and let rpmbuild
  strip to the debug package instead. And run rpmlint on the debug package as
  well.
 
 I can't generate debug packages. How to do that? I even removed the '-s'
 (strip) from 'install' but no debug package is generated.

rpmbuild --rebuild srpm and rpmbuild -ba specfile should both generates
debug packages as long as you don't have anything strange in your rpm setup

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190

Alec Leamas leamas.a...@gmail.com changed:

   What|Removed |Added

 CC||leamas.a...@gmail.com

--- Comment #1 from Alec Leamas leamas.a...@gmail.com 2012-02-22 20:39:00 CET 
---
Hi Avi!

I'm not a reviewer, but perhaps I can help you with some random remarks after a
quick check:

Dont use the %__rm, %__cp macros, use simple 'rm', 'cp' 'c++' instead
See http://fedoraproject.org/wiki/Packaging:Guidelines#Macros

The License: tag does not reflect the fact that some code is MIT/X11
licensed. See http://fedoraproject.org/wiki/Packaging:Guidelines#Licensing.

You can't add COPYING yourself, you must contact upstream about that. And
upstream has already a COPYING in place. Are you replacing it? This is not
possible either for legal reasons.  After all, it's their code. If you have
problem with the fsf-address lint warning, just report to upstream, bring the
link (e. g., bugtracker  ticket) in here and live with the warning.

Remove Buildroot:, %clean, %defattr. These are not used in Fedora.

The Source0 url is wrong, it just fetches a html page. See
http://fedoraproject.org/wiki/Packaging:SourceURL, note the sourceforge
chapter.

Rpmlint shows empty debug package. Probably related to that you remove the -g
option to g++. You should not do that, generate debug info and let rpmbuild
strip to the debug package instead. And run rpmlint on the debug package as
well.

You don't need to require c++, make etc. 
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

Style is a matter of personal taste. However, you might consider to:

Line up the first section properly:
Summary:   Command-Line Program to Read and Set iTunes-style Metadata Tags
URL:   http://atomicparsley.sourceforge.net
Name:  AtomicParsley
Version:   0.9.0
Release:   7%{?dist}
License:   GPLv2

Write the sed code on one line (note there's only the last one left
when you're done)
sed -i -e 's/g++/$CXX/g' -e 's/-g//g' -e 's/-O2/$OPTFLAGS/g' build

Write the %doc list on one line: 
%doc COPYING  AP\ buglist.txt  Using\ AtomicParsley.rtf

Still, formatting is personal and not review remarks.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190

--- Comment #2 from Kevin Kofler kevin.kof...@chello.at 2012-02-23 00:41:16 
CET ---
As I understand it, MP4 metadata is not patent-encumbered, only the codecs are.
So it should be possible to get this into Fedora.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.