Re: [mjpegtools] Disable use of SDL_gfx on EL8
Le ven. 13 sept. 2019 à 00:08, Sérgio Basto a écrit : > > On Wed, 2019-09-11 at 12:42 -0400, FeRD wrote: > > > > On Wed, Sep 11, 2019 at 4:40 AM Kevin Kofler wrote: > > FeRD wrote: > > On cursory inspection of the API docs I also don't see any obvious reason > > why it would need mjpegtools, but I admit I didn't look very hard. > > It is the other way round: mjpegtools needs SDL_gfx, not the opposite. > > > Oh! Gotcha. My mistake. > > Actually, looking at the packages, it appears that only mjpegtools-gui > requires SDL_gfx. > > So the question becomes, do WE need mjpegtools-gui? > > mjpegtools itself is still required by a shocking number of other packages, > all things considered. But its GUI components are, quite frankly, crap. What > use are poor clones of ffplay that each only support one specific (and > outdated) video format? > > I don't think it would be any great loss to just drop mjpegtools-gui, and I > bet nobody would miss it. (Though I suppose only dropping the -gui subpackage > wouldn't really gain us much, either.) > > > Thank you for reply , so you support , that mjpegtools could be "unused code" > ? btw as I just read in this page [1]. > I think we should remove it from RPMFusion , instead propagate it into epel 8 > , If I am allowed I will remove it from rawhide and even more, I remove it > from all Fedora active branches , like I said to see if someone find out the > loss . That looks scarry, we don't remove package from releases branch ever, specially when still used. I think we have determined that mjpegtools is used by severals others projects still. MPEG-2 codec/containers are still used by default on several industrial standard such as DVB, DVD if not for streaming. # dnf repoquery --whatrequires mjpegtools bombono-dvd-0:1.2.4-12.fc29.x86_64 dvdstyler-2:3.1.2-1.fc29.x86_64 mjpegtools-gui-0:2.1.0-13.fc29.x86_64 mytharchive-0:30.0-7.20190601git6bd8cd4993.fc29.x86_64 vdr-burn-0:0.3.0-14.fc29.x86_64 vdr-mp3-0:0.10.2-22.fc29.x86_64 vdrsync-0:0.1.3-25.PRE1.050322.fc29.noarch Libraries are used by # dnf repoquery --whatrequires libmjpegutils-2.1.so.0\* gstreamer-plugins-bad-0:0.10.23-11.fc29.x86_64 gstreamer1-plugins-bad-freeworld-0:1.14.4-1.fc29.x86_64 lives-0:2.10.2-1.fc29.x86_64 So I really see no reason to drop it. With that said, having the plugin in an extras sub-package in gstreamer1-plugins-bad-freeworld can be done. Please concentrate on enabling things rather than removing. Thx in advance. -- - Nicolas (kwizart) ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
On Wed, 2019-09-11 at 12:42 -0400, FeRD wrote: > On Wed, Sep 11, 2019 at 4:40 AM Kevin Kofler > wrote: > > FeRD wrote: > > > > > On cursory inspection of the API docs I also don't see any > > obvious reason > > > > > why it would need mjpegtools, but I admit I didn't look very > > hard. > > > > > > > > It is the other way round: mjpegtools needs SDL_gfx, not the > > opposite. > > Oh! Gotcha. My mistake. > > Actually, looking at the packages, it appears that only mjpegtools- > gui requires SDL_gfx. > > So the question becomes, do WE need mjpegtools-gui? > > mjpegtools itself is still required by a shocking number of other > packages, all things considered. But its GUI components are, quite > frankly, crap. What use are poor clones of ffplay that each only > support one specific (and outdated) video format? > > I don't think it would be any great loss to just drop mjpegtools-gui, > and I bet nobody would miss it. (Though I suppose only dropping the > -gui subpackage wouldn't really gain us much, either.) Thank you for reply , so you support , that mjpegtools could be "unused code" ? btw as I just read in this page [1]. I think we should remove it from RPMFusion , instead propagate it into epel 8 , If I am allowed I will remove it from rawhide and even more, I remove it from all Fedora active branches , like I said to see if someone find out the loss . Thanks. [1]https://www.onswiftwings.com/unused-code-cleanup/ > ___rpmfusion-developers > mailing list -- rpmfusion-developers@lists.rpmfusion.org > To unsubscribe send an email to > rpmfusion-developers-le...@lists.rpmfusion.org -- Sérgio M. B. ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
On Wed, Sep 11, 2019 at 4:40 AM Kevin Kofler wrote: > FeRD wrote: > > On cursory inspection of the API docs I also don't see any obvious reason > > why it would need mjpegtools, but I admit I didn't look very hard. > > It is the other way round: mjpegtools needs SDL_gfx, not the opposite. > Oh! Gotcha. My mistake. Actually, looking at the packages, it appears that only mjpegtools*-gui* requires SDL_gfx. So the question becomes, do WE need mjpegtools-gui? mjpegtools itself is still required by a shocking number of other packages, all things considered. But its GUI components are, quite frankly, crap. What use are poor clones of ffplay that each only support one specific (and outdated) video format? I don't think it would be any great loss to just drop mjpegtools-gui, and I bet nobody would miss it. (Though I suppose only dropping the -gui subpackage wouldn't really *gain* us much, either.) ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
FeRD wrote: > On cursory inspection of the API docs I also don't see any obvious reason > why it would need mjpegtools, but I admit I didn't look very hard. It is the other way round: mjpegtools needs SDL_gfx, not the opposite. Kevin Kofler ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
On Tue, Sep 10, 2019 at 1:04 PM Sérgio Basto wrote: > On Tue, 2019-09-10 at 18:54 +0200, Xavier Bachelot wrote: > > > > Why ? Is there anything wrong with mjpegtools ? > > > I don't know if have any utility ... > latest version is from 2013-09-27, like libquicktime I think these > packages are already suppressed by new software. > If we can't find for what is used or when is used, we may try drop it ,and > find out :) > In fairness, the version of SDL_gfx *itself* that we're packaging is from 2013-10-27, so... ;-) (There actually was a version 2.0.26 released in 2017, but it seems we never updated. You have to do a bunch of scrolling to find it *waaay* down on the page, but it is actually linked here (eventually): http://www.ferzkopp.net/wordpress/2016/01/02/sdl_gfx-sdl2_gfx/ On cursory inspection of the API docs I also don't see any obvious reason why it would need mjpegtools, but I admit I didn't look very hard. ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
On Tue, 2019-09-10 at 18:54 +0200, Xavier Bachelot wrote: > Le 10/09/2019 à 18:43, Sérgio Basto a écrit : > > On Tue, 2019-09-10 at 18:38 +0200, Xavier Bachelot wrote: > > > Hi Sergio, > > > > > > Le 10/09/2019 à 18:27, Sérgio Basto a écrit : > > > > One question, just a question, mjpegtools is need for what ? > > > > > > > gstreamer1-plugins-bad-freeworld > > > > shoundn't be better remove mjpegtools from dependencies of > > gstreamer1- > > plugins-bad-freeworld ? > > > > Why ? Is there anything wrong with mjpegtools ? I don't know if have any utility ... latest version is from 2013-09-27, like libquicktime I think these packages are already suppressed by new software. If we can't find for what is used or when is used, we may try drop it ,and find out :) Thanks. > ___ > rpmfusion-developers mailing list -- > rpmfusion-developers@lists.rpmfusion.org > To unsubscribe send an email to > rpmfusion-developers-le...@lists.rpmfusion.org -- Sérgio M. B. ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
Le 10/09/2019 à 18:43, Sérgio Basto a écrit : On Tue, 2019-09-10 at 18:38 +0200, Xavier Bachelot wrote: Hi Sergio, Le 10/09/2019 à 18:27, Sérgio Basto a écrit : One question, just a question, mjpegtools is need for what ? gstreamer1-plugins-bad-freeworld shoundn't be better remove mjpegtools from dependencies of gstreamer1- plugins-bad-freeworld ? Why ? Is there anything wrong with mjpegtools ? ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
On Tue, 2019-09-10 at 18:38 +0200, Xavier Bachelot wrote: > Hi Sergio, > > Le 10/09/2019 à 18:27, Sérgio Basto a écrit : > > One question, just a question, mjpegtools is need for what ? > > > gstreamer1-plugins-bad-freeworld shoundn't be better remove mjpegtools from dependencies of gstreamer1- plugins-bad-freeworld ? > > Regards, > Xavier -- Sérgio M. B. ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
Hi Sergio, Le 10/09/2019 à 18:27, Sérgio Basto a écrit : One question, just a question, mjpegtools is need for what ? gstreamer1-plugins-bad-freeworld Regards, Xavier ___ rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
Re: [mjpegtools] Disable use of SDL_gfx on EL8
One question, just a question, mjpegtools is need for what ?
Thanks,
On Tue, 2019-09-10 at 17:57 +0200, Xavier Bachelot wrote:
> commit b90b72150039f53d8b5c9260408731e874cf6d24
> Author: Xavier Bachelot
> Date: Tue Sep 10 17:30:03 2019 +0200
>
> Disable use of SDL_gfx on EL8
>
> mjpegtools.spec | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
> ---
> diff --git a/mjpegtools.spec b/mjpegtools.spec
> index 229150e..cd9a432 100644
> --- a/mjpegtools.spec
> +++ b/mjpegtools.spec
> @@ -1,6 +1,10 @@
> +%if 0%{?el8}
> +%global _without_sdlgfx 1
> +%endif
> +
> Name: mjpegtools
> Version:2.1.0
> -Release:16%{?dist}
> +Release:17%{?dist}
> Summary:Tools to manipulate MPEG data
> License:GPLv2
> URL:http://mjpeg.sourceforge.net/
> @@ -9,13 +13,12 @@ Patch0: mjpegtools-2.1.0-sdl-cflags.patch
> Patch1: mjpegtools-2.1.0-no_format.patch
> Patch2: mjpegtools-2.1.0-pic.patch
>
> -BuildRequires: gcc-c++, gcc
> -%{?el7:BuildRequires: epel-rpm-macros}
> +BuildRequires: gcc-c++
> BuildRequires: libjpeg-devel
> BuildRequires: nasm
> BuildRequires: libdv-devel
> BuildRequires: SDL-devel >= 1.1.3
> -BuildRequires: SDL_gfx-devel
> +%{!?_without_sdlgfx:BuildRequires: SDL_gfx-devel}
> BuildRequires: libquicktime-devel >= 0.9.8
> BuildRequires: libpng-devel
> BuildRequires: gtk2-devel >= 2.4.0
> @@ -108,6 +111,7 @@ done
> %ifarch ppc64
> --enable-simd-accel=no \
> %endif
> +%{?_without_sdlgfx: --without-sdlgfx} \
> --disable-static
> %make_build
>
> @@ -167,6 +171,10 @@ rm %buildroot%{_bindir}/mpegtranscode
>
>
> %changelog
> +* Tue Sep 10 2019 Xavier Bachelot - 2.1.0-17
> +- Disable use of SDL_gfx on EL8.
> +- Minor spec cleanup.
> +
> * Fri Aug 09 2019 RPM Fusion Release Engineering <
> leigh123li...@gmail.com> - 2.1.0-16
> - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
>
--
Sérgio M. B.
___
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
