Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
On Fri, 2003-02-21 at 22:31, Sviatoslav Sviridov wrote: > On 21 Feb 2003 21:41:25 +1100 > Donovan Baarda <[EMAIL PROTECTED]> wrote: > > > On Fri, 2003-02-21 at 18:42, Sviatoslav Sviridov wrote: [...] > > Hmmm, sounds like http://librsync.sourceforge.net/. [...] > I know this project, but it's not the thing we need. It is only algorithm > implementation (and I'm don't remember how it correlate with rsync). I wanted > to use this library for rsync method in apt, but I don't want to create own > rsync protocol implementation. The problem is, I'm not sure what is a bigger job; splitting rsync up into decoupled reusable sub-components, or bringing librsync up to the point where it can be protocol compatible with rsync. -- -- ABO: finger [EMAIL PROTECTED] for more info, including pgp key -- -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
On 21 Feb 2003 21:41:25 +1100 Donovan Baarda <[EMAIL PROTECTED]> wrote: > On Fri, 2003-02-21 at 18:42, Sviatoslav Sviridov wrote: > [...] > > And other thing I want to discuss: now rsync designed as standalone > > program, but it will be good if library with protocol implementation > > created, and build rsync program based on this library. > > Hmmm, sounds like http://librsync.sourceforge.net/. > > The current rsync implementation is tightly coupled and difficult to > split out. There have been various attempts to do this by starting from > scratch. librsync is probably the most advanced rsync algorithm > implementation, and there have been various experiments with alternative > protocols. Someone even announced a perl implementation that is rsync > compatible (impressive)! > > However, librsync lags behind rsync in various ways... the most > important of which is active development. I know this project, but it's not the thing we need. It is only algorithm implementation (and I'm don't remember how it correlate with rsync). I wanted to use this library for rsync method in apt, but I don't want to create own rsync protocol implementation. -- Sviatoslav Sviridov [mailto:[EMAIL PROTECTED]] [ICQ#10845380] [Lintec Project] [MLUG] -- "If you are afraid of loneliness, don't marry." -- Chekhov -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
On Fri, 2003-02-21 at 18:42, Sviatoslav Sviridov wrote: [...] > And other thing I want to discuss: now rsync designed as standalone program, > but it will be good if library with protocol implementation created, and build > rsync program based on this library. Hmmm, sounds like http://librsync.sourceforge.net/. The current rsync implementation is tightly coupled and difficult to split out. There have been various attempts to do this by starting from scratch. librsync is probably the most advanced rsync algorithm implementation, and there have been various experiments with alternative protocols. Someone even announced a perl implementation that is rsync compatible (impressive)! However, librsync lags behind rsync in various ways... the most important of which is active development. -- -- ABO: finger [EMAIL PROTECTED] for more info, including pgp key -- -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
On Wed, 19 Feb 2003 13:53:17 -0800 jw schultz <[EMAIL PROTECTED]> wrote: > On Wed, Feb 19, 2003 at 12:25:43PM -0500, Paul Green wrote: > > Sviatoslav Sviridov [mailto:[EMAIL PROTECTED]] wrote: > > >It would be good if attached patch will be included in upstream. This > > >patch adds option --apt-support for rsync and with this option rsync > > >will print some additional information about file being transfered. No > > >program logic changed. Having this option in rsync we can have apt with > > >rsync method support. > > > > 1. What is apt? > > 2. The code changes look pretty simple and quite clean, but I didn't see > > any documentation changes. > > > > Are there any objections to my applying this patch if Sviatoslav supplies > > documentation changes, too? > > I object to the patch. > > As i told him in response to an offline request to me and Martin. > | I will not recommend this patch. The focus seems > | far too narrow and there is no coherent argument for > | inclusion. This just smacks of option proliferation. > > He provides no justification for the patch. It adds yet > another verbosity option for the purposes of reporting > progress. Oh, and why "apt" that smacks of name pollution. > > If we are going to add this sort of progress reporting let's > do so with a unified verbosity/progress report framework. > There are plenty of verbosity methods i and others would > like. Much better would be to have a --log-opts that > accepts a list of independent keywords and can be used > instead of -v with stacking. Looks very good, this would be better. Does anybody want to implement this? Can I help with this? And other thing I want to discuss: now rsync designed as standalone program, but it will be good if library with protocol implementation created, and build rsync program based on this library. -- Sviatoslav Sviridov [mailto:[EMAIL PROTECTED]] [ICQ#10845380] [Lintec Project] [MLUG] -- I do not believe that this generation of Americans is willing to resign itself to going to bed each night by the light of a Communist moon... - Lyndon B. Johnson -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
jw schultz <[EMAIL PROTECTED]> wrote: >On Wed, Feb 19, 2003 at 12:25:43PM -0500, Paul Green wrote: >> Sviatoslav Sviridov [mailto:[EMAIL PROTECTED]] wrote: >> >It would be good if attached patch will be included in upstream. This >> >patch adds option --apt-support for rsync and with this option rsync >> >will print some additional information about file being transfered. No >> >program logic changed. Having this option in rsync we can have apt with >> >rsync method support. >> >> 1. What is apt? >> 2. The code changes look pretty simple and quite clean, but I didn't see any >> documentation changes. >> >> Are there any objections to my applying this patch if Sviatoslav supplies >> documentation changes, too? > >I object to the patch. > >As i told him in response to an offline request to me and Martin. >| I will not recommend this patch. The focus seems >| far too narrow and there is no coherent argument for >| inclusion. This just smacks of option proliferation. I'd like to hold these discussions on-list. I would hate to apply a patch that had been privately rejected because I wasn't aware of the wider context. >He provides no justification for the patch. It adds yet >another verbosity option for the purposes of reporting >progress. Oh, and why "apt" that smacks of name pollution. > >If we are going to add this sort of progress reporting let's >do so with a unified verbosity/progress report framework. >There are plenty of verbosity methods i and others would >like. Much better would be to have a --log-opts that >accepts a list of independent keywords and can be used >instead of -v with stacking. I concur completely. Thanks PG -- Paul Green, Senior Technical Consultant, Stratus Technologies. Voice: +1 978-461-7557; FAX: +1 978-461-3610 Speaking from Stratus not for Stratus -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
On Wed, Feb 19, 2003 at 12:25:43PM -0500, Paul Green wrote: > Sviatoslav Sviridov [mailto:[EMAIL PROTECTED]] wrote: > >It would be good if attached patch will be included in upstream. This > >patch adds option --apt-support for rsync and with this option rsync > >will print some additional information about file being transfered. No > >program logic changed. Having this option in rsync we can have apt with > >rsync method support. > > 1. What is apt? > 2. The code changes look pretty simple and quite clean, but I didn't see any > documentation changes. > > Are there any objections to my applying this patch if Sviatoslav supplies > documentation changes, too? I object to the patch. As i told him in response to an offline request to me and Martin. | I will not recommend this patch. The focus seems | far too narrow and there is no coherent argument for | inclusion. This just smacks of option proliferation. He provides no justification for the patch. It adds yet another verbosity option for the purposes of reporting progress. Oh, and why "apt" that smacks of name pollution. If we are going to add this sort of progress reporting let's do so with a unified verbosity/progress report framework. There are plenty of verbosity methods i and others would like. Much better would be to have a --log-opts that accepts a list of independent keywords and can be used instead of -v with stacking. -- J.W. SchultzPegasystems Technologies email address: [EMAIL PROTECTED] Remember Cernan and Schmitt -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
Sviatoslav Sviridov [mailto:[EMAIL PROTECTED]] wrote: >It would be good if attached patch will be included in upstream. This >patch adds option --apt-support for rsync and with this option rsync >will print some additional information about file being transfered. No >program logic changed. Having this option in rsync we can have apt with >rsync method support. 1. What is apt? 2. The code changes look pretty simple and quite clean, but I didn't see any documentation changes. Are there any objections to my applying this patch if Sviatoslav supplies documentation changes, too? Thanks PG -- Paul Green, Senior Technical Consultant, Stratus Technologies. Voice: +1 978-461-7557; FAX: +1 978-461-3610 Speaking from Stratus not for Stratus -- To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Fw: Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
Hello,
It would be goog if attached patch will be included in upstream. This
patch adds option --apt-support for rsync and with this option rsync
will print some additiona information about file being transfered. No
program logic changed. Having this option in rsync we can have apt with
rsync method support.
Begin forwarded message:
Date: Fri, 31 Jan 2003 11:34:14 -0200
From: Gustavo Niemeyer <[EMAIL PROTECTED]>
To: Sviatoslav Sviridov <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Subject: Re: [Apt-rpm] I: [PATCH] 0.5.4cnc9: rsync method support
> There was 2 patches for rsync: one fixes bug wich causes to recursion
> inside rsync, this applied to upstream. Other required only for apt's
> rsync method, it was not sent to rsync mailing list. May be if apt
> will have rsync method this patch will be applied to upstream :) It
> only add some output to allow apt show download progress.
Can you please contact rsync authors and check if this is doable? I'd
be glad to include support for rsync if no patches in rsync were
necessary.
--
Gustavo Niemeyer
[ 2AAC 7928 0FBF 0299 5EB5 60E2 2253 B29A 6664 3A0C ]
--
Sviatoslav Sviridoff
// Lintec Project/Minsk // PIN AG/Berlin //
--
Kissing a fish is like smoking a bicycle.
--- rsync-2.5.6/options.c.orig 2003-01-28 06:11:57 +0300
+++ rsync-2.5.6/options.c 2003-01-28 17:38:39 +0300
@@ -127,6 +127,8 @@ static int modify_window_set;
* address, or a hostname. **/
char *bind_address;
+/** Print information needed for APT rsync method */
+int apt_support = 0;
static void print_rsync_version(enum logcode f)
{
@@ -370,6 +372,7 @@ static struct poptOption long_options[]
{0,'4', POPT_ARG_VAL,&default_af_hint, AF_INET , 0, 0 },
{0,'6', POPT_ARG_VAL,&default_af_hint, AF_INET6 , 0, 0 },
#endif
+ {"apt-support", 0, POPT_ARG_NONE, &apt_support, 0, 0, 0 },
{0,0,0,0, 0, 0, 0}
};
--- rsync-2.5.6/receiver.c.orig 2003-01-21 02:32:17 +0300
+++ rsync-2.5.6/receiver.c 2003-01-28 17:41:54 +0300
@@ -319,6 +319,7 @@ int recv_files(int f_in,struct file_list
extern int preserve_perms;
extern int delete_after;
extern int orig_umask;
+ extern int apt_support;
struct stats initial_stats;
if (verbose > 2) {
@@ -444,6 +445,12 @@ int recv_files(int f_in,struct file_list
cleanup_set(fnametmp, fname, file, buf, fd1, fd2);
+ if (apt_support) {
+ rprintf(FINFO,"Tmp-Filename: %s\n",fnametmp);
+ rprintf(FINFO,"Size: %u\n",file->length);
+ rprintf(FINFO,"Start: %s\n",fname);
+ }
+
if (!am_server) {
log_transfer(file, fname);
}
@@ -475,6 +482,8 @@ int recv_files(int f_in,struct file_list
rprintf(FINFO,"redoing %s(%d)\n",fname,i);
write_int(f_gen,i);
}
+ } else if (apt_support) {
+ rprintf(FINFO,"Done: %s\n",fname);
}
}
--
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
