Re: [Rails-core] Re: Persistence ignorance in Rails. ActiveRecord 6 and beyond!

2020-02-18 Thread Kasper Hansen
Well said, Pedro. I don’t think there’s much interest in adding the repository 
pattern to Active Record.

--
Kasper
On 18 Feb 2020, 15.28 +0100, Pedro Fernandes Steimbruch 
, wrote:
> Just my two cents here.
>
> Do not waste time trying to apply code concepts (factories, repositories, 
> etc.) from the Eric Evans book, if you think you are DDD only by using those, 
> you are doing it wrong.
> DDD is much more about Crunching Knowledge, Ubiquitous Language, Bounded 
> Contexts and converging these to express your domain on your model always 
> evolving to a deeper insight.
>
> DDD is about tackling complexity on your software. Isn't writing a lot of 
> code just to implement *Persistence Ignorance* increasing the complexity of 
> what you have?
>
> Enjoy what ActiveRecord gives you in a healthy way.
>
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/rubyonrails-core/CAA2Dq%2BMK5MK-tiYpvABbh%3DtV%3DVfdxkS9nhe-JwEWjmLitbWipg%40mail.gmail.com.
On Mon, Feb 10, 2020 at 4:14 PM Laerti Papa  wrote:
> Thank you for your reply,
>
> I understand that it is against the active record philosophy, it would be 
> nice though to support both patterns and let the developer choose. I end up 
> writing a lot of code every time I use AR only as the persistence on top of a 
> repo instance.
>
>
> Thanks again.
> LP
>
>
> On Monday, February 10, 2020 at 4:24:11 AM UTC+1, William T. Nelson wrote:
> > Building this capability into Rails would be contrary to the current 
> > project philosophy, so don't expect it soon.
> >
> > However, Ryan Bigg has been working on similar features recently. See his 
> > reports here: https://ryanbigg.com/2020/02/rom-and-dry-showcase-part-1
> >
> > On Monday, February 3, 2020 at 9:39:47 PM UTC-6, Laerti Papa wrote:
> > > Hi guys,
> > >
> > > thank you for your effort so far and for your contribution.
> > >
> > > I've been playing around with DDD concepts lately and trying to apply 
> > > them to Rails. It's been super annoying and frustrating trying to fight 
> > > the framework to apply them especially when it comes to **Persistence 
> > > ignorance**. It would be nice if the framework supported that out of the 
> > > box either with a DSL likeish framework or configuration files. Also to 
> > > have a more safe typing approach regarding data attributes I have to 
> > > either implement it myself or use existing libraries like dry-rb or 
> > > something.
> > >
> > > I was curious why so many years we don't decouple active record into two 
> > > pieces. One to keep it as is. Second, allow users to decouple entities 
> > > and data access objects and have a framework that will support them in 
> > > better domain modeling without having to write much-supporting code to do 
> > > so.
> > >
> > > I would appreciate any thoughts.
> > >
> > > Best
> > > LP
> > >
> > >
> > >
> > >
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/rubyonrails-core/ec331d07-d81a-45eb-a9e8-eb43728be750%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/rubyonrails-core/bbfc9c27-098f-418f-9434-ba7d373a6429%40Spark.


Re: [Rails-core] Re: ActiveJob and :exponentially_longer

2019-11-28 Thread Kasper Hansen
It’s merged. Thanks everyone 

--
Kasper
On 28 Nov 2019, 19.08 +0100, Santiago Bartesaghi 
, wrote:
> +1 to get this feature into Rails
>
> On Friday, February 2, 2018 at 2:04:30 PM UTC-3, Anthony Ross wrote:
> > We're seeing issues using :exponentially_longer where failures in 
> > downstream systems are causing a thundering herd effect.  A great many jobs 
> > fail, they all get enqueued to try again in a static interval and bring 
> > down the downstream system yet again.  This repeats until the retry limit 
> > is exhausted.
> >
> > We've gotten around this using a custom `wait` block but since exponential 
> > backoff with randomness is builtin to some adapters, like Sidekiq , I'm 
> > propsing to have it baked into to :exponentially_longer.
> >
> > I submitted a PR here: https://github.com/rails/rails/pull/31872
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/rubyonrails-core/9dd33afd-f746-4e68-a382-00f2f352d222%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/rubyonrails-core/25021fa2-d30f-4477-bee9-6460d5575726%40Spark.


Re: [Rails-core] Why don't we redesign our website and docs rubyonrails.org like laravel.com

2019-10-29 Thread Kasper Hansen
I prefer the more differentiated look of the current design to laravel’s 
corporate-ish blandness. So don’t think we’ll be stepping away from that.

Now as for the docs, we’re happy to help review/merge PRs from volunteers with 
concrete suggestions for readability improvements 

--
Kasper

> On 28 Oct 2019, at 17.06, Agus Syahputra  wrote:
> 
> Ruby on Rails is the father of the MVC framework used by many web developers.
> 
> But the design of the main website rubyonrails.org is getting old.
> 
> Can we redesign our website so it looks more modern and to structure the docs 
> so it's more simple and easier to read?
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/rubyonrails-core/57555db3-e7b2-425d-8448-97ec726ec1bf%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/rubyonrails-core/EBF076C7-2B7A-4533-8493-91C7C8383473%40gmail.com.


Re: [Rails-core] [Feature] Support parsing msgpack parameters natively

2019-09-28 Thread Kasper Hansen
This isn’t really fruitful. You’re volunteering this discussion, so it’s on you 
to provide reasons. Which could be benefits of msgpack compared to xml/json, 
how does browsers support it, performance benchmarks, a gist with an attempt at 
a patch, etc.

Instead your request boils down to “I want msgpack, so you should write it and 
maintain it because I said so”. To which the only answer is: nope.

Making a gem is the only way I see this moving forward, then there’d be 
something to talk about ✌️

--
Kasper
On 28 Sep 2019, 21.53 +0200, Hirad Y. , wrote:
> Hi Kasper, thanks for your reply. Why not?! parsing json/xml parameters are 
> built, but not msgpack? I understand it is more of a binary format, but can 
> be simply wrapped in with params hash in specific order, which correspond to 
> activerecord attributes. I'm failing to see the reason for your ambiguous 
> straightforward `no` answer!
>
> On Saturday, 28 September 2019 20:08:33 UTC+1, Kasper Timm Hansen wrote:
> > Hey,
> >
> > I don’t see the reason for why we would accept a PR to add that parsing 
> > within Rails. Make a gem ✌️
> >
> > --
> > Kasper
> > On 23 Sep 2019, 10.52 +0200, Hirad Y. , wrote:
> > > I'd like to request to support parsing MsgPack parameters along with 
> > > other already available parsers (i.e. json and xml parsers).
> > >
> > > Thanks
> > > --
> > > You received this message because you are subscribed to the Google Groups 
> > > "Ruby on Rails: Core" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an 
> > > email to rubyonra...@googlegroups.com.
> > > To view this discussion on the web visit 
> > > https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/rubyonrails-core/2f708316-5257-418d-8c41-419a6390071d%40Spark.


Re: [Rails-core] [Feature] Support parsing msgpack parameters natively

2019-09-28 Thread Kasper Hansen
Hey,

I don’t see the reason for why we would accept a PR to add that parsing within 
Rails. Make a gem ✌️

--
Kasper
On 23 Sep 2019, 10.52 +0200, Hirad Y. , wrote:
> I'd like to request to support parsing MsgPack parameters along with other 
> already available parsers (i.e. json and xml parsers).
>
> Thanks
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/rubyonrails-core/3d33f9ff-6caf-49fa-9d3b-ea5dbed0625f%40Spark.


Re: [Rails-core] Proposal to run RuboCop using GitHub Actions

2019-09-28 Thread Kasper Hansen
Hey Yasuo,

I’m fine with it. But I’d leave final call to Eileen who has an open PR to use 
GitHub actions in general.

--
Kasper
On 23 Sep 2019, 03.35 +0200, Yasuo Honda , wrote:
> Hi,
>
> I'd like to propose run RuboCop at https://github.com/rails/rails using 
> GitHub Actions.
>
> As of right now, RuboCop is running using Code Climate. Here are some 
> restrictions:
>
> * Need to wait for newer channel like `channel: rubocop-0-74` available at 
> Code Climate
> Refer https://github.com/rails/rails/pull/36943
>
> * `rubocop-0-74` locks RuboCop Performance and RuboCop Rails versions to 
> somewhat lower versions
>
> * Code Climate runs for pull requests but not for direct push push
>
> With GitHub Actions I think we can unlock these restrictions:
>
> * Just updating Gemfile and Gemfile.lock to decide which RuboCop, RuboCop 
> Performance and RuboCop Rails versions to run
>
> * Runs for both direct push and pull requests
>
> I have enabled GitHub Actions to run RuboCop for Oracle enhanced adapter 
> https://github.com/rsim/oracle-enhanced/pull/1925
>  and it has been working fine. Also, I have opened a PoC pull request to my 
> forked repository https://github.com/yahonda/rails/pull/2 , which looks good 
> to me.
>
> Let me know your thoughts for my proposal.
>
> Thanks,
> --
> Yasuo Honda
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/rubyonrails-core/c646f0c5-abee-4c7c-b825-beae7aa2d5ac%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/rubyonrails-core/06d1f588-e0c2-4828-8641-42e34e70dc04%40Spark.


Re: [Rails-core] [ActiveStorage][Feature Proposal] Adding Support of Dropbox

2019-04-08 Thread Kasper Hansen
Fantastic! Thanks to you and Abhinav ❤️

--
Kasper

> On 8 Apr 2019, at 07.02, Ashish Prajapati  wrote:
> 
> Kasper,
> 
> Thanks for your email. It worked and we got the name 'activestorage-dropbox 
> '. I am also thanking 
> Abhinav to help us in this.
> 
> I released the gem here :)  
> 
> https://rubygems.org/gems/activestorage-dropbox 
> 
> 
> 
> On Monday, April 8, 2019 at 1:00:21 AM UTC+5:30, Ashish Prajapati wrote:
> Sure.. Many thanks Kasper. 
> 
> On Monday, April 8, 2019 at 12:47:04 AM UTC+5:30, Kasper Timm Hansen wrote:
> I’ve sent an email to him and cc’ed you on it. Let’s continue privately and 
> see if we can’t get the name.
> 
> Thanks again!
> 
> --
> Kasper
> 
>> On 7 Apr 2019, at 20.42, Ashish Prajapati clecotech.com 
>> > wrote:
>> 
>> Kasper, I am saying it (https://rubygems.org/gems/activestorage_dropbox 
>> ) [Official] because 
>> someone else squatted the name `activestorage-dropbox` :-( at the same day 
>> when you suggested me to start working on it. So, I just used 
>> activestorage_dropbox name and calling it official so people will find the 
>> original one and will not get confused with the other one 
>> activestorage-dropbox ( I saw it and It's just a blank copy of gem. It's 
>> just for squatting the name activestorage-dropbox. )  I felt bit unhappy 
>> after seeing it :(
>> 
>> But, I did my job and I came up with activestorage_dropbox name 
>> (https://rubygems.org/gems/activestorage_dropbox 
>> ). 
>> 
>> Thanks
>> 
>> On Sunday, April 7, 2019 at 11:52:49 PM UTC+5:30, Kasper Timm Hansen wrote:
>> Seconded, congrats on the release!
>> 
>> Curious, why you're saying [Official] on RubyGems? It’s just a regular old 
>> gem and I don’t see what’s official about it 
>> https://rubygems.org/gems/activestorage_dropbox 
>> 
>> 
>> Also a little annoying that the activestorage-dropbox gem name got squatted 
>> by someone else right after I had suggested it 
>> https://github.com/abhinavmsra/activestorage-dropbox 
>> 
>> 
>> Happy maintaining! 
>> 
>> --
>> Kasper
>> 
>>> On 7 Apr 2019, at 05.01, Jeremy Daer > wrote:
>>> 
>>> Congratulations on the release, and thank you for sharing your work!
>>> 
>>> On Sat, Apr 6, 2019 at 14:34 Ashish Prajapati > 
>>> wrote:
>>> Hello Kasper,
>>> 
>>> I have completed the work of the Dropbox Support for Active Storage. And 
>>> now, I released the gem activestorage_dropbox and it provides the 
>>> capability to support Dropbox as a storage for Active Storage.
>>> 
>>> Dropbox Support for Active Storage - Official Gem [ 
>>> Activestorage::Service::DropboxService ]
>>> ( Wraps the Dropbox Storage Service as an Active Storage service. )
>>> 
>>> https://github.com/ashishprajapati/activestorage_dropbox 
>>> 
>>> https://rubygems.org/gems/activestorage_dropbox/versions/0.1.0 
>>> 
>>> 
>>> gem 'activestorage_dropbox'
>>> 
>>> Thanks,
>>> Ashish Prajapati
>>> 
>>> 
>>> On Monday, March 11, 2019 at 1:39:01 AM UTC+5:30, Ashish Prajapati wrote:
>>> Thanks Kasper,
>>> 
>>> Yeah, It's a great option and will be really great! I will definitely 
>>> create activestorage-dropbox gem. 
>>> 
>>> On Sunday, March 10, 2019 at 2:09:06 PM UTC+5:30, Kasper Timm Hansen wrote:
>>> Hey,
>>> 
>>> I think Active Storage has the amount of built in services we want. Akin to 
>>> Active Job queues and Active Record databases, we don’t want every option 
>>> directly but gems are cool!
>>> 
>>> So if you made an activestorage-dropbox gem on your account that would be 
>>> sweet!
>>> 
>>> --
>>> Kasper
>>> On 10 Mar 2019, 09.32 +0100, Ashish Prajapati >, 
>>> wrote:
 Hello Team,
 
 I want to add the support of Dropbox to the ActiveStorage. 
 I really hope that it will help lots of people those really need to 
 consume dropbox as the storage option for their projects similar to other 
 Cloud Storage Services.
 
 Well, I have implemented this ability to support Dropbox with in the 
 ActiveStorage in one of my Private Project but I want to make it publicly 
 available so I am thinking to add this support directly to the 
 ActiveStorage module of Rails Project.
 
 Team, Is it feasible to add the support of Dropbox to ActiveStorage  ? I 
 am happy to raise the PR soon if It's good to go.
 
 I am happy to have the views on it.
 
 Thanks,
 Ashish Prajapati 
 https://github.com/ashishprajapati 
 
 
 --
 You received this message because you are subscribed to the Google Groups 
 "Ruby on Rails: Core" group.
 

Re: [Rails-core] [ActiveStorage][Feature Proposal] Adding Support of Dropbox

2019-04-07 Thread Kasper Hansen
I’ve sent an email to him and cc’ed you on it. Let’s continue privately and see 
if we can’t get the name.

Thanks again!

--
Kasper

> On 7 Apr 2019, at 20.42, Ashish Prajapati  wrote:
> 
> Kasper, I am saying it (https://rubygems.org/gems/activestorage_dropbox 
> ) [Official] because someone 
> else squatted the name `activestorage-dropbox` :-( at the same day when you 
> suggested me to start working on it. So, I just used activestorage_dropbox 
> name and calling it official so people will find the original one and will 
> not get confused with the other one activestorage-dropbox ( I saw it and It's 
> just a blank copy of gem. It's just for squatting the name 
> activestorage-dropbox. )  I felt bit unhappy after seeing it :(
> 
> But, I did my job and I came up with activestorage_dropbox name 
> (https://rubygems.org/gems/activestorage_dropbox 
> ). 
> 
> Thanks
> 
> On Sunday, April 7, 2019 at 11:52:49 PM UTC+5:30, Kasper Timm Hansen wrote:
> Seconded, congrats on the release!
> 
> Curious, why you're saying [Official] on RubyGems? It’s just a regular old 
> gem and I don’t see what’s official about it 
> https://rubygems.org/gems/activestorage_dropbox 
> 
> 
> Also a little annoying that the activestorage-dropbox gem name got squatted 
> by someone else right after I had suggested it 
> https://github.com/abhinavmsra/activestorage-dropbox 
> 
> 
> Happy maintaining! 
> 
> --
> Kasper
> 
>> On 7 Apr 2019, at 05.01, Jeremy Daer > wrote:
>> 
>> Congratulations on the release, and thank you for sharing your work!
>> 
>> On Sat, Apr 6, 2019 at 14:34 Ashish Prajapati > 
>> wrote:
>> Hello Kasper,
>> 
>> I have completed the work of the Dropbox Support for Active Storage. And 
>> now, I released the gem activestorage_dropbox and it provides the capability 
>> to support Dropbox as a storage for Active Storage.
>> 
>> Dropbox Support for Active Storage - Official Gem [ 
>> Activestorage::Service::DropboxService ]
>> ( Wraps the Dropbox Storage Service as an Active Storage service. )
>> 
>> https://github.com/ashishprajapati/activestorage_dropbox 
>> 
>> https://rubygems.org/gems/activestorage_dropbox/versions/0.1.0 
>> 
>> 
>> gem 'activestorage_dropbox'
>> 
>> Thanks,
>> Ashish Prajapati
>> 
>> 
>> On Monday, March 11, 2019 at 1:39:01 AM UTC+5:30, Ashish Prajapati wrote:
>> Thanks Kasper,
>> 
>> Yeah, It's a great option and will be really great! I will definitely create 
>> activestorage-dropbox gem. 
>> 
>> On Sunday, March 10, 2019 at 2:09:06 PM UTC+5:30, Kasper Timm Hansen wrote:
>> Hey,
>> 
>> I think Active Storage has the amount of built in services we want. Akin to 
>> Active Job queues and Active Record databases, we don’t want every option 
>> directly but gems are cool!
>> 
>> So if you made an activestorage-dropbox gem on your account that would be 
>> sweet!
>> 
>> --
>> Kasper
>> On 10 Mar 2019, 09.32 +0100, Ashish Prajapati >, 
>> wrote:
>>> Hello Team,
>>> 
>>> I want to add the support of Dropbox to the ActiveStorage. 
>>> I really hope that it will help lots of people those really need to consume 
>>> dropbox as the storage option for their projects similar to other Cloud 
>>> Storage Services.
>>> 
>>> Well, I have implemented this ability to support Dropbox with in the 
>>> ActiveStorage in one of my Private Project but I want to make it publicly 
>>> available so I am thinking to add this support directly to the 
>>> ActiveStorage module of Rails Project.
>>> 
>>> Team, Is it feasible to add the support of Dropbox to ActiveStorage  ? I am 
>>> happy to raise the PR soon if It's good to go.
>>> 
>>> I am happy to have the views on it.
>>> 
>>> Thanks,
>>> Ashish Prajapati 
>>> https://github.com/ashishprajapati 
>>> 
>>> 
>>> --
>>> You received this message because you are subscribed to the Google Groups 
>>> "Ruby on Rails: Core" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to rubyonrails-co...@googlegroups.com <>.
>>> To post to this group, send email to rubyonra...@googlegroups.com <>.
>>> Visit this group at https://groups.google.com/group/rubyonrails-core 
>>> .
>>> For more options, visit https://groups.google.com/d/optout 
>>> .
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Ruby on Rails: Core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to rubyonra...@googlegroups.com <>.
>> To post to this group, send email to rubyonra...@googlegroups.com <>.
>> Visit this group at 

Re: [Rails-core] [ActiveStorage][Feature Proposal] Adding Support of Dropbox

2019-04-07 Thread Kasper Hansen
Seconded, congrats on the release!

Curious, why you're saying [Official] on RubyGems? It’s just a regular old gem 
and I don’t see what’s official about it 
https://rubygems.org/gems/activestorage_dropbox

Also a little annoying that the activestorage-dropbox gem name got squatted by 
someone else right after I had suggested it 
https://github.com/abhinavmsra/activestorage-dropbox

Happy maintaining! 

--
Kasper

> On 7 Apr 2019, at 05.01, Jeremy Daer  wrote:
> 
> Congratulations on the release, and thank you for sharing your work!
> 
> On Sat, Apr 6, 2019 at 14:34 Ashish Prajapati  > wrote:
> Hello Kasper,
> 
> I have completed the work of the Dropbox Support for Active Storage. And now, 
> I released the gem activestorage_dropbox and it provides the capability to 
> support Dropbox as a storage for Active Storage.
> 
> Dropbox Support for Active Storage - Official Gem [ 
> Activestorage::Service::DropboxService ]
> ( Wraps the Dropbox Storage Service as an Active Storage service. )
> 
> https://github.com/ashishprajapati/activestorage_dropbox 
> 
> https://rubygems.org/gems/activestorage_dropbox/versions/0.1.0 
> 
> 
> gem 'activestorage_dropbox'
> 
> Thanks,
> Ashish Prajapati
> 
> 
> On Monday, March 11, 2019 at 1:39:01 AM UTC+5:30, Ashish Prajapati wrote:
> Thanks Kasper,
> 
> Yeah, It's a great option and will be really great! I will definitely create 
> activestorage-dropbox gem. 
> 
> On Sunday, March 10, 2019 at 2:09:06 PM UTC+5:30, Kasper Timm Hansen wrote:
> Hey,
> 
> I think Active Storage has the amount of built in services we want. Akin to 
> Active Job queues and Active Record databases, we don’t want every option 
> directly but gems are cool!
> 
> So if you made an activestorage-dropbox gem on your account that would be 
> sweet!
> 
> --
> Kasper
> On 10 Mar 2019, 09.32 +0100, Ashish Prajapati >, 
> wrote:
>> Hello Team,
>> 
>> I want to add the support of Dropbox to the ActiveStorage. 
>> I really hope that it will help lots of people those really need to consume 
>> dropbox as the storage option for their projects similar to other Cloud 
>> Storage Services.
>> 
>> Well, I have implemented this ability to support Dropbox with in the 
>> ActiveStorage in one of my Private Project but I want to make it publicly 
>> available so I am thinking to add this support directly to the ActiveStorage 
>> module of Rails Project.
>> 
>> Team, Is it feasible to add the support of Dropbox to ActiveStorage  ? I am 
>> happy to raise the PR soon if It's good to go.
>> 
>> I am happy to have the views on it.
>> 
>> Thanks,
>> Ashish Prajapati 
>> https://github.com/ashishprajapati 
>> 
>> 
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Ruby on Rails: Core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to rubyonrails-co...@googlegroups.com <>.
>> To post to this group, send email to rubyonra...@googlegroups.com <>.
>> Visit this group at https://groups.google.com/group/rubyonrails-core 
>> .
>> For more options, visit https://groups.google.com/d/optout 
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to 

Re: [Rails-core] feature: Using locals to generate custom cache key when rendering collection

2019-03-24 Thread Kasper Hansen
Just the documentation section. #cache in render_helper doesn’t make sense.

A guide shouldn’t be an exhaustive list of every possible option, so let’s skip 
that too.

--
Kasper

> On 24 Mar 2019, at 09.56, Abhay Nikam  wrote:
> 
> I would love to contribute. So when you said move Collection caching section 
> to render, did you mean to move out the method `cache` from `cache_helper` to 
> `render_helper`? Or do we need to just move the documentation to render 
> method about collection caching?
> 
> 
> Collection caching is also mentioned here 
> https://guides.rubyonrails.org/caching_with_rails.html#collection-caching 
>  . 
> Do we need to add `cached: block` here?
> 
> On Friday, March 22, 2019 at 10:54:13 PM UTC+5:30, Kasper Timm Hansen wrote:
> Glad to hear it!
> 
> I just realized we should probably move that section to the render method 
> instead. Since that’s where the option is.
> 
> So there’s a free PR there for anyone who’s interested!
> 
> --
> Kasper
> On 22 Mar 2019, 18.20 +0100, Adam Stockland gmail.com 
> >, wrote:
>> How did I miss that??!!  I must have read through those docs a million 
>> times.  Thank you so much for posting.
>> 
>> On Friday, March 22, 2019 at 8:11:57 AM UTC-6, Kasper Timm Hansen wrote:
>> Hey Adam,
>> 
>> That’s already possible. See the Collection Caching section here: 
>> https://api.rubyonrails.org/classes/ActionView/Helpers/CacheHelper.html#method-i-cache
>>  
>> 
>> 
>> <%= render partial: 'projects/project', collection: @projects, cached: -> 
>> project { [ project, current_user ] } %>
>> 
>> --
>> Kasper
>> 
>>> On 15 Mar 2019, at 22.48, Adam Stockland > wrote:
>>> 
>>> Not sure if this is a quality idea, or not.  When rendering a collection, 
>>> could a custom cache key be generated using the object and any locals being 
>>> passed?
>>> Example: including current_user in the collection cache key
>>> 
>>> 
>>> 
>>> --
>>> You received this message because you are subscribed to the Google Groups 
>>> "Ruby on Rails: Core" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to rubyonrails-co...@ <>googlegroups.com .
>>> To post to this group, send email to rubyonra...@ <>googlegroups.com 
>>> .
>>> Visit this group at https://groups.google.com/group/rubyonrails-core 
>>> .
>>> For more options, visit https://groups.google.com/d/optout 
>>> .
>> 
>> 
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Ruby on Rails: Core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to rubyonrails-co...@googlegroups.com <>.
>> To post to this group, send email to rubyonra...@googlegroups.com <>.
>> Visit this group at https://groups.google.com/group/rubyonrails-core 
>> .
>> For more options, visit https://groups.google.com/d/optout 
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] feature: Using locals to generate custom cache key when rendering collection

2019-03-22 Thread Kasper Hansen
Glad to hear it!

I just realized we should probably move that section to the render method 
instead. Since that’s where the option is.

So there’s a free PR there for anyone who’s interested!

--
Kasper
On 22 Mar 2019, 18.20 +0100, Adam Stockland , wrote:
> How did I miss that??!!  I must have read through those docs a million times. 
>  Thank you so much for posting.
>
> On Friday, March 22, 2019 at 8:11:57 AM UTC-6, Kasper Timm Hansen wrote:
> > Hey Adam,
> >
> > That’s already possible. See the Collection Caching section here: 
> > https://api.rubyonrails.org/classes/ActionView/Helpers/CacheHelper.html#method-i-cache
> >
> > <%= render partial: 'projects/project', collection: @projects, cached: -> 
> > project { [ project, current_user ] } %>
> >
> > --
> > Kasper
> >
> > > On 15 Mar 2019, at 22.48, Adam Stockland  wrote:
> > >
> > > Not sure if this is a quality idea, or not.  When rendering a collection, 
> > > could a custom cache key be generated using the object and any locals 
> > > being passed?
> > > Example: including current_user in the collection cache key
> > >
> > >
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups 
> > > "Ruby on Rails: Core" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an 
> > > email to rubyonrails-co...@googlegroups.com.
> > > To post to this group, send email to rubyonra...@googlegroups.com.
> > > Visit this group at https://groups.google.com/group/rubyonrails-core.
> > > For more options, visit https://groups.google.com/d/optout.
> >
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> Visit this group at https://groups.google.com/group/rubyonrails-core.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] feature: Using locals to generate custom cache key when rendering collection

2019-03-22 Thread Kasper Hansen
Hey Adam,

That’s already possible. See the Collection Caching section here: 
https://api.rubyonrails.org/classes/ActionView/Helpers/CacheHelper.html#method-i-cache
 


<%= render partial: 'projects/project', collection: @projects, cached: -> 
project { [ project, current_user ] } %>

--
Kasper

> On 15 Mar 2019, at 22.48, Adam Stockland  wrote:
> 
> Not sure if this is a quality idea, or not.  When rendering a collection, 
> could a custom cache key be generated using the object and any locals being 
> passed?
> Example: including current_user in the collection cache key
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] [ActionMailbox][Feature Proposal] Adding third-party ingress options through dependency injection and/or loadable modules

2019-03-18 Thread Kasper Hansen
Cool, good luck!

--
Kasper

> On 18 Mar 2019, at 18.22, tad...@postageapp.com wrote:
> 
> Will have to try that and see how it goes.
> 
> Was having trouble posting to this mailing list so I wasn't sure if anything 
> was going through.
> 
> Thanks!
> 
> On Saturday, March 9, 2019 at 1:45:13 PM UTC-5, Kasper Timm Hansen wrote:
> Hey Scott,
> 
> There’s an ActionMailbox::BaseController already, so I think you could do 
> this in an engine:
> 
> # Follows the format of 
> https://github.com/rails/rails/blob/62105f0aed847f0ab4012e1b91e094e218aa9e08/actionmailbox/app/controllers/action_mailbox/ingresses/mailgun/inbound_emails_controller.rb
>  
> 
> class ActionMailbox::Ingresses::Postage::InboundEmailsController < 
> ActionMailbox::BaseController
>   before_action :authenticate
> 
>def create
>   ActionMailbox::InboundEmail.create_and_extract_message_id! 
> params.require(…)
> end
> 
>   private
> def authenticate
>   # Hey oh!
> end
> end
> 
> And you’d need to setup a route in your engine that matches: 
> https://github.com/rails/rails/blob/62105f0aed847f0ab4012e1b91e094e218aa9e08/actionmailbox/config/routes.rb#L7
>  
> 
> 
> Then config.action_mailbox.ingress = :postage should work.
> 
> Or perhaps you already tried something like this? :)
> 
> --
> Kasper
> 
>> On 7 Mar 2019, at 01.38, Scott Tadman postageapp.com 
>> > wrote:
>> 
>> The current implementation of ActionMailbox comes with a number of ingress 
>> options out of the box, but as far as I can tell there's no obvious way to 
>> add support for others without making a pull request to the Rails core and 
>> including a complete implementation.
>> 
>> I run a Rails-based email platform with an existing Ruby gem that we're 
>> looking to extend to include ActionMailbox support. Based on testing versus 
>> the Rails 6 beta it looks like adding options could be considerably easier 
>> either through documentation or through support for loadable modules.
>> 
>> Issues Faced
>> 
>> The ActionMailbox ingress options are baked in to the ActionMailbox library.
>> 
>> Proposal
>> 
>> Adding ingress options to ActionMailbox should be an easy process based on 
>> following guidelines and examples.
>> 
>> So the two obvious options are:
>> 
>> 1. A non-invasive method would be to develop a well-documented example in 
>> the form of a minimal gem that uses dependency injection to create the 
>> appropriate ActionMailbox ingress routes and controllers. This would be a 
>> Rails engine-type package that can be easily added or removed to any Rails 6 
>> application.
>> 
>> 2. A more direct method would be to develop a plug-in or module system for 
>> ActionMailbox that makes it easier to define ingress handlers, not unlike 
>> how ActionMailer's handler can be extended or replaced in your Rails config 
>> very easily with a minimum of fuss.
>> 
>> Both of these allow third parties to independently iterate and improve on 
>> their ActionMailbox integrations without having to wait for a new 
>> ActionMailbox release for updates, so that could benefit everyone, even 
>> existing implementations.
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Ruby on Rails: Core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to rubyonrails-co...@ <>googlegroups.com .
>> To post to this group, send email to rubyonra...@ <>googlegroups. 
>> com .
>> Visit this group at https://groups.google.com/group/rubyonrails-core 
>> .
>> For more options, visit https://groups.google.com/d/optout 
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send 

Re: [Rails-core] [ActiveStorage][Feature Proposal] Adding Support of Dropbox

2019-03-10 Thread Kasper Hansen
Hey,

I think Active Storage has the amount of built in services we want. Akin to 
Active Job queues and Active Record databases, we don’t want every option 
directly but gems are cool!

So if you made an activestorage-dropbox gem on your account that would be sweet!

--
Kasper
On 10 Mar 2019, 09.32 +0100, Ashish Prajapati , wrote:
> Hello Team,
>
> I want to add the support of Dropbox to the ActiveStorage.
> I really hope that it will help lots of people those really need to consume 
> dropbox as the storage option for their projects similar to other Cloud 
> Storage Services.
>
> Well, I have implemented this ability to support Dropbox with in the 
> ActiveStorage in one of my Private Project but I want to make it publicly 
> available so I am thinking to add this support directly to the ActiveStorage 
> module of Rails Project.
>
> Team, Is it feasible to add the support of Dropbox to ActiveStorage  ? I am 
> happy to raise the PR soon if It's good to go.
>
> I am happy to have the views on it.
>
> Thanks,
> Ashish Prajapati
> https://github.com/ashishprajapati
> --
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> Visit this group at https://groups.google.com/group/rubyonrails-core.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] Database dump and import

2019-03-09 Thread Kasper Hansen
Don’t sweat it! Hopefully you’ll find a solution too. iirc, Heroku has some 
great thorough database docs or maybe their technical support can help :)

See ya!

--
Kasper

> On 9 Mar 2019, at 20.09, brainiacs...@gmail.com wrote:
> 
> My apologies Kasper.
> 
> On Saturday, March 9, 2019 at 2:06:31 PM UTC-5, Kasper Timm Hansen wrote:
> Hey,
> 
> This mailing list is for feature discussions about the framework itself. 
> Please post to Rails-talk or Stack Overflow. Good luck! :)
> 
> --
> Kasper
> 
>> On 9 Mar 2019, at 20.04, braini...@gmail.com <> wrote:
>> 
>> Hey Everyone,
>> 
>> I need to dump the data from a postgress database in Heroku to a mysql 
>> database in Heroku for the Ruby on Rails app that has been upgraded. Can 
>> anyone walk me through the process. Ideally I want to dump the data to my 
>> machine so there is an offline retention of the change as well. Please 
>> advise. 
>> 
>> 
>> Thanks,
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Ruby on Rails: Core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to rubyonrails-co...@googlegroups.com <>.
>> To post to this group, send email to rubyonra...@googlegroups.com <>.
>> Visit this group at https://groups.google.com/group/rubyonrails-core 
>> .
>> For more options, visit https://groups.google.com/d/optout 
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] Database dump and import

2019-03-09 Thread Kasper Hansen
Hey,

This mailing list is for feature discussions about the framework itself. Please 
post to Rails-talk or Stack Overflow. Good luck! :)

--
Kasper

> On 9 Mar 2019, at 20.04, brainiacs...@gmail.com wrote:
> 
> Hey Everyone,
> 
> I need to dump the data from a postgress database in Heroku to a mysql 
> database in Heroku for the Ruby on Rails app that has been upgraded. Can 
> anyone walk me through the process. Ideally I want to dump the data to my 
> machine so there is an offline retention of the change as well. Please 
> advise. 
> 
> 
> Thanks,
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] [ActionMailbox][Feature Proposal] Adding third-party ingress options through dependency injection and/or loadable modules

2019-03-09 Thread Kasper Hansen
Hey Scott,

There’s an ActionMailbox::BaseController already, so I think you could do this 
in an engine:

# Follows the format of 
https://github.com/rails/rails/blob/62105f0aed847f0ab4012e1b91e094e218aa9e08/actionmailbox/app/controllers/action_mailbox/ingresses/mailgun/inbound_emails_controller.rb
class ActionMailbox::Ingresses::Postage::InboundEmailsController < 
ActionMailbox::BaseController
  before_action :authenticate

   def create
  ActionMailbox::InboundEmail.create_and_extract_message_id! 
params.require(…)
end

  private
def authenticate
  # Hey oh!
end
end

And you’d need to setup a route in your engine that matches: 
https://github.com/rails/rails/blob/62105f0aed847f0ab4012e1b91e094e218aa9e08/actionmailbox/config/routes.rb#L7

Then config.action_mailbox.ingress = :postage should work.

Or perhaps you already tried something like this? :)

--
Kasper

> On 7 Mar 2019, at 01.38, Scott Tadman  wrote:
> 
> The current implementation of ActionMailbox comes with a number of ingress 
> options out of the box, but as far as I can tell there's no obvious way to 
> add support for others without making a pull request to the Rails core and 
> including a complete implementation.
> 
> I run a Rails-based email platform with an existing Ruby gem that we're 
> looking to extend to include ActionMailbox support. Based on testing versus 
> the Rails 6 beta it looks like adding options could be considerably easier 
> either through documentation or through support for loadable modules.
> 
> Issues Faced
> 
> The ActionMailbox ingress options are baked in to the ActionMailbox library.
> 
> Proposal
> 
> Adding ingress options to ActionMailbox should be an easy process based on 
> following guidelines and examples.
> 
> So the two obvious options are:
> 
> 1. A non-invasive method would be to develop a well-documented example in the 
> form of a minimal gem that uses dependency injection to create the 
> appropriate ActionMailbox ingress routes and controllers. This would be a 
> Rails engine-type package that can be easily added or removed to any Rails 6 
> application.
> 
> 2. A more direct method would be to develop a plug-in or module system for 
> ActionMailbox that makes it easier to define ingress handlers, not unlike how 
> ActionMailer's handler can be extended or replaced in your Rails config very 
> easily with a minimum of fuss.
> 
> Both of these allow third parties to independently iterate and improve on 
> their ActionMailbox integrations without having to wait for a new 
> ActionMailbox release for updates, so that could benefit everyone, even 
> existing implementations.
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] Re: [Credentials] Should be able to run credentials related command without going through application booting process

2019-02-20 Thread Kasper Hansen
That’s exactly what I was gonna say, thanks!

--
Kasper

> On 20 Feb 2019, at 15.46, Eric Anderson  wrote:
> 
> I think this was corrected in:
> 
> https://github.com/rails/rails/pull/34789
> 
> Looks to have even been backported to 5.2.
> 
> Eric
> 
> On Tuesday, February 19, 2019 at 10:30:31 PM UTC-5, Quang Vu wrote:
> Id, 
> In my computer, it seems every time I run
> rails credentials:edit
> 
> The whole booting process is run. This creates many strange circumstances.
> For example, if a particular key is required when initialized, the process 
> will failed. Because I haven't added it yet.
> 
> I think there is no purpose in booting the app just to edit credentials?
> Or is there any workaround this that I'm not aware of?
> 
> Quang
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to rubyonrails-core+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to rubyonrails-core@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/rubyonrails-core 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] Magic number in tests

2018-02-20 Thread Kasper Hansen
Artur, send a pull request :)

--
Kasper

On 21 Feb 2018, 01.14 +0100, Artur Beljajev , wrote:
> Should I create a ticket on Github first?
>
> On Saturday, January 20, 2018 at 3:28:49 PM UTC+2, Kasper Timm Hansen wrote:
> > Yep, that sounds good too, Kerri.
> >
> > Artur, go right ahead!
> >
> > --
> > Kasper
> >
> > On 10 Jan 2018, 15.37 +0100, Kerri Miller , wrote:
> > > Not to "well actually" myself but another option might be to use 
> > > MAX_PASSWORD_LENGTH_ALLOWED as the OP suggested, but have an explicit 
> > > test for MAX_PASSWORD_LENGTH_ALLOWED=72.. which might actually be a 
> > > better approach, since it'll isolate the exact defect case 
> > > (MAX_PASSWORD_LENGTH_ALLOWED != 72) rather than have it be implied by a 
> > > well-named-but-oddly-disconnected constant.
> > >
> > > // Kerri
> > >
> > > > On Wed, Jan 10, 2018 at 3:19 PM,  wrote:
> > > > > I would be happy to do this!
> > > > >
> > > > >
> > > > > On Tuesday, January 9, 2018 at 10:30:41 PM UTC+2, Kasper Timm Hansen 
> > > > > wrote:
> > > > > > Yep, we could do that 
> > > > > >
> > > > > > > Den 9. jan. 2018 kl. 12.39 skrev Kerri Miller :
> > > > > > >
> > > > > > > I could see an argument made for making it a constant in the 
> > > > > > > _test_ (EXPECTED_MAX_PASSWORD_LENGTH), which at least would 
> > > > > > > document /why/ the number is being used.
> > > > > > >
> > > > > > > > On Tue, Jan 9, 2018 at 11:37 AM, Kasper Timm Hansen 
> > > > > > > >  wrote:
> > > > > > > > > I’m -1 on changing that. I think the constant 72 is used 
> > > > > > > > > directly such that tests will fail if anybody changes 
> > > > > > > > > MAX_PASSWORD_LENGTH_ALLOWED.
> > > > > > > > >
> > > > > > > > > With your change in, a later change to 
> > > > > > > > > MAX_PASSWORD_LENGTH_ALLOWED by some other contributor 
> > > > > > > > > wouldn’t make any tests fail.
> > > > > > > > >
> > > > > > > > > Since that constant isn’t meant to change without us thinking 
> > > > > > > > > more about it, I’d say we keep the code as is.
> > > > > > > > >
> > > > > > > > > Thanks for starting to contribute!
> > > > > > > > >
> > > > > > > > > > Den 9. jan. 2018 kl. 09.56 skrev artur.b...@internet.ee:
> > > > > > > > > >
> > > > > > > > > > Magic number 72 is used many times throughout the tests, 
> > > > > > > > > > which is actually present under 
> > > > > > > > > > ActiveModel::SecurePassword::MAX_PASSWORD_LENGTH_ALLOWED 
> > > > > > > > > > constant. I propose to replace that magic number either by 
> > > > > > > > > > the constant or method call.
> > > > > > > > > >
> > > > > > > > > > I have never contributed to such large open source project 
> > > > > > > > > > as Rails. Please let me know your thoughts.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > https://github.com/rails/rails/blob/master/activemodel/test/cases/secure_password_test.rb
> > > > > > > > > > https://github.com/rails/rails/blob/ff657e73f0b61a7e224a9f158467ed2ec915bd9b/activemodel/lib/active_model/secure_password.rb
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > You received this message because you are subscribed to the 
> > > > > > > > > > Google Groups "Ruby on Rails: Core" group.
> > > > > > > > > > To unsubscribe from this group and stop receiving emails 
> > > > > > > > > > from it, send an email to 
> > > > > > > > > > rubyonrails-co...@googlegroups.com.
> > > > > > > > > > To post to this group, send email to 
> > > > > > > > > > rubyonra...@googlegroups.com.
> > > > > > > > > > Visit this group at 
> > > > > > > > > > https://groups.google.com/group/rubyonrails-core.
> > > > > > > > > > For more options, visit https://groups.google.com/d/optout.
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Kasper
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > You received this message because you are subscribed to the 
> > > > > > > > > Google Groups "Ruby on Rails: Core" group.
> > > > > > > > > To unsubscribe from this group and stop receiving emails from 
> > > > > > > > > it, send an email to rubyonrails-co...@googlegroups.com.
> > > > > > > > > To post to this group, send email to 
> > > > > > > > > rubyonra...@googlegroups.com.
> > > > > > > > > Visit this group at 
> > > > > > > > > https://groups.google.com/group/rubyonrails-core.
> > > > > > > > > For more options, visit https://groups.google.com/d/optout.
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > You received this message because you are subscribed to the 
> > > > > > > Google Groups "Ruby on Rails: Core" group.
> > > > > > > To unsubscribe from this group and stop receiving emails from it, 
> > > > > > > send an email to rubyonrails-co...@googlegroups.com.
> > > > > > > To post to this group, send email to rubyonra...@googlegroups.com.
> > > > > > > Visit this group at 
> > > > > > > 

[Rails-core] Re: New rubyonrails.org website?

2015-06-06 Thread Kasper Hansen
Sean already answered this in a thread you participated in :)

https://groups.google.com/d/msg/rubyonrails-core/oJAQjXIEJ7Y/Ph6luwwy5foJ

Den fredag den 5. juni 2015 kl. 21.59.14 UTC+2 skrev Frank Tellefsen:

 Hi!

 Anybody know if there are plans to create a new Ruby on Rails website? One 
 that's, say, more similar to RailsGuides or Ruby's website?

 How do you guys feel about the current website?

 Many thanks!

 Frank


-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] ActionCable repo? Need contributors/reviewers?

2015-05-02 Thread Kasper Hansen
We can't wait for your pull requests once Action Cable is public hopefully in a 
month or two: https://twitter.com/dhh/status/590575865106411520.

In the meantime you'll have to wait :)

--
Kasper

 Den 29/04/2015 kl. 22.55 skrev Steven Talcott Smith st...@aelogica.com:
 
 I have searched everywhere for the ActionCable repo but I assume it is 
 private at this point.
 
 I would like to get an early look and would be willing to contribute 
 documentation, code or fixes if welcome.
 
 I have developed real-time collaborative applications with 
 Rails/Pusher/Backbone/Redis/etc and I am excited to try DHH's take on this 
 problem.
 
 I am building something substantial now and would prefer to use or at least 
 prepare for the hopefully accepted Rails 5 method rather than roll my own 
 solution again.
 
 Any advice appreciated.
 
 Kind regards,
 
 
 Steven Talcott Smith
 Master Developer, Chief Happiness Officer
 ÆLOGICA
 
 http://aelogica.com | Great software teams for hire
 http://appexpress.io | Rapid Application Development
 http://leanpub.com/level_up | Level Up! Tips  Techniques to Up Your 
 Professional Developer Game
 
 gpg keyprint C162F8EF  [report security issues promptly and privately]
 
 -- 
 You received this message because you are subscribed to the Google Groups 
 Ruby on Rails: Core group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to rubyonrails-core+unsubscr...@googlegroups.com.
 To post to this group, send email to rubyonrails-core@googlegroups.com.
 Visit this group at http://groups.google.com/group/rubyonrails-core.
 For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] Rails 5 roadmap?

2014-11-25 Thread Kasper Hansen
The Rails team gladly awaits your benchmarks and Pull Requests to help make 
that happen, Bráulio ;)

--
Kasper

 Den 25/11/2014 kl. 21.04 skrev Bráulio Bhavamitra brau...@eita.org.br:
 
 If I could suggest something, I would say: DOUBLE PERFORMACE
 
 On Tue, Nov 25, 2014 at 11:09 AM, Jason Fleetwood-Boldt 
 t...@datatravels.com wrote:
 Rails core,
 
 I was wondering if Rails 5 has a discussed (or proposed) roadmap? A growing 
 chorus of developers are seeking ways to separate domain logic from 
 persistence logic at the model level. I was wondering from a bird’s-eye 
 perspective if the framework plans to adopt patterns to make that easier 
 (and more encouraged) to implement in the future?
 
 I tried to do a little googling for Rails 5 docs but I was unable to find 
 solid stuff.
 
 -Jason
 
 
 
 
 Jason Fleetwood-Boldt
 t...@datatravels.com
 http://www.jasonfleetwoodboldt.com/writing
 
 -- 
 You received this message because you are subscribed to the Google Groups 
 Ruby on Rails: Core group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to rubyonrails-core+unsubscr...@googlegroups.com.
 To post to this group, send email to rubyonrails-core@googlegroups.com.
 Visit this group at http://groups.google.com/group/rubyonrails-core.
 For more options, visit https://groups.google.com/d/optout.
 
 
 
 -- 
 Lute pela sua ideologia. Seja um com sua ideologia. Viva pela sua ideologia. 
 Morra por sua ideologia P.R. Sarkar
 
 EITA - Educação, Informação e Tecnologias para Autogestão
 http://cirandas.net/brauliobo
 http://eita.org.br
 
 Paramapurusha é meu pai e Parama Prakriti é minha mãe. O universo é meu lar 
 e todos nós somos cidadãos deste cosmo. Este universo é a imaginação da Mente 
 Macrocósmica, e todas as entidades estão sendo criadas, preservadas e 
 destruídas nas fases de extroversão e introversão do fluxo imaginativo 
 cósmico. No âmbito pessoal, quando uma pessoa imagina algo em sua mente, 
 naquele momento, essa pessoa é a única proprietária daquilo que ela imagina, 
 e ninguém mais. Quando um ser humano criado mentalmente caminha por um 
 milharal também imaginado, a pessoa imaginada não é a propriedade desse 
 milharal, pois ele pertence ao indivíduo que o está imaginando. Este universo 
 foi criado na imaginação de Brahma, a Entidade Suprema, por isso a 
 propriedade deste universo é de Brahma, e não dos microcosmos que também 
 foram criados pela imaginação de Brahma. Nenhuma propriedade deste mundo, 
 mutável ou imutável, pertence a um indivíduo em particular; tudo é o 
 patrimônio comum de todos.
 Restante do texto em 
 http://cirandas.net/brauliobo/blog/a-problematica-de-hoje-em-dia
 -- 
 You received this message because you are subscribed to the Google Groups 
 Ruby on Rails: Core group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to rubyonrails-core+unsubscr...@googlegroups.com.
 To post to this group, send email to rubyonrails-core@googlegroups.com.
 Visit this group at http://groups.google.com/group/rubyonrails-core.
 For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


[Rails-core] Using Loofah to gain control of what HTML tags get sanitized

2013-06-06 Thread Kasper Hansen
Hi everyone

I'm Kasper. One part 
ofhttp://weblog.rubyonrails.org/2013/5/27/rails-google-summer-of-code-projects/
 the 
Rails Google Summer of Code participants. This means I will replace the 
venerable html-scanner with Loofah, picking up where this issue left off: 
https://github.com/rails/rails/issues/2550. Rafael França was assigned to 
that issue and he is my mentor during the summer.

I want to hear your thoughts about a new API that will take advantage of 
Loofahs custom scrubbers. Here's the example I gave in my project 
proposalhttps://github.com/kaspth/gsoc-application
:

class Comment  ActiveRecord::Base
  # block based
  # block takes a node
  scrubs :body do |node|
node.remove if node.name == script
  end

  # method based
  # method is last argument and has a node parameter
  scrubs :name, :body, :remove_style_blocks 

  # list based via a kind option
  # options are based on the available scrubbers in Loofah
  scrubs :name, kind: :whitelist end

I really want to hear if this is something you would consider, and if so 
where we should define it. I was discussing this a bit with Rafael, and he 
said he wasn't sure if it were to be defined in Active Model, Active 
Support or Action View.

Thanks for reading,
Kasper

-- 
You received this message because you are subscribed to the Google Groups Ruby 
on Rails: Core group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.