Re: [Rails-core] Bump Mail dependency to pick up downstream memory improvements

2016-01-24 Thread Ken Collins
That is a great point too. I can see both sides. But looking at the memory 
decrease as a "feature" seems like a winner to me to at least try to go ~> 2.6 
for the initial release of Rails 5.

 - Ken

On January 24, 2016 at 8:25:07 AM, Karl Freeman (karlfree...@gmail.com) wrote:

That's a solid point. I don't really have a response other than because of the 
benefits above and the opportunity of doing this during a major release (e.g 
when people are already upgrading gems). Logically, in my head seeing a memory 
decrease during a major release of Rails by being progressive with a non 
breaking dependency makes it worth ~> 2.6  


No harm either way as eventually, people will catch this update :).  

--  
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.  
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.  
To post to this group, send email to rubyonrails-core@googlegroups.com.  
Visit this group at https://groups.google.com/group/rubyonrails-core.  
For more options, visit https://groups.google.com/d/optout.  

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


Re: [Rails-core] Bump Mail dependency to pick up downstream memory improvements

2016-01-23 Thread Rafael Mendonça França
It is already allowed to use mail 2.6 with rails, so why should we disallow
to use mail < 2.6?

On Sat, Jan 23, 2016, 21:19 Karl Freeman  wrote:

> Hey all,
>
> Without wanting to claim the hard work of others!! I would love to create
> an issue that tracks bumping Mail to ~> 2.6 for Rails 5 (e.g re-create a PR
> like this one ). Here's why:
>
> Jeremyevan's PR to use a text-based columnar storage
>  in the Mime-types
> gem has been shown to significantly decrease memory when a user opts in
> to it  (I've seen
> 20mb decrease personally). This memory saving behavior is a default in
> the 3.0 release of Mime-types
> 
>  (as well as a raft of other, really lovely changes
> ).
> Given that Mail works with Mime-types 3.0
> 
>  and
> when Mail 2.6.4 has finished brewing
>  it'll
> allow Mime-types 3.0
> 
>  It
> would be great for Rails to nudge users to pick up this behavior too.
>
> What are people's views on this? It feels a little audacious of me to
> modify one line of ActionMailer's gemspec but I'm really keen to see this
> change happen.
>
> Thanks!
>
> --
> You received this message because you are subscribed to the Google Groups
> "Ruby on Rails: Core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to rubyonrails-core+unsubscr...@googlegroups.com.
> To post to this group, send email to rubyonrails-core@googlegroups.com.
> Visit this group at https://groups.google.com/group/rubyonrails-core.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.


[Rails-core] Bump Mail dependency to pick up downstream memory improvements

2016-01-23 Thread Karl Freeman
Hey all,

Without wanting to claim the hard work of others!! I would love to create 
an issue that tracks bumping Mail to ~> 2.6 for Rails 5 (e.g re-create a PR 
like this one ). Here's why:

Jeremyevan's PR to use a text-based columnar storage 
 in the Mime-types 
gem has been shown to significantly decrease memory when a user opts in to 
it  (I've seen 20mb 
decrease personally). This memory saving behavior is a default in the 3.0 
release of Mime-types 

 (as well as a raft of other, really lovely changes 
).
 
Given that Mail works with Mime-types 3.0 
 
and 
when Mail 2.6.4 has finished brewing 
 it'll allow 
Mime-types 
3.0 

 It 
would be great for Rails to nudge users to pick up this behavior too.

What are people's views on this? It feels a little audacious of me to 
modify one line of ActionMailer's gemspec but I'm really keen to see this 
change happen. 

Thanks!

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to rubyonrails-core+unsubscr...@googlegroups.com.
To post to this group, send email to rubyonrails-core@googlegroups.com.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.