Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
On Mon, Jul 30, 2012 at 09:04:44PM -0700, Anne Schilling wrote: > Since there were some nonlocal changes in sage-5.1, I think it would be best > if all > developers now switch to sage-5.2 and we focus our efforts on rebasing all > patches > to this new version of sage (instead of trying to keep backwards compatibilty > for much longer). For the record (see other thread): I have finished rebasing the patches for 5.2. Luckily enough it was not too hard to backport some pieces of the "bad" patches, so that those patches also apply on 5.1 as well. To be pushed as soon as I have network access. Cheers, Nicolas -- Nicolas M. Thiéry "Isil" http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
On Tue, Jul 31, 2012 at 10:25 PM, Franco Saliola wrote: > On Tue, Jul 31, 2012 at 9:01 PM, Andrew Mathas > wrote: >> Sorry, I have pushed the patch onto the queue and reinstated 9265 in the >> series file. Please let me know if there are any problems. >> >> Btw, on trac the patchbot is applying both the old patch and the new one. >> Could some please tell me how I get it to ignore the old patch. > > There is a directive that you can use to tell the patchbot which > patches to apply. The syntax is: > > Apply: patch1, patch2, patch3, > > Two things to note. > > 1. You have to put the directive in a *comment*; the patchbot only > looks for this directive in the comments (and not in the description). > > 2. (It seems that) The patches are applied in chronological order, no > matter what order you specify in the list above. > > Nonetheless, it is also a good idea to include the list of patches to > apply in the *description* since this makes life easier for the > release manager and anyone looking to review the ticket. > > I'll go make this change to #9265. Now when you click on the patchbot swirl, it lists the correct patch. Franco --- -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
On Tue, Jul 31, 2012 at 9:01 PM, Andrew Mathas wrote: > Sorry, I have pushed the patch onto the queue and reinstated 9265 in the > series file. Please let me know if there are any problems. > > Btw, on trac the patchbot is applying both the old patch and the new one. > Could some please tell me how I get it to ignore the old patch. There is a directive that you can use to tell the patchbot which patches to apply. The syntax is: Apply: patch1, patch2, patch3, Two things to note. 1. You have to put the directive in a *comment*; the patchbot only looks for this directive in the comments (and not in the description). 2. (It seems that) The patches are applied in chronological order, no matter what order you specify in the list above. Nonetheless, it is also a good idea to include the list of patches to apply in the *description* since this makes life easier for the release manager and anyone looking to review the ticket. I'll go make this change to #9265. Franco -- -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
Sorry, I have pushed the patch onto the queue and reinstated 9265 in the series file. Please let me know if there are any problems. Btw, on trac the patchbot is applying both the old patch and the new one. Could some please tell me how I get it to ignore the old patch. Cheers, Andrew On Wednesday, 1 August 2012 03:31:04 UTC+10, bump wrote: > > > > I have rebased 9265 so that it applies on 5.1 but I haven't uploaded it > as > > I wanted to rename it and make sure that I don't clobber anything else > in > > the 5.1 or 5.2 queues. The main problem is that even though the queue > > applies on 5.2 sage does not run due -- so far -- to incorrect > deprecation > > imports (because of the change there). I am half way through guarding > the > > offending patches but I have to rush to collect my daughter from school. > I > > won't be able to get back to this until later tonight. > > The patch trac_9265_tableaux_categories_am.patch seems to be missing > from the queue. After a fresh install of the whole combinat queue: > > $ ls sage-combinat/.hg/patches/*9265* > sage-combinat/.hg/patches/trac_9265_tableaux_categories_jb.patch > > Since the patch isn't there, the queue doesn't install. Therefore > I am setting a guard for this patch. > > Dan > > > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/DOcfA7ZbobEJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
> I have rebased 9265 so that it applies on 5.1 but I haven't uploaded it as > I wanted to rename it and make sure that I don't clobber anything else in > the 5.1 or 5.2 queues. The main problem is that even though the queue > applies on 5.2 sage does not run due -- so far -- to incorrect deprecation > imports (because of the change there). I am half way through guarding the > offending patches but I have to rush to collect my daughter from school. I > won't be able to get back to this until later tonight. The patch trac_9265_tableaux_categories_am.patch seems to be missing from the queue. After a fresh install of the whole combinat queue: $ ls sage-combinat/.hg/patches/*9265* sage-combinat/.hg/patches/trac_9265_tableaux_categories_jb.patch Since the patch isn't there, the queue doesn't install. Therefore I am setting a guard for this patch. Dan -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
Dear Dan and Christian, I have rebased 9265 so that it applies on 5.1 but I haven't uploaded it as I wanted to rename it and make sure that I don't clobber anything else in the 5.1 or 5.2 queues. The main problem is that even though the queue applies on 5.2 sage does not run due -- so far -- to incorrect deprecation imports (because of the change there). I am half way through guarding the offending patches but I have to rush to collect my daughter from school. I won't be able to get back to this until later tonight. Andrew On Tuesday, 31 July 2012 13:12:03 UTC+10, bump wrote: > > > Christian Stump wrote: > > > unfortunately, 9265 does not apply anymore on 5.1... > > I think a lot of patches are broke on 5.1 right now. Here is a partial > list. > > trac_5457-review-as.patch > trac_9265_tableaux_categories_jb.patch > trac_12774-coxeter-ms.patch > root_system_plot_refactor-nb.patch > trac_11187-finite_reflection_groups-cs.patch > coxeter3-mh_rebase-cs.patch > > These are all patches that are not guarded for 5.1 and the queue could > be fixed for 5.1 by adding guards to them. Some have been rebased for 5.2* > and some have not. > > However for 5.2 the situation is better. Not all patches have been > rebased but at least the queue applies cleanly. > > Dan > > > > > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/NQtwingWT2gJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
Hi All! Since there were some nonlocal changes in sage-5.1, I think it would be best if all developers now switch to sage-5.2 and we focus our efforts on rebasing all patches to this new version of sage (instead of trying to keep backwards compatibilty for much longer). Best, Anne On 7/30/12 8:12 PM, Daniel Bump wrote: > > Christian Stump wrote: > >> unfortunately, 9265 does not apply anymore on 5.1... > > I think a lot of patches are broke on 5.1 right now. Here is a partial list. > > trac_5457-review-as.patch > trac_9265_tableaux_categories_jb.patch > trac_12774-coxeter-ms.patch > root_system_plot_refactor-nb.patch > trac_11187-finite_reflection_groups-cs.patch > coxeter3-mh_rebase-cs.patch > > These are all patches that are not guarded for 5.1 and the queue could > be fixed for 5.1 by adding guards to them. Some have been rebased for 5.2* > and some have not. > > However for 5.2 the situation is better. Not all patches have been > rebased but at least the queue applies cleanly. > > Dan -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
Sorry, I forgot the guard for trac_5457-review-as.patch and just added it! Anne On 7/30/12 8:12 PM, Daniel Bump wrote: > > Christian Stump wrote: > >> unfortunately, 9265 does not apply anymore on 5.1... > > I think a lot of patches are broke on 5.1 right now. Here is a partial list. > > trac_5457-review-as.patch > trac_9265_tableaux_categories_jb.patch > trac_12774-coxeter-ms.patch > root_system_plot_refactor-nb.patch > trac_11187-finite_reflection_groups-cs.patch > coxeter3-mh_rebase-cs.patch > > These are all patches that are not guarded for 5.1 and the queue could > be fixed for 5.1 by adding guards to them. Some have been rebased for 5.2* > and some have not. > > However for 5.2 the situation is better. Not all patches have been > rebased but at least the queue applies cleanly. > > Dan -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
Christian Stump wrote: > unfortunately, 9265 does not apply anymore on 5.1... I think a lot of patches are broke on 5.1 right now. Here is a partial list. trac_5457-review-as.patch trac_9265_tableaux_categories_jb.patch trac_12774-coxeter-ms.patch root_system_plot_refactor-nb.patch trac_11187-finite_reflection_groups-cs.patch coxeter3-mh_rebase-cs.patch These are all patches that are not guarded for 5.1 and the queue could be fixed for 5.1 by adding guards to them. Some have been rebased for 5.2* and some have not. However for 5.2 the situation is better. Not all patches have been rebased but at least the queue applies cleanly. Dan -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
> It should apply cleanly to 5.2. Assuming you fix that and repost it, unfortunately, 9265 does not apply anymore on 5.1... Best, Christian -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
> I also uploaded the new patch to trac, where I had to rename the patch as > trac would not give me permission to delete some one else's patch. The > patch probably won't apply cleanly to 5.2-rc0 for trivial reasons (white > space) It should apply cleanly to 5.2. Assuming you fix that and repost it, you should change the description to say: Apply: trac_9265_tableaux_categories_am.patch and you can also change the status to "needs review". Dan -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
ps. I put a +5.2 guard on the patch concrete_combinatorial_statistics_and_maps-cs.patch as it didn't apply cleanly to files that I hadn't touched. (I also guarded my patch trac_X-Kleshchev-partitions-am.patch which I forgot to do when I uploaded it earlier). Andrew -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/PQtYRIQMNdIJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
I have rebased Jason's patch so that it apples to 5.2-rc0. I also uploaded the new patch to trac, where I had to rename the patch as trac would not give me permission to delete some one else's patch. The patch probably won't apply cleanly to 5.2-rc0 for trivial reasons (white space) as it does not commute with the two patches trac_5457-symmetric_functions-mz.patch trac_12943-skew-partition-construction-bug-ht.patch Comments welcome! I think that the patch it ready for review. Andrew -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/cTzWWUWUb18J. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
On Tuesday, 24 July 2012 21:53:37 UTC+10, Dima Pasechnik wrote: > > I just marked it as "needs work". it needs a (trivial, hopefully) rebase > for Sage 5.2.rc0. > > Thanks, I'll rebase it, if necessary, and review. Andrew -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/WjcDTCMgCNkJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
[sage-combinat-devel] Re: Trac 9265: Remove `CombinatorialClass` from sage.combinat.tableau
I just marked it as "needs work". it needs a (trivial, hopefully) rebase for Sage 5.2.rc0. Dima On Tuesday, 24 July 2012 10:19:56 UTC+8, Andrew Mathas wrote: > > Hi Jason, > > What is the status of your patch #9265? It is not marked as needing review > and I'd actually assumed it was already merged into the tree. > > My partition tuple and tableau tuple patch heavily depend on, and are > modelled on, your patch. So if it is ready for review I volunteer. > > Hmm, I just searched for Jason on the net and it seems that he may have > left mathematics. Given this, does any one know the status of this patch? > > Andrew > > > -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To view this discussion on the web visit https://groups.google.com/d/msg/sage-combinat-devel/-/vkWjPT9u53cJ. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
