Re: [sage-combinat-devel] Re: sage-combinat queue broken
On 4/1/11 6:18 AM, Nicolas M. Thiery wrote: Hi! On Thu, Mar 31, 2011 at 11:22:18PM -0700, Anne Schilling wrote: On 3/31/11 5:59 PM, Daniel Bump wrote: It seems that your patch has a problem to be applied to the current sage 4.6.2. The patch was tested with 4.7.alphas (because we hope for it to be merged soon). The syntax of classical_crystals.py at the top of the file has changed since 4.6.2. So it doesn't merge. One possibility would be to guard the patch so that it only applies to more recent versions. I'm cc:ing Nicolas to ask his advice. Which patch are you talking about? The #7922 patches (Weyl character rings) did not apply smoothly due to a trivial import conflict with trac_10446_schuetzenberger_involution-as.patch I am writting a quick reviewer patch on #10466 that make them commute. By the way, it avoids importing parent code (RootSystems, WeylGroups) in category code, to reduce risks of import loops. Ok, thanks. I folded the patches and reposted on trac. Cheers, Anne -- You received this message because you are subscribed to the Google Groups sage-combinat-devel group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: sage-combinat queue broken
Hi! On Thu, Mar 31, 2011 at 11:22:18PM -0700, Anne Schilling wrote: On 3/31/11 5:59 PM, Daniel Bump wrote: It seems that your patch has a problem to be applied to the current sage 4.6.2. The patch was tested with 4.7.alphas (because we hope for it to be merged soon). The syntax of classical_crystals.py at the top of the file has changed since 4.6.2. So it doesn't merge. One possibility would be to guard the patch so that it only applies to more recent versions. I'm cc:ing Nicolas to ask his advice. Which patch are you talking about? The #7922 patches (Weyl character rings) did not apply smoothly due to a trivial import conflict with trac_10446_schuetzenberger_involution-as.patch I am writting a quick reviewer patch on #10466 that make them commute. By the way, it avoids importing parent code (RootSystems, WeylGroups) in category code, to reduce risks of import loops. I'll push that in a couple minutes. Cheers, Nicolas -- Nicolas M. Thiéry Isil nthi...@users.sf.net http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups sage-combinat-devel group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
Re: [sage-combinat-devel] Re: sage-combinat queue broken
On Fri, Apr 01, 2011 at 03:18:04PM +0200, Nicolas M. Thiery wrote: I'll push that in a couple minutes. Done. I used the occasion to polish a tiny bit the corresponding doctests. Please check, and if you are happy, fold and upload on trac. Cheers, Nicolas -- Nicolas M. Thiéry Isil nthi...@users.sf.net http://Nicolas.Thiery.name/ -- You received this message because you are subscribed to the Google Groups sage-combinat-devel group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
