[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
I've now placed a new version of pil-1.1.7.p0.spkg at
http://uplib.parc.com/misc/pil-1.1.7.p0.spkg. This contains the .hg
files, but I'm still not sure I've got that correct.
By the way, spkg-check still runs on OS X, but not on Ubuntu. I've
tested it with Sage 4.7.2 on both; seems to build and work fine.
If the test suite runs, you'll see extra output at the end of the
build:
Running the test suite.
testing formats...
PNG: L (512, 512) {}
JPEG: L (512, 512) {'jfif_version': (1, 1), 'jfif': 257, 'jfif_unit':
0, 'jfif_density': (1, 1)}
TIFF: L (512, 512) {'resolution': (1, 1), 'compression': 'raw'}
BMP: L (512, 512) {'compression': 0}
test resize...
after resize: L (50, 50)
test convert...
RGB (512, 512) = RGB (512, 512)
RGBA (512, 512) = RGBA (512, 512)
1 (512, 512)
1 (512, 512)
L (512, 512) = L (512, 512)
P (512, 512) = L (512, 512)
Bill
On Nov 22, 3:59 pm, John H Palmieri jhpalmier...@gmail.com wrote:
On Tuesday, November 22, 2011 3:45:28 PM UTC-8, Bill Janssen wrote:
On Nov 22, 12:53 pm, John H Palmieri jhpalm...@gmail.com wrote:
So pil-1.1.6.p5 *is* the old one.
pil-1.1.6.p4 is the old one.
Remove the src directory from that
one, replacing it with the new source. Modify any patches as necessary,
along with the spkg-install, spkg-check, and SPKG.txt files, as I said in
my previous message. Commit your changes using hg commit (or sage
--hg
commit).
How do I change the name? Just hg rename? Won't that delete
pil-1.1.6.p4? What if someone wants 1.1.6 instead of 1.1.7?
You just change the name of the parent directory:
$ mv pil-1.1.6.p4 pil-1.1.7.p0
The Mercurial repository is contained in this directory, but it doesn't
actually care what the name of the directory is.
As far as 1.1.6 vs. 1.1.7, the new version should only be merged it if
represents an upgrade and works on all platforms where the old one worked,
so most people should be happy with 1.1.7. If someone really wants the old
version, they can download an old version of Sage and get it from there.
We don't keep old versions of spkgs around, as far as I know.
--
John
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
OK, I'll look at that this long weekend. Bill On Nov 17, 2:07 pm, William Stein wst...@gmail.com wrote: On Thu, Nov 17, 2011 at 1:49 PM, Bill Janssen bill.jans...@gmail.com wrote: Some issues with this spkg: - The mercurial repository is completely missing. Yes, it's not a patch to the Sage sources, so there's no Mercurial stuff as there would be if it were. Each spkg has its own Mercurial repository. Look at another spkg. - There are lots of backup files around (SPKG.txt~, etc.). I've put up a new version which should fix this. - You shouldn't build libjpeg in /tmp/..., but probably in a subdirectory of SAGE_ROOT/spkg/build/pil- You also shouldn't delete this temporary directory: the sage-spkg script will clean up spkg/build/pil-... automatically unless requested not to. (What if your $TEMPDIR already exists? What if there is an error running spkg-check and someone wants to look at the build directories?) OK, I'll try that. Thanks! -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/sage-devel URL:http://www.sagemath.org -- William Stein Professor of Mathematics University of Washingtonhttp://wstein.org -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Nov 17, 5:07 pm, kcrisman kcris...@gmail.com wrote: On Nov 17, 5:10 pm, Bill Janssen bill.jans...@gmail.com wrote: OK, the libjpeg now builds in place. I see that on my Ubuntu box, the spkg-check file isn't being run automatically. Any ideas as to why that might be? Did you set SAGE_CHECK=yes ? That is the flag that sets that to run. Otherwise Sage would always fail, because the Python spkg-check always fails... I did not. Neither on my Mac (where spkg-check runs) or on my Ubuntu box (where it doesn't run). I just tried setting it on my Ubuntu machine, then running sage -f pil-1.1.7.p0.spkg again. Still doesn't run spkg-check there. Is there a verbose flag of some sort I could set to see what's going on? Bill Thanks for the work on this. My computer has never passed plot/plot3d/ base.pyx because of not having libjpeg, I guess - at least it says the _imaging_C or whatever extension wasn't built, and my understanding is that that is from PIL (?). - kcrisman -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
You should build your new spkg by starting with the old one Except that the old one doesn't exist -- this is pil-1.1.7.p0, not pil-1.1.6.p5. Still not sure how to go about this -- an example (perhaps it's in the docs) would be helpful. -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Tuesday, November 22, 2011 12:42:41 PM UTC-8, Bill Janssen wrote: You should build your new spkg by starting with the old one Except that the old one doesn't exist -- this is pil-1.1.7.p0, not pil-1.1.6.p5. Still not sure how to go about this -- an example (perhaps it's in the docs) would be helpful. So pil-1.1.6.p5 *is* the old one. Remove the src directory from that one, replacing it with the new source. Modify any patches as necessary, along with the spkg-install, spkg-check, and SPKG.txt files, as I said in my previous message. Commit your changes using hg commit (or sage --hg commit). See, for example, http://sagemath.org/doc/developer/patching_spkgs.html#bumping-up-an-spkg-s-version. -- John -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Nov 22, 12:53 pm, John H Palmieri jhpalmier...@gmail.com wrote: So pil-1.1.6.p5 *is* the old one. pil-1.1.6.p4 is the old one. Remove the src directory from that one, replacing it with the new source. Modify any patches as necessary, along with the spkg-install, spkg-check, and SPKG.txt files, as I said in my previous message. Commit your changes using hg commit (or sage --hg commit). How do I change the name? Just hg rename? Won't that delete pil-1.1.6.p4? What if someone wants 1.1.6 instead of 1.1.7? Bill See, for example, http://sagemath.org/doc/developer/patching_spkgs.html#bumping-up-an-s -- John -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Tuesday, November 22, 2011 3:45:28 PM UTC-8, Bill Janssen wrote: On Nov 22, 12:53 pm, John H Palmieri jhpalm...@gmail.com wrote: So pil-1.1.6.p5 *is* the old one. pil-1.1.6.p4 is the old one. Remove the src directory from that one, replacing it with the new source. Modify any patches as necessary, along with the spkg-install, spkg-check, and SPKG.txt files, as I said in my previous message. Commit your changes using hg commit (or sage --hg commit). How do I change the name? Just hg rename? Won't that delete pil-1.1.6.p4? What if someone wants 1.1.6 instead of 1.1.7? You just change the name of the parent directory: $ mv pil-1.1.6.p4 pil-1.1.7.p0 The Mercurial repository is contained in this directory, but it doesn't actually care what the name of the directory is. As far as 1.1.6 vs. 1.1.7, the new version should only be merged it if represents an upgrade and works on all platforms where the old one worked, so most people should be happy with 1.1.7. If someone really wants the old version, they can download an old version of Sage and get it from there. We don't keep old versions of spkgs around, as far as I know. -- John -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Thursday, November 17, 2011 1:17:45 PM UTC-8, Bill Janssen wrote: I've put up my first try at a PIL 1.1.7 spkg at http://uplib.parc.com/ misc/pil-1.1.7.p0.spkg http://uplib.parc.com/misc/pil-1.1.7.p0.spkg. Please tell me what I did wrong :-). I would open up a ticket, making sure to cc the people involved in previous PIL spkgs, and post the link there. Some issues with this spkg: - The mercurial repository is completely missing. - There are lots of backup files around (SPKG.txt~, etc.). - You shouldn't build libjpeg in /tmp/..., but probably in a subdirectory of SAGE_ROOT/spkg/build/pil- You also shouldn't delete this temporary directory: the sage-spkg script will clean up spkg/build/pil-... automatically unless requested not to. (What if your $TEMPDIR already exists? What if there is an error running spkg-check and someone wants to look at the build directories?) Those are some things I see right away. There are probably other ways it should be cleaned up, too. -- John -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
Some issues with this spkg: - The mercurial repository is completely missing. Yes, it's not a patch to the Sage sources, so there's no Mercurial stuff as there would be if it were. - There are lots of backup files around (SPKG.txt~, etc.). I've put up a new version which should fix this. - You shouldn't build libjpeg in /tmp/..., but probably in a subdirectory of SAGE_ROOT/spkg/build/pil- You also shouldn't delete this temporary directory: the sage-spkg script will clean up spkg/build/pil-... automatically unless requested not to. (What if your $TEMPDIR already exists? What if there is an error running spkg-check and someone wants to look at the build directories?) OK, I'll try that. Thanks! -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Thu, Nov 17, 2011 at 1:49 PM, Bill Janssen bill.jans...@gmail.com wrote: Some issues with this spkg: - The mercurial repository is completely missing. Yes, it's not a patch to the Sage sources, so there's no Mercurial stuff as there would be if it were. Each spkg has its own Mercurial repository. Look at another spkg. - There are lots of backup files around (SPKG.txt~, etc.). I've put up a new version which should fix this. - You shouldn't build libjpeg in /tmp/..., but probably in a subdirectory of SAGE_ROOT/spkg/build/pil- You also shouldn't delete this temporary directory: the sage-spkg script will clean up spkg/build/pil-... automatically unless requested not to. (What if your $TEMPDIR already exists? What if there is an error running spkg-check and someone wants to look at the build directories?) OK, I'll try that. Thanks! -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org -- William Stein Professor of Mathematics University of Washington http://wstein.org -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Thursday, November 17, 2011 1:49:39 PM UTC-8, Bill Janssen wrote: Some issues with this spkg: - The mercurial repository is completely missing. Yes, it's not a patch to the Sage sources, so there's no Mercurial stuff as there would be if it were. Every spkg should contain a Mercurial repository so we can see what the changes have been. If you unpack the current pil spkg (pil-1.1.6.p4.spkg), then do ls -a, you'll see ./.hg/SPKG.txtspkg-install* ../.hgignorepatches/src/ If you do $ hg log you'll get a log of changes to the repository, etc. You should build your new spkg by starting with the old one, replacing the src directory with a new (unmodified) one, and then modifying the other files (spkg-install, patches/*, etc.) as needed. Then commit your changes (hg commit) before creating the actual spkg file. The Sage Developer's Guide has information about Mercurial repositories on spkgs. -- John -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
OK, the libjpeg now builds in place. I see that on my Ubuntu box, the spkg-check file isn't being run automatically. Any ideas as to why that might be? Bill On Nov 17, 1:49 pm, Bill Janssen bill.jans...@gmail.com wrote: - You shouldn't build libjpeg in /tmp/..., but probably in a subdirectory of SAGE_ROOT/spkg/build/pil- You also shouldn't delete this temporary directory: the sage-spkg script will clean up spkg/build/pil-... automatically unless requested not to. (What if your $TEMPDIR already exists? What if there is an error running spkg-check and someone wants to look at the build directories?) OK, I'll try that. Thanks! -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
[sage-devel] Re: tentative PIL-1.1.7.p0.spkg
On Nov 17, 5:10 pm, Bill Janssen bill.jans...@gmail.com wrote: OK, the libjpeg now builds in place. I see that on my Ubuntu box, the spkg-check file isn't being run automatically. Any ideas as to why that might be? Did you set SAGE_CHECK=yes ? That is the flag that sets that to run. Otherwise Sage would always fail, because the Python spkg-check always fails... Thanks for the work on this. My computer has never passed plot/plot3d/ base.pyx because of not having libjpeg, I guess - at least it says the _imaging_C or whatever extension wasn't built, and my understanding is that that is from PIL (?). - kcrisman -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
