Re: [sage-devel] check dependencies

2018-09-22 Thread Volker Braun
On Friday, September 21, 2018 at 2:43:32 PM UTC+2, Thierry 
(sage-googlesucks@xxx) wrote:
>
> Agreed. But how should we deal with testing networkx ? 


Print a warning that nose is required and skip 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-devel] check dependencies

2018-09-21 Thread Thierry
On Fri, Sep 21, 2018 at 01:40:38PM +0100, dimp...@gmail.com wrote:
[...]
> IMHO we don't want such legacy things as standard...

Agreed. But how should we deal with testing networkx ?

Ciao,
Thierry


> 
> Dima
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To post to this group, send email to sage-devel@googlegroups.com.
> Visit this group at https://groups.google.com/group/sage-devel.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-devel] check dependencies

2018-09-21 Thread dimpase
On Fri, Sep 21, 2018 at 02:27:13PM +0200, Thierry wrote:
> Hi,
> 
> on the way to upgrading networkx, i noticed that the source code contains
> tests, but we do not ship any spkg-check script for that (yet).
> 
> However, the check process requires nose, which is an optional package
> (note that networkx is standard). Is there a way to declare "check
> dependencies" (e.g. after a second | or whatever symbol), or should i
> hardcode some message within the spkg-check if it is not installed ?
> 
> Would it make sense to make nose standard so that exporting SPKG_CHECK=yes
> does not breaks everything ?
On https://nose.readthedocs.io/en/latest/ one reads:

Note to Users
Nose has been in maintenance mode for the past several years and will likely 
cease without a new person/team to take over maintainership. New projects 
should consider using Nose2, py.test, or just plain unittest/unittest2.

IMHO we don't want such legacy things as standard...

Dima

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


[sage-devel] check dependencies

2018-09-21 Thread Thierry
Hi,

on the way to upgrading networkx, i noticed that the source code contains
tests, but we do not ship any spkg-check script for that (yet).

However, the check process requires nose, which is an optional package
(note that networkx is standard). Is there a way to declare "check
dependencies" (e.g. after a second | or whatever symbol), or should i
hardcode some message within the spkg-check if it is not installed ?

Would it make sense to make nose standard so that exporting SPKG_CHECK=yes
does not breaks everything ?

Ciao,
Thierry


-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.