Re: [sage-devel] Re: spkg dependency checking
On 02/08/12 16:13, Jeroen Demeyer wrote: > On 2012-02-08 18:40, Jean-Pierre Flori wrote: >> In some packages, we already have some "dependencies" section. >> I guess this could be used (or put somewhere else in the spkg) and >> then used by Sage (and not the spkg-install script itself, just as >> what is done with SAGE_CHECK variable and spgk-check script) to check >> for dependencies. > > Seems like a lot of work for little gain. I'm not in favour. > Not to beat a dead horse (in fact, I've come to appreciate how easy it is to patch e.g. Maxima), but with a monolithic distribution, I only see two possible extremes: * Out-of-tree packages don't work reliably * You essentially become a distro, supplying your own package management. Somewhere in between there's probably at least a local maximum; my guess is that letting autotools notice the missing deps is that spot. -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
On 2012-02-08 18:40, Jean-Pierre Flori wrote: > In some packages, we already have some "dependencies" section. > I guess this could be used (or put somewhere else in the spkg) and > then used by Sage (and not the spkg-install script itself, just as > what is done with SAGE_CHECK variable and spgk-check script) to check > for dependencies. Seems like a lot of work for little gain. I'm not in favour. -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
On Tue, Feb 7, 2012 at 7:47 PM, Julien Puydt wrote: > Le mercredi 08 février, Jeroen Demeyer a écrit: >> On 2012-02-08 04:23, Julien Puydt wrote: >> > Le 8/2/2012, Keshav Kini a écrit : >> > >> >> Upstream configure scripts tend to check for dependencies by just >> >> testing if it can use them. I guess what is meant here is that >> >> spkg-install could check whether certain SPKGs had been installed >> >> into the Sage installation. Also, upstream might not be aware of >> >> certain dependencies it might gain by whatever patches we apply to >> >> it (though we could patch the upstream configure script, I >> >> guess...). >> > >> > Wouldn't it be wiser if instead of checking that kind of dependency >> > with spkg-install, the spkg could contain a "deps" file in which >> > "sage -i" could have a look, and decide to install said >> > dependencies before actually running spkg-install at all? > >> No, because we already have spkg/standard/deps for this. > > No, you don't have spkg/standard/deps for this, as spkg/standard/deps > is for *mandatory* packages, and the discussion was about *optional* > packages ;-) > I think Julien's suggestion seems pretty reasonable. I don't think it makes sense to: "Maybe the best solution then is to add logic to install optional packages to spkg/standard/deps?" since that requires having a central location with all dependency information about all optional spkg's. Remember, anybody can just make an optional spkg and put it up on their webpage. -- William -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
On 2012-02-08 04:47, Julien Puydt wrote: > No, you don't have spkg/standard/deps for this, as spkg/standard/deps > is for *mandatory* packages, and the discussion was about *optional* > packages ;-) Maybe the best solution then is to add logic to install optional packages to spkg/standard/deps? -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
Le mercredi 08 février, Jeroen Demeyer a écrit: > On 2012-02-08 04:23, Julien Puydt wrote: > > Le 8/2/2012, Keshav Kini a écrit : > > > >> Upstream configure scripts tend to check for dependencies by just > >> testing if it can use them. I guess what is meant here is that > >> spkg-install could check whether certain SPKGs had been installed > >> into the Sage installation. Also, upstream might not be aware of > >> certain dependencies it might gain by whatever patches we apply to > >> it (though we could patch the upstream configure script, I > >> guess...). > > > > Wouldn't it be wiser if instead of checking that kind of dependency > > with spkg-install, the spkg could contain a "deps" file in which > > "sage -i" could have a look, and decide to install said > > dependencies before actually running spkg-install at all? > No, because we already have spkg/standard/deps for this. No, you don't have spkg/standard/deps for this, as spkg/standard/deps is for *mandatory* packages, and the discussion was about *optional* packages ;-) Snark on #sagemath -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
On 2012-02-08 04:23, Julien Puydt wrote: > Le 8/2/2012, Keshav Kini a écrit : > >> Upstream configure scripts tend to check for dependencies by just >> testing if it can use them. I guess what is meant here is that >> spkg-install could check whether certain SPKGs had been installed >> into the Sage installation. Also, upstream might not be aware of >> certain dependencies it might gain by whatever patches we apply to it >> (though we could patch the upstream configure script, I guess...). > > Wouldn't it be wiser if instead of checking that kind of dependency > with spkg-install, the spkg could contain a "deps" file in which "sage > -i" could have a look, and decide to install said dependencies before > actually running spkg-install at all? No, because we already have spkg/standard/deps for this. -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
Le 8/2/2012, Keshav Kini a écrit : > Upstream configure scripts tend to check for dependencies by just > testing if it can use them. I guess what is meant here is that > spkg-install could check whether certain SPKGs had been installed > into the Sage installation. Also, upstream might not be aware of > certain dependencies it might gain by whatever patches we apply to it > (though we could patch the upstream configure script, I guess...). Wouldn't it be wiser if instead of checking that kind of dependency with spkg-install, the spkg could contain a "deps" file in which "sage -i" could have a look, and decide to install said dependencies before actually running spkg-install at all? Snark on #sagemath -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
On 2012-02-08 01:29, John H Palmieri wrote: > > > On Tuesday, February 7, 2012 3:06:14 PM UTC-8, Jeroen Demeyer wrote: > > I came across the following in the Sage Developer guide: > >- If your package depends on another package, say boehmgc, then you > should check that this other package has been installed. Your > ``spkg-install`` script should check that it exists, with code > like the following: > > This is relevant for optional packages, so maybe it should say: > > If your package depends on an optional package, say ..., then you > should Agreed for optional packages. For standard packages, we have spkg/standard/deps, so I don't see the need for an *additional* check in spkg-install. -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
BTW I would also point out that all these dependency problems are basically solved in Burcin's `lmonade` repackaging of Sage, in case anyone reading this is not aware of that excellent project. .. lmonade_: http://www.lmona.de/ -Keshav Join us in #sagemath on irc.freenode.net ! -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
On 2012-02-08 12:22, Keshav Kini wrote: > Upstream configure scripts tend to check for dependencies by just > testing if it can use them. I guess what is meant here is that > spkg-install could check whether certain SPKGs had been installed into > the Sage installation. The upstream configure script might also give a very cryptic error message when some dependency doesn't work. It might also silently not build certain functionality. -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
Upstream configure scripts tend to check for dependencies by just testing if it can use them. I guess what is meant here is that spkg-install could check whether certain SPKGs had been installed into the Sage installation. Also, upstream might not be aware of certain dependencies it might gain by whatever patches we apply to it (though we could patch the upstream configure script, I guess...). -Keshav Join us in #sagemath on irc.freenode.net ! -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
Re: [sage-devel] Re: spkg dependency checking
Le 7/2/2012, John H Palmieri a écrit : > This is relevant for optional packages, so maybe it should say: > > If your package depends on an optional package, say ..., then you > should > > As Dima points out, Simon King's group cohomology package does > something like this. > > Is the 'deps' file discussed in the Developer's Guide? I'm not sure I understood things correctly : (1) spkg-install checks for the dependencies (2) spkg-install calls the upstream configure script (3) the upstream configure script checks for dependencies Is there a difference between steps (1) and (3) ? Snark on #sagemath -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org