Re: [sage-devel] VOTE: Use "CI Fix" label for merging into continuous integration runs

[David Lowry-Duda]

+1

- DLD

On 03:43 Mon 04 Mar 2024, David Roe wrote:

The following proposal has been made several times the last few weeks: in
PR #37428 , in this thread
 and then in this
thread .  It is
orthogonal to the ongoing vote in this thread
.  With no further
discussion, I'm calling a vote.

*Background*

Starting in Sage 10.2, PRs with the Blocker label have been merged into all
other PRs before running CI; see the changelog

and this post
 for
more details.  This has led to disagreements about whether this label
should be applied.

*Proposal*
We use "CI Fix" rather than Blocker to determine whether an open PR should
be merged before running CI.  Blocker will retain its previous meaning of a
PR that should be merged before the next release is finished.  The process
below describes how to resolve disagreements about whether the "CI Fix"
label should be applied.
a. Only PRs with positive review should be marked with the "CI Fix" label.
This should be done if both author and reviewer agree that it is
appropriate, and a rationale should be given in a comment on the ticket.
b. If a PR becomes disputed (as described in this proposal
), the "CI Fix"
status can be voted on separately upon request; otherwise it should be
applied if and only if positive review is applied.

Voting will be open until Wednesday, March 13.
David

--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAChs6_mYLUWXMU6AZKJGPKd2oz0AC_qAUjnGoD9Q9yixzNBC2w%40mail.gmail.com.


--
David Lowry-Duda  

--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/ZeucxiWWIwzs7Mm/%40icerm-dld.

Re: [sage-devel] VOTE: Use "CI Fix" label for merging into continuous integration runs

[Vincent Delecroix]

+1

On Mon, 4 Mar 2024 at 20:21, G. M.-S.  wrote:
>
>
> +1
>
> Guillermo
>
> On Mon, 4 Mar 2024 at 09:43, David Roe  wrote:
>>
>> The following proposal has been made several times the last few weeks: in PR 
>> #37428, in this thread and then in this thread.  It is orthogonal to the 
>> ongoing vote in this thread.  With no further discussion, I'm calling a vote.
>>
>> Background
>>
>> Starting in Sage 10.2, PRs with the Blocker label have been merged into all 
>> other PRs before running CI; see the changelog and this post for more 
>> details.  This has led to disagreements about whether this label should be 
>> applied.
>>
>> Proposal
>> We use "CI Fix" rather than Blocker to determine whether an open PR should 
>> be merged before running CI.  Blocker will retain its previous meaning of a 
>> PR that should be merged before the next release is finished.  The process 
>> below describes how to resolve disagreements about whether the "CI Fix" 
>> label should be applied.
>> a. Only PRs with positive review should be marked with the "CI Fix" label.  
>> This should be done if both author and reviewer agree that it is 
>> appropriate, and a rationale should be given in a comment on the ticket.
>> b. If a PR becomes disputed (as described in this proposal), the "CI Fix" 
>> status can be voted on separately upon request; otherwise it should be 
>> applied if and only if positive review is applied.
>>
>> Voting will be open until Wednesday, March 13.
>> David
>
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/CANnG189Rx%3DfXHDCQvDiTS0f_qHwRG9LbfiKKqph6DXuF%3Dd1zcw%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAGEwAAm6wy1c4mDnvfwT5Ow%2BCEYvheqKDyzOpTfjJZUd_Ur%3DNQ%40mail.gmail.com.

Re: [sage-devel] VOTE: Use "CI Fix" label for merging into continuous integration runs

[G. M.-S.]

+1

Guillermo

On Mon, 4 Mar 2024 at 09:43, David Roe  wrote:

> The following proposal has been made several times the last few weeks: in
> PR #37428 , in this thread
>  and then in this
> thread .  It is
> orthogonal to the ongoing vote in this thread
> .  With no further
> discussion, I'm calling a vote.
>
> *Background*
>
> Starting in Sage 10.2, PRs with the Blocker label have been merged into
> all other PRs before running CI; see the changelog
> 
> and this post
>  for
> more details.  This has led to disagreements about whether this label
> should be applied.
>
> *Proposal*
> We use "CI Fix" rather than Blocker to determine whether an open PR should
> be merged before running CI.  Blocker will retain its previous meaning of a
> PR that should be merged before the next release is finished.  The process
> below describes how to resolve disagreements about whether the "CI Fix"
> label should be applied.
> a. Only PRs with positive review should be marked with the "CI Fix"
> label.  This should be done if both author and reviewer agree that it is
> appropriate, and a rationale should be given in a comment on the ticket.
> b. If a PR becomes disputed (as described in this proposal
> ), the "CI Fix"
> status can be voted on separately upon request; otherwise it should be
> applied if and only if positive review is applied.
>
> Voting will be open until Wednesday, March 13.
> David
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CANnG189Rx%3DfXHDCQvDiTS0f_qHwRG9LbfiKKqph6DXuF%3Dd1zcw%40mail.gmail.com.

Re: [sage-devel] VOTE: Use "CI Fix" label for merging into continuous integration runs

[William Stein]

+1

On Mon, Mar 4, 2024 at 8:03 AM Edgar Costa  wrote:

> +1
>
> On Mon, Mar 4, 2024, 10:49 Giacomo Pope  wrote:
>
>> +1
>>
>> On Monday, March 4, 2024 at 1:57:48 PM UTC Dima Pasechnik wrote:
>>
>>> +1
>>>
>>> On Mon, Mar 4, 2024 at 8:43 AM David Roe  wrote:
>>>
 The following proposal has been made several times the last few weeks:
 in PR #37428 , in this
 thread  and then
 in this thread .
 It is orthogonal to the ongoing vote in this thread
 .  With no
 further discussion, I'm calling a vote.

 *Background*

 Starting in Sage 10.2, PRs with the Blocker label have been merged into
 all other PRs before running CI; see the changelog
 
 and this post
 
 for more details.  This has led to disagreements about whether this label
 should be applied.

 *Proposal*
 We use "CI Fix" rather than Blocker to determine whether an open PR
 should be merged before running CI.  Blocker will retain its previous
 meaning of a PR that should be merged before the next release is finished.
 The process below describes how to resolve disagreements about whether the
 "CI Fix" label should be applied.
 a. Only PRs with positive review should be marked with the "CI Fix"
 label.  This should be done if both author and reviewer agree that it is
 appropriate, and a rationale should be given in a comment on the ticket.
 b. If a PR becomes disputed (as described in this proposal
 ), the "CI Fix"
 status can be voted on separately upon request; otherwise it should be
 applied if and only if positive review is applied.

 Voting will be open until Wednesday, March 13.
 David


 --
 You received this message because you are subscribed to the Google
 Groups "sage-devel" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to sage-devel+...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/sage-devel/CAChs6_mYLUWXMU6AZKJGPKd2oz0AC_qAUjnGoD9Q9yixzNBC2w%40mail.gmail.com
 
 .

>>> --
>> You received this message because you are subscribed to the Google Groups
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to sage-devel+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/sage-devel/77cc05b2-1c52-4aae-80ca-4d0ec0830e2dn%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CA%2BiQ7x40QryVx%2BPDDcGB4bJwrd%3D5NqbT94Xq5nSb0wxncwvGZQ%40mail.gmail.com
> 
> .
>


-- 
William (http://wstein.org)

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CACLE5GAhb8Xf9M9ctUSM6R_P3fW1J_rLM%2B7JV6NMvggbqtbYYw%40mail.gmail.com.

Re: [sage-devel] VOTE: Use "CI Fix" label for merging into continuous integration runs

[Edgar Costa]

+1

On Mon, Mar 4, 2024, 10:49 Giacomo Pope  wrote:

> +1
>
> On Monday, March 4, 2024 at 1:57:48 PM UTC Dima Pasechnik wrote:
>
>> +1
>>
>> On Mon, Mar 4, 2024 at 8:43 AM David Roe  wrote:
>>
>>> The following proposal has been made several times the last few weeks:
>>> in PR #37428 , in this
>>> thread  and then
>>> in this thread .
>>> It is orthogonal to the ongoing vote in this thread
>>> .  With no
>>> further discussion, I'm calling a vote.
>>>
>>> *Background*
>>>
>>> Starting in Sage 10.2, PRs with the Blocker label have been merged into
>>> all other PRs before running CI; see the changelog
>>> 
>>> and this post
>>> 
>>> for more details.  This has led to disagreements about whether this label
>>> should be applied.
>>>
>>> *Proposal*
>>> We use "CI Fix" rather than Blocker to determine whether an open PR
>>> should be merged before running CI.  Blocker will retain its previous
>>> meaning of a PR that should be merged before the next release is finished.
>>> The process below describes how to resolve disagreements about whether the
>>> "CI Fix" label should be applied.
>>> a. Only PRs with positive review should be marked with the "CI Fix"
>>> label.  This should be done if both author and reviewer agree that it is
>>> appropriate, and a rationale should be given in a comment on the ticket.
>>> b. If a PR becomes disputed (as described in this proposal
>>> ), the "CI Fix"
>>> status can be voted on separately upon request; otherwise it should be
>>> applied if and only if positive review is applied.
>>>
>>> Voting will be open until Wednesday, March 13.
>>> David
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "sage-devel" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to sage-devel+...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/sage-devel/CAChs6_mYLUWXMU6AZKJGPKd2oz0AC_qAUjnGoD9Q9yixzNBC2w%40mail.gmail.com
>>> 
>>> .
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/77cc05b2-1c52-4aae-80ca-4d0ec0830e2dn%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CA%2BiQ7x40QryVx%2BPDDcGB4bJwrd%3D5NqbT94Xq5nSb0wxncwvGZQ%40mail.gmail.com.

Re: [sage-devel] VOTE: Use "CI Fix" label for merging into continuous integration runs

[Giacomo Pope]

+1

On Monday, March 4, 2024 at 1:57:48 PM UTC Dima Pasechnik wrote:

> +1
>
> On Mon, Mar 4, 2024 at 8:43 AM David Roe  wrote:
>
>> The following proposal has been made several times the last few weeks: in 
>> PR #37428 , in this thread 
>>  and then in this 
>> thread .  It is 
>> orthogonal to the ongoing vote in this thread 
>> .  With no further 
>> discussion, I'm calling a vote.
>>
>> *Background*
>>
>> Starting in Sage 10.2, PRs with the Blocker label have been merged into 
>> all other PRs before running CI; see the changelog 
>> 
>>  
>> and this post 
>>  
>> for more details.  This has led to disagreements about whether this label 
>> should be applied.
>>
>> *Proposal*
>> We use "CI Fix" rather than Blocker to determine whether an open PR 
>> should be merged before running CI.  Blocker will retain its previous 
>> meaning of a PR that should be merged before the next release is finished.  
>> The process below describes how to resolve disagreements about whether the 
>> "CI Fix" label should be applied.
>> a. Only PRs with positive review should be marked with the "CI Fix" 
>> label.  This should be done if both author and reviewer agree that it is 
>> appropriate, and a rationale should be given in a comment on the ticket.
>> b. If a PR becomes disputed (as described in this proposal 
>> ), the "CI Fix" 
>> status can be voted on separately upon request; otherwise it should be 
>> applied if and only if positive review is applied.
>>
>> Voting will be open until Wednesday, March 13.
>> David
>>
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to sage-devel+...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/sage-devel/CAChs6_mYLUWXMU6AZKJGPKd2oz0AC_qAUjnGoD9Q9yixzNBC2w%40mail.gmail.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/77cc05b2-1c52-4aae-80ca-4d0ec0830e2dn%40googlegroups.com.

Re: [sage-devel] VOTE: Use "CI Fix" label for merging into continuous integration runs

[Dima Pasechnik]

+1

On Mon, Mar 4, 2024 at 8:43 AM David Roe  wrote:

> The following proposal has been made several times the last few weeks: in
> PR #37428 , in this thread
>  and then in this
> thread .  It is
> orthogonal to the ongoing vote in this thread
> .  With no further
> discussion, I'm calling a vote.
>
> *Background*
>
> Starting in Sage 10.2, PRs with the Blocker label have been merged into
> all other PRs before running CI; see the changelog
> 
> and this post
>  for
> more details.  This has led to disagreements about whether this label
> should be applied.
>
> *Proposal*
> We use "CI Fix" rather than Blocker to determine whether an open PR should
> be merged before running CI.  Blocker will retain its previous meaning of a
> PR that should be merged before the next release is finished.  The process
> below describes how to resolve disagreements about whether the "CI Fix"
> label should be applied.
> a. Only PRs with positive review should be marked with the "CI Fix"
> label.  This should be done if both author and reviewer agree that it is
> appropriate, and a rationale should be given in a comment on the ticket.
> b. If a PR becomes disputed (as described in this proposal
> ), the "CI Fix"
> status can be voted on separately upon request; otherwise it should be
> applied if and only if positive review is applied.
>
> Voting will be open until Wednesday, March 13.
> David
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CAChs6_mYLUWXMU6AZKJGPKd2oz0AC_qAUjnGoD9Q9yixzNBC2w%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq0ovg%2B0rLyJpDBaew5eFvSBr70GDHN%3Da4cPS6J2xFNiEA%40mail.gmail.com.