[Samba] GPLv3 and Mac OS X
This may have been raised before and if so I apologise for not being able to find it. I was wondering if someone on the list can please explain the relationship that GPLv3 has in preventing Apple from distributing updated builds with their operating systems. I've read over the GPLv3 (I'm not lawyer or anything) and I would guess it has something to do with the patent agreements? I'll admit that I'm not too happy with the GPLv3 and think that, ironically, it is in many ways as restrictive (and in some ways even more so) than closed source software. That's only my opinion though and I understand where it may be useful. Regardless of my opinion, I would like to know about GPLv3 vs. Apple Mac OS X and if there are any plans (i.e. Samba 4) that would allow the software to again be shipped with the operating system. Many thanks, Stephen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] GPLv3 and Mac OS X
On 10/30/2010 02:48 AM, Stephen Norman wrote: This may have been raised before and if so I apologise for not being able to find it. No apology needed. We can discuss this topic on this list. I was wondering if someone on the list can please explain the relationship that GPLv3 has in preventing Apple from distributing updated builds with their operating systems. I've read over the GPLv3 (I'm not lawyer or anything) and I would guess it has something to do with the patent agreements? Why do you believe Apple cannot make use of Samba? That is a very different question from why they might refuse to use it. The word prevention implies a cannot element as opposed to a business decision not to use it. Objection for business reasons is like choosing not to purchase something as opposed to not being able to purchase it for one reason or another. Licensing terms form a contractual boundary to accepted use of a created work in order to preserve the intent (wishes) of those who labored to create it. Samba is the result of many hundreds of man-years of work that was freely contributed for the benefit of all, subject to the specific terms of use that are set out in the GPL. Even if every business on planet Earth should choose not to use it in their products what would be the loss to it creators? I'll admit that I'm not too happy with the GPLv3 and think that, ironically, it is in many ways as restrictive (and in some ways even more so) than closed source software. That's only my opinion though and I understand where it may be useful. Please help us to understand what changes to the licensing terms will cause more people to contribute their labors to its improvement and assure its wider use. What must the creators of Samba give up in order to be successful? What does success look like? How will Apple benefit from this change? How will these benefits help the creators of Samba to better achieve their goals and objectives? If you can convince the authors of Samba that the benefits of being more successful will outweigh what the world will lose you will get a certain hearing. In other words, what must the Samba developers give up and what will be their gain by doing this? Regardless of my opinion, I would like to know about GPLv3 vs. Apple Mac OS X and if there are any plans (i.e. Samba 4) that would allow the software to again be shipped with the operating system. Samba4 is part of the Samba3 code tree. All of Samba will continue to ship under the terms of the GPLv3 until such time as the authors see good reason for change. We respect the right of anyone (person or company) to use or not to use Samba. I would like to see more people benefit from our efforts and our labors. I believe that the GPLv3 is the best way that our users can continue to receive those benefits. The Samba team has chosen to license under the terms of the GPLv3. Cheers, John T. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] writable = yes for Profiles in smb.conf.default
Hello all I'm suggesting to add line 'writable = yes' for Profiles share in file examples/smb.conf.default. Then the complete share def looked like ;[Profiles] ;path = /usr/local/samba/profiles ;browseable = no ;guest ok = yes ;writable = yes The reason is simply I spent two days figuring out why my Samba PDC did not work. That line was missing. Not very clever, I know. (Profile share must be writable if used) Still I'd like to save others from the same error. Regards Benedikt -- Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] writable = yes for Profiles in smb.conf.default
On Sat, Oct 30, 2010 at 11:14 AM, Benedikt Panzer benedikt_pan...@gmx.de wrote: I'm suggesting to add line 'writable = yes' for Profiles share in file examples/smb.conf.default. Then the complete share def looked like I'd vote for read only = no - as the man page seems to indicate that read only is the preferred synonym - by not describing it as a synonym. I'd like to see the complete removal of the synonyms from smb.conf. With writable as a synonym for writeable which is an inverted synonym for read only I've seen shares in smb.conf's that use both instead of one or the other. And even examples/smb.conf.default uses a mixture of read only and writable (although not in the same share). I think the plethora of synonyms for smb.conf cause confusion and assist in the creation of mistakes. Time to clean up this mess, decide on the preferred synonyms and deprecate the others, with testparm warnings, followed by removal a couple of releases later. Chris -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] GPLv3 and Mac OS X
On 31/10/2010, at 1:03 AM, John H Terpstra j...@samba.org wrote: On 10/30/2010 02:48 AM, Stephen Norman wrote: This may have been raised before and if so I apologise for not being able to find it. No apology needed. We can discuss this topic on this list. I was wondering if someone on the list can please explain the relationship that GPLv3 has in preventing Apple from distributing updated builds with their operating systems. I've read over the GPLv3 (I'm not lawyer or anything) and I would guess it has something to do with the patent agreements? Why do you believe Apple cannot make use of Samba? That is a very different question from why they might refuse to use it. The word prevention implies a cannot element as opposed to a business decision not to use it. Objection for business reasons is like choosing not to purchase something as opposed to not being able to purchase it for one reason or another. Licensing terms form a contractual boundary to accepted use of a created work in order to preserve the intent (wishes) of those who labored to create it. Samba is the result of many hundreds of man-years of work that was freely contributed for the benefit of all, subject to the specific terms of use that are set out in the GPL. Even if every business on planet Earth should choose not to use it in their products what would be the loss to it creators? Prevention may have been a poor choice of words here. I guess what I'm asking is, if Apple was to ship Samba 3.2 or above with their OS, what other parts of the OS (if any) would need to be released under GPLv3? For instance, if Finder used some part of Samba in it would it too need to be made available as GPLv3? I'll admit that I'm not too happy with the GPLv3 and think that, ironically, it is in many ways as restrictive (and in some ways even more so) than closed source software. That's only my opinion though and I understand where it may be useful. Please help us to understand what changes to the licensing terms will cause more people to contribute their labors to its improvement and assure its wider use. What must the creators of Samba give up in order to be successful? What does success look like? How will Apple benefit from this change? How will these benefits help the creators of Samba to better achieve their goals and objectives? If you can convince the authors of Samba that the benefits of being more successful will outweigh what the world will lose you will get a certain hearing. In other words, what must the Samba developers give up and what will be their gain by doing this? I definitely see your point here so I'll try and explain. Apple is one of the largest users of open source software in the world, with over 50 million users each using open source software. By largest users, I mean the software is on people's machine (server side projects like Apache would have much greater numbers). That is a large number and second only to Microsoft Windows. They have been an advocate for open source software, shipping a number of technologies, including Samba in Mac OS X for almost a decade. They helped kickstart software technologies including Ruby on Rails by being the first to ship the software with the OS, something which continues to be the case today. I'm not sure how many users use Samba worldwide, but I'd think that the potential loss of such a number would have been considered during the license transition. After all, Apple aren't going to use code in their OS that might require them to open source some of their key technologies, such as the Finder or Workgroup Manager. Instead, Apple will be forced to either fork the old code base of Samba (something no one wants) or develop their own implementation of CIFS/SMB that isn't covered under the GPL. GCC's change to GPLv3 forced Apple to find an entirely new compiler infrastructure, Clang/LLVM, which arguably is actually an improvement over GCC in many ways. The problem for the GCC people is that their are now going to be 50 million of their users potentially moving to a new compiler and that isn't counting other projects such as FreeBSD and other BSD derivatives. The flow on affect could be quiet large, and while GCC isn't going away any time soon, the potential for it to be superseded by LLVM is certainly there. I'd hate to see the open source community end up being divided into a GPLv3 zone and one that has everyone else. It would then prove many anti open-source advocates (i am not one of them) a reason to show how open source doesn't always work. In relation to Samba (I'll play devils advocat here), the question on my mind woud be, how does using software that already exists in the community and is well liked and tested useful to my project if using that code actually results in me having restrictions placed on what I can do with my code, just because I linked to some pre-existing code? I realise a lot of
Re: [Samba] GPLv3 and Mac OS X
On Sun, Oct 31, 2010 at 04:00:21AM +1100, Stephen Norman wrote: Prevention may have been a poor choice of words here. I guess what I'm asking is, if Apple was to ship Samba 3.2 or above with their OS, what other parts of the OS (if any) would need to be released under GPLv3? For instance, if Finder used some part of Samba in it would it too need to be made available as GPLv3? If Finder became a derived work of Samba then yes it would need to be made available under GPLv3. Just as if Finder was a derived work of Samba in their current OS (where they use Samba 3.0.x) they would need to ship Finder under GPLv2. Lest anyone thing I'm making any claims, Finder is *NOT* a derived work of Samba under GPLv2, and neither would the same code be a derived work of Samba under GPLv3. So there really is no difference there to Apple at all. They don't like GPLv3, but that is their right. We *do* like GPLv3, and that is our right. I'm not sure how many users use Samba worldwide, but I'd think that the potential loss of such a number would have been considered during the license transition. After all, Apple aren't going to use code in their OS that might require them to open source some of their key technologies, such as the Finder or Workgroup Manager. Of course we didn't want to lose people. But this is Apple's decision not to ship, not ours. No other OEM's have had problems. These include IBM, HP, Google.. it's a large list. Instead, Apple will be forced to either fork the old code base of Samba (something no one wants) or develop their own implementation of CIFS/SMB that isn't covered under the GPL. Which is their choice. GCC's change to GPLv3 forced Apple to find an entirely new compiler infrastructure, Clang/LLVM, which arguably is actually an improvement over GCC in many ways. The problem for the GCC people is that their are now going to be 50 million of their users potentially moving to a new compiler and that isn't counting other projects such as FreeBSD and other BSD derivatives. The flow on affect could be quiet large, and while GCC isn't going away any time soon, the potential for it to be superseded by LLVM is certainly there. GCC's change to GPLv3 didn't *force* Apple to do anything. Apple *chose* do do it. Are you seeing a pattern here. I'd hate to see the open source community end up being divided into a GPLv3 zone and one that has everyone else. It would then prove many anti open-source advocates (i am not one of them) a reason to show how open source doesn't always work. Rubbish. GPLv2 used to have the same reaction. If you'd only release under BSD then you'd be more *popular* was always the whine. It's not a popularity contest, it's about philosophy. I realise a lot of the changes made in GPLv3 relate to patents, but I'd say that it would make better business sense to most companies to license a technology (such as SMB) from Microsoft and then be allowed to include it in my product, which they can then sell and support, rather than being forced to release their code for free. In other words, giving up the freedom for their users. This is the same with GPLv2 by the way. Look at section 7. If it's better business sense then companies will do it. Some do, some don't. So I'd disagree over that. Finally, companies such as Apple are going to have to deal with problems such as Windows 7 compatibilty in their products, something which the old version of Samba 3.0 seems to have trouble with, and if they find they are unwilling to update to a later version because of the requirements of the new license, then they may have to switch to a different technology or license it from Microsoft. That might make Microsoft happy but it would be a big blow for the Samba project, especially if it meant the loss of over 50 million potential users. What a shame - Apple will have to spend a lot of money to adopt to Windows 7 because they don't want the Free help. Their choice. 3.0.x has problems with Windows 7 as Win7 wasn't even a gleam in Microsoft's eye when 3.0.x was shipped. I think Samba is an amazing project and I don't want to detract from that at all. I personally think that compelling companies to release their code under the GPLv3 for using a small part of GPLv3 code is against the principals of open source software in general. After all, the original purpose (and I think the general public opinion) is that open source means I can take code, include it in my project and sell that project to customers as long as I give any changes I make to the source code of the project back to the community. What complete rubbish. People said *exactly* the same about GPLv2. GPLv3 Samba has pricisely the same effect on Apple as GPLv2 Samba - no more difficult to work with. Your summation of what Open Source means is I guess the biggest problem is that no one seems to be clear on some of the points of the GPLv3. Rubbish again.
Re: [Samba] GPLv3 and Mac OS X
Just to be clear, I'm not attempting to spread FUD about Samba or the GPL. I'm just trying to understand how the license changes may or may not effect the software I work with on a daily basis. On 31/10/2010, at 4:16 AM, Jeremy Allison j...@samba.org wrote: On Sun, Oct 31, 2010 at 04:00:21AM +1100, Stephen Norman wrote: Prevention may have been a poor choice of words here. I guess what I'm asking is, if Apple was to ship Samba 3.2 or above with their OS, what other parts of the OS (if any) would need to be released under GPLv3? For instance, if Finder used some part of Samba in it would it too need to be made available as GPLv3? If Finder became a derived work of Samba then yes it would need to be made available under GPLv3. Just as if Finder was a derived work of Samba in their current OS (where they use Samba 3.0.x) they would need to ship Finder under GPLv2. Lest anyone thing I'm making any claims, Finder is *NOT* a derived work of Samba under GPLv2, and neither would the same code be a derived work of Samba under GPLv3. So there really is no difference there to Apple at all. They don't like GPLv3, but that is their right. We *do* like GPLv3, and that is our right. I'm not sure that I'm not sure how many users use Samba worldwide, but I'd think that the potential loss of such a number would have been considered during the license transition. After all, Apple aren't going to use code in their OS that might require them to open source some of their key technologies, such as the Finder or Workgroup Manager. Of course we didn't want to lose people. But this is Apple's decision not to ship, not ours. No other OEM's have had problems. These include IBM, HP, Google.. it's a large list. Instead, Apple will be forced to either fork the old code base of Samba (something no one wants) or develop their own implementation of CIFS/SMB that isn't covered under the GPL. Which is their choice. GCC's change to GPLv3 forced Apple to find an entirely new compiler infrastructure, Clang/LLVM, which arguably is actually an improvement over GCC in many ways. The problem for the GCC people is that their are now going to be 50 million of their users potentially moving to a new compiler and that isn't counting other projects such as FreeBSD and other BSD derivatives. The flow on affect could be quiet large, and while GCC isn't going away any time soon, the potential for it to be superseded by LLVM is certainly there. GCC's change to GPLv3 didn't *force* Apple to do anything. Apple *chose* do do it. Are you seeing a pattern here. I'd hate to see the open source community end up being divided into a GPLv3 zone and one that has everyone else. It would then prove many anti open-source advocates (i am not one of them) a reason to show how open source doesn't always work. Rubbish. GPLv2 used to have the same reaction. If you'd only release under BSD then you'd be more *popular* was always the whine. It's not a popularity contest, it's about philosophy. I realise a lot of the changes made in GPLv3 relate to patents, but I'd say that it would make better business sense to most companies to license a technology (such as SMB) from Microsoft and then be allowed to include it in my product, which they can then sell and support, rather than being forced to release their code for free. In other words, giving up the freedom for their users. This is the same with GPLv2 by the way. Look at section 7. If it's better business sense then companies will do it. Some do, some don't. So I'd disagree over that. Finally, companies such as Apple are going to have to deal with problems such as Windows 7 compatibilty in their products, something which the old version of Samba 3.0 seems to have trouble with, and if they find they are unwilling to update to a later version because of the requirements of the new license, then they may have to switch to a different technology or license it from Microsoft. That might make Microsoft happy but it would be a big blow for the Samba project, especially if it meant the loss of over 50 million potential users. What a shame - Apple will have to spend a lot of money to adopt to Windows 7 because they don't want the Free help. Their choice. 3.0.x has problems with Windows 7 as Win7 wasn't even a gleam in Microsoft's eye when 3.0.x was shipped. I think Samba is an amazing project and I don't want to detract from that at all. I personally think that compelling companies to release their code under the GPLv3 for using a small part of GPLv3 code is against the principals of open source software in general. After all, the original purpose (and I think the general public opinion) is that open source means I can take code, include it in my project and sell that project to customers as long as I give any changes I make to the source code of the project back to the community.
Re: [Samba] GPLv3 and Mac OS X
Apologies for the previous message. Its what happens at 4 in the morning! On 31/10/2010, at 4:47 AM, Stephen Norman stenorman2...@me.com wrote: Just to be clear, I'm not attempting to spread FUD about Samba or the GPL. I'm just trying to understand how the license changes may or may not effect the software I work with on a daily basis. On 31/10/2010, at 4:16 AM, Jeremy Allison j...@samba.org wrote: On Sun, Oct 31, 2010 at 04:00:21AM +1100, Stephen Norman wrote: Prevention may have been a poor choice of words here. I guess what I'm asking is, if Apple was to ship Samba 3.2 or above with their OS, what other parts of the OS (if any) would need to be released under GPLv3? For instance, if Finder used some part of Samba in it would it too need to be made available as GPLv3? If Finder became a derived work of Samba then yes it would need to be made available under GPLv3. Just as if Finder was a derived work of Samba in their current OS (where they use Samba 3.0.x) they would need to ship Finder under GPLv2. Lest anyone thing I'm making any claims, Finder is *NOT* a derived work of Samba under GPLv2, and neither would the same code be a derived work of Samba under GPLv3. So there really is no difference there to Apple at all. They don't like GPLv3, but that is their right. We *do* like GPLv3, and that is our right. I'm not sure if you could say that Apple doesn't like GPLv3, so that is spreading FUD there as well. Regardless, my guess would be that their legal department has made a case that it might open them for some legal action somewhere. Derived work seems to be a bit of a grey area and opinions seem to be divided. The definition was also revised under GPLv3 so that may have something to do with it. I'm not sure how many users use Samba worldwide, but I'd think that the potential loss of such a number would have been considered during the license transition. After all, Apple aren't going to use code in their OS that might require them to open source some of their key technologies, such as the Finder or Workgroup Manager. Of course we didn't want to lose people. But this is Apple's decision not to ship, not ours. No other OEM's have had problems. These include IBM, HP, Google.. it's a large list. I wasn't aware of these companies shipping products that contained Samba or under what licenses those products are under. Instead, Apple will be forced to either fork the old code base of Samba (something no one wants) or develop their own implementation of CIFS/SMB that isn't covered under the GPL. Which is their choice. True, and it would be a bad choice in my opinion. GCC's change to GPLv3 forced Apple to find an entirely new compiler infrastructure, Clang/LLVM, which arguably is actually an improvement over GCC in many ways. The problem for the GCC people is that their are now going to be 50 million of their users potentially moving to a new compiler and that isn't counting other projects such as FreeBSD and other BSD derivatives. The flow on affect could be quiet large, and while GCC isn't going away any time soon, the potential for it to be superseded by LLVM is certainly there. GCC's change to GPLv3 didn't *force* Apple to do anything. Apple *chose* do do it. Are you seeing a pattern here. See above. I'd hate to see the open source community end up being divided into a GPLv3 zone and one that has everyone else. It would then prove many anti open-source advocates (i am not one of them) a reason to show how open source doesn't always work. Rubbish. GPLv2 used to have the same reaction. If you'd only release under BSD then you'd be more *popular* was always the whine. It's not a popularity contest, it's about philosophy. Having being at school during most of the time of GPLv2, and only having being born at the time of it's release, I can't say I have any knowledge of the issues encountered when GPLv2 was released. I realise a lot of the changes made in GPLv3 relate to patents, but I'd say that it would make better business sense to most companies to license a technology (such as SMB) from Microsoft and then be allowed to include it in my product, which they can then sell and support, rather than being forced to release their code for free. In other words, giving up the freedom for their users. This is the same with GPLv2 by the way. Look at section 7. If it's better business sense then companies will do it. Some do, some don't. So I'd disagree over that. Finally, companies such as Apple are going to have to deal with problems such as Windows 7 compatibilty in their products, something which the old version of Samba 3.0 seems to have trouble with, and if they find they are unwilling to update to a later version because of the requirements of the new license, then they may have to switch to a different technology or license it from Microsoft. That might make
Re: [Samba] GPLv3 and Mac OS X
On 10/30/2010 12:00 PM, Stephen Norman wrote: On 31/10/2010, at 1:03 AM, John H Terpstra j...@samba.org wrote: On 10/30/2010 02:48 AM, Stephen Norman wrote: This may have been raised before and if so I apologise for not being able to find it. No apology needed. We can discuss this topic on this list. I was wondering if someone on the list can please explain the relationship that GPLv3 has in preventing Apple from distributing updated builds with their operating systems. I've read over the GPLv3 (I'm not lawyer or anything) and I would guess it has something to do with the patent agreements? Why do you believe Apple cannot make use of Samba? That is a very different question from why they might refuse to use it. The word prevention implies a cannot element as opposed to a business decision not to use it. Objection for business reasons is like choosing not to purchase something as opposed to not being able to purchase it for one reason or another. Licensing terms form a contractual boundary to accepted use of a created work in order to preserve the intent (wishes) of those who labored to create it. Samba is the result of many hundreds of man-years of work that was freely contributed for the benefit of all, subject to the specific terms of use that are set out in the GPL. Even if every business on planet Earth should choose not to use it in their products what would be the loss to it creators? Prevention may have been a poor choice of words here. I guess what I'm asking is, if Apple was to ship Samba 3.2 or above with their OS, what other parts of the OS (if any) would need to be released under GPLv3? For instance, if Finder used some part of Samba in it would it too need to be made available as GPLv3? The Samba team does not force anyone to use samba. If someone chooses to use it they must comply with its licensing terms. All derivatives of Samba fall under the same license that samba is under - that is what the GPL seeks to achieve. The GPL seeks to prevent the misuse and misappropriation of software source code. Its that simple. You may not like that, and indeed Apple may not like that, but that's the way it is. Please keep in mind that to use or not to use is a choice! I'll admit that I'm not too happy with the GPLv3 and think that, ironically, it is in many ways as restrictive (and in some ways even more so) than closed source software. That's only my opinion though and I understand where it may be useful. Please help us to understand what changes to the licensing terms will cause more people to contribute their labors to its improvement and assure its wider use. What must the creators of Samba give up in order to be successful? What does success look like? How will Apple benefit from this change? How will these benefits help the creators of Samba to better achieve their goals and objectives? If you can convince the authors of Samba that the benefits of being more successful will outweigh what the world will lose you will get a certain hearing. In other words, what must the Samba developers give up and what will be their gain by doing this? I definitely see your point here so I'll try and explain. Apple is one of the largest users of open source software in the world, with over 50 million users each using open source software. By largest users, I mean the software is on people's machine (server side projects like Apache would have much greater numbers). That is a large number and second only to Microsoft Windows. They have been an advocate for open source software, shipping a number of technologies, including Samba in Mac OS X for almost a decade. They helped kickstart software technologies including Ruby on Rails by being the first to ship the software with the OS, something which continues to be the case today. Let's make sure that credit is given where it is due. For all the good things any corporation or individual does let's say thank you - AND - remember to comply with the license terms under which the contribution was made. If we do not like the license terms, ask for reconsideration by all means, but do not demand it. The author has rights of determination over his/her works. I'm not sure how many users use Samba worldwide, but I'd think that the potential loss of such a number would have been considered during the license transition. After all, Apple aren't going to use code in their OS that might require them to open source some of their key technologies, such as the Finder or Workgroup Manager. Please check your facts. Anyone who produces a derivative work from a licensed software application must comply with the original authors' or licensors' terms and conditions. Remember, noone forces anyone to create a derivative work! Only derivative works are affected. Instead, Apple will be forced to either fork the old code base of Samba (something no one wants) or develop their own
Re: [Samba] GPLv3 and Mac OS X
On Sat, Oct 30, 2010 at 2:16 PM, Stephen Norman stenorman2...@me.com wrote: Apologies for the previous message. Its what happens at 4 in the morning! On 31/10/2010, at 4:47 AM, Stephen Norman stenorman2...@me.com wrote: I've read and Googled quiet extensively regarding GPLv3 before posting and find it offensive for anyone to think I'd post the question otherwise. Most of the documentation provided around GPLv3 can only be truly understood by someone with an insight into the law covering such licenses. You do seem to be re-iterating what are common concerns about GPLv3, ones that are not borne out by other experience with open source licenses, especially GPL. versions. The GPLv3 is a logical extension of previous GPL's to prevent precisely the sort of sealed applicance and patent encumbered product riding on top of previous open source development. Tivo's are a great example of this, as are Netgear cable modems. Storage applicances using Samba are a very obvious candidate for similar abuses of GPL, using Samba's GPL code to build an appliance, and patent encumbering it to prevent access to the actual applicance software and to block development with it. Take a good look at those inexpensive Terabyte network storage devices. A lot of them are actually running Samba under the hood, and most of them are good about providing source code access. But without GPLv3, any software patents could encumber and prevent us, as owners of such a device, from rebuilding it. The two points I've seen repeated over and over again in my browsing is the confusion people have in what constitutes derivative work and the concern over the fact that there is yet to be (at least reported) of a legal case involving GPLv3. I believe they are legitimate concerns that anyone should be allowed to have and certainly shouldn't be considered FUD. In time, GPLv3 will probably become as widely accepted as GPLv2. I think everyone can agree that software freedom is important, even if the implementations often differ. And now you're re-iterating the FUD. The GPLv3 is not that hard to follow: it seems a clear statement of privileges already corroborated in copyright and patent law. It's being used in a fascinating judo way: to discredit it requires discrediting many millions of dollars of already existing patent property, and would effectively open up *other* people's previously protected, patented software to otherwise violating use. Samba seems a fabulous toolkit to apply it to: network storage appliances are precisely where encumbering patents could be easily inserted by the vendors to take advantage of Samba's free software development, but block access to their development work by others. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] GPLv3 and Mac OS X
Forget our war of words. It looks like Apple and the FSF can't get along at the moment. http://lwn.net/Articles/405417/ I apologise for my confusion as it does appear to be a problem between Apple and the FSF. Cheers, Stephen On 31/10/2010, at 5:29 AM, John H Terpstra j...@samba.org wrote: On 10/30/2010 12:00 PM, Stephen Norman wrote: On 31/10/2010, at 1:03 AM, John H Terpstra j...@samba.org wrote: On 10/30/2010 02:48 AM, Stephen Norman wrote: This may have been raised before and if so I apologise for not being able to find it. No apology needed. We can discuss this topic on this list. I was wondering if someone on the list can please explain the relationship that GPLv3 has in preventing Apple from distributing updated builds with their operating systems. I've read over the GPLv3 (I'm not lawyer or anything) and I would guess it has something to do with the patent agreements? Why do you believe Apple cannot make use of Samba? That is a very different question from why they might refuse to use it. The word prevention implies a cannot element as opposed to a business decision not to use it. Objection for business reasons is like choosing not to purchase something as opposed to not being able to purchase it for one reason or another. Licensing terms form a contractual boundary to accepted use of a created work in order to preserve the intent (wishes) of those who labored to create it. Samba is the result of many hundreds of man-years of work that was freely contributed for the benefit of all, subject to the specific terms of use that are set out in the GPL. Even if every business on planet Earth should choose not to use it in their products what would be the loss to it creators? Prevention may have been a poor choice of words here. I guess what I'm asking is, if Apple was to ship Samba 3.2 or above with their OS, what other parts of the OS (if any) would need to be released under GPLv3? For instance, if Finder used some part of Samba in it would it too need to be made available as GPLv3? The Samba team does not force anyone to use samba. If someone chooses to use it they must comply with its licensing terms. All derivatives of Samba fall under the same license that samba is under - that is what the GPL seeks to achieve. The GPL seeks to prevent the misuse and misappropriation of software source code. Its that simple. You may not like that, and indeed Apple may not like that, but that's the way it is. Please keep in mind that to use or not to use is a choice! I'll admit that I'm not too happy with the GPLv3 and think that, ironically, it is in many ways as restrictive (and in some ways even more so) than closed source software. That's only my opinion though and I understand where it may be useful. Please help us to understand what changes to the licensing terms will cause more people to contribute their labors to its improvement and assure its wider use. What must the creators of Samba give up in order to be successful? What does success look like? How will Apple benefit from this change? How will these benefits help the creators of Samba to better achieve their goals and objectives? If you can convince the authors of Samba that the benefits of being more successful will outweigh what the world will lose you will get a certain hearing. In other words, what must the Samba developers give up and what will be their gain by doing this? I definitely see your point here so I'll try and explain. Apple is one of the largest users of open source software in the world, with over 50 million users each using open source software. By largest users, I mean the software is on people's machine (server side projects like Apache would have much greater numbers). That is a large number and second only to Microsoft Windows. They have been an advocate for open source software, shipping a number of technologies, including Samba in Mac OS X for almost a decade. They helped kickstart software technologies including Ruby on Rails by being the first to ship the software with the OS, something which continues to be the case today. Let's make sure that credit is given where it is due. For all the good things any corporation or individual does let's say thank you - AND - remember to comply with the license terms under which the contribution was made. If we do not like the license terms, ask for reconsideration by all means, but do not demand it. The author has rights of determination over his/her works. I'm not sure how many users use Samba worldwide, but I'd think that the potential loss of such a number would have been considered during the license transition. After all, Apple aren't going to use code in their OS that might require them to open source some of their key technologies, such as the Finder or Workgroup Manager. Please check your facts. Anyone who produces a derivative work from a
[Samba] Samba 3.4.9 net rpc shutdown and XP Domain client
Hi @all, this is an very old problem, posted the first time 2005 to samba-test...@samba.org: If I have a Domain client with WinXP, which is part of a domain and using this client, if the PDC is not available and want to remote shut down this client with the net tool from other servers, then this is not possible, because net tries to authenticate against the PDC: testeis # net -d3 -S XP -U Administrator%xxx rpc shutdown -t 60 -C Shutting down in 1 minutes. [2010/10/31 01:22:10, 3] param/loadparm.c:9039(lp_load_ex) lp_load_ex: refreshing parameters [2010/10/31 01:22:10, 3] param/loadparm.c:4848(init_globals) Initialising global parameters [2010/10/31 01:22:10, 2] param/loadparm.c:4707(max_open_files) rlimit_max: rlimit_max (1024) below minimum Windows limit (16384) [2010/10/31 01:22:10, 3] ../lib/util/params.c:550(pm_process) params.c:pm_process() - Processing configuration file /etc/smb.conf [2010/10/31 01:22:10, 3] param/loadparm.c:7726(do_section) Processing section [global] [2010/10/31 01:22:10, 2] lib/interface.c:478(interpret_interface) interpret_interface: Adding interface 127.0.0.1/8 [2010/10/31 01:22:10, 2] lib/interface.c:340(add_interface) added interface 127.0.0.1/8 ip=127.0.0.1 bcast=127.255.255.255 netmask=255.0.0.0 [2010/10/31 01:22:10, 2] lib/interface.c:478(interpret_interface) interpret_interface: Adding interface 192.168.0.12/255.255.255.0 [2010/10/31 01:22:10, 2] lib/interface.c:340(add_interface) added interface 192.168.0.12/25 ip=192.168.0.12 bcast=192.168.0.255 netmask=255.255.255.0 lp_load_ex: refreshing parameters params.c:pm_process() - Processing configuration file /etc/smb.conf Processing section [global] interpret_interface: Adding interface 127.0.0.1/8 added interface 127.0.0.1/8 ip=127.0.0.1 bcast=127.255.255.255 netmask=255.0.0.0 interpret_interface: Adding interface 192.168.0.12/255.255.255.0 added interface 192.168.0.12/25 ip=192.168.0.12 bcast=192.168.0.255 netmask=255.255.255.0 Connecting to host=XP Connecting to 192.168.0.37 at port 445 Connecting to 192.168.0.37 at port 139 Doing spnego session setup (blob length=16) server didn't supply a full spnego negprot Got challenge flags: Got NTLMSSP neg_flags=0x62898215 NTLMSSP: Set final flags: Got NTLMSSP neg_flags=0x60088215 NTLMSSP Sign/Seal - Initialising with flags: Got NTLMSSP neg_flags=0x60088215 SPNEGO login failed: No logon servers failed session setup with NT_STATUS_NO_LOGON_SERVERS Could not connect to server XP Connection failed: NT_STATUS_NO_LOGON_SERVERS failed to make ipc connection: NT_STATUS_NO_LOGON_SERVERS initshutdown pipe failed, trying winreg pipe Connecting to host=XP Connecting to 192.168.0.37 at port 445 Doing spnego session setup (blob length=16) server didn't supply a full spnego negprot Got challenge flags: Got NTLMSSP neg_flags=0x62898215 NTLMSSP: Set final flags: Got NTLMSSP neg_flags=0x60088215 NTLMSSP Sign/Seal - Initialising with flags: Got NTLMSSP neg_flags=0x60088215 SPNEGO login failed: No logon servers failed session setup with NT_STATUS_NO_LOGON_SERVERS Could not connect to server XP Connection failed: NT_STATUS_NO_LOGON_SERVERS failed to make ipc connection: NT_STATUS_NO_LOGON_SERVERS return code = -1 Is this a bug? I think, if the PDC is not available, it should also be possible to remote shutdown the clients. Here is the same thing, if the PDC is available: testeis # net -d3 -S XP -U Administrator%xxx rpc shutdown -t 60 -C Shutting down in 1 minutes. [2010/10/31 01:25:43, 3] param/loadparm.c:9039(lp_load_ex) lp_load_ex: refreshing parameters [2010/10/31 01:25:43, 3] param/loadparm.c:4848(init_globals) Initialising global parameters [2010/10/31 01:25:43, 2] param/loadparm.c:4707(max_open_files) rlimit_max: rlimit_max (1024) below minimum Windows limit (16384) [2010/10/31 01:25:43, 3] ../lib/util/params.c:550(pm_process) params.c:pm_process() - Processing configuration file /etc/smb.conf [2010/10/31 01:25:43, 3] param/loadparm.c:7726(do_section) Processing section [global] [2010/10/31 01:25:43, 2] lib/interface.c:478(interpret_interface) interpret_interface: Adding interface 127.0.0.1/8 [2010/10/31 01:25:43, 2] lib/interface.c:340(add_interface) added interface 127.0.0.1/8 ip=127.0.0.1 bcast=127.255.255.255 netmask=255.0.0.0 [2010/10/31 01:25:43, 2] lib/interface.c:478(interpret_interface) interpret_interface: Adding interface 192.168.0.12/255.255.255.0 [2010/10/31 01:25:43, 2] lib/interface.c:340(add_interface) added interface 192.168.0.12/25 ip=192.168.0.12 bcast=192.168.0.255 netmask=255.255.255.0 lp_load_ex: refreshing parameters params.c:pm_process() - Processing configuration file /etc/smb.conf Processing section [global] interpret_interface: Adding interface 127.0.0.1/8 added interface 127.0.0.1/8 ip=127.0.0.1 bcast=127.255.255.255 netmask=255.0.0.0 interpret_interface: Adding interface 192.168.0.12/255.255.255.0 added interface 192.168.0.12/25 ip=192.168.0.12 bcast=192.168.0.255
Re: [Samba] GPLv3 and Mac OS X
On Sun, Oct 31, 2010 at 05:16:53AM +1100, Stephen Norman wrote: I'm not sure if you could say that Apple doesn't like GPLv3, so that is spreading FUD there as well. Regardless, my guess would be that their legal department has made a case that it might open them for some legal action somewhere. Derived work seems to be a bit of a grey area and opinions seem to be divided. The definition was also revised under GPLv3 so that may have something to do with it. I don't think it's spreading FUD about Apple to say they don't like the GPLv3. As you pointed out, they are spending large amounts of resources replaceing gcc with clang, simply because gcc is under GPLv3. I think saying Apple doesn't like the GPLv3 is stating a fact. Of course we didn't want to lose people. But this is Apple's decision not to ship, not ours. No other OEM's have had problems. These include IBM, HP, Google.. it's a large list. I wasn't aware of these companies shipping products that contained Samba or under what licenses those products are under. It's Samba, so they're under GPL v2 and v3, depending on the version being used. Most Samba vendors (other than Apple) have moved or are in the process of moving the 3.2.x or above, which means GPLv3. True, and it would be a bad choice in my opinion. I completely agree, and anything I can do to change their mind short of changing our license - the license that all other Samba vendors ship under, I will do. I've read and Googled quiet extensively regarding GPLv3 before posting and find it offensive for anyone to think I'd post the question otherwise. Most of the documentation provided around GPLv3 can only be truly understood by someone with an insight into the law covering such licenses. I'm sorry - I apologise for claiming you're spreading FUD about GPLv3 (I was in a hurry too when I wrote that email :-). I disagree about people needing an insight into the law to understang the meaning of GPLv3 - the FAQ does makes things very clear. But companies making decisions about licensing should be working with people who *do* have an insight into such law, and in my experience they do. Their legal Dept. usually, staffed with very capable lawyers :-). The two points I've seen repeated over and over again in my browsing is the confusion people have in what constitutes derivative work and the concern over the fact that there is yet to be (at least reported) of a legal case involving GPLv3. I believe they are legitimate concerns that anyone should be allowed to have and certainly shouldn't be considered FUD. In time, GPLv3 will probably become as widely accepted as GPLv2. I think everyone can agree that software freedom is important, even if the implementations often differ. Well people were confused over what a derivative work is when GPLv2 was all there was out there, so I don't think GPLv3 makes a difference here. As for no legal case involving GPLv3, that's a read herring. Remember, if an enforcement action makes it to a case, then it's a failure. The goal of enforcement actions isn't to make case law, it's to get people to quietly obey the license. We (Samba) have done many such enforcements over the years - for both GPLv2 and GPLv3 Samba. You don't hear about them because they are successful, and the license is upheld. People only go to court if they think they can invalidate the license - it's a testiment to the GPL that so few actions actually make it that far. Eventually someone will make similar mistakes with GPLv3 that were made with GPLv3 and it'll end up being enforced by a court, just as GPLv2 was. But I hope that isn't with Samba - court cases are exhausting for everyone involved. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba 3.5.6 jumbo patch
Update, I was able to configure samba 3-5-test with the patch, though make fails when I use source3. Make fails with the error 'cli_krb5_get_ticket'. Derek -Original Message- From: Volker Lendecke [mailto:volker.lende...@sernet.de] Sent: Friday, October 29, 2010 1:28 AM To: Derek Lewis Cc: 'Jeremy Allison'; samba@lists.samba.org Subject: Re: [Samba] Samba 3.5.6 jumbo patch On Fri, Oct 29, 2010 at 01:17:30AM -0700, Derek Lewis wrote: I selected the origin/v3-5-test and tested the patch with git apply --check. I see the same error message as before. I also confirmed that the new branch I created for the build is the current branch via git branch. Just tried the following git am -3 /tmp/samba-3-5-x-acl-jumbo-patch/* in a git checkout of v3-5-test. Works fine. I've also uploaded a summary patch against 3.5.6 at http://www.samba.org/~vlendec/jumbo-patch-3-5-6.diff that you should be able to apply with patch -p1 jumbo-patch-3-5-6.diff Hope that helps. Volker -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] GPLv3 and Mac OS X
Hi Jermey, Thanks for helping me understand all the a bit better. According to discussions on the LLVM mailing list (sorry I don't have the link) when LLVM's libc++ was released, a number of people commented saying that Apple employees are currently unable to work on GPLv3 software, possibly due to some disagreement between Apple and the FSF. My best guess would be something to do with Section 11 of GPLv3 (patents), and that Apple may have made deals after the date specified (28 March 2007) that cannot be easily revoked or altered and would not allow them to meet the requirements of GPLv3. I don't think we'll ever know though. Thanks again, Stephen On 31/10/2010, at 2:48 PM, Jeremy Allison wrote: On Sun, Oct 31, 2010 at 05:16:53AM +1100, Stephen Norman wrote: I'm not sure if you could say that Apple doesn't like GPLv3, so that is spreading FUD there as well. Regardless, my guess would be that their legal department has made a case that it might open them for some legal action somewhere. Derived work seems to be a bit of a grey area and opinions seem to be divided. The definition was also revised under GPLv3 so that may have something to do with it. I don't think it's spreading FUD about Apple to say they don't like the GPLv3. As you pointed out, they are spending large amounts of resources replaceing gcc with clang, simply because gcc is under GPLv3. I think saying Apple doesn't like the GPLv3 is stating a fact. Of course we didn't want to lose people. But this is Apple's decision not to ship, not ours. No other OEM's have had problems. These include IBM, HP, Google.. it's a large list. I wasn't aware of these companies shipping products that contained Samba or under what licenses those products are under. It's Samba, so they're under GPL v2 and v3, depending on the version being used. Most Samba vendors (other than Apple) have moved or are in the process of moving the 3.2.x or above, which means GPLv3. True, and it would be a bad choice in my opinion. I completely agree, and anything I can do to change their mind short of changing our license - the license that all other Samba vendors ship under, I will do. I've read and Googled quiet extensively regarding GPLv3 before posting and find it offensive for anyone to think I'd post the question otherwise. Most of the documentation provided around GPLv3 can only be truly understood by someone with an insight into the law covering such licenses. I'm sorry - I apologise for claiming you're spreading FUD about GPLv3 (I was in a hurry too when I wrote that email :-). I disagree about people needing an insight into the law to understang the meaning of GPLv3 - the FAQ does makes things very clear. But companies making decisions about licensing should be working with people who *do* have an insight into such law, and in my experience they do. Their legal Dept. usually, staffed with very capable lawyers :-). The two points I've seen repeated over and over again in my browsing is the confusion people have in what constitutes derivative work and the concern over the fact that there is yet to be (at least reported) of a legal case involving GPLv3. I believe they are legitimate concerns that anyone should be allowed to have and certainly shouldn't be considered FUD. In time, GPLv3 will probably become as widely accepted as GPLv2. I think everyone can agree that software freedom is important, even if the implementations often differ. Well people were confused over what a derivative work is when GPLv2 was all there was out there, so I don't think GPLv3 makes a difference here. As for no legal case involving GPLv3, that's a read herring. Remember, if an enforcement action makes it to a case, then it's a failure. The goal of enforcement actions isn't to make case law, it's to get people to quietly obey the license. We (Samba) have done many such enforcements over the years - for both GPLv2 and GPLv3 Samba. You don't hear about them because they are successful, and the license is upheld. People only go to court if they think they can invalidate the license - it's a testiment to the GPL that so few actions actually make it that far. Eventually someone will make similar mistakes with GPLv3 that were made with GPLv3 and it'll end up being enforced by a court, just as GPLv2 was. But I hope that isn't with Samba - court cases are exhausting for everyone involved. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Build status as of Sat Oct 30 06:00:02 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-10-29 00:00:03.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-10-30 00:00:10.0 -0600 @@ -1,4 +1,4 @@ -Build status as of Fri Oct 29 06:00:02 2010 +Build status as of Sat Oct 30 06:00:02 2010 Build counts: Tree Total Broken Panic @@ -16,7 +16,7 @@ samba_3_current 32 30 3 samba_3_master 32 19 0 samba_3_next 32 30 0 -samba_4_0_test 37 30 0 +samba_4_0_test 37 28 0 talloc 32 9 0 tdb 30 11 0
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 56b46d8 talloc: Fix manual pages in standalone build. from 14ff2e8 Fix bug #7700 - Improvement of return code of smbclient http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 56b46d8d886cf7c42d52234fe5e6e67ee92e4906 Author: Jelmer Vernooij jel...@samba.org Date: Sat Oct 30 08:27:12 2010 +0200 talloc: Fix manual pages in standalone build. --- Summary of changes: lib/talloc/wscript |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/talloc/wscript b/lib/talloc/wscript index 4e5131c..62759c7 100644 --- a/lib/talloc/wscript +++ b/lib/talloc/wscript @@ -53,8 +53,7 @@ def configure(conf): conf.env.TALLOC_COMPAT1 = Options.options.TALLOC_COMPAT1 -if conf.env.standalone_talloc: -conf.find_program('xsltproc', var='XSLTPROC') +conf.CHECK_XSLTPROC_MANPAGES() if not conf.env.disable_python: # also disable if we don't have the python libs installed -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b4ba669 s4-smbd: initialise process models in smbtorture before use via 35d466e s4-smbd: leave the single process model as internal via 55063cd waf: fixed building of non-shared binaries that contain modules via b2a5654 s4-heimdal: lex_err_message() should not be static via a139628 s4-waf: added a lexyacc.sh script that manually rebuilds the heimdal parsers via a00657d s4-test: don't override modules dir via e08c9ac waf: get rid of target aliases in wafsamba via 679eba6 s4-build: removed some unnecessary dependencies via f5251c0 s4-ndr: make ndr-table a subsystem via 2ea41fd s4-cmdline: make cmdline-credentials a private library via 88fd7e0 s4-dns: make the dns update task an external module via 87b3d38 s4-cluster: make cluster a private shared lib via 3f3783c s4-replace: make libreplace a private shared lib in s4 via eb0005d s4-tdb: make tdb-wrap into a private library via 045e344 s4-auth: make KERBEROS subsystem into authkrb5 private library via 7a26bb9 s4-credentials: make a private library from CREDENTIALS subsystem via 306754f s4-ldb: add explicit depenencies on ldb library in ldb modules via 04574d5 s4-ldbwrap: split ldb-wrap out from the LDBSAMBA subsystem via 228803c zlib: use the real library name 'z' instead of ZLIB via 0563c5b s4-rpc: split the dcesrv reply code out of dcerpc_server via ac8e910 s4-modules: remove LD_SAMBA_MODULE_PATH via 256349d s4-torture: simplify the depenencies for TORTURE_DRS via a57e0ae s4-smbd: make our process models into real modules via 046d38f s4-smbd: don't initialise process models more than once via 3a78148 waf: save the samba_deps_extended via f7b70a5 waf: give a better error on a bad grouping library via 78d732c waf: cope with subsystems with no static modules via ae0f420 waf: don't auto-depend on subsystems via adabc3d waf: added --symbol-check option via df34bb2 waf: build all libraries after all object files via 170c255 waf: use Utils.WafError() instead of raising an AssertionError via d1e9498 waf: cope with rules with no inputs via ccbb776 waf: separate out get_tgt_list() via e97be08 waf: display the paths in library loops via d489880 waf: added env.DEVELOPER_MODE flag via 65743f9 waf: added suncc_wrap via b6b0d2c s4-kdc: create a 'pac' private grouping library via 89c829f s4-heimdal: removed the use of signal.c from roken via 4bd7814 s4-heimdal: fixed the use of error_message() in heimdal via d6299d2 replace: create a private replace-test library via 0d45d97 s4-ldb: create a private library ldb-cmdline from 56b46d8 talloc: Fix manual pages in standalone build. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b4ba669e48f7dd213d530a24f4587dea93c84223 Author: Andrew Tridgell tri...@samba.org Date: Sat Oct 30 23:42:27 2010 +1100 s4-smbd: initialise process models in smbtorture before use the spoolss notify test needs to setup the process models before use Autobuild-User: Andrew Tridgell tri...@samba.org Autobuild-Date: Sat Oct 30 13:32:09 UTC 2010 on sn-devel-104 commit 35d466e66b464cefca2e33fa8e1ff7301b029690 Author: Andrew Tridgell tri...@samba.org Date: Sat Oct 30 21:44:17 2010 +1100 s4-smbd: leave the single process model as internal This helps with the static smbtorture for samba3, and the spoolss tests which start a server commit 55063cddd574ecca6a51b20a10fa979d55d6b70a Author: Andrew Tridgell tri...@samba.org Date: Sat Oct 30 16:37:27 2010 +1100 waf: fixed building of non-shared binaries that contain modules we need to incorporate the module objects too commit b2a565488ef0b2aad7401a0a2c61dd5853038a28 Author: Andrew Tridgell tri...@samba.org Date: Sat Oct 30 15:47:21 2010 +1100 s4-heimdal: lex_err_message() should not be static commit a139628423e0a48c1a63321ee054734673f03c9e Author: Andrew Tridgell tri...@samba.org Date: Sat Oct 30 15:47:03 2010 +1100 s4-waf: added a lexyacc.sh script that manually rebuilds the heimdal parsers we so rarely need to rebuild these that it is simplest to just run lexyacc.sh when we import a new heimdal release commit a00657db758ba2a1bdc26f27024d72b8c7a1f114 Author: Andrew Tridgell tri...@samba.org Date: Sat Oct 30 15:09:30 2010 +1100 s4-test: don't override modules dir it is set correctly during the build commit e08c9ac696776cbd0bcd13b08409c709a18680e2 Author: Andrew Tridgell tri...@samba.org Date: Sat Oct 30 14:33:06 2010 +1100 waf: get rid of target aliases in wafsamba these aliases are no longer needed, and can cause a lot of
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 23b5880 talloc.3: Remove documentation for deprecated talloc_append_string, consistent with other deprecated functionality. from b4ba669 s4-smbd: initialise process models in smbtorture before use http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 23b58804ba8ab2bb190758df283eacf3ec5d8787 Author: Jelmer Vernooij jel...@samba.org Date: Sat Oct 30 15:42:41 2010 +0200 talloc.3: Remove documentation for deprecated talloc_append_string, consistent with other deprecated functionality. --- Summary of changes: lib/talloc/talloc.3.xml | 11 --- 1 files changed, 0 insertions(+), 11 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/talloc/talloc.3.xml b/lib/talloc/talloc.3.xml index 1d5476b..a327922 100644 --- a/lib/talloc/talloc.3.xml +++ b/lib/talloc/talloc.3.xml @@ -645,17 +645,6 @@ if (ptr) memcpy(ptr, p, strlen(p)+1);/programlisting /para programlistingtalloc_set_name_const(ptr, ptr)/programlisting /refsect2 -refsect2titlechar *talloc_append_string(const void *emphasis role=italict/emphasis, char *emphasis role=italicorig/emphasis, const char *emphasis role=italicappend/emphasis);/title -para - The talloc_append_string() function appends the given formatted - string to the given string. -/para -para - This function sets the name of the new pointer to the new - string. This is equivalent to: -/para -programlistingtalloc_set_name_const(ptr, ptr)/programlisting -/refsect2 refsect2titlechar *talloc_vasprintf(const void *emphasis role=italict/emphasis, const char *emphasis role=italicfmt/emphasis, va_list emphasis role=italicap/emphasis);/title para The talloc_vasprintf() function is the talloc equivalent of the C -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via dce provision: when deriving netbiosname from hostname force the netbiosname to be compliant via edebb76 build: strip -single_module when doing bundle on mac OS X via 33b276c build: set shared libraries flags correctly on mac os X from 23b5880 talloc.3: Remove documentation for deprecated talloc_append_string, consistent with other deprecated functionality. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit dce1a8f5233608d5bf59730200af3e041ce5 Author: Matthieu Patou m...@matws.net Date: Thu Oct 28 13:09:51 2010 +0400 provision: when deriving netbiosname from hostname force the netbiosname to be compliant It means no space/_/-/@ and less than 16 chars. Autobuild-User: Matthieu Patou m...@samba.org Autobuild-Date: Sat Oct 30 14:26:22 UTC 2010 on sn-devel-104 commit edebb76a616c40565383363bc240c0df50a850f3 Author: Matthieu Patou m...@matws.net Date: Sat Oct 30 16:51:20 2010 +0400 build: strip -single_module when doing bundle on mac OS X commit 33b276c2f16c4ec70cf392e850558cfd6703d7e6 Author: Matthieu Patou m...@matws.net Date: Sat Oct 30 16:50:33 2010 +0400 build: set shared libraries flags correctly on mac os X --- Summary of changes: buildtools/wafsamba/samba_conftests.py | 21 + buildtools/wafsamba/wafsamba.py | 12 buildtools/wafsamba/wscript |2 -- source4/scripting/python/samba/provision.py | 16 +--- source4/wscript |5 + 5 files changed, 51 insertions(+), 5 deletions(-) Changeset truncated at 500 lines: diff --git a/buildtools/wafsamba/samba_conftests.py b/buildtools/wafsamba/samba_conftests.py index 8a57d20..49cd4ff 100644 --- a/buildtools/wafsamba/samba_conftests.py +++ b/buildtools/wafsamba/samba_conftests.py @@ -93,6 +93,27 @@ def find_config_dir(conf): conf.fatal('cannot use the configuration test folder %r' % dir) return dir +...@conf +def CHECK_SHLIB_W_PYTHON(conf, msg): +'''check if we need -undefined dynamic_lookup''' + +dir = find_config_dir(conf) + +env = conf.env + +snip = ''' +#include Python.h +#include crt_externs.h +#define environ (*_NSGetEnviron()) + +static PyObject *ldb_module = NULL; +int foo(int v) { +extern char **environ; +environ[0] = 1; +ldb_module = PyImport_ImportModule(ldb); +return v * 2; +}''' +return conf.check(features='cc cshlib',uselib='PYEMBED',fragment=snip,msg=msg) # this one is quite complex, and should probably be broken up # into several parts. I'd quite like to create a set of CHECK_COMPOUND() diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py index a9dfc40..35b39d3 100644 --- a/buildtools/wafsamba/wafsamba.py +++ b/buildtools/wafsamba/wafsamba.py @@ -972,3 +972,15 @@ def samba_display(self): Task.TaskBase.classes['Task'].old_display = Task.TaskBase.classes['Task'].display Task.TaskBase.classes['Task'].display = samba_display + + +...@after('apply_link') +...@feature('cshlib') +def apply_bundle_remove_dynamiclib_patch(self): +if self.env['MACBUNDLE'] or getattr(self,'mac_bundle',False): +if not getattr(self,'vnum',None): +try: +self.env['LINKFLAGS'].remove('-dynamiclib') +self.env['LINKFLAGS'].remove('-single_module') +except ValueError: +pass diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript index 49f1cf4..90aeb45 100644 --- a/buildtools/wafsamba/wscript +++ b/buildtools/wafsamba/wscript @@ -275,8 +275,6 @@ def configure(conf): else: conf.ADD_CFLAGS('-fPIC', testflags=True) -if sys.platform == 'darwin': -conf.ADD_LDFLAGS('-fno-common', testflags=True) conf.CHECK_INLINE() # check for pkgconfig diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py index 5205ba5..49ad5d7 100644 --- a/source4/scripting/python/samba/provision.py +++ b/source4/scripting/python/samba/provision.py @@ -443,6 +443,11 @@ def guess_names(lp=None, hostname=None, domain=None, dnsdomain=None, netbiosname = lp.get(netbios name) if netbiosname is None: netbiosname = hostname +# remove forbidden chars +for char in !#$%'()-...@^_{}~: +netbiosname = .join(netbiosname.split(char)) +#force the length to be 16 +netbiosname = netbiosname[0:15] assert netbiosname is not None netbiosname = netbiosname.upper() if not valid_netbios_name(netbiosname): @@ -534,7 +539,14 @@ def make_smbconf(smbconf, setup_path, hostname, domain, realm, serverrole, assert smbconf is not None if hostname is None: hostname =
Invalid Netbios Names? Re: [SCM] Samba Shared Repository - branch master updated
Hi Matthieu, Author: Matthieu Patou m...@matws.net Date: Thu Oct 28 13:09:51 2010 +0400 provision: when deriving netbiosname from hostname force the netbiosname to be compliant It means no space/_/-/@ and less than 16 chars. What's wrong with '-'? It's allowed in netbios and dns names. See http://support.microsoft.com/kb/909264 metze signature.asc Description: OpenPGP digital signature
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 1620697 s4:local_password LDB module - fix typos via 2c0a9e9 s4:resolve_oids LDB module - fix counter types via 45ee4e9 s4:partition_init LDB module - fix counter type via 5ab8e4f s4:extended_dn_store LDB module - fix counter types from dce provision: when deriving netbiosname from hostname force the netbiosname to be compliant http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 16206974e6557e71cd0e3595c3fe0538bfef956d Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 16:58:34 2010 +0200 s4:local_password LDB module - fix typos Autobuild-User: Matthias Dieter Wallnöfer m...@samba.org Autobuild-Date: Sat Oct 30 15:41:46 UTC 2010 on sn-devel-104 commit 2c0a9e9f2118d36c7d8af5caa72346581c2197c1 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 16:46:13 2010 +0200 s4:resolve_oids LDB module - fix counter types commit 45ee4e9a6b3847dc54b3c6bec8b4ebccbbac93da Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 16:41:52 2010 +0200 s4:partition_init LDB module - fix counter type commit 5ab8e4f7e190c40f3da675c295e2580c92a86d39 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 16:35:12 2010 +0200 s4:extended_dn_store LDB module - fix counter types --- Summary of changes: source4/dsdb/samdb/ldb_modules/extended_dn_store.c |4 ++-- source4/dsdb/samdb/ldb_modules/local_password.c| 12 ++-- source4/dsdb/samdb/ldb_modules/partition_init.c|6 -- source4/dsdb/samdb/ldb_modules/resolve_oids.c |4 ++-- 4 files changed, 14 insertions(+), 12 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/samdb/ldb_modules/extended_dn_store.c b/source4/dsdb/samdb/ldb_modules/extended_dn_store.c index fafe511..7338944 100644 --- a/source4/dsdb/samdb/ldb_modules/extended_dn_store.c +++ b/source4/dsdb/samdb/ldb_modules/extended_dn_store.c @@ -298,7 +298,7 @@ static int extended_dn_add(struct ldb_module *module, struct ldb_request *req) { struct extended_dn_context *ac; int ret; - int i, j; + unsigned int i, j; if (ldb_dn_is_special(req-op.add.message-dn)) { /* do not manipulate our control entries */ @@ -371,7 +371,7 @@ static int extended_dn_modify(struct ldb_module *module, struct ldb_request *req /* Determine the effect of the modification */ /* Apply the modify to the linked entry */ - int i, j; + unsigned int i, j; struct extended_dn_context *ac; int ret; diff --git a/source4/dsdb/samdb/ldb_modules/local_password.c b/source4/dsdb/samdb/ldb_modules/local_password.c index 359a3d0..1a7b19d 100644 --- a/source4/dsdb/samdb/ldb_modules/local_password.c +++ b/source4/dsdb/samdb/ldb_modules/local_password.c @@ -301,7 +301,7 @@ static int lpdb_add_callback(struct ldb_request *req, * MODIFY / -static int lpdb_modify_callabck(struct ldb_request *req, +static int lpdb_modify_callback(struct ldb_request *req, struct ldb_reply *ares); static int lpdb_mod_search_callback(struct ldb_request *req, struct ldb_reply *ares); @@ -369,7 +369,7 @@ static int local_password_modify(struct ldb_module *module, struct ldb_request * ret = ldb_build_mod_req(remote_req, ldb, ac, remote_message, req-controls, - ac, lpdb_modify_callabck, + ac, lpdb_modify_callback, req); LDB_REQ_SET_LOCATION(remote_req); if (ret != LDB_SUCCESS) { @@ -381,7 +381,7 @@ static int local_password_modify(struct ldb_module *module, struct ldb_request * /* On a modify, we don't have the objectGUID handy, so we need to * search our DN for it */ -static int lpdb_modify_callabck(struct ldb_request *req, +static int lpdb_modify_callback(struct ldb_request *req, struct ldb_reply *ares) { struct ldb_context *ldb; @@ -546,7 +546,7 @@ static int lpdb_mod_search_callback(struct ldb_request *req, * DELETE / -static int lpdb_delete_callabck(struct ldb_request *req, +static int lpdb_delete_callback(struct ldb_request *req, struct ldb_reply *ares); static int lpdb_del_search_callback(struct ldb_request *req, struct ldb_reply *ares); @@ -583,7 +583,7 @@ static int local_password_delete(struct ldb_module *module, ret = ldb_build_del_req(remote_req, ldb, ac,
Re: Invalid Netbios Names? Re: [SCM] Samba Shared Repository - branch master updated
Hi Metze Date: Thu Oct 28 13:09:51 2010 +0400 provision: when deriving netbiosname from hostname force the netbiosname to be compliant It means no space/_/-/@ and less than 16 chars. What's wrong with '-'? It's allowed in netbios and dns names. See http://support.microsoft.com/kb/909264 Well the test that check if it's a valid netbiosname checks for the absence of '-': def valid_netbios_name(name): Check whether a name is valid as a NetBIOS name. # See crh's book (1.4.1.1) if len(name) 15: return False for x in name: if not x.isalnum() and not x in !#$%'()-...@^_{}~: return False return True So I guess this function is wrong. Because I made my function based on this test ... -- Matthieu Patou Samba Teamhttp://samba.org Private repo http://git.samba.org/?p=mat/samba.git;a=summary
Re: Invalid Netbios Names? Re: [SCM] Samba Shared Repository - branch master updated
On Sat, 2010-10-30 at 20:04 +0400, Matthieu Patou wrote: Hi Metze Date: Thu Oct 28 13:09:51 2010 +0400 provision: when deriving netbiosname from hostname force the netbiosname to be compliant It means no space/_/-/@ and less than 16 chars. What's wrong with '-'? It's allowed in netbios and dns names. See http://support.microsoft.com/kb/909264 Well the test that check if it's a valid netbiosname checks for the absence of '-': def valid_netbios_name(name): Check whether a name is valid as a NetBIOS name. # See crh's book (1.4.1.1) if len(name) 15: return False for x in name: if not x.isalnum() and not x in !#$%'()-...@^_{}~: return False return True So I guess this function is wrong. Because I made my function based on this test ... That function does allow -, it will return false if there are characters that are not in that list. - is part of the list. Cheers, Jelmer signature.asc Description: This is a digitally signed message part
Re: Invalid Netbios Names? Re: [SCM] Samba Shared Repository - branch master updated
def valid_netbios_name(name): Check whether a name is valid as a NetBIOS name. # See crh's book (1.4.1.1) if len(name) 15: return False for x in name: if not x.isalnum() and not x in !#$%'()-...@^_{}~: return False return True So I guess this function is wrong. Because I made my function based on this test ... That function does allow -, it will return false if there are characters that are not in that list. - is part of the list. Sorry my fault next time I'll learn how to read :-) Will fix it soon. -- Matthieu Patou Samba Teamhttp://samba.org Private repo http://git.samba.org/?p=mat/samba.git;a=summary
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 4dee76f replace: Fix formatting. via 7fc0aab ldb: Drop autoconf-based build system. via fe6d404 tevent: Drop autoconf-based build system for standalone build. via d1eba07 replace: Avoid autoproto as it breaks standalone builds. via 58e99ae replace: Only build replace-test in standalone build. from 1620697 s4:local_password LDB module - fix typos http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 4dee76f1cd1364718ba385121c00b8b8eb1c917e Author: Jelmer Vernooij jel...@samba.org Date: Sat Oct 30 17:43:48 2010 +0200 replace: Fix formatting. Autobuild-User: Jelmer Vernooij jel...@samba.org Autobuild-Date: Sat Oct 30 16:32:15 UTC 2010 on sn-devel-104 commit 7fc0aaba4b7383973bbc2e80addea11658d48fbf Author: Jelmer Vernooij jel...@samba.org Date: Sat Oct 30 16:17:58 2010 +0200 ldb: Drop autoconf-based build system. commit fe6d404ea506e492c0a29715ed1e88ebe044e875 Author: Jelmer Vernooij jel...@samba.org Date: Sat Oct 30 16:16:33 2010 +0200 tevent: Drop autoconf-based build system for standalone build. commit d1eba07e54d20ec9222f1ee448cc4223b9341c70 Author: Jelmer Vernooij jel...@samba.org Date: Sat Oct 30 16:01:00 2010 +0200 replace: Avoid autoproto as it breaks standalone builds. Automatic prototype generation uses ../../source4/script/mkproto.pl. Signed-off-by: Jelmer Vernooij jel...@samba.org commit 58e99ae9169df39b383f711c91e0c0f76b954b33 Author: Jelmer Vernooij jel...@samba.org Date: Sat Oct 30 15:59:14 2010 +0200 replace: Only build replace-test in standalone build. This allows turning libreplace-test back into a subsystem. --- Summary of changes: lib/replace/replace-test.h | 10 + lib/replace/wscript | 35 +- lib/tevent/Makefile.in | 79 -- lib/tevent/autogen-autotools.sh | 14 - lib/tevent/build_macros.m4 | 15 - lib/tevent/config.guess | 1561 --- lib/tevent/config.sub| 1686 -- lib/tevent/configure.ac | 25 - lib/tevent/install-sh| 238 - lib/tevent/libtalloc.m4 |7 - lib/tevent/pkg.m4| 156 lib/tevent/rules.mk | 18 - lib/tevent/samba.m4 | 11 - lib/tevent/tevent.exports| 62 -- lib/tevent/tevent.mk | 46 - source4/lib/ldb/Makefile.in | 187 source4/lib/ldb/aclocal.m4 |1 - source4/lib/ldb/autogen-autotools.sh | 18 - source4/lib/ldb/build_macros.m4 | 15 - source4/lib/ldb/config.guess | 1561 --- source4/lib/ldb/config.mk| 152 --- source4/lib/ldb/config.sub | 1686 -- source4/lib/ldb/configure.ac | 102 -- source4/lib/ldb/install-sh | 238 - source4/lib/ldb/ldap.m4 | 90 -- source4/lib/ldb/ldb.mk | 81 -- source4/lib/ldb/libldb.m4|7 - source4/lib/ldb/python.mk|6 - source4/lib/ldb/rules.mk | 26 - source4/lib/ldb/sqlite3.m4 | 62 -- source4/lib/ldb/standalone.sh| 28 - 31 files changed, 28 insertions(+), 8195 deletions(-) create mode 100644 lib/replace/replace-test.h delete mode 100644 lib/tevent/Makefile.in delete mode 100755 lib/tevent/autogen-autotools.sh delete mode 100644 lib/tevent/build_macros.m4 delete mode 100755 lib/tevent/config.guess delete mode 100755 lib/tevent/config.sub delete mode 100644 lib/tevent/configure.ac delete mode 100755 lib/tevent/install-sh delete mode 100644 lib/tevent/libtalloc.m4 delete mode 100644 lib/tevent/pkg.m4 delete mode 100644 lib/tevent/rules.mk delete mode 100644 lib/tevent/samba.m4 delete mode 100644 lib/tevent/tevent.exports delete mode 100644 lib/tevent/tevent.mk delete mode 100644 source4/lib/ldb/Makefile.in delete mode 100644 source4/lib/ldb/aclocal.m4 delete mode 100755 source4/lib/ldb/autogen-autotools.sh delete mode 100644 source4/lib/ldb/build_macros.m4 delete mode 100755 source4/lib/ldb/config.guess delete mode 100644 source4/lib/ldb/config.mk delete mode 100755 source4/lib/ldb/config.sub delete mode 100644 source4/lib/ldb/configure.ac delete mode 100755 source4/lib/ldb/install-sh delete mode 100644 source4/lib/ldb/ldap.m4 delete mode 100644 source4/lib/ldb/ldb.mk delete mode 100644 source4/lib/ldb/libldb.m4 delete mode 100644 source4/lib/ldb/python.mk delete mode 100644 source4/lib/ldb/rules.mk delete mode 100644 source4/lib/ldb/sqlite3.m4 delete mode 100755 source4/lib/ldb/standalone.sh Changeset truncated at 500 lines: diff --git
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b548674 provision: fix wrong tests via a509b93 build: Remove zlib from the cache if we failed to pass all the tests via 4e30a5d build: make this test darwin only as it mess a bit more the freebsd build from 4dee76f replace: Fix formatting. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b548674c29aa04594e70599d9021182f9a69d753 Author: Matthieu Patou m...@matws.net Date: Sat Oct 30 20:42:50 2010 +0400 provision: fix wrong tests Autobuild-User: Matthieu Patou m...@samba.org Autobuild-Date: Sat Oct 30 17:31:23 UTC 2010 on sn-devel-104 commit a509b93518b17309f401a6fd107c726c7ab7582f Author: Matthieu Patou m...@matws.net Date: Sat Oct 30 20:47:45 2010 +0400 build: Remove zlib from the cache if we failed to pass all the tests This will avoid problems with redefinition of libs tests commit 4e30a5dd0b3ca2b56d228730ad4d43f1986f39fa Author: Matthieu Patou m...@matws.net Date: Sat Oct 30 20:22:22 2010 +0400 build: make this test darwin only as it mess a bit more the freebsd build --- Summary of changes: lib/zlib/wscript|6 ++ source4/scripting/python/samba/provision.py | 17 +++-- source4/wscript |2 +- 3 files changed, 18 insertions(+), 7 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/zlib/wscript b/lib/zlib/wscript index bc6de34..a091de6 100644 --- a/lib/zlib/wscript +++ b/lib/zlib/wscript @@ -15,6 +15,12 @@ def configure(conf): msg='Checking for ZLIB_VERNUM = 0x1230', define='HAVE_ZLIB') +# If we don't do this then we will receive an error that lib 'z' +# is already declared as a system lib (for the cases where zlibVersion +# is defined +if not conf.env['HAVE_ZLIB']: +conf.LOCAL_CACHE_SET('TARGET_TYPE', 'z', 'EMPTY') + def build(bld): if not bld.CONFIG_SET('HAVE_ZLIB'): bld.SAMBA_LIBRARY('z', diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py index 49ad5d7..319b63d 100644 --- a/source4/scripting/python/samba/provision.py +++ b/source4/scripting/python/samba/provision.py @@ -61,6 +61,7 @@ import samba.registry from samba.schema import Schema from samba.samdb import SamDB +VALID_NETBIOS_CHARS = !#$%'()-...@^_{}~ __docformat__ = restructuredText DEFAULT_POLICY_GUID = 31B2F340-016D-11D2-945F-00C04FB984F9 DEFAULT_DC_POLICY_GUID = 6AC1786C-016F-11D2-945F-00C04fB984F9 @@ -444,10 +445,12 @@ def guess_names(lp=None, hostname=None, domain=None, dnsdomain=None, if netbiosname is None: netbiosname = hostname # remove forbidden chars -for char in !#$%'()-...@^_{}~: -netbiosname = .join(netbiosname.split(char)) +newnbname = +for x in netbiosname: +if x.isalnum() or x in VALID_NETBIOS_CHARS: +newnbname = %s%c % (newnbname, x) #force the length to be 16 -netbiosname = netbiosname[0:15] +netbiosname = newnbname[0:15] assert netbiosname is not None netbiosname = netbiosname.upper() if not valid_netbios_name(netbiosname): @@ -541,10 +544,12 @@ def make_smbconf(smbconf, setup_path, hostname, domain, realm, serverrole, hostname = socket.gethostname().split(.)[0] netbiosname = hostname.upper() # remove forbidden chars -for char in !#$%'()-...@^_{}~: -netbiosname = .join(netbiosname.split(char)) +newnbname = +for x in netbiosname: +if x.isalnum() or x in VALID_NETBIOS_CHARS: +newnbname = %s%c % (newnbname, x) #force the length to be 16 -netbiosname = netbiosname[0:15] +netbiosname = newnbname[0:15] else: netbiosname = hostname.upper() diff --git a/source4/wscript b/source4/wscript index 333079d..cbc0bf4 100644 --- a/source4/wscript +++ b/source4/wscript @@ -86,7 +86,7 @@ def configure(conf): conf.check_python_version((2,4,2)) conf.check_python_headers(mandatory=True) -if not conf.env['HAVE_ENVIRON_DECL']: +if sys.platform == 'darwin' and not conf.env['HAVE_ENVIRON_DECL']: if not conf.CHECK_SHLIB_W_PYTHON(Checking if -single_module is not needed): conf.env.append_value('shlib_LINKFLAGS', ['-single_module']) if not conf.CHECK_SHLIB_W_PYTHON(Checking if -undefined dynamic_lookup is not need): -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via c0ebf5d s4:sam.py - add a short double swap primaryGroupID test via 98fefa8 s4:samldb LDB module - adapt the samldb_prim_group_change trigger to support multiple primaryGroupID modification entries via 02355fc s4:samr RPC server - the LDB error codes for adding or deleting a group member have changed via c664f01 s4:sam.py - enhance member tests via 4987467 s4:samldb LDB module - member trigger via 5a2c3ad s4:rpc_server/common.h - quiet compilation warnings from b548674 provision: fix wrong tests http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit c0ebf5d7435c3c4968eefafc6c566dc818e600a0 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 17:48:51 2010 +0200 s4:sam.py - add a short double swap primaryGroupID test It's not really meaningful but can happen. Autobuild-User: Matthias Dieter Wallnöfer m...@samba.org Autobuild-Date: Sat Oct 30 18:15:31 UTC 2010 on sn-devel-104 commit 98fefa8a017bbb67f6c33080c8a80c77c34e42b8 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 17:43:17 2010 +0200 s4:samldb LDB module - adapt the samldb_prim_group_change trigger to support multiple primaryGroupID modification entries commit 02355fc6fd176312b61198e626cfe1fbb1ed5ac5 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 18:32:43 2010 +0200 s4:samr RPC server - the LDB error codes for adding or deleting a group member have changed commit c664f010d387af483dce41816d5d222bd8d84f46 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 18:09:12 2010 +0200 s4:sam.py - enhance member tests commit 4987467b785a5870cb338881c8916b4268006cd6 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 17:12:48 2010 +0200 s4:samldb LDB module - member trigger - adapt the samldb_member_check trigger to support multiple member modification entries. There can exist special modification messages which delete and add members in one operation - support the right error codes when modifications do fail (ERR_ENTRY_ALREADY_EXISTS, ERR_UNWILLING_TO_PERFORM) commit 5a2c3ad2fa198b260bd8f0934fad0e3113c9f670 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 17:55:56 2010 +0200 s4:rpc_server/common.h - quiet compilation warnings --- Summary of changes: source4/dsdb/samdb/ldb_modules/samldb.c | 172 ++- source4/dsdb/tests/python/sam.py| 44 source4/rpc_server/common/common.h |2 + source4/rpc_server/samr/dcesrv_samr.c |6 +- 4 files changed, 172 insertions(+), 52 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c b/source4/dsdb/samdb/ldb_modules/samldb.c index 924c05e..44c8fee 100644 --- a/source4/dsdb/samdb/ldb_modules/samldb.c +++ b/source4/dsdb/samdb/ldb_modules/samldb.c @@ -1002,8 +1002,41 @@ static int samldb_prim_group_change(struct samldb_ctx *ac) uint32_t rid; struct dom_sid *sid; struct ldb_dn *prev_prim_group_dn, *new_prim_group_dn; + unsigned int i; int ret; + /* We've to walk over all modification entries and consider the +* primaryGroupID ones. +* +* 1.) Add operations aren't allowed and there is returned +* ATTRIBUTE_OR_VALUE_EXISTS. +* 2.) Replace operations are allowed but the last one is taken +* 3.) Delete operations are also not allowed and there is returned +* UNWILLING_TO_PERFORM. +* +* If el is afterwards NULL then that means we've nothing to do here. +*/ + el = NULL; + for (i = 0; i ac-msg-num_elements; i++) { + if (ldb_attr_cmp(ac-msg-elements[i].name, +primaryGroupID) != 0) { + continue; + } + + el = ac-msg-elements[i]; + if (LDB_FLAG_MOD_TYPE(el-flags) == LDB_FLAG_MOD_ADD) { + return LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS; + } + if (LDB_FLAG_MOD_TYPE(el-flags) == LDB_FLAG_MOD_DELETE) { + return LDB_ERR_UNWILLING_TO_PERFORM; + } + } + if (el == NULL) { + return LDB_SUCCESS; + } + + /* Okay, now for sure we are performing a primaryGroupID replace */ + /* Fetch informations from the existing object */ ret = ldb_search(ldb, ac, res, ac-msg-dn, LDB_SCOPE_BASE, attrs, @@ -1033,9 +1066,20 @@ static int samldb_prim_group_change(struct samldb_ctx *ac) return ldb_operr(ldb); } - /* Finds out the DN of the new primary group */ + /* Finds out the DN of the new
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 9401189 s4:samldb LDB module - make the userAccountControl and groupType modify handlers separate functions via 098ea71 s4:samldb LDB module - add a new function which handles special cases for single-valued attribute on SAM modifications via 095c8b2 s4:samldb LDB module - primary group change - free temporary messages to save memory from c0ebf5d s4:sam.py - add a short double swap primaryGroupID test http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 9401189d5435632bcc6a177845ce03beaa804113 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 19:56:54 2010 +0200 s4:samldb LDB module - make the userAccountControl and groupType modify handlers separate functions It's easier to maintain afterwards Autobuild-User: Matthias Dieter Wallnöfer m...@samba.org Autobuild-Date: Sat Oct 30 19:07:20 UTC 2010 on sn-devel-104 commit 098ea71728eb6389ff4c5314d17df533f79a07a8 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 19:37:30 2010 +0200 s4:samldb LDB module - add a new function which handles special cases for single-valued attribute on SAM modifications This saves quiet some work. commit 095c8b2078128838f6b830613e80cbdcf49e10cf Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Oct 30 19:56:24 2010 +0200 s4:samldb LDB module - primary group change - free temporary messages to save memory --- Summary of changes: source4/dsdb/samdb/ldb_modules/samldb.c | 380 ++ 1 files changed, 228 insertions(+), 152 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c b/source4/dsdb/samdb/ldb_modules/samldb.c index 44c8fee..9b6d6e0 100644 --- a/source4/dsdb/samdb/ldb_modules/samldb.c +++ b/source4/dsdb/samdb/ldb_modules/samldb.c @@ -751,6 +751,53 @@ static int samldb_schema_info_update(struct samldb_ctx *ac) } /* + * Gets back a single-valued attribute by the rules of the SAM triggers when + * performing a modify operation + */ +static int samldb_get_single_valued_attr(struct samldb_ctx *ac, +const char *attr_name, +struct ldb_message_element **attr) +{ + struct ldb_context *ldb = ldb_module_get_ctx(ac-module); + struct ldb_message_element *el = NULL; + unsigned int i; + + /* We've to walk over all modification entries and consider the +* attr_name ones. +* +* 1.) Add operations aren't allowed and there is returned +* ATTRIBUTE_OR_VALUE_EXISTS. +* 2.) Replace operations are allowed but the last one is taken +* 3.) Delete operations are also not allowed and there is returned +* UNWILLING_TO_PERFORM. +* +* If el is afterwards NULL then that means we've nothing to do here. +*/ + for (i = 0; i ac-msg-num_elements; i++) { + if (ldb_attr_cmp(ac-msg-elements[i].name, attr_name) != 0) { + continue; + } + + el = ac-msg-elements[i]; + if (LDB_FLAG_MOD_TYPE(el-flags) == LDB_FLAG_MOD_ADD) { + ldb_asprintf_errstring(ldb, + samldb: attribute '%s' already exists!, + attr_name); + return LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS; + } + if (LDB_FLAG_MOD_TYPE(el-flags) == LDB_FLAG_MOD_DELETE) { + ldb_asprintf_errstring(ldb, + samldb: attribute '%s' cannot be deleted!, + attr_name); + return LDB_ERR_UNWILLING_TO_PERFORM; + } + } + + *attr = el; + return LDB_SUCCESS; +} + +/* * Objectclass trigger (MS-SAMR 3.1.1.8.1) * * Has to be invoked on add and modify operations on user, computer and @@ -1002,41 +1049,17 @@ static int samldb_prim_group_change(struct samldb_ctx *ac) uint32_t rid; struct dom_sid *sid; struct ldb_dn *prev_prim_group_dn, *new_prim_group_dn; - unsigned int i; int ret; - /* We've to walk over all modification entries and consider the -* primaryGroupID ones. -* -* 1.) Add operations aren't allowed and there is returned -* ATTRIBUTE_OR_VALUE_EXISTS. -* 2.) Replace operations are allowed but the last one is taken -* 3.) Delete operations are also not allowed and there is returned -* UNWILLING_TO_PERFORM. -* -* If el is afterwards NULL then that means we've nothing to do here. -*/ - el = NULL; -
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 3deece5 s4: Remove the old perl/m4/make/mk-based build system. from 9401189 s4:samldb LDB module - make the userAccountControl and groupType modify handlers separate functions http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 3deece559159150a0710d8160f39583ba7f2e582 Author: Jelmer Vernooij jel...@samba.org Date: Sun Oct 31 02:17:29 2010 +0100 s4: Remove the old perl/m4/make/mk-based build system. The new waf-based build system now has all the same functionality, and the old build system has been broken for quite some time. Autobuild-User: Jelmer Vernooij jel...@samba.org Autobuild-Date: Sun Oct 31 02:01:44 UTC 2010 on sn-devel-104 --- Summary of changes: lib/async_req/config.mk |4 - lib/crypto/config.mk | 18 - lib/nss_wrapper/config.mk |7 - lib/popt/config.mk|5 - lib/smbconf/config.mk |3 - lib/socket_wrapper/config.mk |8 - lib/talloc/config.mk |7 - lib/tdb/config.mk | 66 -- lib/tdr/config.mk |9 - lib/torture/config.mk | 17 - lib/tsocket/config.mk | 13 - lib/uid_wrapper/config.mk |9 - lib/util/capability.m4| 17 - lib/util/charset/config.m4| 86 -- lib/util/charset/config.mk| 11 - lib/util/config.mk| 98 -- lib/util/fault.m4 | 18 - lib/util/fsusage.m4 | 200 lib/util/signal.m4|1 - lib/util/util.m4 |1 - lib/util/xattr.m4 | 32 - libcli/auth/config.mk | 26 - libcli/cldap/config.mk|7 - libcli/drsuapi/config.mk |6 - libcli/ldap/config.mk | 15 - libcli/named_pipe_auth/config.mk |4 - libcli/nbt/config.mk | 51 - libcli/samsync/config.mk |6 - libcli/security/config.mk |5 - libcli/smb/config.mk | 11 - libcli/smbreadline/readline.m4| 96 -- libgpo/config.mk |7 - nsswitch/config.m4| 46 - nsswitch/config.mk| 41 - nsswitch/libwbclient/config.mk| 10 - nsswitch/nsstest.m4 |8 - pidl/config.m4|9 - pidl/config.mk| 34 - source4/Makefile.in | 314 -- source4/aclocal.m4| 65 -- source4/auth/config.m4| 32 - source4/auth/config.mk| 51 - source4/auth/credentials/config.mk| 20 - source4/auth/gensec/config.m4 |2 - source4/auth/gensec/config.mk | 82 -- source4/auth/kerberos/config.m4 | 542 - source4/auth/kerberos/config.mk | 19 - source4/auth/ntlm/config.mk | 80 -- source4/auth/ntlmssp/config.mk| 13 - source4/autogen-autotools.sh | 85 -- source4/build/m4/ax_cflags_gcc_option.m4 | 109 -- source4/build/m4/ax_cflags_irix_option.m4 | 174 --- source4/build/m4/check_cc.m4 | 180 --- source4/build/m4/check_doc.m4 |1 - source4/build/m4/check_ld.m4 | 187 source4/build/m4/check_path.m4| 233 source4/build/m4/env.m4 | 90 -- source4/build/m4/public.m4| 282 - source4/build/make/lex_compile.sh | 60 - source4/build/make/python.mk | 51 - source4/build/make/rules.mk | 190 source4/build/make/templates.mk | 143 --- source4/build/make/yacc_compile.sh| 45 - source4/build/smb_build/README.txt| 83 -- source4/build/smb_build/TODO | 25 - source4/build/smb_build/config_mk.pm | 284 - source4/build/smb_build/dot.pl| 63 -- source4/build/smb_build/input.pm | 278 - source4/build/smb_build/main.pl | 105 -- source4/build/smb_build/makefile.pm | 281 - source4/build/smb_build/output.pm | 172 --- source4/build/smb_build/summary.pm| 87 -- source4/cldap_server/config.mk| 24 - source4/client/config.mk | 36 - source4/cluster/config.mk |4 - source4/config.guess | 1561 -- source4/config.sub|
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via f99c009 replace: Build using waf by default. via 4f22cc7 talloc: Switch over to using waf as the default build system for the standalone build. from 3deece5 s4: Remove the old perl/m4/make/mk-based build system. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit f99c009b61c9e8b5968a9b074546408ce93db73c Author: Jelmer Vernooij jel...@samba.org Date: Sun Oct 31 02:44:32 2010 +0100 replace: Build using waf by default. Autobuild-User: Jelmer Vernooij jel...@samba.org Autobuild-Date: Sun Oct 31 02:45:21 UTC 2010 on sn-devel-104 commit 4f22cc7a283d21000e8ffa0c39746aa9f824f49e Author: Jelmer Vernooij jel...@samba.org Date: Sun Oct 31 02:31:59 2010 +0100 talloc: Switch over to using waf as the default build system for the standalone build. --- Summary of changes: .gitignore |2 -- .../scripts/Makefile.waf = lib/replace/Makefile |8 +--- lib/replace/{autogen.sh = autogen-autotools.sh} |0 lib/replace/autogen-waf.sh | 12 +++- lib/replace/autogen.sh | 14 +- {source4 = lib/replace}/configure |2 +- .../scripts/Makefile.waf = lib/talloc/Makefile|8 +--- lib/talloc/{autogen.sh = autogen-autotools.sh}|0 lib/talloc/autogen-waf.sh | 12 +++- lib/talloc/autogen.sh | 15 +-- {source4 = lib/talloc}/configure |2 +- 11 files changed, 36 insertions(+), 39 deletions(-) copy buildtools/scripts/Makefile.waf = lib/replace/Makefile (75%) copy lib/replace/{autogen.sh = autogen-autotools.sh} (100%) mode change 12 = 100755 lib/replace/autogen-waf.sh mode change 100755 = 12 lib/replace/autogen.sh copy {source4 = lib/replace}/configure (88%) copy buildtools/scripts/Makefile.waf = lib/talloc/Makefile (75%) copy lib/talloc/{autogen.sh = autogen-autotools.sh} (100%) mode change 12 = 100755 lib/talloc/autogen-waf.sh mode change 100755 = 12 lib/talloc/autogen.sh copy {source4 = lib/talloc}/configure (88%) Changeset truncated at 500 lines: diff --git a/.gitignore b/.gitignore index 49b24a0..3c521a2 100644 --- a/.gitignore +++ b/.gitignore @@ -15,8 +15,6 @@ config.log config.status source3/configure source3/Makefile -lib/talloc/configure -lib/talloc/Makefile lib/tdb/configure lib/tdb/Makefile *.d diff --git a/buildtools/scripts/Makefile.waf b/lib/replace/Makefile similarity index 75% copy from buildtools/scripts/Makefile.waf copy to lib/replace/Makefile index c07f859..2cc2819 100644 --- a/buildtools/scripts/Makefile.waf +++ b/lib/replace/Makefile @@ -1,6 +1,8 @@ # simple makefile wrapper to run waf -WAF=WAF_MAKE=1 BUILDTOOLS/bin/waf +WAFPATH:=$(shell PATH=../../buildtools/bin:buildtools/bin:$(PATH) which waf) + +WAF=WAF_MAKE=1 $(WAFPATH) all: $(WAF) build @@ -60,8 +62,8 @@ bin/%:: FORCE $(WAF) --targets=`basename $...@` FORCE: -configure: autogen-waf.sh BUILDTOOLS/scripts/configure.waf +configure: autogen-waf.sh ../../buildtools/scripts/configure.waf ./autogen-waf.sh -Makefile: autogen-waf.sh configure BUILDTOOLS/scripts/Makefile.waf +Makefile: autogen-waf.sh configure ../../buildtools/scripts/Makefile.waf ./autogen-waf.sh diff --git a/lib/replace/autogen.sh b/lib/replace/autogen-autotools.sh similarity index 100% copy from lib/replace/autogen.sh copy to lib/replace/autogen-autotools.sh diff --git a/lib/replace/autogen-waf.sh b/lib/replace/autogen-waf.sh deleted file mode 12 index 99150f3..000 --- a/lib/replace/autogen-waf.sh +++ /dev/null @@ -1 +0,0 @@ -../../buildtools/scripts/autogen-waf.sh \ No newline at end of file diff --git a/lib/replace/autogen-waf.sh b/lib/replace/autogen-waf.sh new file mode 100755 index 000..ee95847 --- /dev/null +++ b/lib/replace/autogen-waf.sh @@ -0,0 +1,11 @@ +#!/bin/sh + +p=`dirname $0` + +echo Setting up for waf build + +echo done. Now run $p/configure or $p/configure.developer then make. +if [ $p != . ]; then + echo Notice: The build invoke path is not the main directory! Use make with the parameter + echo -C $p. Example: make -C $p all +fi diff --git a/lib/replace/autogen.sh b/lib/replace/autogen.sh deleted file mode 100755 index d46a427..000 --- a/lib/replace/autogen.sh +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/sh - -rm -rf autom4te.cache -rm -f configure config.h.in - -autoheader || exit 1 -autoconf || exit 1 - -rm -rf autom4te.cache - -echo Now run ./configure and then make. -exit 0 - diff --git a/lib/replace/autogen.sh b/lib/replace/autogen.sh new file mode 12 index 000..a229cc9 --- /dev/null +++ b/lib/replace/autogen.sh @@ -0,0 +1 @@ +autogen-waf.sh \ No newline at end of