Re: [Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
Michael Adam wrote: one more missing piece of information: please put the script update-pkginfo.sh into packaging/bin/ Thanks - Michael I applied the 3 patches from the bugzilla page that you and Karolin uploaded. Then I put the script in samba-3.2.7/packaging/bin and ran it: [r...@roark bin]# ./update-pkginfo.sh ~/samba-3.2.7/source ~/samba-3.2.7/packaging/bin ./script/mkversion.sh: 'include/version.h' created for Samba("3.2.7") ~/samba-3.2.7/packaging/bin VERSION: 3.2.7 and then ran makerpms.sh but still get the same error about mount.cifs not compiling. am I doing something wrong? -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
one more missing piece of information: please put the script update-pkginfo.sh into packaging/bin/ Thanks - Michael Michael Adam wrote: > my promised-attachement-problem again... :-) > > Michael Adam wrote: > > Hi Adam, > > > > in this case it is not sufficient to just apply the patches > > since the are applied to the template file. These are transformed > > to the proper files (samba.spec, makerpms.sh) by the script > > release-scripts/create-tarball. > > > > Since it is no good to call create-tarball from the unpacked > > tarball, I have attached a script for you that you should call > > from the base dir of the unpacked tarball and that will update > > the specfile and makerpms.sh for you. > > > > I think I am going to check this into relevant branches. > > > > Thanks for your feedback. > > > > Cheers - Michael > > > > Adam Williams wrote: > > > Karolin Seeger wrote: > > > >yes, three patches concerning RHEL packaging will be included. > > > >These patches fix the problem for me. Please report if it they don't work > > > >for you. > > > > > > > >Please find attached the patches. > > > > > > > >Karolin > > > > > > > Hi Karolin, thanks for the response. I apologize if I sounded rude in > > > my last message. I applied the patches as follows: > > > > > > [r...@roark samba-3.2.7]# patch > > > -p1<0001-packaging-RHEL-fix-build-of-u-mount.cifs.patch > > > (Stripping trailing CRs from patch.) > > > patching file packaging/RHEL/samba.spec.tmpl > > > [r...@roark samba-3.2.7]# patch > > > -p1<0001-packaging-RHEL-Fix-syntax-error-in-samba.spec.tmpl.patch > > > (Stripping trailing CRs from patch.) > > > patching file packaging/RHEL/samba.spec.tmpl > > > [r...@roark samba-3.2.7]# patch > > > -p1<0002-packaging-RHEL-fix-typo-in-u-mount.cifs-installat.patch > > > (Stripping trailing CRs from patch.) > > > patching file packaging/RHEL/samba.spec.tmpl > > > Hunk #1 succeeded at 244 (offset -1 lines). > > > > > > > > > but I still get the same error with makerpms.sh: > > > > > > > > > Linking shared library bin/libnetapi.so.0 > > > make: Nothing to be done for `pam_smbpass'. > > > Linking shared library bin/libsmbclient.so.0 > > > Linking bin/net > > > + cd client > > > + gcc -o mount.cifs -O2 -g -D_GNU_SOURCE -Wall -D_GNU_SOURCE > > > -D_LARGEFILE64_SOURCE mount.cifs.c > > > /tmp/ccXRkvaz.o: In function `main': > > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1415: > > > undefined reference to `unlock_mtab' > > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1416: > > > undefined reference to `lock_mtab' > > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1462: > > > undefined reference to `unlock_mtab' > > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1424: > > > undefined reference to `unlock_mtab' > > > collect2: ld returned 1 exit status > > > error: Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > > > > > > > > > RPM build errors: > > >Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > > > makerpms.sh: Done. > > > > -- > > Michael Adam > > SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen > > phone: +49-551-37-0, fax: +49-551-37-9 > > AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen > > http://www.SerNet.DE, mailto: Info @ SerNet.DE > > > > -- > > i.A. Michael Adam > > -- > Michael Adam > SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen > phone: +49-551-37-0, fax: +49-551-37-9 > AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen > http://www.SerNet.DE, mailto: Info @ SerNet.DE -- i.A. Michael Adam -- Michael Adam SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen http://www.SerNet.DE, mailto: Info @ SerNet.DE pgpjCTeOQ6BEF.pgp Description: PGP signature -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
my promised-attachement-problem again... :-) Michael Adam wrote: > Hi Adam, > > in this case it is not sufficient to just apply the patches > since the are applied to the template file. These are transformed > to the proper files (samba.spec, makerpms.sh) by the script > release-scripts/create-tarball. > > Since it is no good to call create-tarball from the unpacked > tarball, I have attached a script for you that you should call > from the base dir of the unpacked tarball and that will update > the specfile and makerpms.sh for you. > > I think I am going to check this into relevant branches. > > Thanks for your feedback. > > Cheers - Michael > > Adam Williams wrote: > > Karolin Seeger wrote: > > >yes, three patches concerning RHEL packaging will be included. > > >These patches fix the problem for me. Please report if it they don't work > > >for you. > > > > > >Please find attached the patches. > > > > > >Karolin > > > > > Hi Karolin, thanks for the response. I apologize if I sounded rude in > > my last message. I applied the patches as follows: > > > > [r...@roark samba-3.2.7]# patch > > -p1<0001-packaging-RHEL-fix-build-of-u-mount.cifs.patch > > (Stripping trailing CRs from patch.) > > patching file packaging/RHEL/samba.spec.tmpl > > [r...@roark samba-3.2.7]# patch > > -p1<0001-packaging-RHEL-Fix-syntax-error-in-samba.spec.tmpl.patch > > (Stripping trailing CRs from patch.) > > patching file packaging/RHEL/samba.spec.tmpl > > [r...@roark samba-3.2.7]# patch > > -p1<0002-packaging-RHEL-fix-typo-in-u-mount.cifs-installat.patch > > (Stripping trailing CRs from patch.) > > patching file packaging/RHEL/samba.spec.tmpl > > Hunk #1 succeeded at 244 (offset -1 lines). > > > > > > but I still get the same error with makerpms.sh: > > > > > > Linking shared library bin/libnetapi.so.0 > > make: Nothing to be done for `pam_smbpass'. > > Linking shared library bin/libsmbclient.so.0 > > Linking bin/net > > + cd client > > + gcc -o mount.cifs -O2 -g -D_GNU_SOURCE -Wall -D_GNU_SOURCE > > -D_LARGEFILE64_SOURCE mount.cifs.c > > /tmp/ccXRkvaz.o: In function `main': > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1415: > > undefined reference to `unlock_mtab' > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1416: > > undefined reference to `lock_mtab' > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1462: > > undefined reference to `unlock_mtab' > > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1424: > > undefined reference to `unlock_mtab' > > collect2: ld returned 1 exit status > > error: Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > > > > > > RPM build errors: > >Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > > makerpms.sh: Done. > > -- > Michael Adam > SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen > phone: +49-551-37-0, fax: +49-551-37-9 > AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen > http://www.SerNet.DE, mailto: Info @ SerNet.DE -- i.A. Michael Adam -- Michael Adam SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen http://www.SerNet.DE, mailto: Info @ SerNet.DE pgpzDvjHCMtOA.pgp Description: PGP signature -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
Hi Adam, in this case it is not sufficient to just apply the patches since the are applied to the template file. These are transformed to the proper files (samba.spec, makerpms.sh) by the script release-scripts/create-tarball. Since it is no good to call create-tarball from the unpacked tarball, I have attached a script for you that you should call from the base dir of the unpacked tarball and that will update the specfile and makerpms.sh for you. I think I am going to check this into relevant branches. Thanks for your feedback. Cheers - Michael Adam Williams wrote: > Karolin Seeger wrote: > >yes, three patches concerning RHEL packaging will be included. > >These patches fix the problem for me. Please report if it they don't work > >for you. > > > >Please find attached the patches. > > > >Karolin > > > Hi Karolin, thanks for the response. I apologize if I sounded rude in > my last message. I applied the patches as follows: > > [r...@roark samba-3.2.7]# patch > -p1<0001-packaging-RHEL-fix-build-of-u-mount.cifs.patch > (Stripping trailing CRs from patch.) > patching file packaging/RHEL/samba.spec.tmpl > [r...@roark samba-3.2.7]# patch > -p1<0001-packaging-RHEL-Fix-syntax-error-in-samba.spec.tmpl.patch > (Stripping trailing CRs from patch.) > patching file packaging/RHEL/samba.spec.tmpl > [r...@roark samba-3.2.7]# patch > -p1<0002-packaging-RHEL-fix-typo-in-u-mount.cifs-installat.patch > (Stripping trailing CRs from patch.) > patching file packaging/RHEL/samba.spec.tmpl > Hunk #1 succeeded at 244 (offset -1 lines). > > > but I still get the same error with makerpms.sh: > > > Linking shared library bin/libnetapi.so.0 > make: Nothing to be done for `pam_smbpass'. > Linking shared library bin/libsmbclient.so.0 > Linking bin/net > + cd client > + gcc -o mount.cifs -O2 -g -D_GNU_SOURCE -Wall -D_GNU_SOURCE > -D_LARGEFILE64_SOURCE mount.cifs.c > /tmp/ccXRkvaz.o: In function `main': > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1415: > undefined reference to `unlock_mtab' > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1416: > undefined reference to `lock_mtab' > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1462: > undefined reference to `unlock_mtab' > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1424: > undefined reference to `unlock_mtab' > collect2: ld returned 1 exit status > error: Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > > > RPM build errors: >Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > makerpms.sh: Done. -- Michael Adam SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen http://www.SerNet.DE, mailto: Info @ SerNet.DE pgpTzCPw7BZEu.pgp Description: PGP signature -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
Karolin Seeger wrote: yes, three patches concerning RHEL packaging will be included. These patches fix the problem for me. Please report if it they don't work for you. Please find attached the patches. Karolin Hi Karolin, thanks for the response. I apologize if I sounded rude in my last message. I applied the patches as follows: [r...@roark samba-3.2.7]# patch -p1<0001-packaging-RHEL-fix-build-of-u-mount.cifs.patch (Stripping trailing CRs from patch.) patching file packaging/RHEL/samba.spec.tmpl [r...@roark samba-3.2.7]# patch -p1<0001-packaging-RHEL-Fix-syntax-error-in-samba.spec.tmpl.patch (Stripping trailing CRs from patch.) patching file packaging/RHEL/samba.spec.tmpl [r...@roark samba-3.2.7]# patch -p1<0002-packaging-RHEL-fix-typo-in-u-mount.cifs-installat.patch (Stripping trailing CRs from patch.) patching file packaging/RHEL/samba.spec.tmpl Hunk #1 succeeded at 244 (offset -1 lines). but I still get the same error with makerpms.sh: Linking shared library bin/libnetapi.so.0 make: Nothing to be done for `pam_smbpass'. Linking shared library bin/libsmbclient.so.0 Linking bin/net + cd client + gcc -o mount.cifs -O2 -g -D_GNU_SOURCE -Wall -D_GNU_SOURCE -D_LARGEFILE64_SOURCE mount.cifs.c /tmp/ccXRkvaz.o: In function `main': /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1415: undefined reference to `unlock_mtab' /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1416: undefined reference to `lock_mtab' /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1462: undefined reference to `unlock_mtab' /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1424: undefined reference to `unlock_mtab' collect2: ld returned 1 exit status error: Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) makerpms.sh: Done. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
Hi Adam, On Tue, Jan 13, 2009 at 09:16:29AM -0600, Adam Williams wrote: > will the mount.cifs compile error on Fedora 10 i386 and x86_64 be fixed > when running packing/RHEL/makerpms.sh? I've submitted bug reports and got > a patch on 12/23/08 from you and reported that the patch didn't fix the > error and never got a reply. yes, three patches concerning RHEL packaging will be included. These patches fix the problem for me. Please report if it they don't work for you. Please find attached the patches. Karolin -- Samba http://www.samba.org SerNet http://www.sernet.de sambaXP http://www.sambaxp.org From c93a5131913a1a18645c4f972be6f6b2c1715f28 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Wed, 17 Dec 2008 18:56:34 +0100 Subject: [PATCH] packaging(RHEL): fix build of [u]mount.cifs mount.cifs is now built by make everything. And it needs extra objects anyways (mtab.o), which is why the build of mount.cifs failed. Michael (cherry picked from commit 96c811cf222be5463a6705feae73d6215685c5f1) Signed-off-by: Michael Adam (cherry picked from commit 308dbca653ce1d689b75f9b781237c67df4233a8) (cherry picked from commit 9745e36c011a76669aad7a0a861ba1520ef8cec3) (cherry picked from commit 1c1e196b648ae3ef241401f859842450c5153181) --- packaging/RHEL/samba.spec.tmpl | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/packaging/RHEL/samba.spec.tmpl b/packaging/RHEL/samba.spec.tmpl index 49a0109..1e43116 100644 --- a/packaging/RHEL/samba.spec.tmpl +++ b/packaging/RHEL/samba.spec.tmpl @@ -179,12 +179,6 @@ fi make CFLAGS="$RPM_OPT_FLAGS -D_GNU_SOURCE" %{?_smp_mflags} \ all modules pam_smbpass -## build the cifs fs mount helper -cd client -gcc -o mount.cifs $RPM_OPT_FLAGS -D_GNU_SOURCE -Wall -D_GNU_SOURCE -D_LARGEFILE64_SOURCE mount.cifs.c -gcc -o umount.cifs $RPM_OPT_FLAGS -D_GNU_SOURCE -Wall -D_GNU_SOURCE -D_LARGEFILE64_SOURCE umount.cifs.c -cd .. - # Remove some permission bits to avoid to many dependencies cd .. find examples docs -type f | xargs -r chmod -x @@ -251,8 +245,8 @@ install -m644 setup/samba.pamd $RPM_BUILD_ROOT%{_sysconfdir}/pam.d/samba install -m755 setup/smbprint $RPM_BUILD_ROOT%{_bindir} install -m644 setup/smbusers $RPM_BUILD_ROOT%{_sysconfdir}/samba/smbusers install -m644 setup/smb.conf $RPM_BUILD_ROOT%{_sysconfdir}/samba/smb.conf -install -m755 source/client/mount.cifs $RPM_BUILD_ROOT/sbin/mount.cifs -install -m755 source/client/umount.cifs $RPM_BUILD_ROOT/sbin/umount.cifs +install -m755 bin/mount.cifs $RPM_BUILD_ROOT/sbin/mount.cifs +install -m755 bin/umount.cifs $RPM_BUILD_ROOT/sbin/umount.cifs install -m755 source/script/mksmbpasswd.sh $RPM_BUILD_ROOT%{_bindir} /bin/rm $RPM_BUILD_ROOT%{_sbindir}/*mount.cifs -- 1.6.0.2 From 097e9d64ade609da9f920156c98b466dc6c42dab Mon Sep 17 00:00:00 2001 From: Karolin Seeger Date: Thu, 8 Jan 2009 13:10:59 +0100 Subject: [PATCH] packaging RHEL: Fix syntax error in samba.spec.tmpl. Karolin --- packaging/RHEL/samba.spec.tmpl |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/packaging/RHEL/samba.spec.tmpl b/packaging/RHEL/samba.spec.tmpl index a93b5d9..e0e772c 100644 --- a/packaging/RHEL/samba.spec.tmpl +++ b/packaging/RHEL/samba.spec.tmpl @@ -222,8 +222,7 @@ install -m 755 source/nsswitch/libnss_wins.so $RPM_BUILD_ROOT/%{_libarch}/libnss # Samba 3.2.2 installs them into /usr/lib{,64}/samba/ . # This step will become unnecessary in 3.3.0. # -for library in libsmbclient libsmbsharemodes libwbclient libtalloc libtdb -libnetapi +for library in libsmbclient libsmbsharemodes libwbclient libtalloc libtdb libnetapi do mv -f ${RPM_BUILD_ROOT}%{_libarchdir}/samba/${library}.* \ ${RPM_BUILD_ROOT}%{_libarchdir}/ -- 1.6.0.2 From 9995378cf3f28af183030c3867513552d85bf935 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Wed, 17 Dec 2008 22:27:39 +0100 Subject: [PATCH] packaging(RHEL): fix typo in [u]mount.cifs installation Michael (cherry picked from commit 835108bcf84a5f47f46d237c7a93c572348125a1) Signed-off-by: Michael Adam (cherry picked from commit 71c74725bce403e36e4dc38287802c95b8d4de66) (cherry picked from commit cfc140d3924dd6be893d242ce5df22e2128f09f8) (cherry picked from commit 8b4c199deffd724a4a2219ccb8ffb91524101cd9) --- packaging/RHEL/samba.spec.tmpl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packaging/RHEL/samba.spec.tmpl b/packaging/RHEL/samba.spec.tmpl index 1e43116..a93b5d9 100644 --- a/packaging/RHEL/samba.spec.tmpl +++ b/packaging/RHEL/samba.spec.tmpl @@ -245,8 +245,8 @@ install -m644 setup/samba.pamd $RPM_BUILD_ROOT%{_sysconfdir}/pam.d/samba install -m755 setup/smbprint $RPM_BUILD_ROOT%{_bindir} install -m644 setup/smbusers $RPM_BUILD_ROOT%{_sysconfdir}/samba/smbusers install -m644 setup/smb.conf $RPM_BUILD_ROOT%{_sysconfdir}/samba/smb.conf -install -m755 bin/mount.cifs $RPM_BUILD_ROOT/sbin/mount.cifs -install -m755 bin/umount.cifs $RPM_BUILD_ROOT/sbin/umount.cifs +in
Re: [Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
will the mount.cifs compile error on Fedora 10 i386 and x86_64 be fixed when running packing/RHEL/makerpms.sh? I've submitted bug reports and got a patch on 12/23/08 from you and reported that the patch didn't fix the error and never got a reply. Karolin Seeger wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey folks, fyi: The planned release date for Samba 3.2.8 is February 03, 2009. Karolin - -- Samba http://www.samba.org SerNet http://www.sernet.de sambaXP http://www.sambaxp.org -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAklsVa0ACgkQKGi9fisXk1G+XwCfTKWiARlspK6dFKaSBpPCe5W1 PAcAnRLbGFF1ANS0qTmpSZRQ26PeEAvQ =L25z -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] [Release Planning 3.2] Samba 3.2.8 on February 03, 2009
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey folks, fyi: The planned release date for Samba 3.2.8 is February 03, 2009. Karolin - -- Samba http://www.samba.org SerNet http://www.sernet.de sambaXP http://www.sambaxp.org -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAklsVa0ACgkQKGi9fisXk1G+XwCfTKWiARlspK6dFKaSBpPCe5W1 PAcAnRLbGFF1ANS0qTmpSZRQ26PeEAvQ =L25z -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba