[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 269738d6ce4 lib/replace: fix strlcat/strlcpy compile for Honggfuzz via f0e0ff262ab tldap: avoid infinite loop when filter contains "\)" via 17e35c26914 fuzz: add fuzzer for ldb_comparison_fold via 019bee54c6b fuzz: add fuzzer for sess_crypt_blob via f404ef3c2aa libcli:auth:sess_crypt_blob: ensure key has 7 bytes via 5c007600dcd util/base64: add a note about zero length strings via c3ded9d9343 lib/fuzzing:fuzz_sddl_access_check fix nul-term check via 5c81f349354 lib/fuzzing: LLVMFuzzerTestOneInput() takes const uint8_t* via 43b44827d63 s4:torture: Fix code spelling via 3ec0c61c4d3 s4:smb_server: Fix code spelling via d61c3684c59 s4:smb_server: Add missing newlines to logging messages via 6386306671e s4:samba: Add missing newline to logging message via 56561fd0455 s4:rpc_server: Fix typo via 29c927054dd s4:rpc_server: Remove unnecessary parentheses via 2e1adcfc2db s4:rpc_server/backupkey: Fix leaks via 68bf480b9c8 s4:rpc_server: Add missing newlines to logging messages via 5b2e60588aa s4:policy: Fix leak via 36bbfe62fa7 s4:param: Add missing newlines to logging messages via c4d055ded21 s4:ntvfs: Add missing newline to logging message via 90a9f78afeb s4:librpc: Add missing newline to logging message via 45abe2853fe s4:libnet: Add missing newlines to logging messages via b07dd255a44 s4:lib: Add missing newlines to logging messages via fd6c3e6b7ca s4:ldap_server: Add missing newlines to logging messages via 178a7ed8a9c s4:dsdb:tests: Remove unused variables via 5a19ea9bce3 s4:dsdb:tests: Use control that was (presumably) intended via 68388153c0e s4:dsdb: Do not dereference a NULL pointer via 4fad62d953c s4:dsdb: Check result of talloc functions via c850ffdec75 s4:dsdb: Correct error messages via d4db9a2793f s4:dsdb: Fix leaks via 54714b35806 s4:dsdb: Remove unnecessary parentheses via cb2053ee17e s4:dsdb: Improve grammar via 79cc9adf3c9 s4:dsdb: Add missing newlines to logging messages via 1e753542aa7 s4:dns_server: Add missing newline to logging message via ffbd69ed71f s4:client: Add missing newlines to logging messages via 3076bb6cb92 s4:cldap_server: Add missing newline to logging message via e663c1d96b3 s4:auth: Correct condition and remove redundant check via c590d8d3a38 s4:auth: Check return value of talloc_reference() via 703978c7763 s4:auth: Fix leaks via 146a9260fb8 s3:winbindd: Fix debug messages via ac0f599cabf s3:winbindd: Add missing newlines to logging messages via 90a3aca4324 s3:vfs: Add missing space in debug message via 88acf7de082 s3:utils: Fix code spelling via a30b6d1eb7c s3:utils: Add missing newlines to logging messages via aec5307ef72 s3:smbd: Add missing space to warning message via 732923e7e0a s3:smbd: Fix code spelling via 44d3f17aa9e s3:smbd Remove unnecessary newlines from logging messages via aff878dc82b s3:smbd: Add missing newlines to logging messages via 867b192cadb s3:rpc_server: Fix typo via ce0ace6700f s3:rpc_server: Add missing space to debug message via f7e86f5045e s3:rpc_server: Fix incomplete logging messages via c172de6ee4a s3:rpc_server: Add missing newlines to logging messages via 687a0f016fc s3:rpc_client: Add missing newlines to logging messages via cd3d9aa25d7 s3:registry: Add missing newlines to logging messages via 6489f31378e s3:printing: Fix code spelling via 575f0016d43 s3:printing: Add missing spaces to error messages via 1fbfe05023e s3:printing: Add missing newlines to logging messages via f80a8516b3a s3:passdb: Fix typo via 1b082f7bd64 s3:passdb: Add missing newlines to logging messages via 4fef81f183f s3:nmbd: Add missing newlines to logging messages via e9882f8207d s3:modules: Fix error message via ae147ebc584 s3:modules: Correct escape sequence via fa24c5de840 s3:modules: Remove redundant newlines in logging messages via cef6692ba00 s3:modules: Add missing newlines to logging messages via 728eebbfbb6 s3:libsmb: Add missing parenthesis to logging message via bba1613d552 s3:libsmb: Add missing newlines to logging messages via 956c7a2828e s3:librpc: Add missing newline to logging message via f798cf932e2 s3:libnet: Add missing newline to logging message via 67decfc75b6 s3:libads: Add missing newlines to logging messages via 09a13ca46e3 tldap: Use portable integer constant via 769aa901999 s3:lib: Use portable format specifiers via c7d71dd1255 s3:lib: Add missing newlines to logging messages via 8ea7b8a0af7 s3:groupdb: Add missing newline to logging
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via f87f02f6f99 ctdb-doc: Fix documentation for ctdb event status
via f01a179abcb ctdb-tools: Fix CID 1539212 - signed/unsigned issue
from 3452b0d2cec netcmd: user: readpasswords: move syncpasswords command
to readpasswords
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit f87f02f6f99157601a6607927305e91835d45ab8
Author: Martin Schwenke
Date: Sat Jul 29 10:07:35 2023 +1000
ctdb-doc: Fix documentation for ctdb event status
Behaviour was changed, documentation wasn't.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15438
Signed-off-by: Martin Schwenke
Reviewed-by: Amitay Isaacs
Autobuild-User(master): Amitay Isaacs
Autobuild-Date(master): Mon Aug 7 09:43:33 UTC 2023 on atb-devel-224
commit f01a179abcb33d9da6097f5ae45c7e7df1bc0397
Author: Martin Schwenke
Date: Sun Jul 30 11:07:47 2023 +1000
ctdb-tools: Fix CID 1539212 - signed/unsigned issue
>>> CID 1539212: Control flow issues (NO_EFFECT)
>>> This greater-than-or-equal-to-zero comparison of an unsigned value
is always true. "p >= 0UL".
216 while (p >= 0 && output[p] == '\n') {
This is a real problem in the unlikely event that the output contains
only newlines.
Fix the issue by using a pointer and add a test to cover this case.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15438
Signed-off-by: Martin Schwenke
Reviewed-by: Amitay Isaacs
---
Summary of changes:
ctdb/doc/ctdb.1.xml| 58 +++---
ctdb/event/event_tool.c| 9 ++--
.../etc-ctdb/events/random/02.enabled.script | 8 +++
ctdb/tests/UNIT/eventd/eventd_008.sh | 10
4 files changed, 51 insertions(+), 34 deletions(-)
Changeset truncated at 500 lines:
diff --git a/ctdb/doc/ctdb.1.xml b/ctdb/doc/ctdb.1.xml
index 65c254762eb..2973fbf2832 100644
--- a/ctdb/doc/ctdb.1.xml
+++ b/ctdb/doc/ctdb.1.xml
@@ -646,10 +646,10 @@ Interface[2]: Name:eth5 Link:up References:2 (active)
The output is the list of event scripts executed.
Each line shows the name, status, duration and start time
- for each script.
+ for each script. Output from each script is shown.
- Example
+ Example #1
# ctdb event status legacy monitor
@@ -671,6 +671,28 @@ Interface[2]: Name:eth5 Link:up References:2 (active)
70.iscsi OK 0.009 Sat Dec 17 19:39:12 2016
91.lvs OK 0.007 Sat Dec 17 19:39:12 2016
+
+
+ Example #2
+
+
+# ctdb event status legacy monitor
+00.ctdb OK 0.011 Sat Dec 17 19:40:46 2016
+01.reclock OK 0.010 Sat Dec 17 19:40:46 2016
+05.systemOK 0.030 Sat Dec 17 19:40:46 2016
+06.nfs OK 0.014 Sat Dec 17 19:40:46 2016
+10.interface OK 0.041 Sat Dec 17 19:40:46 2016
+11.natgw OK 0.008 Sat Dec 17 19:40:46 2016
+11.routing OK 0.007 Sat Dec 17 19:40:46 2016
+13.per_ip_routingOK 0.007 Sat Dec 17 19:40:46 2016
+20.multipathdOK 0.007 Sat Dec 17 19:40:46 2016
+31.clamd OK 0.007 Sat Dec 17 19:40:46 2016
+40.vsftpdOK 0.013 Sat Dec 17 19:40:46 2016
+41.httpd OK 0.015 Sat Dec 17 19:40:46 2016
+49.winbind OK 0.022 Sat Dec 17 19:40:46 2016
+50.samba ERROR 0.077 Sat Dec 17 19:40:46 2016
+ OUTPUT: ERROR: samba tcp port 445 is not responding
+
@@ -741,37 +763,15 @@ Interface[2]: Name:eth5 Link:up References:2 (active)
scriptstatus
- This command displays which event scripts where run in the previous
- monitoring cycle and the result of each script. If a script
- failed with an error, causing the node to become unhealthy,
- the output from that script is also shown.
+ This is an alias for ctdb event status legacy
+ EVENT, where EVENT defaults to
+ monitor.
This command is deprecated. It's provided for backward
- compatibility. In place of ctdb scriptstatus,
- use ctdb event status.
+ compatibility. Use ctdb event status
+ instead.
-
- Example
-
-# ctdb scriptstatus
-00.ctdb OK 0.011 Sat Dec 17 19:40:46 2016
-01.reclock OK 0.010 Sat Dec 17 19:40:46 2016
-05.systemOK 0.030 Sat Dec 17 19:40:46 2016
-06.nfs OK 0.014 Sat Dec 17 19:40:46 2016
