Re: [SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-622-gb12edbe
On Wed, Apr 02, 2008 at 05:54:27AM -0500, G??nther Deschner wrote: > The branch, v3-2-test has been updated >via b12edbeffee1f7d1fd971cde9189e5137ddeb35b (commit) >via 8a1a9f967db25d3928f19e46d60af249f934f323 (commit) > from 4714bae0dbbb2ad010c2929f83de6bca84cfac46 (commit) > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test > > > - Log - > commit b12edbeffee1f7d1fd971cde9189e5137ddeb35b > Author: GĂźnther Deschner <[EMAIL PROTECTED]> > Date: Wed Apr 2 12:29:24 2008 +0200 > > Fix "net rpc trustdom establish" for win2k8 trusts. > > When establishing trusts to a windows 2008 dc, the NetServerEnum2 RAP > call fails > with some exotic RAP failure. Let's just try a netlogon getdcname call in > that case to convince ourselve we're talking to a proper machine. > > Rafael, looks ok? Yep, though (as we discussed on #samba-technical) we should probably drop doing RAP call here or provide fallback perhaps. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewisesoftware.com signature.asc Description: Digital signature
Re: [SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-713-g7a911b3
> commit 7a911b35713538d82001a3c9f34152e293fe1943 > Author: Volker Lendecke <[EMAIL PROTECTED]> > Date: Tue Dec 18 09:41:03 2007 +0100 > > Add a in-memory cache > > This is a more general API that caches data with a LRU scheme. See > include/cache.h. No comments yet, I'm still working on it. But Jeremy has > given > me a hint in one of his checkins that he would like to make use of this > now. > > The idea is that we get rid of all our silly little caches and merge them > all > into one cache I thought gencache was originally implemented for this reason :-) > that we can then very easily trim, for example even with a > smbcontrol message if someone decides memory is tight. The main user is > the > stat cache, this patch also converts the getwd cache. More caches to come. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r25674 - in branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3: .
On Wed, Oct 17, 2007 at 08:26:55AM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2007-10-17 08:26:55 + (Wed, 17 Oct 2007) > New Revision: 25674 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25674 > [...] > I've tested with midl to see how windows handles this situation > and also the reverse case where the client sends NULL and > the server reposnse with non-NULL. > > It appears that midl generated code just ignores this > and only copies the result if both pointers are non-NULL. Did midl ignore all cases but the one where both pointers were non-NULL at the same time ? I'm not sure right now, but midl shouldn't have problems with [in,out] pointer set to NULL on either "in" or "out" direction (as long as it's not "ref" pointer). cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r24787 - in branches/SAMBA_3_2_0/source: rpc_parse utils
On Wed, Aug 29, 2007 at 05:14:55PM +, [EMAIL PROTECTED] wrote: > Author: jra > Date: 2007-08-29 17:14:54 + (Wed, 29 Aug 2007) > New Revision: 24787 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24787 > > Log: > Janitor for Mimir. Mimir, you checked into SAMBA_3_2 and > SAMBA_3_0 - this second branch is defunct. You should > be checking into SAMBA_3_2_0 instead - this is what we > will be shipping as 3.2.0. Oh, sorry. I thought I have already checked it into 3_2_0 after I found my samba3 tree was SAMBA_3_0. Thanks! cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r24733 - in branches: SAMBA_3_2/source/lib SAMBA_3_2/source/torture SAMBA_3_2_0/source/lib SAMBA_3_2_0/source/torture
On Tue, Aug 28, 2007 at 12:40:03PM +, [EMAIL PROTECTED] wrote:
> Author: gd
> Date: 2007-08-28 12:40:01 + (Tue, 28 Aug 2007)
> New Revision: 24733
>
> WebSVN:
> http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24733
>
> Log:
> Add support for storing DATA_BLOBs in gencache.tdb (including torturetest).
>
> Mimir, please have a look. DATA_BLOBs will now just show up as "DATA_BLOB"
> values with "net cache list".
Looks fine to me.
One aesthetic note - couldn't this:
> + again:
> + len = 0;
> +
> + len += tdb_pack(buf+len, buflen-len, "fB",
> + valstr,
> + blob->length, blob->data);
> +
> + if (len == -1) {
> + goto out;
> + }
> +
> + if (buflen < len) {
> + SAFE_FREE(buf);
> + buf = SMB_MALLOC_ARRAY(unsigned char, len);
> + if (!buf) {
> + goto out;
> + }
> + buflen = len;
> + goto again;
> + }
be implemented as a loop ?
cheers,
--
Rafal Szczesniak
Samba Team member http://www.samba.org
signature.asc
Description: Digital signature
Re: svn commit: samba r24568 - in branches/SAMBA_4_0/source/torture/libnet: .
On Mon, Aug 20, 2007 at 01:03:51AM +, [EMAIL PROTECTED] wrote: > Author: abartlet > Date: 2007-08-20 01:03:51 + (Mon, 20 Aug 2007) > New Revision: 24568 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24568 > > Log: > Fix the build, caused by a conflict betwen mimir's work and metze's bulk > rename. Thanks Andrew! cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r23066 - in branches/SAMBA_4_0/source/torture/libnet: .
Metze,
On Tue, May 22, 2007 at 09:02:17AM +, [EMAIL PROTECTED] wrote:
> Author: metze
> Date: 2007-05-22 09:02:16 + (Tue, 22 May 2007)
> New Revision: 23066
>
> WebSVN:
> http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23066
>
> Log:
> don't ignore errors
>
> metze
> Modified:
>branches/SAMBA_4_0/source/torture/libnet/libnet_user.c
>
>
> Changeset:
> Modified: branches/SAMBA_4_0/source/torture/libnet/libnet_user.c
> ===
> --- branches/SAMBA_4_0/source/torture/libnet/libnet_user.c2007-05-22
> 06:34:14 UTC (rev 23065)
> +++ branches/SAMBA_4_0/source/torture/libnet/libnet_user.c2007-05-22
> 09:02:16 UTC (rev 23066)
> @@ -536,6 +536,7 @@
> status = libnet_UserInfo(ctx, mem_ctx, &user_req);
> if (!NT_STATUS_IS_OK(status)) {
> printf("libnet_UserInfo call failed: %s\n",
> nt_errstr(status));
> + ret = False;
> continue;
> }
Thanks for catching that.
cheers,
--
Rafal Szczesniak
Samba Team member http://www.samba.org
signature.asc
Description: Digital signature
Re: svn commit: samba r23047 - in branches/SAMBA_4_0/source/scripting/ejs: .
On Tue, May 22, 2007 at 04:32:30PM +1000, [EMAIL PROTECTED] wrote: > Rafal, > > > Well, yes, you're right. I messed the order :) But it should be ok, > > to reverse the order of inclusion - defined paths first, local dir > > second. This would allow not to substitue commonly used include files > > and still be able to include something local. > > no, it's not OK. It's _never_ ok. > > Imagine that Samba is installed in /net/some_nfs/drive/samba and nfs > is down. What happens then? smbstatus then goes to '.' and the > security hole is back. > > Please just revert the patch. There is no way we should ever be > looking in '.' for scripts or libraries of any kind. ok, you're right. My foolish mistake. It's reverted now. My life is more complicated back again ;-) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r23047 - in branches/SAMBA_4_0/source/scripting/ejs: .
On Tue, May 22, 2007 at 09:17:36AM +1000, [EMAIL PROTECTED] wrote: > Mimir, > > > + /* First, try to include file from current working directory. > > + This allows local includes which is handy sometimes. */ > > yes, it's very handy if you are a malicious hacker! > > Imagine the admin has a ftp upload area, and cd's to that > directory. He wants to see if anyone is connected to that area with > "smbstatus". The attacker uploads util.js and hey presto the attacker > has just got the admin to run his code inside smbstatus, as root. Well, yes, you're right. I messed the order :) But it should be ok, to reverse the order of inclusion - defined paths first, local dir second. This would allow not to substitue commonly used include files and still be able to include something local. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r21852 - in branches/SAMBA_4_0/webapps/swat/source/class/swat/module/netmgr: .
On Thu, Mar 15, 2007 at 10:52:34PM -0400, [EMAIL PROTECTED] wrote:
> [EMAIL PROTECTED] writes:
>
> > + if (typeof(parentNode.credentials) == "object")
> > + {
> > + var creds = parentNode.credentials;
> > + var request = _this.callRpc("samba.ejsnet", "NetContext", [ creds ]);
> > + request.setUserData("requestType", "NetContext");
> > + }
> > + else
> > + {
> > + // TODO: display a login dialog
> > + }
> > + }
> > +
> > +});
>
> I'm not sure what you're doing here, but login is handled automatically for
> all of the modules. Either you don't understand the SWAT framework and its
> standard capabilities, or (more likely) I just don't understand what you're
> doing here. If I'm off base, just tell me to shut up. :-)
Yes, I know the login is handled by SWAT.
I need to create NetContext for the host node. Since each host I connect
to by means of libnet may require different credentials, I attach them
to the node and create the actual context on the server side. So, this
is creating libnet credentials rather than logging in to SWAT.
There's one thing that might turned useful here. Default credentials could
be created on the basis of SWAT login credentials. However, specifying
different ones needs to be available. Right now, if there's nothing given
yet, I ask (vide TODO).
Don't shut up - thanks for keeping an eye on this code :-)
cheers,
--
Rafal Szczesniak
Samba Team member http://www.samba.org
signature.asc
Description: Digital signature
Re: svn commit: samba r20908 - in branches/SAMBA_4_0/source/scripting/ejs/ejsnet: .
On Fri, Jan 19, 2007 at 03:37:20PM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2007-01-19 15:37:20 + (Fri, 19 Jan 2007) > New Revision: 20908 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20908 > > Log: > - fix uninitialized usage of 'ctx' > - remove unused mem_ctx variable > - copy the userman_domain string as child of obj Metze, thank you and please let me finish :) I don't have the whole day for samba coding so I leave something for the next one:) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r20791 - in branches/SAMBA_4_0/source: . scripting/ejs scripting/ejs/ejsnet
On Mon, Jan 15, 2007 at 07:34:04AM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2007-01-15 07:34:04 + (Mon, 15 Jan 2007) > New Revision: 20791 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20791 > > Log: > the ejsnet stuff can be a normal smbcalls module... Why is it still called smbcalls ? I realise there are "historical" reasons, but ejs interface has became much more than just a gateway to smbcalls. > mimir: when you want to register more functions >please do that in the smb_setup_ejs_net() function ok. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r20225 - in branches/SAMBA_4_0/source/libnet: .
On Sun, Dec 17, 2006 at 01:33:43PM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2006-12-17 13:33:43 + (Sun, 17 Dec 2006) > New Revision: 20225 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20225 > > Log: > we can't use composite_error() in a _recv() function, as that would > trigger the caller to call the _recv() function again and will be an endless > loop. Doh! You're right. Thanks. > this is just a fix the to prevent this, and use a more usefull error code > than NT_STATUS_UNSUCCESSFUL > > I think we should move the checks about valid responses into the function > which receives the the response (here continue_name_found()), > so that the _recv() function only needs to transfer the output vars to the > caller > without any logic to analyse the network response. Yes, but on the other hand I'd prefer to leave some of the code in _recv function to be able to perform some checks when transferring the results to given memory context. Alternative approach would be to replace all _recv functions with some generic call, just like dcerpc_ndr_request_recv() cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r20166 - in branches/SAMBA_4_0/source/libnet: .
On Thu, Dec 14, 2006 at 08:23:56AM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2006-12-14 08:23:55 + (Thu, 14 Dec 2006) > New Revision: 20166 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20166 > > Log: > we have a dom_sid_add_rid() function that adds the rid after allocating > enough memory for the new sub_auth element. > > the old version wrote behind the buffer. > > also make the output sid a pointer. Hey! I was supposed to fix that tonight :) Thanks anyway :) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r20011 - in branches/SAMBA_4_0/source/libnet: .
Metze, Could we implement it as part of libnet_SetRole function ? This way functionality of various roles would be put into respective role_*.c files - role_become_dc.c in this case. With libnet_SetRole we could provide high level of support for complicated tasks like promoting a server do DC, becoming domain member, etc. On Sat, Dec 02, 2006 at 03:35:27PM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2006-12-02 15:35:27 + (Sat, 02 Dec 2006) > New Revision: 20011 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20011 > > Log: > define libnet_BecomeDC_state struct and add some dummy functions cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r19933 - in branches/SAMBA_4_0/source/libnet: .
On Tue, Nov 28, 2006 at 04:05:11PM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2006-11-28 16:05:10 + (Tue, 28 Nov 2006) > New Revision: 19933 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19933 > > Log: > something is really wrong here... > > mimir: please take a look! Oh, I forgot to pass the actual data pointer to the message. Other than that, it's just passing pipe connection parameters to synchronous monitor functions (what ensures the validity of the pointers). Thanks for catching that! Is there anything else troubling you ? cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r18614 - in branches/SAMBA_4_0/source/lib/util: .
On Tue, Sep 19, 2006 at 10:14:44PM -0700, [EMAIL PROTECTED] wrote: > Mimir, > > > a new function converting NTTIME to struct timeval > > > + tv->tv_usec = t - tv->tv_sec*100; > > +} > > Are you sure thats correct? Well, just for a quick check I put a code, in one of my test, getting current time in timeval, converting it to NTTIME, and converting it to timeval back again. It did work correctly, though I didn't do any random tests. > Maybe it's equivalent somehow, but I > suspect to get the tv_usec value will involve a modulo operation, > something like: > > tv->tv_usec = ((t+5) % 1000) / 10; The idea of doing it was based on nt_time_to_unix function. > Maybe we need a LOCAL-TIME unit test for these time functions? > Converting from timeval to NTTIME then back again for some random > times might be a useful test (with appropriate 0.5usec tolerence > levels). Sure, I was also thinking about that. The only thing that stopped me that time was "do we really need to test this ?", but it looks like we do. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r18607 - in branches/SAMBA_4_0/source/libnet: .
On Mon, Sep 18, 2006 at 09:02:50AM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2006-09-18 09:02:50 + (Mon, 18 Sep 2006) > New Revision: 18607 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18607 > > Log: > remove unused structure element > > rafal: is there a reason why we don't use libnet_AddShare() in the torture > test? Yes, the original code is not mine, but the volunteer (sorry, forgot his name) on the net. He probably did not write the test for it. I'm going to check the share manipulation code and probably reconstruct it a little once I'm done with user account functions. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r18587 - in branches/SAMBA_4_0/source/libnet: .
Tridge,
On Sat, Sep 16, 2006 at 05:59:34PM +, [EMAIL PROTECTED] wrote:
> Author: tridge
> Date: 2006-09-16 17:59:33 + (Sat, 16 Sep 2006)
> New Revision: 18587
>
> WebSVN:
> http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18587
>
> Log:
>
> fixed a potential memory leak in libnet
How did that introduce a memory leak ? Should libnet ctx as a parent not
depend on any other ?
> Changeset:
> Modified: branches/SAMBA_4_0/source/libnet/libnet.c
> ===
> --- branches/SAMBA_4_0/source/libnet/libnet.c 2006-09-16 17:57:50 UTC (rev
> 18586)
> +++ branches/SAMBA_4_0/source/libnet/libnet.c 2006-09-16 17:59:33 UTC (rev
> 18587)
> @@ -27,7 +27,7 @@
> struct libnet_context *ctx;
>
> /* create brand new libnet context */
> - ctx = talloc(NULL, struct libnet_context);
> + ctx = talloc(ev, struct libnet_context);
> if (!ctx) {
> return NULL;
> }
cheers,
--
Rafal Szczesniak
Samba Team member http://www.samba.org
signature.asc
Description: Digital signature
Re: svn commit: samba r18529 - in branches/SAMBA_3_0/source/lib: .
On Thu, Sep 14, 2006 at 02:06:35PM -0400, simo wrote:
> On Thu, 2006-09-14 at 13:56 -0400, [EMAIL PROTECTED] wrote:
> > [EMAIL PROTECTED] writes:
> >
> > > + DEBUG(1, ("WARNING: your /etc/hosts file may be
> > > broken!\n"));
> > > + DEBUGADD(1, ("specifing the machine hostname for
> > > address 127.0.0.1 may lead\n"));
> > > + DEBUGADD(1, ("to Kerberos authentication probelms
> > > as localhost.localdomain\n"));
> > > + DEBUGADD(1, ("may end up to be used instead of the
> > > real machine FQDN.\n"));
> >
> > Verb conjugation in English of "to be" is really strange. This should say:
> >
> > DEBUGADD(1, ("may end up being used instead of the
> > real machine FQDN.\n"));
>
> Thanks,
> will change it.
Just for the sake of completeness - in the same shot you could fix
a typo: s/probelms/problems/ :-)
cheers,
--
Rafal Szczesniak
Samba Team member http://www.samba.org
signature.asc
Description: Digital signature
Re: svn commit: samba r17990 - in branches/SAMBA_4_0/source/librpc/rpc:.
On Fri, Sep 01, 2006 at 01:06:40PM +0200, Stefan (metze) Metzmacher wrote:
> Hi Tridge,
>
> > /*
> > + handle timeouts of a dcerpc connect
> > +*/
> > +static void dcerpc_connect_timeout_handler(struct event_context *ev,
> > struct timed_event *te,
> > + struct timeval t, void *private)
> > +{
> > + struct composite_context *c = talloc_get_type(private, struct
> > composite_context);
> > + DEBUG(0,("DCERPC CONNECT TIMEOUT\n"));
> > + composite_error(c, NT_STATUS_IO_TIMEOUT);
> > + composite_done(c);
> > +}
>
> this is wrong, composite_error() already calls the callback and frees 'c'
> and composite_done() would use freed memory
Though I sometimes think it would be more convenient to be able to first
set the status code with composite_error() and then do something more,
before calling the callback and freeing the composite context.
cheers,
--
Rafal Szczesniak
Samba Team member http://www.samba.org
signature.asc
Description: Digital signature
Re: svn commit: samba r17717 - in branches/SAMBA_4_0/source/torture/libnet: .
On Tue, Aug 22, 2006 at 07:28:44PM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2006-08-22 19:28:44 + (Tue, 22 Aug 2006) > New Revision: 17717 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17717 > > Log: > this cried for bugs...and they happened... > we were passing a struct timeval reference as string, > and gcc gives a warning...use C99 style initialisation. > > is there a special reason why the ACB_NORMAL is passed > when the force_password_change is selected? No, this was a quick test of setting this field. This test is about to change, but thank you for fixing this version. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r14172 - in branches/SAMBA_4_0/source/librpc/rpc: .
On Fri, Mar 10, 2006 at 08:08:16PM +, [EMAIL PROTECTED] wrote: > Author: metze > Date: 2006-03-10 20:08:15 + (Fri, 10 Mar 2006) > New Revision: 14172 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14172 > > Log: > composite_is_ok(c) destroys c, when the status isn't ok. > so we need to return directly. Thanks for this, Stefan. I need to put those debug messages elsewhere. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r11794 - in branches/SAMBA_4_0/source/libnet: .
On Fri, Nov 18, 2005 at 11:27:58PM +, [EMAIL PROTECTED] wrote: > Author: tridge > Date: 2005-11-18 23:27:58 + (Fri, 18 Nov 2005) > New Revision: 11794 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11794 > > Log: > > - fixed a valgrind error in libnet, caused by using a stack variable > after the function has returned (the *address variable was assigned > into the state). Doh! Thanks for catching that, Andrew. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r8839 - in trunk/source: param registry rpc_server services
On Thu, Jul 28, 2005 at 07:50:09PM +, [EMAIL PROTECTED] wrote: > Author: jerry > Date: 2005-07-28 19:50:07 + (Thu, 28 Jul 2005) > New Revision: 8839 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8839 > > Log: > adding patches from Marcin. Have to still work on > testing and reviewing. Wow! A polish hacker! :) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r7511 - in branches/SAMBA_3_0/source: param utils
On Sun, Jun 12, 2005 at 04:00:31PM +, [EMAIL PROTECTED] wrote: > Author: lmuelle > Date: 2005-06-12 16:00:29 + (Sun, 12 Jun 2005) > New Revision: 7511 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=7511 > > Log: > Add three new command line switches to testparm: > > --show-all-parameters > Enumerates all available parameters, grouped in to sections > [local] and [global] by the class of the parameter. Each line > is formated name=type[,enum values],flags > --parameter-name > Display the setting of the named parameter. The global section > is assumed if no other is set with --section-name > --section-name > Limit the view of testparm to the named section. Use 'global' > to only view the settings of the global section. This is your first commit - congratulations! :) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r7253 - in branches/SAMBA_4_0/source/include: .
On Sat, Jun 04, 2005 at 12:20:32AM +, [EMAIL PROTECTED] wrote: > Author: tpot > Date: 2005-06-04 00:20:32 + (Sat, 04 Jun 2005) > New Revision: 7253 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=7253 > > Log: > Fix build. Thank you and sorry about the mess. As Andrew noticed it's a part of uncommited code. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r6426 - in branches/SAMBA_4_0/source/torture/libnet: .
On Thu, Apr 21, 2005 at 06:20:34PM -0700, Richard Sharpe wrote:
> On Fri, 22 Apr 2005 [EMAIL PROTECTED] wrote:
>
> > - if (!NT_STATUS_IS_OK(status)) {
> > - return False;
> > - }
> > + if (!NT_STATUS_IS_OK(status)) return False;
>
> I don't think this is a big item, but I actually prefer the first one
> above that was deleted, because it makes things much easier when you are
> inserting debugging statements and so forth, at the cost of a few more
> characters.
Certainly, when you add debug statements you use the deleted form.
I changed it to single line because it is smaller. Once I put there
something more it will be just what you prefer.
cheers,
--
Rafal Szczesniak
Samba Team member http://www.samba.org
signature.asc
Description: Digital signature
Re: svn commit: samba r6165 - in branches/SAMBA_4_0/source: libnet torture/libnet
On Fri, Apr 01, 2005 at 11:24:52AM +, [EMAIL PROTECTED] wrote: > Author: tridge > Date: 2005-04-01 11:24:52 + (Fri, 01 Apr 2005) > New Revision: 6165 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6165 > > Log: > fixed up the userinfo composite code. Fixes include: > [...] > Mimir, please look at the diff carefully for more detailed info on the fixes Thanks a lot! I'll study it tonight. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r5372 - in branches/SAMBA_4_0/source/include: .
On Sun, Feb 13, 2005 at 09:33:32AM +, [EMAIL PROTECTED] wrote: > Author: tridge > Date: 2005-02-13 09:33:31 + (Sun, 13 Feb 2005) > New Revision: 5372 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=5372 > > Log: > fixed the build Oh, sorry about that, but how could it be ? I did clean and complete build twice and nothing had happened. > Modified: >branches/SAMBA_4_0/source/include/structs.h > > > Changeset: > Modified: branches/SAMBA_4_0/source/include/structs.h > === > --- branches/SAMBA_4_0/source/include/structs.h 2005-02-13 09:10:33 UTC > (rev 5371) > +++ branches/SAMBA_4_0/source/include/structs.h 2005-02-13 09:33:31 UTC > (rev 5372) > @@ -119,6 +119,7 @@ > union libnet_rpc_connect; > union libnet_RemoteTOD; > union libnet_JoinDomain; > +union libnet_CreateUser; > struct net_functable; > struct net_context; cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: lorikeet r59 - in trunk: . samba4-ad-thesis
On Thu, Sep 16, 2004 at 03:38:41AM +, [EMAIL PROTECTED] wrote: > Author: abartlet > Date: 2004-09-16 03:38:41 + (Thu, 16 Sep 2004) > New Revision: 59 > > WebSVN: > http://websvn.samba.org/websvn/changeset.php?rep=lorikeet&path=/trunk&rev=59&nolog=1 > > Log: > As residents on #samba-technical would be aware, I'm working on Samba4 > for University credit - finally! This thesis describes the Samba4 > work towards an Active Directory compatible DC. > > In any case, I figure the best backup procedure for this document is > to simply put it in SVN, so I'm doing just that :-) That's perfectly reasonable. I used my cvs server to host my own thesis. > There is a long way to go on this, but you have to start somehwere... > > If you wish to make changes to this, talk to me first, so I can ensure > that appropriate credit is given, and my supervisor doesn't kill me > ;-) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r2339 - in branches/SAMBA_4_0/source/scripting/swig/torture: .
On Wed, Sep 15, 2004 at 04:36:13AM +, [EMAIL PROTECTED] wrote: > Author: tridge > Date: 2004-09-15 04:36:13 + (Wed, 15 Sep 2004) > New Revision: 2339 > > WebSVN: > http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_4_0/source/scripting/swig/torture&rev=2339&nolog=1 > > Log: > my first python commit! How do you like the language ? :) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r1720 - branches/SAMBA_3_0/source/utils trunk/source/utils
On Wed, Aug 11, 2004 at 06:21:00PM +0200, Volker Lendecke wrote: > On Wed, Aug 11, 2004 at 01:59:46PM +0200, Guenther Deschner wrote: > > quite easy: I just checked out $SERVER/samba and below samba I call > > Ok, I did not do this quite yet as this probably is huge :-) Not so horrible, but growing fast as you've joined the 3.2-merge efforts :-) Besides, we're in US, so take an opportunity to use fast links ;) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r1720 - branches/SAMBA_3_0/source/utils trunk/source/utils
On Wed, Aug 11, 2004 at 01:41:14PM +0200, Volker Lendecke wrote: > On Wed, Aug 11, 2004 at 09:32:32AM +, [EMAIL PROTECTED] wrote: > >branches/SAMBA_3_0/source/utils/net_groupmap.c > >trunk/source/utils/net_groupmap.c > > Wait a minute -- how did you set up your tree to be able to do a combined > commit??? You can easily checkout the whole samba svn tree witch all branches under in subdirectory (as Guenter have pointed out). It's a nice feature compared to cvs. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r1692 - in branches/SAMBA_3_0/source: . printing rpc_client rpc_parse rpc_server rpcclient utils
On Tue, Aug 10, 2004 at 02:27:18PM +, [EMAIL PROTECTED] wrote: > Author: gd > Date: 2004-08-10 14:27:17 + (Tue, 10 Aug 2004) > New Revision: 1692 > WebSVN: > http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source&rev=1692&nolog=1 > Log: > first commit :) Welcome onboard ! Fun and ocasionally "what-the-hell-is-that" guaranteed :-) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r1689 - trunk/source/libsmb
On Tue, Aug 10, 2004 at 11:23:08AM +, [EMAIL PROTECTED] wrote: > Author: vlendec > Date: 2004-08-10 11:23:08 + (Tue, 10 Aug 2004) > New Revision: 1689 > WebSVN: > http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/&rev=1689&nolog=1 > Log: > Forgot asn1.c in last ldap commit Yes, you've had :) First I wanted to commit turned off code (ifdef-ed) as it broke my build, but then I just left this "fix" in my local repo. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba-web r105 - trunk/support
On Tue, Jun 22, 2004 at 09:02:48PM +, [EMAIL PROTECTED] wrote: > Author: deryck > Date: 2004-06-22 21:02:48 + (Tue, 22 Jun 2004) > New Revision: 105 > > Removed: >trunk/support/poland.html Absolutely no one replied in Poland ??? cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org signature.asc Description: Digital signature
Re: svn commit: samba r94 - trunk/source/utils
On Tue, Apr 06, 2004 at 10:23:06PM +, [EMAIL PROTECTED] wrote: > Author: jmcd > Date: 2004-04-06 22:23:06 + (Tue, 06 Apr 2004) > New Revision: 94 > > Modified: >trunk/source/utils/pdbedit.c > Log: > Fix the build that mimir broke! > > Function was declared as delete_trustpw, but called as delete_trustpw_entry. Sorry, just tried to fix that when I noticed you commited the fix. The latter was the original function name, and it seems I didn't change it completely... -- Rafal Szczesniak Samba Team member http://www.samba.org
Re: CVS update: samba/source/include
On Fri, Mar 19, 2004 at 01:40:50PM -0500, Jim McDonough wrote: > > > > > > Can you see any reason why this could not be written to utilise gencache > ? > > As far as I can see there's actually no data that couldn't be represented > > with gencache entry. If so, I could port it. > Yes, the cache entries do not expire based on a timestamp, but rather a > timestamp+current password policy setting. Of course and it's still doable. As caches based on gencache have their own specifics they're built on top of it. This mechanism provides a GENeric CACHE :) If you think it is better to leave logon caching with its own mechanism, I am still happy with that. I just thought I had written gencache with using it this way on mind. I'll take a look once more at the code and talk to you. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org
Re: CVS update: samba/source/include
On Thu, Mar 18, 2004 at 08:05:00PM +, [EMAIL PROTECTED] wrote: > > Date: Thu Mar 18 20:05:00 2004 > Author: jmcd > > Update of /home/cvs/samba/source/include > In directory dp.samba.org:/tmp/cvs-serv17754/include > > Modified Files: > passdb.h smbldap.h > Log Message: > merge from 3.0...LDAP password lockout support Can you see any reason why this could not be written to utilise gencache ? As far as I can see there's actually no data that couldn't be represented with gencache entry. If so, I could port it. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org
Re: CVS update: samba/source/utils
On Thu, Mar 18, 2004 at 07:32:15AM +, [EMAIL PROTECTED] wrote: > > Date: Thu Mar 18 07:32:15 2004 > Author: vlendec > > Update of /data/cvs/samba/source/utils > In directory dp.samba.org:/tmp/cvs-serv28359 > > Modified Files: > Tag: SAMBA_3_0 > net.c net_rpc.c > Log Message: > Two little annoyances: > > net rpc did not inform you if no smbd is running. > > I never liked the error message (!) Success! when we established a trust. Don't you like error message first and then "success" ? ;-) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org
Re: CVS update: samba/source/auth
On Sun, Feb 29, 2004 at 04:48:19PM +, [EMAIL PROTECTED] wrote: > > Date: Sun Feb 29 16:48:19 2004 > Author: vlendec > > Update of /data/cvs/samba/source/auth > In directory dp.samba.org:/tmp/cvs-serv14749/auth > > Modified Files: > auth_util.c > Log Message: > Apply my experimental aliases support to HEAD. This will be a bit difficult to > merge to 3_0, as the pdb interfaces has changed a bit between the two. > > This has not been tested too severly (which means it's completely broken ;-), > but I want it in for review. Feel free to revert it :-) > > TODO: > > make 'net groupmap' a bit more friendly for alias members. > > Put that stuff into pdb_ldap. > > Getting the information over to winbind. One plan without linking pdb into > winbind would be to fill group_mapping.tdb with the membership information and > have that as a cache (or use gencache.tdb?). Yes, use it. That's what it's been implemented for :) > smbd on a PDC or stand-alone > could trigger that itself, the problem is a BDC using LDAP. This needs to do > it on a regular basis. The BDC smbd needs to be informed about SAM changes > somehow... cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org
Re: CVS update: samba4/source/ntvfs/cifs
On Thu, Jan 08, 2004 at 06:48:55AM +, Stefan Metzmacher wrote: > > Date: Thu Jan 8 06:48:55 2004 > Author: metze > > Update of /home/cvs/samba4/source/ntvfs/cifs > In directory dp.samba.org:/tmp/cvs-serv5214/ntvfs/cifs > > Modified Files: > vfs_cifs.c > Log Message: > remove a useless assignment Congratulations on your first commit! :) cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org
Re: CVS update: samba/source/include
On Thu, Jan 08, 2004 at 09:40:20AM +0100, Volker Lendecke wrote: > On Wed, Jan 07, 2004 at 09:41:48PM +, [EMAIL PROTECTED] wrote: > > Prototype version of trust passwords moved to SAM/pdb. This is > > backend-independent part ie. interface - does build and (it seems) > > doesn't break anything else. > > Thanks! We *really* need that in 3_0 as well. "Patience, Luke" ;-) I'd rather try it out with basic backends (tdb and smbpasswd, namely) in HEAD and then port it to 3_0. We don't want to have passdb backends broken in our production release, I guess. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org
Re: CVS update: samba/source/utils
On Thu, Aug 14, 2003 at 05:21:22PM +, [EMAIL PROTECTED] wrote: > > Date: Thu Aug 14 17:21:22 2003 > Author: vlendec > > Update of /data/cvs/samba/source/utils > In directory dp.samba.org:/tmp/cvs-serv2876/utils > > Modified Files: > Tag: SAMBA_3_0 > ntlm_auth.c > Log Message: > Fix the build for non-kerberos environments. Well done, Volker! This is probably fix for the issue I wrote about yesterday. cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: sambaweb/docs
On Sat, Apr 12, 2003 at 01:57:49PM +, Jelmer Vernooij wrote: > > Date: Sat Apr 12 13:57:49 2003 > Author: jelmer > > Update of /home/cvs/sambaweb/docs > In directory dp.samba.org:/tmp/cvs-serv30831 > > Modified Files: > index.html > Log Message: > > Fix links to the HEAD/3.0 documentation You said you didn't fix it (on #samba-technical) Fixed itself ? :-) cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/lib
On Sat, Mar 22, 2003 at 11:25:09PM +, [EMAIL PROTECTED] wrote: > > Date: Sat Mar 22 23:25:09 2003 > Author: abartlet > > Update of /data/cvs/samba/source/lib > In directory dp.samba.org:/tmp/cvs-serv27868/lib > > Modified Files: > gencache.c > Log Message: > Valgrind found a few memory leaks! Nice! I better start to use it... cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/libsmb
On Tue, Mar 18, 2003 at 09:42:50AM +1100, Andrew Bartlett wrote: > On Tue, 2003-03-18 at 09:24, [EMAIL PROTECTED] wrote: > > On Mon, Mar 17, 2003 at 04:42:57AM +, [EMAIL PROTECTED] wrote: > > > > > > Date: Mon Mar 17 04:42:57 2003 > > > Author: abartlet > > > > > > Update of /data/cvs/samba/source/libsmb > > > In directory dp.samba.org:/tmp/cvs-serv3421/libsmb > > > > > > Modified Files: > > > trusts_util.c > > > Log Message: > > > Fix a memory leak - 'smbcontrol smbd pool-usage' is your freind! > > > > Excuse me, but looking at source code I don't quite understand why > > to remove this talloc destroy ? If function doesn't return after > > successful string compare, then initialised talloc should be destroyed > > before "default" return. > > Correct. I *added* it :-) Oh, indeed! I thought I've seen '-' on the left hand side! Well, I was really tired yesterday night and that's my only excuse :) Thank you. cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/auth
On Sat, Mar 15, 2003 at 06:10:49AM +, [EMAIL PROTECTED] wrote: > > Date: Sat Mar 15 06:10:49 2003 > Author: abartlet > > Update of /data/cvs/samba/source/auth > In directory dp.samba.org:/tmp/cvs-serv4501/auth > > Modified Files: > auth_util.c > Log Message: > Now that mimir has done the grunt work, I'll fix up the comment Indeed :) I forgot to remove it. cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/libsmb
On Sat, Mar 15, 2003 at 09:24:33AM +1100, Andrew Bartlett wrote: > On Sat, 2003-03-15 at 04:07, Rafal Szczesniak wrote: > > On Fri, Mar 14, 2003 at 05:03:43PM +, [EMAIL PROTECTED] wrote: > > > > > > Date: Fri Mar 14 17:03:43 2003 > > > Author: mimir > > > > > > Update of /home/cvs/samba/source/libsmb > > > In directory dp.samba.org:/tmp/cvs-serv12490 > > > > > > Removed Files: > > > trust_passwd.c > > > Log Message: > > > /tmp/newfun.msg > > > > Ugh, option mistaken :( > > Your new 'trusted domains cache' shuts down the gencache when it's > finished. We need to find the 'correct' way to handle that. Agreed. > Other than that, this looks very nice! Thank you :) > At the moment, :-) cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/passdb
On Sat, Mar 15, 2003 at 09:28:24AM +1100, Andrew Bartlett wrote: > On Sat, 2003-03-15 at 04:12, [EMAIL PROTECTED] wrote: > > > > Date: Fri Mar 14 17:12:40 2003 > > Author: mimir > > > > Update of /home/cvs/samba/source/passdb > > In directory dp.samba.org:/tmp/cvs-serv14137/passdb > > > > Modified Files: > > secrets.c > > Log Message: > We need to extend that struct, to have the account name, old password > and the account type. (If we have a interdomain trust account, or a > workstation account, we have to specify the right type to NT). > > Now it *should* always be interdomain trust, but... ;-) In fact, it's likely to appear in two cases: one with any number of trusted domains passwords and another with one password for 'our' trusted account on PDC. Mixtures of above shuoldn't take place in clear installations :) I've found interesting situation when having such a mixture and in domain membership mode. Thanks to that I know we must be prepared for that ...just in case. > The old password is needed in case the PDC/BDC we contact isn't up to > speed yet, and the account name helps generalize the case and avoids > problems when we rename ourselves. Yes, I didn't forget about these things. We've discussed it on irc. Under construction :) cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/libsmb
On Fri, Mar 14, 2003 at 05:03:43PM +, [EMAIL PROTECTED] wrote: > > Date: Fri Mar 14 17:03:43 2003 > Author: mimir > > Update of /home/cvs/samba/source/libsmb > In directory dp.samba.org:/tmp/cvs-serv12490 > > Removed Files: > trust_passwd.c > Log Message: > /tmp/newfun.msg Ugh, option mistaken :( cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/auth
On Sat, Feb 22, 2003 at 08:01:00PM +, [EMAIL PROTECTED] wrote: > > Date: Sat Feb 22 20:01:00 2003 > Author: abartlet > > Update of /data/cvs/samba/source/auth > In directory dp.samba.org:/tmp/cvs-serv27687/auth > > Modified Files: > auth_rhosts.c > Log Message: > See if I can make this look slightly like C. It compiled locally, honest... So it was you ! :-) I was surprised by a compile time error today and found that part of the source looks a bit like C++. OK, you have fixed it, so I don't have to check in my fix. I was about to do it yet this day (my local time)... I also have some problems with kerberos parts, but I'll see whether it still raises after my Debian upgrade. cheers, -- Rafal Szczesniak mimir[at]diament.ists.pwr.wroc.pl Samba Team member mimir[at]samba.org +-+ *BSD, GNU/Linux and Samba http://www.samba.org +-+
Re: CVS update: samba/source/lib
On Sat, Jan 04, 2003 at 03:48:15AM -0500, [EMAIL PROTECTED] wrote: > > Date: Sat Jan 4 08:48:15 2003 > Author: abartlet > > Update of /home/cvs/samba/source/lib > In directory dp.samba.org:/tmp/cvs-serv23378/lib > > Modified Files: > Tag: SAMBA_3_0 > gencache.c util_str.c > Log Message: > Merge from HEAD - mimir's new gencache based namecache code. Oh, thank you. This way the gencache may become more widely used. I found the ability of easy looking into the cache very useful. -- cheers, ++ |Rafal 'Mimir' Szczesniak <[EMAIL PROTECTED]> | |*BSD, GNU/Linux and Samba / |__/
Re: CVS update: samba/source/utils
On Sun, Dec 29, 2002 at 10:01:51AM +0100, Simo Sorce wrote: > On Sun, 2002-12-29 at 09:24, Simo Sorce wrote: > > On Sat, 2002-12-28 at 20:49, [EMAIL PROTECTED] wrote: > > > On Sat, Dec 28, 2002 at 05:30:16PM +0100, Simo Sorce wrote: > > > > This is plain wrong > > > > pdbedit can be used fine without a username > > > > > > > > without username it simply fixes all the accounts > > > > oops, fixes -> works :-) > > I think I should sleep some more :-) > Let's see if I get it right this time :-P > > fixes -> works -> show show -> shows Sorry, Simo, just couldn't help myself ;-) PS. Sleep is good... generally speaking :) -- cheers, ++ |Rafal 'Mimir' Szczesniak <[EMAIL PROTECTED]> | |*BSD, GNU/Linux and Samba / |__/
Re: CVS update: samba/source/libsmb
On Tue, Nov 26, 2002 at 05:40:59PM +, [EMAIL PROTECTED] wrote: > On Tue, Nov 26, 2002 at 06:35:42PM +0100, Rafal Szczesniak wrote: > > > > Perhaps it would be good thing to merge latest changes in namecache > > from HEAD to SAMBA_3_0 ? > > I agree, but the person who added it to HEAD should have done > that. I'm ensuring what is there is as bug free as I can make > it Sure. Then I should catch Andrew and force him to apply my last patch. You hear me, Andrew ? There's no way to hide :-) -- cheers, ++ |Rafal 'Mimir' Szczesniak <[EMAIL PROTECTED]> | |*BSD, GNU/Linux and Samba / |__/
Re: CVS update: samba/source/libsmb
On Tue, Nov 26, 2002 at 12:03:16PM -0500, [EMAIL PROTECTED] wrote: > > Date: Tue Nov 26 17:03:16 2002 > Author: jra > > Update of /data/cvs/samba/source/libsmb > In directory dp.samba.org:/tmp/cvs-serv30459/libsmb > > Modified Files: > Tag: SAMBA_3_0 > namecache.c > Log Message: > Fix bug in tdb_fetch tidyup. Perhaps it would be good thing to merge latest changes in namecache from HEAD to SAMBA_3_0 ? -- cheers, ++ |Rafal 'Mimir' Szczesniak <[EMAIL PROTECTED]> | |*BSD, GNU/Linux and Samba / |__/
Re: CVS update: samba/source/libsmb
On Sun, Nov 24, 2002 at 07:17:49PM -0500, [EMAIL PROTECTED] wrote: > > Date: Mon Nov 25 00:17:49 2002 > Author: tpot > > Update of /data/cvs/samba/source/libsmb > In directory dp.samba.org:/tmp/cvs-serv11977 > > Modified Files: > Tag: APPLIANCE_HEAD > namecache.c > Log Message: > Fix bug in name timeout code found by mimir. Actually, abartlet was the one who said "something's wrong here". So, Andrew caught this and I just placed it in my patch. > Changed 0x1b and 0x1c name timeout to 15 seconds (observed from > nbtstat on Windows). > > No CR # > > > Revisions: > namecache.c 1.1.2.5 => 1.1.2.6 > >http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/namecache.c?r1=1.1.2.5&r2=1.1.2.6 -- cheers, ++ |Rafal 'Mimir' Szczesniak <[EMAIL PROTECTED]> | |*BSD, GNU/Linux and Samba / |__/
Re: CVS update: samba/source/nsswitch
On Thu, Nov 07, 2002 at 03:36:44AM +, Andrew Bartlett wrote: > > On Wed, Nov 06, 2002 at 08:06:38PM -0500, [EMAIL PROTECTED] wrote: > > > > Date: Thu Nov 7 01:06:38 2002 > > Author: tpot > > > > Update of /data/cvs/samba/source/nsswitch > > In directory dp.samba.org:/tmp/cvs-serv17865/nsswitch > > > > Modified Files: > > winbindd.c winbindd_util.c > > Log Message: > > Call winbindd_param_init() earlier on in the piece so we don't get stuck in > > the holding pattern when started up when security = user or security = ads. > > A PDC can run winbindd - it is often used for PAM, and for squid. Also, this > is how we intend to support trusted domains. Exactly. I was about to say this. -- cheers, ++ |Rafal 'Mimir' Szczesniak <[EMAIL PROTECTED]> | |*BSD, GNU/Linux and Samba / |__/
Re: CVS update: samba/source/utils
On Wed, Sep 18, 2002 at 05:02:58PM +, [EMAIL PROTECTED] wrote: > On Wed, Sep 18, 2002 at 05:11:26PM +1000, Tim Potter wrote: > > On Wed, Sep 18, 2002 at 02:34:10AM -0400, [EMAIL PROTECTED] wrote: > > > > > Modified Files: > > > net_rpc_samsync.c net_rpc.c > > > Log Message: > > > First code for 'net rpc vampire'. We should probably find a more > > > positive name for this. It creates users and global groups. More to come. > > > > net rpc lamprey? > > Nah. > > net rpc sucks yes, I like this one :-) -- cheers, ++ |Rafal 'Mimir' Szczesniak <[EMAIL PROTECTED]> | |*BSD, GNU/Linux and Samba / |__/
