[jira] Commented: (SCM-139) Create a utility class for scm url checking/parsing
[ http://jira.codehaus.org/browse/SCM-139?page=comments#action_59465 ] Dennis Lundberg commented on SCM-139: - I'll pull something together then. I assume that this will be put in after 1.0 has been released, so I will create the patch against 1.0 final. Will that be OK? > Create a utility class for scm url checking/parsing > --- > > Key: SCM-139 > URL: http://jira.codehaus.org/browse/SCM-139 > Project: Maven SCM > Type: New Feature > Components: maven-scm-api > Reporter: Dennis Lundberg > Attachments: SCM-139-2.zip, SCM-139.zip, ScmUrlUtils.java > > > There is a lot of code in different places, both in maven-scm and elsewhere, > that checks and parses scm url:s. I propose that a utility class ScmUrlUtils > be crated in maven-scm-api where such code (static methods) can be placed. > The code there should not be scm provider specific. This should be > accompanied by a test suite. > This concept might also be applied to individual scm providers, e.g. there > could be a CvsScmUrlUtils in maven-scm-provider-cvs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-139) Create a utility class for scm url checking/parsing
[ http://jira.codehaus.org/browse/SCM-139?page=comments#action_59343 ] Dennis Lundberg commented on SCM-139: - Do you mean duplicated code in the new files that I created or in the files that are already a part of maven-scm? > Create a utility class for scm url checking/parsing > --- > > Key: SCM-139 > URL: http://jira.codehaus.org/browse/SCM-139 > Project: Maven SCM > Type: New Feature > Components: maven-scm-api > Reporter: Dennis Lundberg > Attachments: SCM-139-2.zip, SCM-139.zip, ScmUrlUtils.java > > > There is a lot of code in different places, both in maven-scm and elsewhere, > that checks and parses scm url:s. I propose that a utility class ScmUrlUtils > be crated in maven-scm-api where such code (static methods) can be placed. > The code there should not be scm provider specific. This should be > accompanied by a test suite. > This concept might also be applied to individual scm providers, e.g. there > could be a CvsScmUrlUtils in maven-scm-provider-cvs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-29) test with CVS NT
[ http://jira.codehaus.org/browse/SCM-29?page=comments#action_58451 ] Dennis Lundberg commented on SCM-29: I agree with your decision to remove the check for CVSNT. > test with CVS NT > > > Key: SCM-29 > URL: http://jira.codehaus.org/browse/SCM-29 > Project: Maven SCM > Type: Test > Components: maven-scm-provider-cvs > Reporter: Brett Porter > Assignee: Emmanuel Venisse > Fix For: 1.0-beta-3 > > > Vincent reported test failures on CVS NT... test it and fix if required. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-150) Start pure java cvs provider
[ http://jira.codehaus.org/browse/SCM-150?page=comments#action_57690 ] Dennis Lundberg commented on SCM-150: - How is this different from SCM-10? > Start pure java cvs provider > > > Key: SCM-150 > URL: http://jira.codehaus.org/browse/SCM-150 > Project: Maven SCM > Type: New Feature > Components: maven-scm-provider-cvs > Reporter: Emmanuel Venisse > Assignee: Emmanuel Venisse > Fix For: 1.0-beta-3 > > > required by changelo plugin for backward compatibility -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=all ] Dennis Lundberg reopened SCM-124: - Reopening so that I can attach a file. > StarteamChangeLogConsumerTest does not work if locale is not en or fr > - > > Key: SCM-124 > URL: http://jira.codehaus.org/browse/SCM-124 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-starteam > Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale > Reporter: Dennis Lundberg > Assignee: Emmanuel Venisse > Fix For: 1.0-beta-3 > Attachments: SCM-124.patch > > > The testcase StarteamChangeLogConsumerTest makes assumptions about the user's > locale that are not always true. > Lines 45-52 uses the default locale and if a suitable changelog for that > locale is not found, it defaults to using the English changelog file. This > works well for English and French which have changelog files. But it does not > work for other locales that use a different dateformat than English, i.e most > of Europe. > The problem is that the class StarteamChangeLogConsumer has a private > instance variable of SimpleDateFormat called localFormat. This variable can > not be set from outside the class. On line 390 localFormat is used to parse > dates. This will fail if the user has a different locale than the one being > used in the logfile being parsed. I imagine that it is common (at least not > uncommon) to have different locales on the server and the client. > So the locale used in the StarteamChangeLogConsumer needs to be set to the > locale used by the *server* and not the *client*. A simple getter/setter > would do the trick. The locale would need to be configurable in some way so > that the user can set the locale that is used by his/her server. > The reason I stumbled upon this was when I tried to do "mvn test" for > maven-scm. It produced this stacktrace: > ... > [INFO] > > [INFO] Building Maven SCM Starteam Provider > [INFO]task-segment: [test] > [INFO] > > [INFO] [resources:resources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:compile] > Compiling 25 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes > [INFO] [resources:testResources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:testCompile] > Compiling 22 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes > [INFO] [surefire:test] > [INFO] Setting reports dir: > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports > --- > T E S T S > --- > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [surefire] Running > org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest > [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec > Added: ./maven.xml > Added: ./target/checkout/maven.xml > Added: ./target/checkout/project.properties > Added: ./target/checkout/project.xml > Added: ./target/checkout/bootstrap/maven.xml > Added: ./target/checkout/bootstrap/project.properties > Added: ./target/checkout/bootstrap/project.xml > [surefire] Running > org.apache.maven.scm.provider.starteam.command.add.StarteamAddConsumerTest > [surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,03 sec > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [surefire] Running > org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommandTest > [surefire] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,02 sec > [ERROR] ParseException Caught > java.text.ParseException: Unparseable date: "4/21/04 1:05:00 PM PDT" > at java.text.DateFormat.parse(DateFormat.java:335) > at > org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.parseDate(StarteamChangeLogConsumer.java:390) > at > org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.proce
[jira] Updated: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=all ] Dennis Lundberg updated SCM-124: Attachment: SCM-124.patch > StarteamChangeLogConsumerTest does not work if locale is not en or fr > - > > Key: SCM-124 > URL: http://jira.codehaus.org/browse/SCM-124 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-starteam > Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale > Reporter: Dennis Lundberg > Assignee: Emmanuel Venisse > Fix For: 1.0-beta-3 > Attachments: SCM-124.patch > > > The testcase StarteamChangeLogConsumerTest makes assumptions about the user's > locale that are not always true. > Lines 45-52 uses the default locale and if a suitable changelog for that > locale is not found, it defaults to using the English changelog file. This > works well for English and French which have changelog files. But it does not > work for other locales that use a different dateformat than English, i.e most > of Europe. > The problem is that the class StarteamChangeLogConsumer has a private > instance variable of SimpleDateFormat called localFormat. This variable can > not be set from outside the class. On line 390 localFormat is used to parse > dates. This will fail if the user has a different locale than the one being > used in the logfile being parsed. I imagine that it is common (at least not > uncommon) to have different locales on the server and the client. > So the locale used in the StarteamChangeLogConsumer needs to be set to the > locale used by the *server* and not the *client*. A simple getter/setter > would do the trick. The locale would need to be configurable in some way so > that the user can set the locale that is used by his/her server. > The reason I stumbled upon this was when I tried to do "mvn test" for > maven-scm. It produced this stacktrace: > ... > [INFO] > > [INFO] Building Maven SCM Starteam Provider > [INFO]task-segment: [test] > [INFO] > > [INFO] [resources:resources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:compile] > Compiling 25 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes > [INFO] [resources:testResources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:testCompile] > Compiling 22 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes > [INFO] [surefire:test] > [INFO] Setting reports dir: > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports > --- > T E S T S > --- > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [surefire] Running > org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest > [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec > Added: ./maven.xml > Added: ./target/checkout/maven.xml > Added: ./target/checkout/project.properties > Added: ./target/checkout/project.xml > Added: ./target/checkout/bootstrap/maven.xml > Added: ./target/checkout/bootstrap/project.properties > Added: ./target/checkout/bootstrap/project.xml > [surefire] Running > org.apache.maven.scm.provider.starteam.command.add.StarteamAddConsumerTest > [surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,03 sec > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [surefire] Running > org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommandTest > [surefire] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,02 sec > [ERROR] ParseException Caught > java.text.ParseException: Unparseable date: "4/21/04 1:05:00 PM PDT" > at java.text.DateFormat.parse(DateFormat.java:335) > at > org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.parseDate(StarteamChangeLogConsumer.java:390) > at > org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.processGetAuthor(Start
[jira] Commented: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=comments#action_57688 ] Dennis Lundberg commented on SCM-124: - I can confirm that the tests run successfully using revision 374523. But I do think that the root of the problem is still there. Running the tests succeeds, but they produce 6 ERROR lines in the output, which seems to be ignored. They look like this: [ERROR] ParseException Caught java.text.ParseException: Unparseable date: "4/21/04 1:05:00 PM PDT" at java.text.DateFormat.parse(DateFormat.java:335) at org.apache.maven.scm.util.AbstractConsumer.parseDate(AbstractConsumer.java:79) The reason for these exceptions is this. If no pattern is specified in a call to parseDate( String date, String userPattern, String defaultPattern ) a SimpleDateInstance is created using the users default locale. This assumes that the ChangeLog that is being parsed uses the same date format as the users default locale. As I stated in a previous comment, I don't know much about Starteam, so please correct me if I'm wrong here: Wouldn't it be better to assume a locale of en_US if no pattern is specified? By using a DateFormat factory method I managed to do this in AbstractConsumer, which made the test run successfully *without* any ERROR lines. I'll attach a patch shortly. I do not know, however, how this would affect normal usage. Perhaps someone knowledgeable in Starteam can step up and shed some light on this. > StarteamChangeLogConsumerTest does not work if locale is not en or fr > - > > Key: SCM-124 > URL: http://jira.codehaus.org/browse/SCM-124 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-starteam > Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale > Reporter: Dennis Lundberg > Assignee: Emmanuel Venisse > Fix For: 1.0-beta-3 > > > The testcase StarteamChangeLogConsumerTest makes assumptions about the user's > locale that are not always true. > Lines 45-52 uses the default locale and if a suitable changelog for that > locale is not found, it defaults to using the English changelog file. This > works well for English and French which have changelog files. But it does not > work for other locales that use a different dateformat than English, i.e most > of Europe. > The problem is that the class StarteamChangeLogConsumer has a private > instance variable of SimpleDateFormat called localFormat. This variable can > not be set from outside the class. On line 390 localFormat is used to parse > dates. This will fail if the user has a different locale than the one being > used in the logfile being parsed. I imagine that it is common (at least not > uncommon) to have different locales on the server and the client. > So the locale used in the StarteamChangeLogConsumer needs to be set to the > locale used by the *server* and not the *client*. A simple getter/setter > would do the trick. The locale would need to be configurable in some way so > that the user can set the locale that is used by his/her server. > The reason I stumbled upon this was when I tried to do "mvn test" for > maven-scm. It produced this stacktrace: > ... > [INFO] > > [INFO] Building Maven SCM Starteam Provider > [INFO]task-segment: [test] > [INFO] > > [INFO] [resources:resources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:compile] > Compiling 25 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes > [INFO] [resources:testResources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:testCompile] > Compiling 22 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes > [INFO] [surefire:test] > [INFO] Setting reports dir: > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports > --- > T E S T S > --- > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [surefire] Running > org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest > [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec > Added: ./maven.xml > Added: ./target/checkout/maven.xml > Added: ./t
[jira] Reopened: (SCM-106) Validation of scm url fails because of ambiquities between source code and site documentation
[ http://jira.codehaus.org/browse/SCM-106?page=all ] Dennis Lundberg reopened SCM-106: - After some discussion on scm-dev we have come to the conclusion that the correct format of an scm url should be: scm: I will attach a new patch for this later on. > Validation of scm url fails because of ambiquities between source code and > site documentation > - > > Key: SCM-106 > URL: http://jira.codehaus.org/browse/SCM-106 > Project: Maven SCM > Type: Bug > Components: maven-scm-api > Reporter: Dennis Lundberg > Assignee: Emmanuel Venisse > Fix For: 1.0-beta-3 > Attachments: SCM-106.patch > > > I am trying out Continuum and am tracking down the cause of why I get an > error regarding the scm url that I provide when adding an ant project. This > has led me here. I copied the scm url from my maven 1 project.xml and got a > very breif error message telling me to enter a valid scm url. > My scm url looks like this: > scm|cvs|pserver|[EMAIL PROTECTED]|C:/Program/cvsnt/repositories|project-name > This works just fine using maven 1. > These two files are involved in this: > maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java > maven-scm-site/src/site/apt/cvs.apt > AbstractScmManager.java has the following error message declared: > private final static String ILLEGAL_SCM_URL = "The scm url must be on the > form " > + "'scm: provider>' " > + "where can be > either ':' or '|'."; > which explains how a correct scm url should look. > cvs.apt on the other hand does not have this explanation. It does say: > For all URLs below, we use a colon (:) as separator. If you use a colon for > one of the variables (e.g. a windows path), then use a pipe (|) as separator. > Then follows a bunch of examples, none of which use pipe (|) as a separator. > So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven > scm flags my scm url as invalid, but the docs for the urls are not really > clear about what a delimiter/separator is and where they are in the scm url. > Asuming that the source code is correct, the the docs need updating to > reflect this. There should also be an example using pipe as a separator. If > someone can confirm this I can write a patch for the docs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-139) Create a utility class for scm url checking/parsing
[ http://jira.codehaus.org/browse/SCM-139?page=all ] Dennis Lundberg updated SCM-139: Attachment: ScmUrlUtils.java > Create a utility class for scm url checking/parsing > --- > > Key: SCM-139 > URL: http://jira.codehaus.org/browse/SCM-139 > Project: Maven SCM > Type: New Feature > Components: maven-scm-api > Reporter: Dennis Lundberg > Attachments: ScmUrlUtils.java > > > There is a lot of code in different places, both in maven-scm and elsewhere, > that checks and parses scm url:s. I propose that a utility class ScmUrlUtils > be crated in maven-scm-api where such code (static methods) can be placed. > The code there should not be scm provider specific. This should be > accompanied by a test suite. > This concept might also be applied to individual scm providers, e.g. there > could be a CvsScmUrlUtils in maven-scm-provider-cvs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SCM-139) Create a utility class for scm url checking/parsing
Create a utility class for scm url checking/parsing --- Key: SCM-139 URL: http://jira.codehaus.org/browse/SCM-139 Project: Maven SCM Type: New Feature Components: maven-scm-api Reporter: Dennis Lundberg There is a lot of code in different places, both in maven-scm and elsewhere, that checks and parses scm url:s. I propose that a utility class ScmUrlUtils be crated in maven-scm-api where such code (static methods) can be placed. The code there should not be scm provider specific. This should be accompanied by a test suite. This concept might also be applied to individual scm providers, e.g. there could be a CvsScmUrlUtils in maven-scm-provider-cvs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-131) mvn scm:validate does not validate the developerConnection in the pom
[ http://jira.codehaus.org/browse/SCM-131?page=all ]
Dennis Lundberg updated SCM-131:
Attachment: SCM-131.patch
> mvn scm:validate does not validate the developerConnection in the pom
> -
>
> Key: SCM-131
> URL: http://jira.codehaus.org/browse/SCM-131
> Project: Maven SCM
> Type: Bug
> Components: maven-plugin
> Reporter: Dennis Lundberg
> Attachments: SCM-131.patch
>
>
> There are a couple of reasons for this, in ValidateMojo:
> # The check to see if the scmDeveloperConnection is not null is done on the
> scmConnection
> # The @parameter definitions are wrong for both the the scmConnection and
> scmDeveloperConnection
> The check for scmConnection is never run either because of of the wrong
> @parameter definitions. But the actual value from the pom is normally checked
> anyway because the default-value for connectionUrl in AbstractScmMojo is
> ${pom.scm.connection}. But if you run it like this:
> mvn scm:validate -DconnectionUrl=invalidScmUrl
> the value of pom.scm.connection will not be checked.
> The supplied patch fixes these problems and logs an extra error the tells the
> user the value of the invalid scm connection url, to help resolve the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Created: (SCM-131) mvn scm:validate does not validate the developerConnection in the pom
mvn scm:validate does not validate the developerConnection in the pom
-
Key: SCM-131
URL: http://jira.codehaus.org/browse/SCM-131
Project: Maven SCM
Type: Bug
Components: maven-plugin
Reporter: Dennis Lundberg
There are a couple of reasons for this, in ValidateMojo:
# The check to see if the scmDeveloperConnection is not null is done on the
scmConnection
# The @parameter definitions are wrong for both the the scmConnection and
scmDeveloperConnection
The check for scmConnection is never run either because of of the wrong
@parameter definitions. But the actual value from the pom is normally checked
anyway because the default-value for connectionUrl in AbstractScmMojo is
${pom.scm.connection}. But if you run it like this:
mvn scm:validate -DconnectionUrl=invalidScmUrl
the value of pom.scm.connection will not be checked.
The supplied patch fixes these problems and logs an extra error the tells the
user the value of the invalid scm connection url, to help resolve the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-129) maven-release-plugin's checkForLocalModifications fails when there is non scm files the project
[ http://jira.codehaus.org/browse/SCM-129?page=comments#action_55189 ] Dennis Lundberg commented on SCM-129: - But the (non scm) files are created by Maven as part of the release process. In my setup there are two files that are reported as unknown when I do maven scm:prepare-release - project.xml.backup - xdocs/changes.xml.backup Both of these are modifies by Maven. Before I run maven I have checked that there are *no* files that needs to be checked in. Shouldn't Maven remove these files before it starts tagging files for release? > maven-release-plugin's checkForLocalModifications fails when there is non scm > files the project > --- > > Key: SCM-129 > URL: http://jira.codehaus.org/browse/SCM-129 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-cvs > Versions: 1.0-beta-3 > Environment: xp, cvs, latest maven-release-snapshot snaphot > Reporter: Dan Tran > Fix For: 1.0-beta-3 > > > when there are local files ( non scm files ) in the project, it becomes > unknow files when release plugin perform scm:status > and there for release:prepare will fail. > Is there a way for cvs provider to ignore those files so that release plugin > will be happy? > The word around is to do a clean checkout before release:prepare. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-129) maven-release-plugin's checkForLocalModifications fails when there is non scm files the project
[ http://jira.codehaus.org/browse/SCM-129?page=comments#action_55187 ] Dennis Lundberg commented on SCM-129: - I believe that this has been fixed by SCM-125. I will try to set up my dependencies on a project, to use the latest snapshots and see if I can get it to work. > maven-release-plugin's checkForLocalModifications fails when there is non scm > files the project > --- > > Key: SCM-129 > URL: http://jira.codehaus.org/browse/SCM-129 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-cvs > Versions: 1.0-beta-3 > Environment: xp, cvs, latest maven-release-snapshot snaphot > Reporter: Dan Tran > Fix For: 1.0-beta-3 > > > when there are local files ( non scm files ) in the project, it becomes > unknow files when release plugin perform scm:status > and there for release:prepare will fail. > Is there a way for cvs provider to ignore those files so that release plugin > will be happy? > The word around is to do a clean checkout before release:prepare. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-1) Publish site for 1.0
[ http://jira.codehaus.org/browse/SCM-1?page=all ] Dennis Lundberg updated SCM-1: -- Attachment: SCM-1.patch > Publish site for 1.0 > > > Key: SCM-1 > URL: http://jira.codehaus.org/browse/SCM-1 > Project: Maven SCM > Type: Task > Versions: 1.0-alpha-1 > Reporter: Jason van Zyl > Assignee: Emmanuel Venisse > Fix For: 1.0-beta-3 > Attachments: SCM-1.patch > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-31) The scm url validator should return a code corresponding to the error
[ http://jira.codehaus.org/browse/SCM-31?page=comments#action_54374 ] Dennis Lundberg commented on SCM-31: Where in the code chain would you like this? I looked at the code and found this chain of execution regarding validation of the scmUrl: maven-scm-plugin - ValidateMojo.execute() - ValidateMojo.validateConnection( String connectionString, String type ) maven-scm-api - AbstractScmManager.validateScmRepository( String scmUrl ) - AbstractScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) maven-scm-provider - CvsScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) / SvnScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) - CvsScmProvider.parseScmUrl( String scmSpecificUrl, char delimiter ) / SvnScmProvider.validateScmUrl( String scmSpecificUrl, char delimiter ) The other scm implementations just uses the default implementation available in AbstractScmProvider which makes a call to makeProviderScmRepository( String scmSpecificUrl, char delimiter ) My choice would be to put the resource files inside maven-scm-api somewhere, and put constants defining the error messages in AbstractScmProvider. To make this work we also need a list of possible error codes. Here's something to start with. It's basically a harvesting from the chain above: - Malformed URL - Cannot be null - Must start with "scm" - No such provider - The SCM provider cannot return null from validateScmUrl() - Illegal delimiter - Too few tokens - Too many tokens - Unknown transport (found in cvs provider) - Various "The user_password_host part must be on the form: ..." (found in cvs provider) - Various "A svn '' url must be on the form ..." (found in svn provider) > The scm url validator should return a code corresponding to the error > - > > Key: SCM-31 > URL: http://jira.codehaus.org/browse/SCM-31 > Project: Maven SCM > Type: Improvement > Versions: 1.0-alpha-1 > Reporter: Jason van Zyl > Fix For: 1.0-beta-3 > > > I would like an error code to be returned so that I can use the error code to > select an i18n key that will provide users with a localized error message. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-121) Intermittent CVS test failures
[ http://jira.codehaus.org/browse/SCM-121?page=comments#action_54368 ] Dennis Lundberg commented on SCM-121: - I am experiencing this as well. My environment is Windows XP using cvsnt as my command-line client. Mike wrote about this error on the dev-list: org.apache.maven.scm.provider.cvslib.command.checkout.CvsCheckoutCommandTest junit.framework.AssertionFailedError: expected:<38403> but was:<39511> at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.failNotEquals(Assert.java:282) at junit.framework.Assert.assertEquals(Assert.java:64) at junit.framework.Assert.assertEquals(Assert.java:136) at junit.framework.Assert.assertEquals(Assert.java:142) at org.apache.maven.scm.provider.cvslib.command.checkout.CvsCheckoutCommandTest.testCheckOutWithTag(CvsCheckoutCommandTest.java:88) After some investigation I have concluded that this happens in a Windows environment because the command-line cvs client checks out the file with windows line-endings (CR LF). This makes the total size of the file in bytes larger than it would in a unix environment. That is what the error above is telling us. I googled and found the CVS-book at http://cvsbook.red-bean.com/cvsbook.html#CVS%20is%20not%20doing%20line-end%20conversion%20correctly They seem to imply that the only way of stopping a cvs client from converting line-endings to the native sort is to say that the file is binary. That would mean specifying -kb in the CVS/Entries file. So I tried this and created such a directory and file in the test repository, but the results were the same. I am trying to make improvements to the cvs provider but I'm having all sorts of trouble just building maven-scm, being on Windows and not having a default locale of English. It's quite frustrating. To move forward, SCM-10 talks about switching from command line cvs to cvslib. This would be a major improvement for compatibility. There is a gotcha that cvslib might not support the ext transport. If that is the case, do you think it would be possible to use command line cvs for ext transport and cvslib for the rest? > Intermittent CVS test failures > -- > > Key: SCM-121 > URL: http://jira.codehaus.org/browse/SCM-121 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-cvs > Versions: 1.0-beta-3 > Reporter: mike perham > Fix For: 1.0-beta-3 > > > Dan and I continue to have test failures when trying to compile the cvs > plugin in our environment. I emailed these problems to the scm-dev list > about a week ago. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=comments#action_54238 ] Dennis Lundberg commented on SCM-124: - Actually I have never used Starteam so do not know whether locale is determined by client or server. It was just an assumption on my part. I do not have access to Starteam so I cannot supply a changelog file for my locale. The problem is not really my locale, it's all locales. To be able to successfully build/test/deploy maven-scm you have to do it using either French or English locale, or one that uses the same date format as English. I am trying to create patches for other issues for maven-scm, but I am unable to compile and test them properly because of this issue. > StarteamChangeLogConsumerTest does not work if locale is not en or fr > - > > Key: SCM-124 > URL: http://jira.codehaus.org/browse/SCM-124 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-starteam > Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale > Reporter: Dennis Lundberg > > > The testcase StarteamChangeLogConsumerTest makes assumptions about the user's > locale that are not always true. > Lines 45-52 uses the default locale and if a suitable changelog for that > locale is not found, it defaults to using the English changelog file. This > works well for English and French which have changelog files. But it does not > work for other locales that use a different dateformat than English, i.e most > of Europe. > The problem is that the class StarteamChangeLogConsumer has a private > instance variable of SimpleDateFormat called localFormat. This variable can > not be set from outside the class. On line 390 localFormat is used to parse > dates. This will fail if the user has a different locale than the one being > used in the logfile being parsed. I imagine that it is common (at least not > uncommon) to have different locales on the server and the client. > So the locale used in the StarteamChangeLogConsumer needs to be set to the > locale used by the *server* and not the *client*. A simple getter/setter > would do the trick. The locale would need to be configurable in some way so > that the user can set the locale that is used by his/her server. > The reason I stumbled upon this was when I tried to do "mvn test" for > maven-scm. It produced this stacktrace: > ... > [INFO] > > [INFO] Building Maven SCM Starteam Provider > [INFO]task-segment: [test] > [INFO] > > [INFO] [resources:resources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:compile] > Compiling 25 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes > [INFO] [resources:testResources] > [INFO] Using default encoding to copy filtered resources. > [INFO] [compiler:testCompile] > Compiling 22 source files to > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes > [INFO] [surefire:test] > [INFO] Setting reports dir: > G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports > --- > T E S T S > --- > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [surefire] Running > org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest > [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec > Added: ./maven.xml > Added: ./target/checkout/maven.xml > Added: ./target/checkout/project.properties > Added: ./target/checkout/project.xml > Added: ./target/checkout/bootstrap/maven.xml > Added: ./target/checkout/bootstrap/project.properties > Added: ./target/checkout/bootstrap/project.xml > [surefire] Running > org.apache.maven.scm.provider.starteam.command.add.StarteamAddConsumerTest > [surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,03 sec > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [WARNING] Your scm URL use a deprecated format. The new format is > :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] > [surefire] Running > org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommandTest > [surefire]
[jira] Created: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
StarteamChangeLogConsumerTest does not work if locale is not en or fr - Key: SCM-124 URL: http://jira.codehaus.org/browse/SCM-124 Project: Maven SCM Type: Bug Components: maven-scm-provider-starteam Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale Reporter: Dennis Lundberg The testcase StarteamChangeLogConsumerTest makes assumptions about the user's locale that are not always true. Lines 45-52 uses the default locale and if a suitable changelog for that locale is not found, it defaults to using the English changelog file. This works well for English and French which have changelog files. But it does not work for other locales that use a different dateformat than English, i.e most of Europe. The problem is that the class StarteamChangeLogConsumer has a private instance variable of SimpleDateFormat called localFormat. This variable can not be set from outside the class. On line 390 localFormat is used to parse dates. This will fail if the user has a different locale than the one being used in the logfile being parsed. I imagine that it is common (at least not uncommon) to have different locales on the server and the client. So the locale used in the StarteamChangeLogConsumer needs to be set to the locale used by the *server* and not the *client*. A simple getter/setter would do the trick. The locale would need to be configurable in some way so that the user can set the locale that is used by his/her server. The reason I stumbled upon this was when I tried to do "mvn test" for maven-scm. It produced this stacktrace: ... [INFO] [INFO] Building Maven SCM Starteam Provider [INFO]task-segment: [test] [INFO] [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 25 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes [INFO] [surefire:test] [INFO] Setting reports dir: G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports --- T E S T S --- [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec Added: ./maven.xml Added: ./target/checkout/maven.xml Added: ./target/checkout/project.properties Added: ./target/checkout/project.xml Added: ./target/checkout/bootstrap/maven.xml Added: ./target/checkout/bootstrap/project.properties Added: ./target/checkout/bootstrap/project.xml [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddConsumerTest [surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,03 sec [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommandTest [surefire] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,02 sec [ERROR] ParseException Caught java.text.ParseException: Unparseable date: "4/21/04 1:05:00 PM PDT" at java.text.DateFormat.parse(DateFormat.java:335) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.parseDate(StarteamChangeLogConsumer.java:390) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.processGetAuthor(StarteamChangeLogConsumer.java:281 at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.consumeLine(StarteamChangeLogConsumer.java:174) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumerTest.testParse(StarteamChangeLogConsumerTest.java:68 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.refl
[jira] Updated: (SCM-123) scm plugin ignores -Dusername for CSV provider
[ http://jira.codehaus.org/browse/SCM-123?page=all ] Dennis Lundberg updated SCM-123: Attachment: SCM-123-docs.patch > scm plugin ignores -Dusername for CSV provider > -- > > Key: SCM-123 > URL: http://jira.codehaus.org/browse/SCM-123 > Project: Maven SCM > Type: Bug > Components: maven-plugin > Versions: 1.0-beta-2 > Environment: xp, cvs > Reporter: Dan Tran > Fix For: 1.0-beta-3 > Attachments: SCM-123-docs.patch > > > mvn scm:validate -DconnectionUrl=scm:cvs:pserver:host:/cvs:module -X > -Dusername=joe > fails with > [DEBUG] (f) basedir = C:\dev\maven\src\scm > [DEBUG] (f) connectionUrl = scm:cvs:pserver:host:/cvs:module > [DEBUG] (f) settings = [EMAIL PROTECTED] > [DEBUG] (f) username = joe > [DEBUG] -- end configuration -- > [INFO] [scm:validate] > [ERROR] Error scm url connection (connectionUrl) validation failed : > [ERROR] The userhost part must be on the form: @. > is it intended? > Found this problem when looking at MNG-1783 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-123) scm plugin ignores -Dusername for CSV provider
[ http://jira.codehaus.org/browse/SCM-123?page=comments#action_54201 ] Dennis Lundberg commented on SCM-123: - Regarding my first comment: ignore it. The docs are talking about something else. I'll attach a patch that makes the docs a bit more clear. I have studied the source now and I can confirm that the @ character is indeed required. The reason for this seems to be that it would be hard to parse the scm url if the @ character is not there. I do think that it could be done though. A patch to get improved error messages is also coming soon. > scm plugin ignores -Dusername for CSV provider > -- > > Key: SCM-123 > URL: http://jira.codehaus.org/browse/SCM-123 > Project: Maven SCM > Type: Bug > Components: maven-plugin > Versions: 1.0-beta-2 > Environment: xp, cvs > Reporter: Dan Tran > Fix For: 1.0-beta-3 > > > mvn scm:validate -DconnectionUrl=scm:cvs:pserver:host:/cvs:module -X > -Dusername=joe > fails with > [DEBUG] (f) basedir = C:\dev\maven\src\scm > [DEBUG] (f) connectionUrl = scm:cvs:pserver:host:/cvs:module > [DEBUG] (f) settings = [EMAIL PROTECTED] > [DEBUG] (f) username = joe > [DEBUG] -- end configuration -- > [INFO] [scm:validate] > [ERROR] Error scm url connection (connectionUrl) validation failed : > [ERROR] The userhost part must be on the form: @. > is it intended? > Found this problem when looking at MNG-1783 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-123) scm plugin ignores -Dusername for CSV provider
[ http://jira.codehaus.org/browse/SCM-123?page=comments#action_54199 ] Dennis Lundberg commented on SCM-123: - Having read the Cederqvist http://ximbiot.com/cvs/manual/cvs-1.11.21/cvs_2.html#SEC26 I think that maven-scm is wrong in assuming that "The userhost part must be on the form: @" It should be valid to use a userhost part without a username as shown in the example. I'll see if I can put together a patch for this, together with clarifications about this in the docs. > scm plugin ignores -Dusername for CSV provider > -- > > Key: SCM-123 > URL: http://jira.codehaus.org/browse/SCM-123 > Project: Maven SCM > Type: Bug > Components: maven-plugin > Versions: 1.0-beta-2 > Environment: xp, cvs > Reporter: Dan Tran > Fix For: 1.0-beta-3 > > > mvn scm:validate -DconnectionUrl=scm:cvs:pserver:host:/cvs:module -X > -Dusername=joe > fails with > [DEBUG] (f) basedir = C:\dev\maven\src\scm > [DEBUG] (f) connectionUrl = scm:cvs:pserver:host:/cvs:module > [DEBUG] (f) settings = [EMAIL PROTECTED] > [DEBUG] (f) username = joe > [DEBUG] -- end configuration -- > [INFO] [scm:validate] > [ERROR] Error scm url connection (connectionUrl) validation failed : > [ERROR] The userhost part must be on the form: @. > is it intended? > Found this problem when looking at MNG-1783 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-123) scm plugin ignores -Dusername for CSV provider
[ http://jira.codehaus.org/browse/SCM-123?page=comments#action_54177 ] Dennis Lundberg commented on SCM-123: - The docs for the cvs provider seems to indicate that the @ character is needed. "If you use an anonymous access, you need to add a colon (:) between login and "@" like it's done in the first example." Which is the last line of this file http://svn.apache.org/viewcvs.cgi/maven/scm/trunk/maven-scm-site/src/site/apt/cvs.apt?rev=355486&view=markup > scm plugin ignores -Dusername for CSV provider > -- > > Key: SCM-123 > URL: http://jira.codehaus.org/browse/SCM-123 > Project: Maven SCM > Type: Bug > Components: maven-plugin > Versions: 1.0-beta-2 > Environment: xp, cvs > Reporter: Dan Tran > Fix For: 1.0-beta-3 > > > mvn scm:validate -DconnectionUrl=scm:cvs:pserver:host:/cvs:module -X > -Dusername=joe > fails with > [DEBUG] (f) basedir = C:\dev\maven\src\scm > [DEBUG] (f) connectionUrl = scm:cvs:pserver:host:/cvs:module > [DEBUG] (f) settings = [EMAIL PROTECTED] > [DEBUG] (f) username = joe > [DEBUG] -- end configuration -- > [INFO] [scm:validate] > [ERROR] Error scm url connection (connectionUrl) validation failed : > [ERROR] The userhost part must be on the form: @. > is it intended? > Found this problem when looking at MNG-1783 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-106) Validation of scm url fails because of ambiquities between source code and site documentation
[ http://jira.codehaus.org/browse/SCM-106?page=all ] Dennis Lundberg updated SCM-106: Attachment: SCM-106.patch > Validation of scm url fails because of ambiquities between source code and > site documentation > - > > Key: SCM-106 > URL: http://jira.codehaus.org/browse/SCM-106 > Project: Maven SCM > Type: Bug > Components: maven-scm-api > Reporter: Dennis Lundberg > Attachments: SCM-106.patch > > > I am trying out Continuum and am tracking down the cause of why I get an > error regarding the scm url that I provide when adding an ant project. This > has led me here. I copied the scm url from my maven 1 project.xml and got a > very breif error message telling me to enter a valid scm url. > My scm url looks like this: > scm|cvs|pserver|[EMAIL PROTECTED]|C:/Program/cvsnt/repositories|project-name > This works just fine using maven 1. > These two files are involved in this: > maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java > maven-scm-site/src/site/apt/cvs.apt > AbstractScmManager.java has the following error message declared: > private final static String ILLEGAL_SCM_URL = "The scm url must be on the > form " > + "'scm: provider>' " > + "where can be > either ':' or '|'."; > which explains how a correct scm url should look. > cvs.apt on the other hand does not have this explanation. It does say: > For all URLs below, we use a colon (:) as separator. If you use a colon for > one of the variables (e.g. a windows path), then use a pipe (|) as separator. > Then follows a bunch of examples, none of which use pipe (|) as a separator. > So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven > scm flags my scm url as invalid, but the docs for the urls are not really > clear about what a delimiter/separator is and where they are in the scm url. > Asuming that the source code is correct, the the docs need updating to > reflect this. There should also be an example using pipe as a separator. If > someone can confirm this I can write a patch for the docs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SCM-112) Broken links to mail-archives
Broken links to mail-archives - Key: SCM-112 URL: http://jira.codehaus.org/browse/SCM-112 Project: Maven SCM Type: Bug Reporter: Dennis Lundberg Priority: Minor Attachments: mail-archive.patch The links to the mail-archives are broken. I've attached a patch that fixes this in the master pom.xml. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-106) Validation of scm url fails because of ambiquities between source code and site documentation
[ http://jira.codehaus.org/browse/SCM-106?page=comments#action_53320 ] Dennis Lundberg commented on SCM-106: - A patch for the code is in the works. I thought that I would write a testcase for it as well, but am having trouble finding a good home for it. The class I really want to test is AbstractScmManager which is in maven-scm-api, but since that class is abstract I thought that I would test DefaultScmManager in maven-scm-managers. So I put my testcase there. The method validateScmRepository( String ) in AbstractScmManager makes use of providers which in turn are found in maven-scm-provider. But maven-scm-managers does not have a dependency on maven-scm-provider, so I'm stuck! The tests that should pass, fails because no providers can be found... Should I just drop the whole testcase and just attach a patch for the source code and documentation? > Validation of scm url fails because of ambiquities between source code and > site documentation > - > > Key: SCM-106 > URL: http://jira.codehaus.org/browse/SCM-106 > Project: Maven SCM > Type: Bug > Components: maven-scm-api > Reporter: Dennis Lundberg > > > I am trying out Continuum and am tracking down the cause of why I get an > error regarding the scm url that I provide when adding an ant project. This > has led me here. I copied the scm url from my maven 1 project.xml and got a > very breif error message telling me to enter a valid scm url. > My scm url looks like this: > scm|cvs|pserver|[EMAIL PROTECTED]|C:/Program/cvsnt/repositories|project-name > This works just fine using maven 1. > These two files are involved in this: > maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java > maven-scm-site/src/site/apt/cvs.apt > AbstractScmManager.java has the following error message declared: > private final static String ILLEGAL_SCM_URL = "The scm url must be on the > form " > + "'scm: provider>' " > + "where can be > either ':' or '|'."; > which explains how a correct scm url should look. > cvs.apt on the other hand does not have this explanation. It does say: > For all URLs below, we use a colon (:) as separator. If you use a colon for > one of the variables (e.g. a windows path), then use a pipe (|) as separator. > Then follows a bunch of examples, none of which use pipe (|) as a separator. > So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven > scm flags my scm url as invalid, but the docs for the urls are not really > clear about what a delimiter/separator is and where they are in the scm url. > Asuming that the source code is correct, the the docs need updating to > reflect this. There should also be an example using pipe as a separator. If > someone can confirm this I can write a patch for the docs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SCM-106) Validation of scm url fails because of ambiquities between source code and site documentation
Validation of scm url fails because of ambiquities between source code and site documentation - Key: SCM-106 URL: http://jira.codehaus.org/browse/SCM-106 Project: Maven SCM Type: Bug Components: maven-scm-api Reporter: Dennis Lundberg I am trying out Continuum and am tracking down the cause of why I get an error regarding the scm url that I provide when adding an ant project. This has led me here. I copied the scm url from my maven 1 project.xml and got a very breif error message telling me to enter a valid scm url. My scm url looks like this: scm|cvs|pserver|[EMAIL PROTECTED]|C:/Program/cvsnt/repositories|project-name This works just fine using maven 1. These two files are involved in this: maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java maven-scm-site/src/site/apt/cvs.apt AbstractScmManager.java has the following error message declared: private final static String ILLEGAL_SCM_URL = "The scm url must be on the form " + "'scm:' " + "where can be either ':' or '|'."; which explains how a correct scm url should look. cvs.apt on the other hand does not have this explanation. It does say: For all URLs below, we use a colon (:) as separator. If you use a colon for one of the variables (e.g. a windows path), then use a pipe (|) as separator. Then follows a bunch of examples, none of which use pipe (|) as a separator. So to conclude: Continuum uses validateScmRepository(String scmUrl) and maven scm flags my scm url as invalid, but the docs for the urls are not really clear about what a delimiter/separator is and where they are in the scm url. Asuming that the source code is correct, the the docs need updating to reflect this. There should also be an example using pipe as a separator. If someone can confirm this I can write a patch for the docs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
