hg: jdk7/tl/jdk: 2 new changesets
Changeset: f9dbb7d2e8a3 Author:michaelm Date: 2010-11-17 14:29 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f9dbb7d2e8a3 6725892: Http server stability issues Reviewed-by: chegar ! src/share/classes/com/sun/net/httpserver/HttpsConfigurator.java ! src/share/classes/com/sun/net/httpserver/HttpsParameters.java ! src/share/classes/sun/net/httpserver/ChunkedInputStream.java ! src/share/classes/sun/net/httpserver/Event.java ! src/share/classes/sun/net/httpserver/ExchangeImpl.java ! src/share/classes/sun/net/httpserver/FixedLengthInputStream.java ! src/share/classes/sun/net/httpserver/HttpConnection.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/SSLStreams.java - src/share/classes/sun/net/httpserver/SelectorCache.java ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/net/httpserver/ServerImpl.java ! test/com/sun/net/httpserver/Test.java ! test/com/sun/net/httpserver/Test1.java ! test/com/sun/net/httpserver/Test13.java + test/com/sun/net/httpserver/bugs/6725892/Test.java ! test/com/sun/net/httpserver/bugs/B6401598.java Changeset: 664b35adabd2 Author:michaelm Date: 2010-11-17 14:32 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/664b35adabd2 Merge
Re: 6995424 Code Review Request
On 11/17/2010 02:34 PM, Mandy Chung wrote: Hi Sean, On 11/16/10 5:56 AM, Sean Mullan wrote: http://cr.openjdk.java.net/~mullan/6995424/webrev.00/ Policy.java: I was initially confused with the meaning of 'compatPolicy'. I thought that when 'compatPolicy' is set to true, it means that the deprecated javax.security.auth.Policy class or the legacy com.sun.security.auth.PolicyFile is used for backward compatibility support. It turns out that it's the reverse as it's set in line 241 and 295. Should it be renamed to 'useStandardPolicy' to make it clear? I agree it is confusing but since that was the prior name I left it alone. What we are trying to find out is if the application is using a *custom* (one they wrote themselves and not com.sun.security.auth.PolicyFile) JAAS policy provider. The flag essentially means: if true, provide backwards compatibility for a deprecated, custom JAAS policy provider. I am open to changing the name but didn't feel that it was strictly necessary because I am not changing the meaning of it. However, in line 273, javax.security.auth.Policy.setPolicy sets compatPolicy to true. Is the given Policy object a javax.security.auth.Policy object? Should it set it to false? No, if someone invokes Policy.setPolicy then they are using a custom JAAS policy provider. Probably I'm missing something here: 276 // maintain backwards compatibility for people who provide 277 // their own javax.security.auth.Policy implementations It would help if some comments are added to explain further. Ok, let me add some comments and send another webrev. --Sean
Re: 6995424 Code Review Request
On 11/17/10 12:41 PM, Sean Mullan wrote: On 11/17/2010 02:34 PM, Mandy Chung wrote: Hi Sean, On 11/16/10 5:56 AM, Sean Mullan wrote: http://cr.openjdk.java.net/~mullan/6995424/webrev.00/ Policy.java: I was initially confused with the meaning of 'compatPolicy'. I thought that when 'compatPolicy' is set to true, it means that the deprecated javax.security.auth.Policy class or the legacy com.sun.security.auth.PolicyFile is used for backward compatibility support. It turns out that it's the reverse as it's set in line 241 and 295. Should it be renamed to 'useStandardPolicy' to make it clear? I agree it is confusing but since that was the prior name I left it alone. What we are trying to find out is if the application is using a *custom* (one they wrote themselves and not com.sun.security.auth.PolicyFile) JAAS policy provider. The flag essentially means: if true, provide backwards compatibility for a deprecated, custom JAAS policy provider. This helps. Thanks. I am open to changing the name but didn't feel that it was strictly necessary because I am not changing the meaning of it. how about isCustomProvider? Your comment above describing the flag already explains it's for backward compatibility. Mandy
hg: jdk7/tl/langtools: 7000973: isBogus needs to be called on the to-be-returned entry, not on the current entry
Changeset: abaceae7c9f8 Author:jjg Date: 2010-11-17 15:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/abaceae7c9f8 7000973: isBogus needs to be called on the to-be-returned entry, not on the current entry Reviewed-by: jjg Contributed-by: jan.lah...@oracle.com ! src/share/classes/com/sun/tools/javac/code/Scope.java
hg: jdk7/tl/jdk: 6615506: (fmt spec) Date/Time conversion table missing column for 'Z'
Changeset: 59d10b97be7c Author:sherman Date: 2010-11-17 15:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59d10b97be7c 6615506: (fmt spec) Date/Time conversion table missing column for 'Z' Summary: added the column entry back in Reviewed-by: alanb ! src/share/classes/java/util/Formatter.java
Code Review Request 6203816 and 6720456
Hi, Max, Can you please help reviewing the following two regression test fixes? 6203816: Can not run test/java/security/Security/ClassLoaderDeadlock.sh from the command line Webrev: http://cr.openjdk.java.net/~valeriep/6203816/webrev.00/ I noticed that Deadlock2.sh would fail when the TESTJAVA env variable is set to a JDK instead of a JRE. So, I fixed it here as well. 6720456: New 4150 may have larger blowfish keysizes Webrev: http://cr.openjdk.java.net/~valeriep/6720456/webrev.00/ Thanks, Valerie
Code Review Request for 6604496: Support for CKM_AES_CTR (counter mode)
Vinnie, Can you please help reviewing the following fix for supporting AES with CTR mode? 6604496: Support for CKM_AES_CTR (counter mode) Webrev: http://cr.openjdk.java.net/~valeriep/6604496/webrev.00/ Thanks, Valerie
Re: Code Review Request 6203816 and 6720456
On 11/18/2010 07:31 AM, Valerie (Yu-Ching) Peng wrote: Hi, Max, Can you please help reviewing the following two regression test fixes? 6203816: Can not run test/java/security/Security/ClassLoaderDeadlock.sh from the command line Webrev: http://cr.openjdk.java.net/~valeriep/6203816/webrev.00/ Fix looks fine. I noticed that Deadlock2.sh would fail when the TESTJAVA env variable is set to a JDK instead of a JRE. So, I fixed it here as well. 6720456: New 4150 may have larger blowfish keysizes Webrev: http://cr.openjdk.java.net/~valeriep/6720456/webrev.00/ Haven't looked into the base class PKCS11Test yet, so TBD means you don't care if it succeed or fails? I guess if a bitsize is not supported, the exception should be different and you can detect it and mark PASS? Thanks Max Thanks, Valerie
Re: Code Review Request 6203816 and 6720456
Thanks for the lightning fast review! TBD means to be determined at runtime. Different machines w/ different versions of Solaris may support different key sizes. So, I use TBD to indicate the key sizes which may only be supported by the newer versions of Solairs release. I thought you are on vacation? If not, there are some new PKCS11 test failures which seems related to your resource string changes. I'll take a shot at them if you are on vacation... Valerie On 11/17/10 17:00, Weijun Wang wrote: On 11/18/2010 07:31 AM, Valerie (Yu-Ching) Peng wrote: Hi, Max, Can you please help reviewing the following two regression test fixes? 6203816: Can not run test/java/security/Security/ClassLoaderDeadlock.sh from the command line Webrev: http://cr.openjdk.java.net/~valeriep/6203816/webrev.00/ Fix looks fine. I noticed that Deadlock2.sh would fail when the TESTJAVA env variable is set to a JDK instead of a JRE. So, I fixed it here as well. 6720456: New 4150 may have larger blowfish keysizes Webrev: http://cr.openjdk.java.net/~valeriep/6720456/webrev.00/ Haven't looked into the base class PKCS11Test yet, so TBD means you don't care if it succeed or fails? I guess if a bitsize is not supported, the exception should be different and you can detect it and mark PASS? Thanks Max Thanks, Valerie
hg: jdk7/tl/jdk: 6217210: RFE: Support for Cp833 in 1.4.2
Changeset: ce757906302f Author:sherman Date: 2010-11-17 21:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ce757906302f 6217210: RFE: Support for Cp833 in 1.4.2 Summary: Forward port the Cp833 charset Reviewed-by: poonam ! make/sun/nio/cs/FILES_java.gmk + make/tools/CharsetMapping/IBM833.c2b + make/tools/CharsetMapping/IBM833.map ! make/tools/CharsetMapping/extsbcs + src/share/classes/sun/io/ByteToCharCp833.java + src/share/classes/sun/io/CharToByteCp833.java ! src/share/classes/sun/io/CharacterEncoding.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! test/sun/nio/cs/CheckHistoricalNames.java
