Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Pengvalerie.p...@oracle.com wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Ok, thanks! Valerie On 8/18/2015 12:34 AM, Erik Joelsson wrote: One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Pengvalerie.p...@oracle.com wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Build changes still look good. /Erik On 2015-08-15 01:30, Valerie Peng wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Pengvalerie.p...@oracle.com wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Build changes look good. /Erik On 2015-08-14 04:31, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Couple of minor comments on ProviderConfig.java 183: you can use the diamond operator for anonymous classes now (PrivilegedAction). You could also use a lambda expression here but I'll leave that up to you. 193: the braces around if (debug != null) are not indented properly Looks fine otherwise. --Sean On 08/13/2015 10:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
On Aug 13, 2015, at 7:31 PM, Valerie Peng valerie.p...@oracle.com wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks for doing this. jdk.deploy.osx is temporary home for Apple security provider and a couple of MacOSX specific stuff. The change looks good in general. Identation in line 193-200 in ProviderConfig.java needs fixing, as Sean pointed out. As we discussed offline, we should rename the library name to reflect what it’s. A couple of suggestions: libosxkeychain, libosxcrypto, or libosxsec etc. We could go with libosxkeychain for now and rename it in the future for new feature, if any. Mandy
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Peng valerie.p...@oracle.com wrote: Updated the webrev in place to use osxsecurity given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
[9] RFR 8086002: Move apple.security.AppleProvider to a proper module
Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the osx one generated in jdk.deploy.osx module and named osxapple (sort of following the convention of SunMSCAPI provider whose native library is named sunmscapi). webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/ Thanks, Valerie
