Re: RFR: 8218553: Enhance keystore load debug output
On 06/02/2019 16:24, Weijun Wang wrote: Hi Séan, Change looks fine. I usually think there is no need to provide data in the debug output that were already available from public APIs (i.e. they are not something that can only be revealed from "internally"), but these numbers could help a supporter engineer to quickly find out if there is some really simple error in a customer's environment. So, good to have them. And I definitely believe you know better that I what a support engineer needs. Thanks for review. Yes - use of APIs to retrieve such data is not an option when someone is trying to debug a live production issue. I think this will help admins to confirm if keystore configuration looks correct in such environments. regards, Sean. Thanks, Max On Feb 6, 2019, at 11:32 PM, Seán Coffey wrote: Looking to improve debug output in the keystore area. It's useful to know how many keys/certs are found in such stores to ensure correct set up. https://bugs.openjdk.java.net/browse/JDK-8218553 http://cr.openjdk.java.net/~coffeys/webrev.8218553/webrev/ -- Regards, Sean.
Re: RFR: 8218553: Enhance keystore load debug output
Hi Séan, Change looks fine. I usually think there is no need to provide data in the debug output that were already available from public APIs (i.e. they are not something that can only be revealed from "internally"), but these numbers could help a supporter engineer to quickly find out if there is some really simple error in a customer's environment. So, good to have them. And I definitely believe you know better that I what a support engineer needs. Thanks, Max > On Feb 6, 2019, at 11:32 PM, Seán Coffey wrote: > > Looking to improve debug output in the keystore area. > > It's useful to know how many keys/certs are found in such stores > to ensure correct set up. > > https://bugs.openjdk.java.net/browse/JDK-8218553 > http://cr.openjdk.java.net/~coffeys/webrev.8218553/webrev/ > > -- > Regards, > Sean. >
RFR: 8218553: Enhance keystore load debug output
Looking to improve debug output in the keystore area. It's useful to know how many keys/certs are found in such stores to ensure correct set up. https://bugs.openjdk.java.net/browse/JDK-8218553 http://cr.openjdk.java.net/~coffeys/webrev.8218553/webrev/ -- Regards, Sean.
