Re: RFR: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs [v2]
On Wed, 29 Sep 2021 18:13:14 GMT, Joe Darcy wrote: >> Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various security libraries would >> need some changes to pass under the expanded checks. >> >> The changes are to suppress warnings where non-transient fields in >> serializable types are not declared with a type statically known to be >> serializable. That isn't necessarily a correctness issues, but it does merit >> further scrutiny. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Add explanatory comments for SuppressWarnings annotations. > - Merge branch 'master' into JDK-8274393 > - 8274393: Suppress more warnings on non-serializable non-transient instance > fields in security libs Looks fine. - Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5720
Re: RFR: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs [v2]
> Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial > checking are out for review (#5709) and various security libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Add explanatory comments for SuppressWarnings annotations. - Merge branch 'master' into JDK-8274393 - 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs - Changes: - all: https://git.openjdk.java.net/jdk/pull/5720/files - new: https://git.openjdk.java.net/jdk/pull/5720/files/5d95dea7..08718270 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5720&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5720&range=00-01 Stats: 4821 lines in 185 files changed: 3414 ins; 967 del; 440 mod Patch: https://git.openjdk.java.net/jdk/pull/5720.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5720/head:pull/5720 PR: https://git.openjdk.java.net/jdk/pull/5720
Re: RFR: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs [v2]
On Wed, 29 Sep 2021 18:13:14 GMT, Joe Darcy wrote: >> Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various security libraries would >> need some changes to pass under the expanded checks. >> >> The changes are to suppress warnings where non-transient fields in >> serializable types are not declared with a type statically known to be >> serializable. That isn't necessarily a correctness issues, but it does merit >> further scrutiny. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Add explanatory comments for SuppressWarnings annotations. > - Merge branch 'master' into JDK-8274393 > - 8274393: Suppress more warnings on non-serializable non-transient instance > fields in security libs I added explanatory comments alongside the SuppressWarnings annotations to explain their presence. - PR: https://git.openjdk.java.net/jdk/pull/5720
