Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v9]
On Tue, 17 May 2022 23:11:06 GMT, Weijun Wang wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more minor cleanups for consistencies. > > src/java.base/share/classes/java/security/SignatureSpi.java line 377: > >> 375: * >> 376: * This method is overridden by providers to initialize >> 377: * this signature object with the specified parameter set. > > 1st paragraph: values, 2nd: set. Make them the same. Will also remove the second sentence here. Thanks. > src/java.base/share/classes/java/security/SignatureSpi.java line 397: > >> 395: * >> 396: * This method is overridden by providers to return the >> parameters >> 397: * used with this signature object. > > The 2 paragraphs above look the same. Of course, if you believe the 1st > paragraph should always be a simple description, that's OK. Yes, I will remove the second sentence to match the javadoc of other methods. - PR: https://git.openjdk.java.net/jdk/pull/8396
Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v9]
On Tue, 17 May 2022 22:22:36 GMT, Valerie Peng wrote: >> This is to update the method javadoc of >> java.security.Signature.getParameters() with the missing `@throws >> UnsupportedOperationException`. In addition, the wording on the returned >> parameters are updated to match those in Cipher and CipherSpi classes. >> >> CSR will be filed later. >> >> Thanks, >> Valerie > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > more minor cleanups for consistencies. src/java.base/share/classes/java/security/SignatureSpi.java line 377: > 375: * > 376: * This method is overridden by providers to initialize > 377: * this signature object with the specified parameter set. 1st paragraph: values, 2nd: set. Make them the same. src/java.base/share/classes/java/security/SignatureSpi.java line 397: > 395: * > 396: * This method is overridden by providers to return the parameters > 397: * used with this signature object. The 2 paragraphs above look the same. Of course, if you believe the 1st paragraph should always be a simple description, that's OK. - PR: https://git.openjdk.java.net/jdk/pull/8396
Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v9]
> This is to update the method javadoc of > java.security.Signature.getParameters() with the missing `@throws > UnsupportedOperationException`. In addition, the wording on the returned > parameters are updated to match those in Cipher and CipherSpi classes. > > CSR will be filed later. > > Thanks, > Valerie Valerie Peng has updated the pull request incrementally with one additional commit since the last revision: more minor cleanups for consistencies. - Changes: - all: https://git.openjdk.java.net/jdk/pull/8396/files - new: https://git.openjdk.java.net/jdk/pull/8396/files/94a584bc..681a5bc4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8396=08 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8396=07-08 Stats: 43 lines in 2 files changed: 4 ins; 0 del; 39 mod Patch: https://git.openjdk.java.net/jdk/pull/8396.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8396/head:pull/8396 PR: https://git.openjdk.java.net/jdk/pull/8396
