On Tue, 17 May 2022 23:11:06 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more minor cleanups for consistencies. > > src/java.base/share/classes/java/security/SignatureSpi.java line 377: > >> 375: * >> 376: * <p>This method is overridden by providers to initialize >> 377: * this signature object with the specified parameter set. > > 1st paragraph: values, 2nd: set. Make them the same. Will also remove the second sentence here. Thanks. > src/java.base/share/classes/java/security/SignatureSpi.java line 397: > >> 395: * >> 396: * <p>This method is overridden by providers to return the >> parameters >> 397: * used with this signature object. > > The 2 paragraphs above look the same. Of course, if you believe the 1st > paragraph should always be a simple description, that's OK. Yes, I will remove the second sentence to match the javadoc of other methods. ------------- PR: https://git.openjdk.java.net/jdk/pull/8396
