Re: Should Sequel continue shipping tests in the gem?

[Jeremy Evans]

On Saturday, January 18, 2020 at 11:27:50 AM UTC-8, Jeremy Evans wrote:
>
> Sequel has always shipped tests in the gem, so that users and packagers 
> can test it without cloning the repository, but it does make the gem 
> significantly larger.  I'm open to feedback on whether Sequel should 
> continue to do this, so if you feel strongly one way or the other, please 
> respond.
>

Looks like a few people are in favor and nobody stated opposition, so I'm 
going to make this change.  I will not be made in tomorrow's 5.29.0 
release, but probably starting in 5.30.0.

Thanks,
Jeremy

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sequel-talk/6eb9c60f-7f27-45b7-9c52-0ddb67e828d9%40googlegroups.com.

Re: Should Sequel continue shipping tests in the gem?

[Adam Daniels]

No strong feelings either way; when I run Sequel tests I'm normally 
authoring a patch, which means I have the git repository anyways. I have to 
wonder how frequently the tests in the gem are being run tho.

That said, I can imagine the tests in something with a C extension (such as 
sequel_pg) being more valuable shipping inside the gem, as that's more 
frequently where I seem to run into edge cases. C extensions with 
Linuxism's not building on FreeBSD. Not directly applicable to sequel 
itself obviously, but might affect things since sequel_pg piggybacks on 
sequel tests.

On Saturday, January 18, 2020 at 2:27:50 PM UTC-5, Jeremy Evans wrote:
>
> Sequel has always shipped tests in the gem, so that users and packagers 
> can test it without cloning the repository, but it does make the gem 
> significantly larger.  I'm open to feedback on whether Sequel should 
> continue to do this, so if you feel strongly one way or the other, please 
> respond.
>
> Thanks,
> Jeremy
>

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sequel-talk/e3822936-097d-464b-86da-5c88f7bc0c01%40googlegroups.com.

Re: Should Sequel continue shipping tests in the gem?

[abhijit nandy]

I've never run the Sequel tests, so I'm fine with them not being included
in the gem. The source can anyway be downloaded if testing is to be done.
 - Abhijit.


On Sun, Jan 19, 2020 at 12:57 AM Jeremy Evans 
wrote:

> Sequel has always shipped tests in the gem, so that users and packagers
> can test it without cloning the repository, but it does make the gem
> significantly larger.  I'm open to feedback on whether Sequel should
> continue to do this, so if you feel strongly one way or the other, please
> respond.
>
> Thanks,
> Jeremy
>
> --
> You received this message because you are subscribed to the Google Groups
> "sequel-talk" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sequel-talk+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sequel-talk/700971c1-78e9-4fce-a857-960c06318a47%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sequel-talk/CA%2BgkkgPc5WF_SwPydaHOfCK_30vQ7QdRseYbT5jrafdd5XPnsA%40mail.gmail.com.

Re: Should Sequel continue shipping tests in the gem?

[Marcelo Pereira]

I would guess most of the time users are not running Sequel tests and, if 
one wants to run them, it's simple enough to clone the repository - so I 
would say not shipping the tests sounds like a good idea. No strong 
opinions on this one, though - having the tests in the gem is, of course, 
not a big issue, and I will keep using Sequel either way.

On Saturday, January 18, 2020 at 8:27:50 PM UTC+1, Jeremy Evans wrote:
>
> Sequel has always shipped tests in the gem, so that users and packagers 
> can test it without cloning the repository, but it does make the gem 
> significantly larger.  I'm open to feedback on whether Sequel should 
> continue to do this, so if you feel strongly one way or the other, please 
> respond.
>
> Thanks,
> Jeremy
>

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sequel-talk/0a08bedf-4570-47d2-8ea5-323df84aeddc%40googlegroups.com.

Should Sequel continue shipping tests in the gem?

[Jeremy Evans]

Sequel has always shipped tests in the gem, so that users and packagers can 
test it without cloning the repository, but it does make the gem 
significantly larger.  I'm open to feedback on whether Sequel should 
continue to do this, so if you feel strongly one way or the other, please 
respond.

Thanks,
Jeremy

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sequel-talk/700971c1-78e9-4fce-a857-960c06318a47%40googlegroups.com.