[jira] Created: (JAMES-559) Message body get lost after call saveChanges() and move to other processor

2006-07-09 Thread Norman Maurer (JIRA)
Message body get lost after call saveChanges() and move to other processor
--

 Key: JAMES-559
 URL: http://issues.apache.org/jira/browse/JAMES-559
 Project: James
Type: Bug

Versions: 3.0, 2.3.0b2
Reporter: Norman Maurer
Priority: Blocker
 Fix For: 3.0, 2.3.0b2


After call saveChanges() in a mailet and move the mail to a other processor 
with ToProcessor the whole messageBody getting lost.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Blocking defect for JAMES v2.3

2006-07-09 Thread Stefano Bagnara

Norman Maurer wrote:

So the problem only appears after call saveChanges() in a mailet and
move it to a other processor ? That whould explain why i not notice it
on our Server ..
Someone wrote a junit test for this so far? 


I'm working on it but I cannot reproduce it using a mock environment yet.

Stefano


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Testing for production [was: Re: Blocking defect for JAMES v2.3]

2006-07-09 Thread Bernd Fondermann

Norman Maurer wrote:

Am Sonntag, den 09.07.2006, 12:25 +0200 schrieb Bernd Fondermann:


Noel J. Bergman wrote:

Bernd, we should have some round-trip testing that would detect this sort of
problem.  :-)


What Postage today is already helpful at is building a clean room 
environment. All mail is kept within. This is good for debugging or 
staging to production.


It's not satisfying to see debugging going on on production systems.

What Postage does not support is provide means to inspect its received 
emails. I take this as a todo. We would probably want to check headers, 
sizes etc.
Until we have that I'd recommend to attach the debugger of your choice 
to James (or Postage) to see what's happening.


  Bernd



IMHO such a debugging should be better done with JUNIT tests...
Postage is great for performance tests etc.. 


Agreed, a unit test would be the best and most lightweight tool to 
reproduce and resolve this issue and make sure it does not appear again.


A unit test only focusses one specific class (or small group of classes).

If you want to do end-to-end tests for actually testing your 
fully-fledged production server you can no longer rely on your unit tests.


From my experience, the best way to work with a new release would be:
1. Clone production system into test/staging system
2. Change it as slightly as possible into a 'clean-room'.
3. Deploy new James into test system
4. Generate production-like load
5. Run tests
6. no bug: deploy to production
7. Detect and narrow bug
8. Write unit test reproducing the bug
9. Resolve, test, build. goto 3.

  Bernd

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JAMES-559) Message body get lost after call saveChanges() and move to other processor

2006-07-09 Thread Norman Maurer (JIRA)
[ 
http://issues.apache.org/jira/browse/JAMES-559?page=comments#action_12419903 ] 

Norman Maurer commented on JAMES-559:
-

After more testing it seems that the problem appears only with file repos. I 
tested it also with db and dbfile. No problem ..


 Message body get lost after call saveChanges() and move to other processor
 --

  Key: JAMES-559
  URL: http://issues.apache.org/jira/browse/JAMES-559
  Project: James
 Type: Bug

 Versions: 3.0, 2.3.0b2
 Reporter: Norman Maurer
 Priority: Blocker
  Fix For: 3.0, 2.3.0b2


 After call saveChanges() in a mailet and move the mail to a other processor 
 with ToProcessor the whole messageBody getting lost.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (JAMES-560) SetMimeHeader not throw an MessagingException if needed config values missed

2006-07-09 Thread Norman Maurer (JIRA)
SetMimeHeader not throw an MessagingException if needed config values missed


 Key: JAMES-560
 URL: http://issues.apache.org/jira/browse/JAMES-560
 Project: James
Type: Bug

  Components: Matchers/Mailets (bundled)  
Reporter: Norman Maurer
 Assigned to: Norman Maurer 
 Fix For: 3.0, 2.3.0


SetMimeHeader not throw an Exception if needed config values missed

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r420289 - /james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/SetMimeHeader.java

2006-07-09 Thread norman
Author: norman
Date: Sun Jul  9 06:02:12 2006
New Revision: 420289

URL: http://svn.apache.org/viewvc?rev=420289view=rev
Log:
Throw MessagingException if needed config values missed. See JAMES-560

Modified:

james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/SetMimeHeader.java

Modified: 
james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/SetMimeHeader.java
URL: 
http://svn.apache.org/viewvc/james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/SetMimeHeader.java?rev=420289r1=420288r2=420289view=diff
==
--- 
james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/SetMimeHeader.java
 (original)
+++ 
james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/SetMimeHeader.java
 Sun Jul  9 06:02:12 2006
@@ -17,6 +17,7 @@
 
 package org.apache.james.transport.mailets;
 
+import javax.mail.MessagingException;
 import javax.mail.internet.MimeMessage ;
 
 import org.apache.mailet.GenericMailet ;
@@ -50,9 +51,15 @@
 /**
  * Initialize the mailet.
  */
-public void init() {
+public void init() throws MessagingException {
 headerName = getInitParameter(name);
 headerValue = getInitParameter(value);
+
+// Check if needed config values are used
+if (headerName == null || headerName.equals() || headerValue == null
+|| headerValue.equals()) {
+throw new MessagingException(Please configure a name and a 
value);
+}
 }
 
 /**



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (JAMES-561) User aliasing does not work

2006-07-09 Thread Vincenzo Gianferrari Pini (JIRA)
User aliasing does not work
---

 Key: JAMES-561
 URL: http://issues.apache.org/jira/browse/JAMES-561
 Project: James
Type: Bug

  Components: Matchers/Mailets (bundled)  
Versions: 3.0, 2.3.0b2
Reporter: Vincenzo Gianferrari Pini
Priority: Blocker


If user A is an alias of user B ( or viceversa - remote manager help is 
misleading) messages sent to A have to go (and were going) to B's inbox. Now it 
ends in A's inbox, that should not even exist.
The problem has been found by me using both file and db repositories under 
2.3.0b2, but I expect it to occur also under 3.0.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Blocking defect for JAMES v2.3

2006-07-09 Thread Noel J. Bergman
Stefano Bagnara wrote:

 I'm working on it but I cannot reproduce it using a mock environment yet.

See the below.  All I did was telnet into JAMES and post a sample message,
and in the root processor I used SetMimeHeader.

--- Noel


Index: src/java/org/apache/james/mailrepository/AvalonMailRepository.java
===
--- src/java/org/apache/james/mailrepository/AvalonMailRepository.java
(revision 420194)
+++ src/java/org/apache/james/mailrepository/AvalonMailRepository.java
(working copy)
@@ -236,6 +236,15 @@
 }
 }

+private void logMessage(Mail mc, String label) throws
java.io.IOException, MessagingException {
+// NjB
+System.out.println( AMR: store( + destination +
) ---);
+System.out.println(  + label + ) );
+mc.getMessage().writeTo(System.out);
+System.out.println(-);
+// NjB
+}
+
 /**
  * Stores a message in this repository. Shouldn't this return the key
  * under which it is stored?
@@ -296,8 +305,11 @@
 if (saveStream) {
 OutputStream out = null;
 try {
+logMessage(mc, mark 4);
 out = sr.put(key);
+logMessage(mc, mark 5);
 mc.getMessage().writeTo(out);
+logMessage(mc, mark 6);
 } finally {
 if (out != null) out.close();
 }






 AMR: store(file://var/mail/spool/) ---
 mark 4) 
Return-Path: null
Received: from localhost.localdomain ([127.0.0.1])
  by localhost.localdomain (JAMES SMTP Server 2.3.0b2) with SMTP ID
254
  for [EMAIL PROTECTED];
  Sun, 9 Jul 2006 00:51:17 -0400 (EDT)
Date: Now
Subject: Binary search?
To: Me
From: Me
X-MailetHeader: TheHeaderValue
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Message-ID: [EMAIL PROTECTED]

Help me!

Please.  :-)

-
 AMR: store(file://var/mail/spool/) ---
 mark 5) 
Return-Path: null
Received: from localhost.localdomain ([127.0.0.1])
  by localhost.localdomain (JAMES SMTP Server 2.3.0b2) with SMTP ID
254
  for [EMAIL PROTECTED];
  Sun, 9 Jul 2006 00:51:17 -0400 (EDT)
Date: Now
Subject: Binary search?
To: Me
From: Me
X-MailetHeader: TheHeaderValue
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Message-ID: [EMAIL PROTECTED]

-
 AMR: store(file://var/mail/spool/) ---
 mark 6) 
Return-Path: null
Received: from localhost.localdomain ([127.0.0.1])
  by localhost.localdomain (JAMES SMTP Server 2.3.0b2) with SMTP ID
254
  for [EMAIL PROTECTED];
  Sun, 9 Jul 2006 00:51:17 -0400 (EDT)
Date: Now
Subject: Binary search?
To: Me
From: Me
X-MailetHeader: TheHeaderValue
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Message-ID: [EMAIL PROTECTED]

o: Me
From: Me
X-MailetHea-


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Testing for production [was: Re: Blocking defect for JAMESv2.3]

2006-07-09 Thread Noel J. Bergman
Norman Maurer wrote:

 IMHO such a debugging should be better done with JUNIT tests...
 Postage is great for performance tests etc..

JUNIT testing is not the same as an external test harness.  We should be
able to drive a test from SMTP connection through to POP3 or IMAP.  So
Postage could send a known message and test the results that it receives,
including testing for any expected changes (e.g., use of any
SetMimeHeaders).

Perhaps adding BSF (or JSR-223) support to Postage would be a good thing.
Postage providing core capabilities, and allowing scripting for tests.

--- Noel


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Testing for production [was: Re: Blocking defect for JAMES v2.3]

2006-07-09 Thread Noel J. Bergman
Bernd Fondermann wrote:

  Bernd, we should have some round-trip testing that would detect
  this sort of problem.  :-)

 What Postage today is already helpful at is building a clean room
 environment. All mail is kept within. This is good for debugging or
 staging to production.

I know. :-)

 It's not satisfying to see debugging going on on production systems.

No kidding!  :-)

 What Postage does not support is provide means to inspect its received
 emails. I take this as a todo. We would probably want to check headers,
 sizes etc.

Exactly.  That was the point of my aside to you.  And see my reply to Norman
for another thought (re: scripting).

--- Noel


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Blocking defect for JAMES v2.3

2006-07-09 Thread Noel J. Bergman
Norman Maurer wrote:

 So the problem only appears after call saveChanges() in a mailet and
 move it to a other processor ?

It appears to happen whenever you change a header and not the body.  A
defect in how we optimized message handling.

--- Noel


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JAMES-559) Message body get lost after call saveChanges() and move to other processor

2006-07-09 Thread Noel J. Bergman (JIRA)
[ 
http://issues.apache.org/jira/browse/JAMES-559?page=comments#action_12419912 ] 

Noel J. Bergman commented on JAMES-559:
---

This appears to be a side-effect of optimizing message handling.  Since the 
message is not in memory, we lose it when we call sr.put(key).  See below.

For v2.3, it might be best to revert behavior.  For later versions, perhaps the 
file support from Jakarta Commons Transactions 
(http://jakarta.apache.org/commons/transaction/file/index.html) will resolve it.

--- Noel

Index: src/java/org/apache/james/mailrepository/AvalonMailRepository.java
===
--- src/java/org/apache/james/mailrepository/AvalonMailRepository.java  
(revision 420194)
+++ src/java/org/apache/james/mailrepository/AvalonMailRepository.java  
(working copy)
@@ -236,6 +236,15 @@
 }
 }

+private void logMessage(Mail mc, String label) throws java.io.IOException, 
MessagingException {
+// NjB
+System.out.println( AMR: store( + destination + ) ---);
+System.out.println(  + label + ) );
+mc.getMessage().writeTo(System.out);
+System.out.println(-);
+// NjB
+}
+
 /**
  * Stores a message in this repository. Shouldn't this return the key
  * under which it is stored?
@@ -296,8 +305,11 @@
 if (saveStream) {
 OutputStream out = null;
 try {
+logMessage(mc, mark 4);
 out = sr.put(key);
+logMessage(mc, mark 5);
 mc.getMessage().writeTo(out);
+logMessage(mc, mark 6);
 } finally {
 if (out != null) out.close();
 }





 AMR: store(file://var/mail/spool/) ---
 mark 4) 
Return-Path: null
Received: from localhost.localdomain ([127.0.0.1])
  by localhost.localdomain (JAMES SMTP Server 2.3.0b2) with SMTP ID 254
  for [EMAIL PROTECTED];
  Sun, 9 Jul 2006 00:51:17 -0400 (EDT)
Date: Now
Subject: Binary search?
To: Me
From: Me
X-MailetHeader: TheHeaderValue
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Message-ID: [EMAIL PROTECTED]

Help me!

Please.  :-)

-
 AMR: store(file://var/mail/spool/) ---
 mark 5) 
Return-Path: null
Received: from localhost.localdomain ([127.0.0.1])
  by localhost.localdomain (JAMES SMTP Server 2.3.0b2) with SMTP ID 254
  for [EMAIL PROTECTED];
  Sun, 9 Jul 2006 00:51:17 -0400 (EDT)
Date: Now
Subject: Binary search?
To: Me
From: Me
X-MailetHeader: TheHeaderValue
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Message-ID: [EMAIL PROTECTED]

-
 AMR: store(file://var/mail/spool/) ---
 mark 6) 
Return-Path: null
Received: from localhost.localdomain ([127.0.0.1])
  by localhost.localdomain (JAMES SMTP Server 2.3.0b2) with SMTP ID 254
  for [EMAIL PROTECTED];
  Sun, 9 Jul 2006 00:51:17 -0400 (EDT)
Date: Now
Subject: Binary search?
To: Me
From: Me
X-MailetHeader: TheHeaderValue
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Message-ID: [EMAIL PROTECTED]

o: Me
From: Me
X-MailetHea-


 Message body get lost after call saveChanges() and move to other processor
 --

  Key: JAMES-559
  URL: http://issues.apache.org/jira/browse/JAMES-559
  Project: James
 Type: Bug

 Versions: 3.0, 2.3.0b2
 Reporter: Norman Maurer
 Priority: Blocker
  Fix For: 3.0, 2.3.0b2


 After call saveChanges() in a mailet and move the mail to a other processor 
 with ToProcessor the whole messageBody getting lost.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Testing for production [was: Re: Blocking defect for JAMESv2.3]

2006-07-09 Thread Bernd Fondermann

Noel J. Bergman wrote:


Perhaps adding BSF (or JSR-223) support to Postage would be a good thing.
Postage providing core capabilities, and allowing scripting for tests.


OK, good idea. I'd like to have standard tests, like checking headers, 
built into Postage directly and provide scripting for more complicated 
evaluations.


  Bernd

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Assigned: (JAMES-559) Message body get lost after call saveChanges() and move to other processor

2006-07-09 Thread Stefano Bagnara (JIRA)
 [ http://issues.apache.org/jira/browse/JAMES-559?page=all ]

Stefano Bagnara reassigned JAMES-559:
-

Assign To: Stefano Bagnara

 Message body get lost after call saveChanges() and move to other processor
 --

  Key: JAMES-559
  URL: http://issues.apache.org/jira/browse/JAMES-559
  Project: James
 Type: Bug

 Versions: 3.0, 2.3.0b2
 Reporter: Norman Maurer
 Assignee: Stefano Bagnara
 Priority: Blocker
  Fix For: 3.0, 2.3.0b2


 After call saveChanges() in a mailet and move the mail to a other processor 
 with ToProcessor the whole messageBody getting lost.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JAMES-561) User aliasing does not work

2006-07-09 Thread Norman Maurer (JIRA)
[ 
http://issues.apache.org/jira/browse/JAMES-561?page=comments#action_12419917 ] 

Norman Maurer commented on JAMES-561:
-

After some debug it seems that the UsersRepositoryAliasingForwarding Mailet get 
not called. No time now to investigate time on this now :-(

 User aliasing does not work
 ---

  Key: JAMES-561
  URL: http://issues.apache.org/jira/browse/JAMES-561
  Project: James
 Type: Bug

   Components: Matchers/Mailets (bundled)
 Versions: 3.0, 2.3.0b2
 Reporter: Vincenzo Gianferrari Pini
 Priority: Blocker


 If user A is an alias of user B ( or viceversa - remote manager help is 
 misleading) messages sent to A have to go (and were going) to B's inbox. Now 
 it ends in A's inbox, that should not even exist.
 The problem has been found by me using both file and db repositories 
 under 2.3.0b2, but I expect it to occur also under 3.0.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Assigned: (JAMES-561) User aliasing does not work

2006-07-09 Thread Norman Maurer (JIRA)
 [ http://issues.apache.org/jira/browse/JAMES-561?page=all ]

Norman Maurer reassigned JAMES-561:
---

Assign To: Norman Maurer

 User aliasing does not work
 ---

  Key: JAMES-561
  URL: http://issues.apache.org/jira/browse/JAMES-561
  Project: James
 Type: Bug

   Components: Matchers/Mailets (bundled)
 Versions: 3.0, 2.3.0b2
 Reporter: Vincenzo Gianferrari Pini
 Assignee: Norman Maurer
 Priority: Blocker


 If user A is an alias of user B ( or viceversa - remote manager help is 
 misleading) messages sent to A have to go (and were going) to B's inbox. Now 
 it ends in A's inbox, that should not even exist.
 The problem has been found by me using both file and db repositories 
 under 2.3.0b2, but I expect it to occur also under 3.0.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (JAMES-561) User aliasing does not work

2006-07-09 Thread Noel J. Bergman (JIRA)
[ 
http://issues.apache.org/jira/browse/JAMES-561?page=comments#action_12419928 ] 

Noel J. Bergman commented on JAMES-561:
---

Just to keep people following this in the loop, Norman observed on IM that The 
problem is that ((JamesUser) user).getAliasing() return false.

 User aliasing does not work
 ---

  Key: JAMES-561
  URL: http://issues.apache.org/jira/browse/JAMES-561
  Project: James
 Type: Bug

   Components: Matchers/Mailets (bundled)
 Versions: 3.0, 2.3.0b2
 Reporter: Vincenzo Gianferrari Pini
 Assignee: Norman Maurer
 Priority: Blocker


 If user A is an alias of user B ( or viceversa - remote manager help is 
 misleading) messages sent to A have to go (and were going) to B's inbox. Now 
 it ends in A's inbox, that should not even exist.
 The problem has been found by me using both file and db repositories 
 under 2.3.0b2, but I expect it to occur also under 3.0.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



(JAMES-561) User aliasing does not work

2006-07-09 Thread Noel J. Bergman
I just found and fixed it.  Unfortunately, I'm 30,000 feet in the air, but as 
soon as I land in LA this evening (about 4 hours from now), I'll commit the 
fix, unless someone has beaten me to it.

 Norman observed on IM that The problem is that
 ((JamesUser) user).getAliasing() return false.

Actually, no.  I tested for that, and it was working just fine.  The problem 
was elsewhere in the UserRepositoryAliasForwarding mailet.  One character.  
Just one missing character in the condition of an if statement.

--- Noel


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r420415 - /james/server/trunk/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java

2006-07-09 Thread noel
Author: noel
Date: Sun Jul  9 21:08:16 2006
New Revision: 420415

URL: http://svn.apache.org/viewvc?rev=420415view=rev
Log:
Fix JAMES-561.  Check was comparing for the name being EQUAL instead of NOT 
EQUAL (changed)

Modified:

james/server/trunk/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java

Modified: 
james/server/trunk/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java
URL: 
http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java?rev=420415r1=420414r2=420415view=diff
==
--- 
james/server/trunk/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java
 (original)
+++ 
james/server/trunk/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java
 Sun Jul  9 21:08:16 2006
@@ -112,7 +112,7 @@
 // remaining recipients
 if (username == null) {
 i.remove();
-} else if (username.equals(recipient.getUser())) {
+} else if (!username.equals(recipient.getUser())) {
 i.remove();
 // if the username has been changed we add a new recipient
 // with the new name.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r420416 - /james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java

2006-07-09 Thread noel
Author: noel
Date: Sun Jul  9 21:10:37 2006
New Revision: 420416

URL: http://svn.apache.org/viewvc?rev=420416view=rev
Log:
Remove in order to copy replacement from trunk

Removed:

james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r420417 - /james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java

2006-07-09 Thread noel
Author: noel
Date: Sun Jul  9 21:13:36 2006
New Revision: 420417

URL: http://svn.apache.org/viewvc?rev=420417view=rev
Log:
Copy fix for JAMES-561 from trunk.

Added:

james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java
  - copied unchanged from r420416, 
james/server/trunk/src/java/org/apache/james/transport/mailets/UsersRepositoryAliasingForwarding.java


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Resolved: (JAMES-561) User aliasing does not work

2006-07-09 Thread Noel J. Bergman (JIRA)
 [ http://issues.apache.org/jira/browse/JAMES-561?page=all ]
 
Noel J. Bergman resolved JAMES-561:
---

Fix Version: 2.3.0
 3.0
 Resolution: Fixed

Committed fix to both trunk and v2.3 branch.  The check for an aliased name had 
the wrong polarity.

 User aliasing does not work
 ---

  Key: JAMES-561
  URL: http://issues.apache.org/jira/browse/JAMES-561
  Project: James
 Type: Bug

   Components: Matchers/Mailets (bundled)
 Versions: 2.3.0b2, 3.0
 Reporter: Vincenzo Gianferrari Pini
 Assignee: Norman Maurer
 Priority: Blocker
  Fix For: 3.0, 2.3.0


 If user A is an alias of user B ( or viceversa - remote manager help is 
 misleading) messages sent to A have to go (and were going) to B's inbox. Now 
 it ends in A's inbox, that should not even exist.
 The problem has been found by me using both file and db repositories 
 under 2.3.0b2, but I expect it to occur also under 3.0.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]