Re: [VOTE] Release Apache James Server 3.0-beta1 (second try)
On Thu, Jun 9, 2011 at 7:12 PM, Norman Maurer wrote: > Hello again, > > here is the next try to cut the first beta of the upcoming > Apache James Server 3.0. > > Here is the list of changes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10411&version=12315512 > > So please take the time to review and vote: > https://repository.apache.org/content/repositories/orgapachejames-064/ Thanks norman :-) I've set my download and analysis scripts running. I expect to have enough typing to take a look at the results later today. Robert - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: [VOTE] Release Apache James IMAP 0.2.1
On Thu, Jun 9, 2011 at 5:44 PM, Norman Maurer wrote: > [X] +1 Go ahead > [ ] +0 No time to review > [ ] -1 Something wrong with it (there are still a few small issues but no blockers for me) Robert - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: [VOTE] Release Apache James IMAP 0.2.1
On Thu, Jun 9, 2011 at 6:31 PM, Norman Maurer wrote: > well I thought lowrisk features could go to .z . at least thats what > others do too. (Reserving point releases (.z) for bug fixes allows downstreams to easily take just these fixes but means that minor release (.x.) increments vary in impact) > But Im not strong on this. +1 Just needs to be documented Robert - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134560 - /james/server/trunk/NOTICE
Author: rdonkin Date: Sat Jun 11 10:17:44 2011 New Revision: 1134560 URL: http://svn.apache.org/viewvc?rev=1134560&view=rev Log: JAMES-1263 Fix copyright dates. Modified: james/server/trunk/NOTICE Modified: james/server/trunk/NOTICE URL: http://svn.apache.org/viewvc/james/server/trunk/NOTICE?rev=1134560&r1=1134559&r2=1134560&view=diff == --- james/server/trunk/NOTICE (original) +++ james/server/trunk/NOTICE Sat Jun 11 10:17:44 2011 @@ -3,7 +3,7 @@ = Apache JAMES Server - Copyright 1999-2010 The Apache Software Foundation + Copyright 1999-2011 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: [VOTE] Release Apache James Server 3.0-beta1 (second try)
On Sat, Jun 11, 2011 at 8:50 AM, Robert Burrell Donkin wrote: > On Thu, Jun 9, 2011 at 7:12 PM, Norman Maurer > wrote: >> Hello again, >> >> here is the next try to cut the first beta of the upcoming >> Apache James Server 3.0. >> >> Here is the list of changes: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10411&version=12315512 >> >> So please take the time to review and vote: >> https://repository.apache.org/content/repositories/orgapachejames-064/ > > Thanks norman :-) > > I've set my download and analysis scripts running. I expect to have > enough typing to take a look at the results later today. The binary releases have licensing issues. I'll fix them once I slap Maven into line :-/ Robert - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: [VOTE] Release Apache James Server 3.0-beta1 (second try)
bummer ok so we need to re-roll again once they are fixed. bye Norman Am Samstag, 11. Juni 2011 schrieb Robert Burrell Donkin : > On Sat, Jun 11, 2011 at 8:50 AM, Robert Burrell Donkin > wrote: >> On Thu, Jun 9, 2011 at 7:12 PM, Norman Maurer >> wrote: >>> Hello again, >>> >>> here is the next try to cut the first beta of the upcoming >>> Apache James Server 3.0. >>> >>> Here is the list of changes: >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10411&version=12315512 >>> >>> So please take the time to review and vote: >>> https://repository.apache.org/content/repositories/orgapachejames-064/ >> >> Thanks norman :-) >> >> I've set my download and analysis scripts running. I expect to have >> enough typing to take a look at the results later today. > > The binary releases have licensing issues. I'll fix them once I slap > Maven into line :-/ > > Robert > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Imap status
Hi there, first of its 0.2 and 0.2.1 ;) For the rest see inside Am Samstag, 11. Juni 2011 schrieb Eric Charles : > Hi, > > This weekend, I will test server-beta1 (ok so far), imap-2.0.1 and will > update documentation for the releases. > > Is the following correct (Norman was so fast I could even not follow him :) > > IMAP4rev1 2.0 0.2 > LITERAL+ 2.0 0.2 > CHILDREN 0.2 > I18NLEVEL=1 2.0.1 0.2.1 > WITHIN 2.0.1 0.2 > ESEARCH 2.0.1 0.2.1 > SEARCHRES 2.0.1 0.2.1 > IDLE 2.0 0.2 > NAMESPACE 2.0 0.2 > UIDPLUS 2.0 0.2 > UNSELECT 2.0.1 0.2 > AUTH=PLAIN 2.0.1 0.2.1 > SASL-IR 2.0.1 0.2.1 > ENABLE 2.0.1 0.2.1 > > Also, are there specific tests for all these imap extensions (what is the > test coverage ?). > You can most of them test with dovecot's imaptest. I will write an email later and explain how > Tks, > - Eric > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > > bye norman - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Imap status
0.2.x, of course :) I will add a table on the imap web site with the supported extension per version. Sure, we can rely for now on dovecot testsuite. For the "how to test", we can simply link for now to http://www.imapwiki.org/ImapTest In the long run, mailbox-integration-tests could be enhanced. Tks, - Eric On 11/06/11 12:53, Norman Maurer wrote: Hi there, first of its 0.2 and 0.2.1 ;) For the rest see inside Am Samstag, 11. Juni 2011 schrieb Eric Charles: Hi, This weekend, I will test server-beta1 (ok so far), imap-2.0.1 and will update documentation for the releases. Is the following correct (Norman was so fast I could even not follow him :) IMAP4rev1 2.0 0.2 LITERAL+ 2.0 0.2 CHILDREN 0.2 I18NLEVEL=1 2.0.1 0.2.1 WITHIN 2.0.1 0.2 ESEARCH 2.0.1 0.2.1 SEARCHRES 2.0.1 0.2.1 IDLE 2.0 0.2 NAMESPACE 2.0 0.2 UIDPLUS 2.0 0.2 UNSELECT 2.0.1 0.2 AUTH=PLAIN 2.0.1 0.2.1 SASL-IR 2.0.1 0.2.1 ENABLE 2.0.1 0.2.1 Also, are there specific tests for all these imap extensions (what is the test coverage ?). You can most of them test with dovecot's imaptest. I will write an email later and explain how Tks, - Eric - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org bye norman - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (IMAP-316) STORE 1:* FLAGS \RECENT should return a tagged BAD response
STORE 1:* FLAGS \RECENT should return a tagged BAD response --- Key: IMAP-316 URL: https://issues.apache.org/jira/browse/IMAP-316 Project: JAMES Imap Issue Type: Improvement Components: Parser Affects Versions: 0.2, 0.2.1 Reporter: Norman Maurer Assignee: Norman Maurer Priority: Minor Fix For: 0.3 RFC3501 disallow setting the \RECENT flag via the STORE command. At the moment we just ignore it when parsing the STORE command. We should better return a tagged BAD response if we detect that the client tries to set the \RECENT flag. That is what dovecot does: C: a store 1:* FLAGS \RECENT S: a BAD Invalid system flag \RECENT -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134574 - in /james/imap/trunk: api/src/main/java/org/apache/james/imap/api/display/HumanReadableText.java message/src/main/java/org/apache/james/imap/decode/DecoderUtils.java
Author: norman
Date: Sat Jun 11 11:52:52 2011
New Revision: 1134574
URL: http://svn.apache.org/viewvc?rev=1134574&view=rev
Log:
Return tagged BAD if a client tries to set/unset the recent flag via the STORE
command. See IMAP-316
Modified:
james/imap/trunk/api/src/main/java/org/apache/james/imap/api/display/HumanReadableText.java
james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/DecoderUtils.java
Modified:
james/imap/trunk/api/src/main/java/org/apache/james/imap/api/display/HumanReadableText.java
URL:
http://svn.apache.org/viewvc/james/imap/trunk/api/src/main/java/org/apache/james/imap/api/display/HumanReadableText.java?rev=1134574&r1=1134573&r2=1134574&view=diff
==
---
james/imap/trunk/api/src/main/java/org/apache/james/imap/api/display/HumanReadableText.java
(original)
+++
james/imap/trunk/api/src/main/java/org/apache/james/imap/api/display/HumanReadableText.java
Sat Jun 11 11:52:52 2011
@@ -61,6 +61,8 @@ public class HumanReadableText {
public static final HumanReadableText INVALID_MESSAGESET = new
HumanReadableText("org.apache.james.imap.INVALID_MESSAGESET", "failed. Invalid
messageset.");
public static final HumanReadableText INVALID_COMMAND = new
HumanReadableText("org.apache.james.imap.INVALID_COMMAND", "failed. Command not
valid in this state.");
+
+public static final HumanReadableText INVALID_SYSTEM_FLAG = new
HumanReadableText("org.apache.james.imap.INVALID_SYSTEM_FLAG", "Invalid system
flag \\RECENT.");
public static final HumanReadableText ILLEGAL_TAG = new
HumanReadableText("org.apache.james.imap.ILLEGAL_TAG", "Illegal tag.");
Modified:
james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/DecoderUtils.java
URL:
http://svn.apache.org/viewvc/james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/DecoderUtils.java?rev=1134574&r1=1134573&r2=1134574&view=diff
==
---
james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/DecoderUtils.java
(original)
+++
james/imap/trunk/message/src/main/java/org/apache/james/imap/decode/DecoderUtils.java
Sat Jun 11 11:52:52 2011
@@ -63,7 +63,7 @@ public final class DecoderUtils {
private static final int ALL_MONTH_BITS = JAN_BIT | FEB_BIT | MAR_BIT |
APR_BIT | MAY_BIT | JUN_BIT | JUL_BIT | AUG_BIT | SEP_BIT | OCT_BIT | NOV_BIT |
DEC_BIT;
-public static void setFlag(final String flagString, final Flags flags) {
+public static void setFlag(final String flagString, final Flags flags)
throws DecodingException{
if (flagString.equalsIgnoreCase(MessageFlags.ANSWERED_ALL_CAPS)) {
flags.add(Flags.Flag.ANSWERED);
} else if (flagString.equalsIgnoreCase(MessageFlags.DELETED_ALL_CAPS))
{
@@ -78,8 +78,11 @@ public final class DecoderUtils {
if (flagString.equalsIgnoreCase(MessageFlags.RECENT_ALL_CAPS)) {
// NOPMD
// keep
// comment
-// RFC3501 specifically excludes /Recent
-// The /Recent flag should be set automatically by the server
+// RFC3501 specifically excludes \Recent
+// The \Recent flag should be set automatically by the server
so throw Exception
+//
+// See IMAP-316
+throw new
DecodingException(HumanReadableText.INVALID_SYSTEM_FLAG, "\\Recent flag is now
allowed to set.");
} else {
// RFC3501 allows novel flags
flags.add(flagString);
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Resolved] (IMAP-316) STORE 1:* FLAGS \RECENT should return a tagged BAD response
[ https://issues.apache.org/jira/browse/IMAP-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved IMAP-316. Resolution: Fixed > STORE 1:* FLAGS \RECENT should return a tagged BAD response > --- > > Key: IMAP-316 > URL: https://issues.apache.org/jira/browse/IMAP-316 > Project: JAMES Imap > Issue Type: Improvement > Components: Parser >Affects Versions: 0.2, 0.2.1 >Reporter: Norman Maurer >Assignee: Norman Maurer >Priority: Minor > Fix For: 0.3 > > > RFC3501 disallow setting the \RECENT flag via the STORE command. At the > moment we just ignore it when parsing the STORE command. We should better > return a tagged BAD response if we detect that the client tries to set the > \RECENT flag. That is what dovecot does: > C: a store 1:* FLAGS \RECENT > S: a BAD Invalid system flag \RECENT -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (MAILBOX-85) Copy messages should set the RECENT flag on the copies as these messages are in fact recent in the target mailbox
Copy messages should set the RECENT flag on the copies as these messages are in fact recent in the target mailbox - Key: MAILBOX-85 URL: https://issues.apache.org/jira/browse/MAILBOX-85 Project: James Mailbox Issue Type: Improvement Reporter: Norman Maurer Assignee: Norman Maurer -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134591 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
Author: norman
Date: Sat Jun 11 12:28:05 2011
New Revision: 1134591
URL: http://svn.apache.org/viewvc?rev=1134591&view=rev
Log:
Make sure we normalize the Date header to GMT so searching via SENTON,
SENTSINCE, SENTBEFORE works like expected. See MAILBOX-10
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java?rev=1134591&r1=1134590&r2=1134591&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
Sat Jun 11 12:28:05 2011
@@ -22,7 +22,10 @@ import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
+import java.io.StringReader;
import java.nio.charset.Charset;
+import java.text.DateFormat;
+import java.text.ParseException;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.Date;
@@ -31,20 +34,19 @@ import java.util.Iterator;
import java.util.List;
import java.util.Locale;
import java.util.Set;
+import java.util.TimeZone;
import javax.mail.Flags;
import javax.mail.Flags.Flag;
-import org.apache.commons.lang.time.DateUtils;
import org.apache.james.mailbox.MailboxException;
import org.apache.james.mailbox.MailboxSession;
import org.apache.james.mailbox.MessageRange;
import org.apache.james.mailbox.SearchQuery;
-import org.apache.james.mailbox.SearchQuery.CustomFlagCriterion;
-import org.apache.james.mailbox.UnsupportedSearchException;
import org.apache.james.mailbox.SearchQuery.AllCriterion;
import org.apache.james.mailbox.SearchQuery.ContainsOperator;
import org.apache.james.mailbox.SearchQuery.Criterion;
+import org.apache.james.mailbox.SearchQuery.CustomFlagCriterion;
import org.apache.james.mailbox.SearchQuery.DateOperator;
import org.apache.james.mailbox.SearchQuery.DateResolution;
import org.apache.james.mailbox.SearchQuery.FlagCriterion;
@@ -53,6 +55,7 @@ import org.apache.james.mailbox.SearchQu
import org.apache.james.mailbox.SearchQuery.NumericOperator;
import org.apache.james.mailbox.SearchQuery.NumericRange;
import org.apache.james.mailbox.SearchQuery.UidCriterion;
+import org.apache.james.mailbox.UnsupportedSearchException;
import org.apache.james.mailbox.store.mail.MessageMapperFactory;
import org.apache.james.mailbox.store.mail.model.Mailbox;
import org.apache.james.mailbox.store.mail.model.Message;
@@ -66,16 +69,19 @@ import org.apache.james.mime4j.field.add
import org.apache.james.mime4j.field.address.AddressList;
import org.apache.james.mime4j.field.address.Group;
import org.apache.james.mime4j.field.address.MailboxList;
+import org.apache.james.mime4j.field.datetime.DateTime;
+import org.apache.james.mime4j.field.datetime.parser.DateTimeParser;
import org.apache.james.mime4j.message.Header;
import org.apache.james.mime4j.message.SimpleContentHandler;
import org.apache.james.mime4j.parser.MimeEntityConfig;
import org.apache.james.mime4j.parser.MimeStreamParser;
import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.document.DateTools;
import org.apache.lucene.document.Document;
import org.apache.lucene.document.Field;
-import org.apache.lucene.document.NumericField;
import org.apache.lucene.document.Field.Index;
import org.apache.lucene.document.Field.Store;
+import org.apache.lucene.document.NumericField;
import org.apache.lucene.index.CorruptIndexException;
import org.apache.lucene.index.IndexReader;
import org.apache.lucene.index.IndexWriter;
@@ -92,6 +98,7 @@ import org.apache.lucene.search.ScoreDoc
import org.apache.lucene.search.Sort;
import org.apache.lucene.search.SortField;
import org.apache.lucene.search.TermQuery;
+import org.apache.lucene.search.TermRangeQuery;
import org.apache.lucene.search.TopDocs;
import org.apache.lucene.search.WildcardQuery;
import org.apache.lucene.store.Directory;
@@ -106,7 +113,18 @@ import org.apache.lucene.util.Version;
* @param
*/
public class LuceneMessageSearchIndex extends
ListeningMessageSearchIndex{
-
+private final static Date MAX_DATE;
+private final static Date MIN_DATE;
+
+static {
+Calendar cal = Calendar.getInstance();
+cal.set(, 11, 31);
+MAX_DATE = cal.getTime();
+
+cal.set(, 0, 1);
+MIN_DATE = cal.getTime();
+}
+
/**
* Default max query results
*/
@@ -437,13 +455,13 @@ public class LuceneMessageSearchIndex
svn commit: r1134605 - in /james/mailbox/trunk: jcr/src/main/java/org/apache/james/mailbox/jcr/mail/ jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/ maildir/src/main/java/org/apache
Author: norman
Date: Sat Jun 11 12:50:39 2011
New Revision: 1134605
URL: http://svn.apache.org/viewvc?rev=1134605&view=rev
Log:
Set the \RECENT flag on copied messages. See MAILBOX-85
Modified:
james/mailbox/trunk/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java
james/mailbox/trunk/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMessage.java
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/model/SimpleMailboxMembership.java
Modified:
james/mailbox/trunk/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java?rev=1134605&r1=1134604&r2=1134605&view=diff
==
---
james/mailbox/trunk/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java
(original)
+++
james/mailbox/trunk/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java
Sat Jun 11 12:50:39 2011
@@ -607,7 +607,9 @@ public class JCRMessageMapper extends Ab
node.setProperty(JCRMessage.MAILBOX_UUID_PROPERTY,
mailbox.getMailboxId());
node.setProperty(JCRMessage.UID_PROPERTY, uid);
node.setProperty(JCRMessage.MODSEQ_PROPERTY, modSeq);
-
+// A copy of a message is recent
+// See MAILBOX-85
+node.setProperty(JCRMessage.RECENT_PROPERTY, true);
return new SimpleMessageMetaData(new JCRMessage(node,
mailboxSession.getLog()));
} catch (RepositoryException e) {
throw new MailboxException("Unable to copy message " +original + "
in mailbox " + mailbox, e);
Modified:
james/mailbox/trunk/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMessage.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMessage.java?rev=1134605&r1=1134604&r2=1134605&view=diff
==
---
james/mailbox/trunk/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMessage.java
(original)
+++
james/mailbox/trunk/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/model/openjpa/AbstractJPAMessage.java
Sat Jun 11 12:50:39 2011
@@ -289,9 +289,12 @@ public abstract class AbstractJPAMessage
this.mailbox = mailbox;
this.uid = uid;
this.modSeq = modSeq;
-userFlags = new ArrayList();
+this.userFlags = new ArrayList();
setFlags(original.createFlags());
+// A copy of a message is recent
+// See MAILBOX-85
+this.recent = true;
this.contentOctets = original.getFullContentOctets();
this.bodyStartOctet = (int) (original.getFullContentOctets() -
original.getBodyOctets());
Modified:
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java?rev=1134605&r1=1134604&r2=1134605&view=diff
==
---
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
(original)
+++
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
Sat Jun 11 12:50:39 2011
@@ -105,7 +105,7 @@ public class MaildirMessage extends Abst
this.deleted = message.isDeleted();
this.draft = message.isDraft();
this.flagged = message.isFlagged();
-this.recent = message.isRecent();
+
this.seen = message.isSeen();
try {
@@ -134,6 +134,9 @@ public class MaildirMessage extends Abst
}
// this is a copy and thus new
newMessage = true;
+// A copy of a message is recent
+// See MAILBOX-85
+this.recent = true;
}
Modified:
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/model/SimpleMailboxMembership.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/model/SimpleMailboxMembership.java?rev=1134605&r1=1134604&r2=1134605&view=diff
==
---
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/model/SimpleMailboxMembership.java
(original)
+++
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/model/SimpleMailboxMembership.java
Sat Jun 11 12:50:39 2011
@
svn commit: r1134609 - /james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
Author: norman
Date: Sat Jun 11 12:52:36 2011
New Revision: 1134609
URL: http://svn.apache.org/viewvc?rev=1134609&view=rev
Log:
Set the \RECENT flag on copied messages. See MAILBOX-85
Modified:
james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
Modified:
james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/MailboxManager.java?rev=1134609&r1=1134608&r2=1134609&view=diff
==
---
james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
(original)
+++
james/mailbox/trunk/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
Sat Jun 11 12:52:36 2011
@@ -120,8 +120,9 @@ public interface MailboxManager extends
void renameMailbox(MailboxPath from, MailboxPath to, MailboxSession
session) throws MailboxException;
/**
- * This is done by the MailboxRepository because maybe this operation could
- * be optimized in the corresponding store.
+ * Copy the given {@link MessageRange} from one Mailbox to the other.
+ *
+ * Be aware that the copied Messages MUST get the \RECENT flag set!
*
* @param set
*messages to copy
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Resolved] (MAILBOX-85) Copy messages should set the RECENT flag on the copies as these messages are in fact recent in the target mailbox
[ https://issues.apache.org/jira/browse/MAILBOX-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved MAILBOX-85. -- Resolution: Fixed Fix Version/s: 0.3 > Copy messages should set the RECENT flag on the copies as these messages are > in fact recent in the target mailbox > - > > Key: MAILBOX-85 > URL: https://issues.apache.org/jira/browse/MAILBOX-85 > Project: James Mailbox > Issue Type: Improvement >Reporter: Norman Maurer >Assignee: Norman Maurer > Fix For: 0.3 > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134610 - /james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java
Author: norman Date: Sat Jun 11 12:55:42 2011 New Revision: 1134610 URL: http://svn.apache.org/viewvc?rev=1134610&view=rev Log: Change CopyProcessor to reflect latest mailbox changes. See MAILBOX-85 Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java Modified: james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java URL: http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java?rev=1134610&r1=1134609&r2=1134610&view=diff == --- james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java (original) +++ james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/CopyProcessor.java Sat Jun 11 12:55:42 2011 @@ -22,8 +22,6 @@ package org.apache.james.imap.processor; import java.util.ArrayList; import java.util.List; -import javax.mail.Flags; - import org.apache.james.imap.api.ImapCommand; import org.apache.james.imap.api.ImapSessionUtils; import org.apache.james.imap.api.display.HumanReadableText; @@ -85,7 +83,10 @@ public class CopyProcessor extends Abstr // done. // See RFC 3501 6.4.7. COPY Command // See IMAP-287 -mailbox.setFlags(new Flags(Flags.Flag.RECENT), true, false, mr, mailboxSession); +// +// Disable this as this is now done directly in the scope of the copy operation. +// See MAILBOX-85 +//mailbox.setFlags(new Flags(Flags.Flag.RECENT), true, false, mr, mailboxSession); resultRanges.add(new IdRange(mr.getUidFrom(), mr.getUidTo())); } } - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134612 - /james/imap/trunk/pom.xml
Author: norman Date: Sat Jun 11 12:57:37 2011 New Revision: 1134612 URL: http://svn.apache.org/viewvc?rev=1134612&view=rev Log: Move to 0.3-SNAPSHOT version for mailbox dependency Modified: james/imap/trunk/pom.xml Modified: james/imap/trunk/pom.xml URL: http://svn.apache.org/viewvc/james/imap/trunk/pom.xml?rev=1134612&r1=1134611&r2=1134612&view=diff == --- james/imap/trunk/pom.xml (original) +++ james/imap/trunk/pom.xml Sat Jun 11 12:57:37 2011 @@ -383,12 +383,12 @@ org.apache.james apache-james-mailbox-api -0.2 +0.3-SNAPSHOT org.apache.james apache-james-mailbox-api -0.2 +0.3-SNAPSHOT test-jar test - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134621 - /james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/LazyLoadingMaildirMessage.java
Author: norman
Date: Sat Jun 11 13:10:51 2011
New Revision: 1134621
URL: http://svn.apache.org/viewvc?rev=1134621&view=rev
Log:
Make sure the \Recent flag is respect when load LazyLoadingMaildirMessage. See
MAILBOX-84
Modified:
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/LazyLoadingMaildirMessage.java
Modified:
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/LazyLoadingMaildirMessage.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/LazyLoadingMaildirMessage.java?rev=1134621&r1=1134620&r2=1134621&view=diff
==
---
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/LazyLoadingMaildirMessage.java
(original)
+++
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/LazyLoadingMaildirMessage.java
Sat Jun 11 13:10:51 2011
@@ -18,7 +18,9 @@
/
package org.apache.james.mailbox.maildir.mail.model;
+import java.io.File;
import java.io.FileInputStream;
+import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStream;
import java.io.PushbackInputStream;
@@ -26,9 +28,11 @@ import java.util.ArrayList;
import java.util.Date;
import java.util.List;
+import javax.mail.Flags;
import javax.mail.util.SharedFileInputStream;
import org.apache.commons.io.IOUtils;
+import org.apache.james.mailbox.maildir.MaildirFolder;
import org.apache.james.mailbox.maildir.MaildirMessageName;
import org.apache.james.mailbox.store.mail.model.Header;
import org.apache.james.mailbox.store.mail.model.Mailbox;
@@ -55,7 +59,20 @@ public class LazyLoadingMaildirMessage e
super(mailbox);
setUid(uid);
setModSeq(messageName.getFile().lastModified());
-setFlags(messageName.getFlags());
+Flags flags = messageName.getFlags();
+
+// Set the flags for the message and respect if its RECENT
+// See MAILBOX-84
+File file = messageName.getFile();
+if (!file.exists()) {
+throw new FileNotFoundException("Unable to read file " +
file.getAbsolutePath() + " for the message");
+} else {
+// if the message resist in the new folder its RECENT
+if (file.getParentFile().getName().equals(MaildirFolder.NEW)) {
+flags.add(Flags.Flag.RECENT);
+}
+}
+setFlags(flags);
this.messageName = messageName;
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Resolved] (MAILBOX-84) LazyLoadingMaildirMessage does not set the RECENT flag when getting loaded
[ https://issues.apache.org/jira/browse/MAILBOX-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved MAILBOX-84. -- Resolution: Fixed > LazyLoadingMaildirMessage does not set the RECENT flag when getting loaded > -- > > Key: MAILBOX-84 > URL: https://issues.apache.org/jira/browse/MAILBOX-84 > Project: James Mailbox > Issue Type: Bug > Components: maildir mailbox >Affects Versions: 0.2 >Reporter: Norman Maurer >Assignee: Norman Maurer >Priority: Minor > Fix For: 0.3 > > > If you load a Message from the Maildir mailbox which has a Recent flag set, > its not included in the flags. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134622 - in /james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base: FakeMailboxListenerAdded.java MailboxEventAnalyserTest.java
Author: norman
Date: Sat Jun 11 13:12:50 2011
New Revision: 1134622
URL: http://svn.apache.org/viewvc?rev=1134622&view=rev
Log:
Move to 0.3-SNAPSHOT version for mailbox dependency
Modified:
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/FakeMailboxListenerAdded.java
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java
Modified:
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/FakeMailboxListenerAdded.java
URL:
http://svn.apache.org/viewvc/james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/FakeMailboxListenerAdded.java?rev=1134622&r1=1134621&r2=1134622&view=diff
==
---
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/FakeMailboxListenerAdded.java
(original)
+++
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/FakeMailboxListenerAdded.java
Sat Jun 11 13:12:50 2011
@@ -27,6 +27,7 @@ import javax.mail.Flags;
import org.apache.james.mailbox.MailboxListener;
import org.apache.james.mailbox.MailboxPath;
import org.apache.james.mailbox.MailboxSession;
+import org.apache.james.mailbox.MessageMetaData;
public class FakeMailboxListenerAdded extends MailboxListener.Added {
@@ -72,6 +73,11 @@ public class FakeMailboxListenerAdded ex
// TODO Auto-generated method stub
return null;
}
+
+public long getModSeq() {
+// TODO Auto-generated method stub
+return 0;
+}
};
}
Modified:
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java
URL:
http://svn.apache.org/viewvc/james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java?rev=1134622&r1=1134621&r2=1134622&view=diff
==
---
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java
(original)
+++
james/imap/trunk/processor/src/test/java/org/apache/james/imap/processor/base/MailboxEventAnalyserTest.java
Sat Jun 11 13:12:50 2011
@@ -242,7 +242,7 @@ public class MailboxEventAnalyserTest {
MailboxEventAnalyser analyser = new MailboxEventAnalyser(imapsession,
mailboxPath, new Flags());
final FakeMailboxListenerFlagsUpdate update = new
FakeMailboxListenerFlagsUpdate(
-mSession, Arrays.asList(90L), Arrays.asList(new
UpdatedFlags(90, new Flags(), new Flags())), mailboxPath);
+mSession, Arrays.asList(90L), Arrays.asList(new
UpdatedFlags(90, -1, new Flags(), new Flags())), mailboxPath);
analyser.event(update);
assertNotNull(analyser.flagUpdateUids());
assertFalse(analyser.flagUpdateUids().iterator().hasNext());
@@ -259,7 +259,7 @@ public class MailboxEventAnalyserTest {
final FakeMailboxListenerFlagsUpdate update = new
FakeMailboxListenerFlagsUpdate(
-mSession, Arrays.asList(uid), Arrays.asList(new
UpdatedFlags(uid, new Flags(), new Flags(Flags.Flag.ANSWERED))), mailboxPath);
+mSession, Arrays.asList(uid), Arrays.asList(new
UpdatedFlags(uid, -1, new Flags(), new Flags(Flags.Flag.ANSWERED))),
mailboxPath);
analyser.event(update);
final Iterator iterator = analyser.flagUpdateUids().iterator();
assertNotNull(iterator);
@@ -276,7 +276,7 @@ public class MailboxEventAnalyserTest {
MailboxEventAnalyser analyser = new MailboxEventAnalyser(imapsession,
mailboxPath, new Flags());
final FakeMailboxListenerFlagsUpdate update = new
FakeMailboxListenerFlagsUpdate(
-mSession, Arrays.asList(uid), Arrays.asList(new
UpdatedFlags(uid, new Flags(), new Flags(Flags.Flag.ANSWERED))), mailboxPath);
+mSession, Arrays.asList(uid), Arrays.asList(new
UpdatedFlags(uid, -1, new Flags(), new Flags(Flags.Flag.ANSWERED))),
mailboxPath);
analyser.event(update);
analyser.event(update);
analyser.reset();
@@ -294,7 +294,7 @@ public class MailboxEventAnalyserTest {
MailboxEventAnalyser analyser = new MailboxEventAnalyser(imapsession,
mailboxPath,new Flags());
final FakeMailboxListenerFlagsUpdate update = new
FakeMailboxListenerFlagsUpdate(
-new MyMailboxSession(BASE_SESSION_ID), Arrays.asList(uid),
Arrays.asList(new UpdatedFlags(uid, new Flags(), new
Flags(Flags.Flag.ANSWERED))), mailboxPath);
+new MyMailboxSession(BASE_SESSION_ID), Arrays.asList(uid),
Arrays.asList(new UpdatedFlags(uid, -1, new Flags(), new
Flags(Flags.Flag.ANSWERED))), mailboxPath);
analyser.event(update);
analyser.setSilentFlagChanges(true);
svn commit: r1134623 - /james/imap/trunk/message/src/test/java/org/apache/james/imap/decode/DecoderUtilsTest.java
Author: norman
Date: Sat Jun 11 13:13:25 2011
New Revision: 1134623
URL: http://svn.apache.org/viewvc?rev=1134623&view=rev
Log:
Return tagged BAD if a client tries to set/unset the recent flag via the STORE
command. See IMAP-316
Modified:
james/imap/trunk/message/src/test/java/org/apache/james/imap/decode/DecoderUtilsTest.java
Modified:
james/imap/trunk/message/src/test/java/org/apache/james/imap/decode/DecoderUtilsTest.java
URL:
http://svn.apache.org/viewvc/james/imap/trunk/message/src/test/java/org/apache/james/imap/decode/DecoderUtilsTest.java?rev=1134623&r1=1134622&r2=1134623&view=diff
==
---
james/imap/trunk/message/src/test/java/org/apache/james/imap/decode/DecoderUtilsTest.java
(original)
+++
james/imap/trunk/message/src/test/java/org/apache/james/imap/decode/DecoderUtilsTest.java
Sat Jun 11 13:13:25 2011
@@ -37,16 +37,17 @@ public class DecoderUtilsTest {
private static final String A_CUSTOM_FLAG = "Another";
-private static final String FLAG_MESSAGE = "RFC3501 specifies that
\\Recent flag cannot be set by the client but accept liberally for better
compatibility.";
-
@Test
-public void testSetRecentFlag() throws Exception {
+public void testSetRecentFlag() {
Flags flags = new Flags();
-DecoderUtils.setFlag("\\Recent", flags);
-assertFalse(FLAG_MESSAGE, flags.contains("\\Recent"));
-assertFalse(FLAG_MESSAGE, flags.contains(Flags.Flag.RECENT));
+try {
+DecoderUtils.setFlag("\\Recent", flags);
+fail();
+} catch (DecodingException e) {
+// expected
+}
}
@Test
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134624 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
Author: norman Date: Sat Jun 11 13:14:22 2011 New Revision: 1134624 URL: http://svn.apache.org/viewvc?rev=1134624&view=rev Log: Remove unused imports Modified: james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java Modified: james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java URL: http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java?rev=1134624&r1=1134623&r2=1134624&view=diff == --- james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java (original) +++ james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java Sat Jun 11 13:14:22 2011 @@ -24,8 +24,6 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.io.StringReader; import java.nio.charset.Charset; -import java.text.DateFormat; -import java.text.ParseException; import java.util.ArrayList; import java.util.Calendar; import java.util.Date; - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: let the coding start
Hi Ioan, Even if James can be considered as a replacement for existing de-facto mailservers (simply for example by taking the maildir folder), the adoption will probably occur for some special use cases: - Mail integration in existing JAVA applications/environment - Mail processing during the spool, for some functions such as transformation, ai (artificial intelligence)... - Deployment in the cloud (amazon...) with the addition of some components such as a distributed mailbox... - IMAP extensions that wouldn't be implemented by others - ... For "standard" usage correctly served by today servers, the chance is high that we won't find today much echo in the "classical" segment. This may change as more and more James installations arise. About the HBase samples, you can look at [1]. HBase needs Hadoop behind, so [2] could be interesting, even if the Hadoop API should normally not be called directly. I will also ping the hbase mailing list that we launch a GSOC with their component (don't forget to register to their mailing list if this is not already the case). Tks, - Eric [1] https://github.com/echarles/t4f-hbase [2] https://github.com/echarles/t4f-hadoop On 10/06/11 00:02, Ioan Eugen Stan wrote: Well, the presentation went smooth, you can read more about it on my blog. The slides and the video will be available on slideshare and blip.tv soon. James was new to them. I don't think I convinced the one/two sys-admins to switch from postfix, but they have some different needs and a well background with postfix. I hope I will be able to make a workshop later and install James and run some tests (hopefully around HBase). That's another story. If there's anyone out there who wants to learn how to code protocols in Java, this is a good opportunity to jump in :-) Unfortunately it's not that kind of a crowd. More like general type opensource enthusiasts and sys-admins. I managed to talk to someone and he will put me in contact with the programmers who will probably find this kind of activity more appealing. This will happen at some next events. Regards, - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: let the coding start
There's also Lars' git with code that will be used for the O'Reilly book "HBase Definitive Guide" (in pre-order). It seems that you need a real cluster running the code. I will also ping on that. https://github.com/larsgeorge/hbase-book http://oreilly.com/catalog/0636920014348 Tks, - Eric On 11/06/11 16:42, Eric Charles wrote: Hi Ioan, Even if James can be considered as a replacement for existing de-facto mailservers (simply for example by taking the maildir folder), the adoption will probably occur for some special use cases: - Mail integration in existing JAVA applications/environment - Mail processing during the spool, for some functions such as transformation, ai (artificial intelligence)... - Deployment in the cloud (amazon...) with the addition of some components such as a distributed mailbox... - IMAP extensions that wouldn't be implemented by others - ... For "standard" usage correctly served by today servers, the chance is high that we won't find today much echo in the "classical" segment. This may change as more and more James installations arise. About the HBase samples, you can look at [1]. HBase needs Hadoop behind, so [2] could be interesting, even if the Hadoop API should normally not be called directly. I will also ping the hbase mailing list that we launch a GSOC with their component (don't forget to register to their mailing list if this is not already the case). Tks, - Eric [1] https://github.com/echarles/t4f-hbase [2] https://github.com/echarles/t4f-hadoop On 10/06/11 00:02, Ioan Eugen Stan wrote: Well, the presentation went smooth, you can read more about it on my blog. The slides and the video will be available on slideshare and blip.tv soon. James was new to them. I don't think I convinced the one/two sys-admins to switch from postfix, but they have some different needs and a well background with postfix. I hope I will be able to make a workshop later and install James and run some tests (hopefully around HBase). That's another story. If there's anyone out there who wants to learn how to code protocols in Java, this is a good opportunity to jump in :-) Unfortunately it's not that kind of a crowd. More like general type opensource enthusiasts and sys-admins. I managed to talk to someone and he will put me in contact with the programmers who will probably find this kind of activity more appealing. This will happen at some next events. Regards, - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134668 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
Author: norman
Date: Sat Jun 11 15:11:19 2011
New Revision: 1134668
URL: http://svn.apache.org/viewvc?rev=1134668&view=rev
Log:
Fix address indexing now only recent flag indexing seems to not work like
expected. See MAILBOX-10
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java?rev=1134668&r1=1134667&r2=1134668&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/lucene/LuceneMessageSearchIndex.java
Sat Jun 11 15:11:19 2011
@@ -61,7 +61,6 @@ import org.apache.james.mailbox.store.se
import org.apache.james.mailbox.store.search.SearchUtil;
import org.apache.james.mime4j.MimeException;
import org.apache.james.mime4j.descriptor.BodyDescriptor;
-import org.apache.james.mime4j.field.AddressListField;
import org.apache.james.mime4j.field.DateTimeField;
import org.apache.james.mime4j.field.address.Address;
import org.apache.james.mime4j.field.address.AddressList;
@@ -73,6 +72,7 @@ import org.apache.james.mime4j.message.H
import org.apache.james.mime4j.message.SimpleContentHandler;
import org.apache.james.mime4j.parser.MimeEntityConfig;
import org.apache.james.mime4j.parser.MimeStreamParser;
+import org.apache.james.mime4j.util.MimeUtil;
import org.apache.lucene.analysis.Analyzer;
import org.apache.lucene.document.DateTools;
import org.apache.lucene.document.Document;
@@ -444,7 +444,7 @@ public class LuceneMessageSearchIndex membership) throws
MailboxException{
+private Document createMessageDocument(final MailboxSession session, final
Message membership) throws MailboxException{
final Document doc = new Document();
// TODO: Better handling
doc.add(new Field(MAILBOX_ID_FIELD,
membership.getMailboxId().toString().toUpperCase(Locale.ENGLISH), Store.YES,
Index.NOT_ANALYZED));
@@ -495,14 +495,12 @@ public class LuceneMessageSearchIndex mailbox, Message
membership) throws MailboxException {
-Document doc = createMessageDocument(membership);
+Document doc = createMessageDocument(session, membership);
Document flagsDoc = createFlagsDocument(membership);
try {
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (MAILBOX-86) Cache MessageMapper.countMessagesInMailbox()
Cache MessageMapper.countMessagesInMailbox() Key: MAILBOX-86 URL: https://issues.apache.org/jira/browse/MAILBOX-86 Project: James Mailbox Issue Type: Improvement Reporter: Norman Maurer Assignee: Norman Maurer Priority: Minor We should maybe cache the message count in mailbox to speed up things a bit. There may be other areas which could cache some data. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134670 - /james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/lucene/LuceneMessageSearchIndexTest.java
Author: norman
Date: Sat Jun 11 15:15:35 2011
New Revision: 1134670
URL: http://svn.apache.org/viewvc?rev=1134670&view=rev
Log:
Fix address indexing now only recent flag indexing seems to not work like
expected. See MAILBOX-10
Modified:
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/lucene/LuceneMessageSearchIndexTest.java
Modified:
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/lucene/LuceneMessageSearchIndexTest.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/lucene/LuceneMessageSearchIndexTest.java?rev=1134670&r1=1134669&r2=1134670&view=diff
==
---
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/lucene/LuceneMessageSearchIndexTest.java
(original)
+++
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/lucene/LuceneMessageSearchIndexTest.java
Sat Jun 11 15:15:35 2011
@@ -34,6 +34,7 @@ import javax.mail.Flags;
import javax.mail.Flags.Flag;
import org.apache.james.mailbox.SearchQuery;
+import org.apache.james.mailbox.SearchQuery.AddressType;
import org.apache.james.mailbox.SearchQuery.DateResolution;
import org.apache.james.mailbox.store.MessageBuilder;
import org.apache.james.mailbox.store.SimpleHeader;
@@ -54,7 +55,7 @@ public class LuceneMessageSearchIndexTes
private SimpleMailbox mailbox3 = new SimpleMailbox(2);
-private static final String FROM_ADDRESS = "Harry ");
builder.header("To", FROM_ADDRESS);
builder.header("Subject", "A " + SUBJECT_PART + " Multipart Mail");
builder.header("Date", "Thu, 14 Feb 2008 12:00:00 + (GMT)");
@@ -185,6 +186,39 @@ public class LuceneMessageSearchIndexTes
}
@Test
+public void testSearchAddress() throws Exception {
+
+SearchQuery query = new SearchQuery();
+query.andCriteria(SearchQuery.address(AddressType.To,FROM_ADDRESS));
+Iterator result = index.search(null, mailbox3, query);
+assertEquals(10L, result.next().longValue());
+assertFalse(result.hasNext());
+
+query = new SearchQuery();
+query.andCriteria(SearchQuery.address(AddressType.To,"Harry"));
+result = index.search(null, mailbox3, query);
+assertEquals(10L, result.next().longValue());
+assertFalse(result.hasNext());
+
+query = new SearchQuery();
+
query.andCriteria(SearchQuery.address(AddressType.To,"ha...@example.org"));
+result = index.search(null, mailbox3, query);
+assertEquals(10L, result.next().longValue());
+assertFalse(result.hasNext());
+}
+
+@Test
+public void testSearchAddressFrom() throws Exception {
+
+SearchQuery query = new SearchQuery();
+
query.andCriteria(SearchQuery.address(AddressType.From,"ser-f...@domain.or"));
+Iterator result = index.search(null, mailbox3, query);
+assertEquals(10L, result.next().longValue());
+assertFalse(result.hasNext());
+
+
+}
+@Test
public void testBodyShouldMatchPhraseOnlyInHeader() throws Exception {
SearchQuery query = new SearchQuery();
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1134671 - in /james/mailbox/trunk: maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMessageMapper.java store/src/main/java/org/apache/james/mailbox/store/StoreMessageMan
Author: norman
Date: Sat Jun 11 15:17:56 2011
New Revision: 1134671
URL: http://svn.apache.org/viewvc?rev=1134671&view=rev
Log:
replace spaces by tabs
Modified:
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMessageMapper.java
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
Modified:
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMessageMapper.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMessageMapper.java?rev=1134671&r1=1134670&r2=1134671&view=diff
==
---
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMessageMapper.java
(original)
+++
james/mailbox/trunk/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMessageMapper.java
Sat Jun 11 15:17:56 2011
@@ -137,14 +137,14 @@ public class MaildirMessageMapper extend
break;
}
-if(batchSize > 0) {
- int i = 0;
- while(i*batchSize < results.size()) {
- callback.onMailboxMembers(results.subList(i*batchSize,
(i+1)*batchSize < results.size() ? (i+1)*batchSize : results.size()));
- i++;
- }
+if (batchSize > 0) {
+int i = 0;
+while (i * batchSize < results.size()) {
+callback.onMailboxMembers(results.subList(i * batchSize, (i +
1) * batchSize < results.size() ? (i + 1) * batchSize : results.size()));
+i++;
+}
} else {
- callback.onMailboxMembers(results);
+callback.onMailboxMembers(results);
}
}
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java?rev=1134671&r1=1134670&r2=1134671&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
Sat Jun 11 15:17:56 2011
@@ -528,9 +528,9 @@ public abstract class StoreMessageManage
}
public Iterator getIterator() {
- if (iterator == null) {
- iterator = new ResultIterator(null, null);
- }
+if (iterator == null) {
+iterator = new ResultIterator(null, null);
+}
return iterator;
}
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
Why does SMTP sending mail w/o authentication?
Hi I am using the James-M3-Snapshot-06012011, I am being confused by smtp authentication issue. The smtpserver.xml content as below: 0.0.0.0:25 200 360 0 0 127.0.0.0/8 true true 0 true But the smtp server can't do authentication, just saying it allows any user to send mail. could you please tell me what is wrong here? Thanks a lot Barry
Re: Why does SMTP sending mail w/o authentication?
Hi maybe I made a mistake here. 127.0.0.0/8 does this line mean the localhost will automatically be authorized? is it correct? Thanks, Barry 2011/6/12 Barry > Hi I am using the James-M3-Snapshot-06012011, I am being confused by smtp > authentication issue. > > The smtpserver.xml content as below: > > > 0.0.0.0:25 > 200 > > > 360 >0 >0 > 127.0.0.0/8 > true > true > 0 > true > > class="org.apache.james.smtpserver.fastfail.ValidRcptHandler"/> > > > > > > But the smtp server can't do authentication, just saying it allows any user > to send mail. could you please tell me what is wrong here? > > Thanks a lot > Barry > >
[jira] [Commented] (JAMES-1266) Found an exception when sending a mail
[ https://issues.apache.org/jira/browse/JAMES-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048198#comment-13048198 ] Barry commented on JAMES-1266: -- I think the problem does't belong to james, just mysql connection pool's problem. I am testing the configuration as below: I think you can guess the problem, just the connection idles long time (default 8 hours), the connection will be interrupted by mysql server. I need some time to test, and will give you feedback as soon as I can do. > Found an exception when sending a mail > -- > > Key: JAMES-1266 > URL: https://issues.apache.org/jira/browse/JAMES-1266 > Project: JAMES Server > Issue Type: Bug > Components: Build System >Reporter: Barry > > DEBUG 09:02:08,281 | james.smtpserver | Unable to process request > > org.apache.openjpa.persistence.InvalidStateException: This operation cannot > be performed while a Transaction is active. > at org.apache.openjpa.kernel.BrokerImpl.close(BrokerImpl.java:4304) > at > org.apache.openjpa.kernel.DelegatingBroker.close(DelegatingBroker.java:1346) > at > org.apache.openjpa.persistence.EntityManagerImpl.close(EntityManagerImpl.java:1284) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > at java.lang.reflect.Method.invoke(Unknown Source) > at > org.springframework.orm.jpa.ExtendedEntityManagerCreator$ExtendedEntityManagerInvocationHandler.invoke(ExtendedEntityManagerCreator.java:365) > at $Proxy55.close(Unknown Source) > at > org.apache.james.domainlist.jpa.JPADomainList.containsDomain(JPADomainList.java:119) > at > org.apache.james.smtpserver.fastfail.ValidRcptHandler.isLocalDomain(ValidRcptHandler.java:152) > at > org.apache.james.protocols.smtp.core.fastfail.AbstractValidRcptHandler.doRcpt(AbstractValidRcptHandler.java:49) > at > org.apache.james.protocols.smtp.core.RcptCmdHandler.callHook(RcptCmdHandler.java:249) > at > org.apache.james.protocols.smtp.core.RcptCmdHandler.callHook(RcptCmdHandler.java:39) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.processHooks(AbstractHookableCmdHandler.java:92) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.onCommand(AbstractHookableCmdHandler.java:59) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.onCommand(AbstractHookableCmdHandler.java:40) > at > org.apache.james.protocols.api.AbstractCommandDispatcher.onLine(AbstractCommandDispatcher.java:150) > at > org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.messageReceived(AbstractChannelUpstreamHandler.java:122) > at > org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69) > at > org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:316) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown > Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > DEBUG 09:02:08,453 | james.smtpserver | Unable to process request > java.lang.NullPointerException > at > org.apache.james.protocols.api.AbstractCommandDispatcher.onLine(AbstractCommandDispatcher.java:140) > at > org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.messageReceived(AbstractChannelUpstreamHandler.java:122) > at > org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69) > at > org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:316) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown > Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1266) Found an exception when sending a mail
[ https://issues.apache.org/jira/browse/JAMES-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048243#comment-13048243 ] Eric Charles commented on JAMES-1266: - In the process, the issue could be 1. on the client side 2. on james 3. on the database I looked at james and was not able to find something wrong, this is why I asked you to look at the client side. The next step would have been to look at the database side. However, the logged stacktrace are not crystal-clear. Normally, we should better see what the potential problem is from the logged error (it should for example display a jdbc error message). This comes probably here in the OpenJPA layer, so we can't do much on James level for that... I hope the configuration can solve the problem, but if your MySQL holds a connection for 8 hours, even if you change the connection settings, it will still hold the connection, which is not normal. > Found an exception when sending a mail > -- > > Key: JAMES-1266 > URL: https://issues.apache.org/jira/browse/JAMES-1266 > Project: JAMES Server > Issue Type: Bug > Components: Build System >Reporter: Barry > > DEBUG 09:02:08,281 | james.smtpserver | Unable to process request > > org.apache.openjpa.persistence.InvalidStateException: This operation cannot > be performed while a Transaction is active. > at org.apache.openjpa.kernel.BrokerImpl.close(BrokerImpl.java:4304) > at > org.apache.openjpa.kernel.DelegatingBroker.close(DelegatingBroker.java:1346) > at > org.apache.openjpa.persistence.EntityManagerImpl.close(EntityManagerImpl.java:1284) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > at java.lang.reflect.Method.invoke(Unknown Source) > at > org.springframework.orm.jpa.ExtendedEntityManagerCreator$ExtendedEntityManagerInvocationHandler.invoke(ExtendedEntityManagerCreator.java:365) > at $Proxy55.close(Unknown Source) > at > org.apache.james.domainlist.jpa.JPADomainList.containsDomain(JPADomainList.java:119) > at > org.apache.james.smtpserver.fastfail.ValidRcptHandler.isLocalDomain(ValidRcptHandler.java:152) > at > org.apache.james.protocols.smtp.core.fastfail.AbstractValidRcptHandler.doRcpt(AbstractValidRcptHandler.java:49) > at > org.apache.james.protocols.smtp.core.RcptCmdHandler.callHook(RcptCmdHandler.java:249) > at > org.apache.james.protocols.smtp.core.RcptCmdHandler.callHook(RcptCmdHandler.java:39) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.processHooks(AbstractHookableCmdHandler.java:92) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.onCommand(AbstractHookableCmdHandler.java:59) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.onCommand(AbstractHookableCmdHandler.java:40) > at > org.apache.james.protocols.api.AbstractCommandDispatcher.onLine(AbstractCommandDispatcher.java:150) > at > org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.messageReceived(AbstractChannelUpstreamHandler.java:122) > at > org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69) > at > org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:316) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown > Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > DEBUG 09:02:08,453 | james.smtpserver | Unable to process request > java.lang.NullPointerException > at > org.apache.james.protocols.api.AbstractCommandDispatcher.onLine(AbstractCommandDispatcher.java:140) > at > org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.messageReceived(AbstractChannelUpstreamHandler.java:122) > at > org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69) > at > org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:316) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown > Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-
Re: Why does SMTP sending mail w/o authentication?
Hi Barry, Yes, you're right. The documentation we will put online with the release of sever beta1 will state for authorizedAddresses in smtpserver.xml If you use SMTP AUTH, addresses that match those specified here will be permitted to relay without SMTP AUTH. If you do not use SMTP AUTH, and you specify addreses here, then only addresses that match those specified will be permitted to relay. Addresses may be specified as a an IP address or domain name, with an optional netmask, e.g. 127.*, 127.0.0.0/8, 127.0.0.0/255.0.0.0, and localhost/8 are all the same See also the RemoteAddrNotInNetwork matcher in the transport processor. You would generally use one OR the other approach. Tks, - Eric On 12/06/11 03:57, Barry wrote: Hi maybe I made a mistake here. 127.0.0.0/8 does this line mean the localhost will automatically be authorized? is it correct? Thanks, Barry 2011/6/12 Barry Hi I am using the James-M3-Snapshot-06012011, I am being confused by smtp authentication issue. The smtpserver.xml content as below: 0.0.0.0:25 200 360 0 0 127.0.0.0/8 true true 0 true But the smtp server can't do authentication, just saying it allows any user to send mail. could you please tell me what is wrong here? Thanks a lot Barry - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Why does SMTP sending mail w/o authentication?
Hi Eric, when will you plan to release the James BETA1? the JPA-mailbox v0.2 will be still used in BETA1? because we have some specified requirement, we have to do some customization on JPA-mailbox, Thanks, Barry 2011/6/12 Eric Charles > Hi Barry, > > Yes, you're right. > > The documentation we will put online with the release of sever beta1 will > state for authorizedAddresses in smtpserver.xml > > If you use SMTP AUTH, addresses that match those specified here will be > permitted to relay without SMTP AUTH. If you do not use SMTP AUTH, and you > specify addreses here, then only addresses that match those specified will > be permitted to relay. > > Addresses may be specified as a an IP address or domain name, with an > optional netmask, e.g. 127.*, 127.0.0.0/8, 127.0.0.0/255.0.0.0, and > localhost/8 are all the same > > See also the RemoteAddrNotInNetwork matcher in the transport processor. You > would generally use one OR the other approach. > > Tks, > - Eric > > > On 12/06/11 03:57, Barry wrote: > >> Hi maybe I made a mistake here. >> >> 127.0.0.0/8 >> >> does this line mean the localhost will automatically be authorized? is it >> correct? >> >> Thanks, >> Barry >> >> >> 2011/6/12 Barry >> >> Hi I am using the James-M3-Snapshot-06012011, I am being confused by smtp >>> authentication issue. >>> >>> The smtpserver.xml content as below: >>> >>> >>> 0.0.0.0:25 >>> 200 >>> >>> >>> 360 >>> 0 >>> 0 >>> 127.0.0.0/8 >>> true >>> true >>> 0 >>> true >>> >>> >> class="org.apache.james.smtpserver.fastfail.ValidRcptHandler"/> >>> >>> >>> >>> >>> >>> But the smtp server can't do authentication, just saying it allows any >>> user >>> to send mail. could you please tell me what is wrong here? >>> >>> Thanks a lot >>> Barry >>> >>> >>> >> > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > >
Re: Imap status
Hi, I'm a bit lost... The vote for imap-0.2.1 is open wich is coherent with [1] (only 0.2 is release) However, the beta1 proposal (I'm running fine now btw) refers and contains a imap-0.2.1 which is not yet released. I must miss something... Tks, - Eric [1] https://repository.apache.org/content/repositories/releases/org/apache/james/apache-james-imap-api/ On 11/06/11 13:01, Eric Charles wrote: 0.2.x, of course :) I will add a table on the imap web site with the supported extension per version. Sure, we can rely for now on dovecot testsuite. For the "how to test", we can simply link for now to http://www.imapwiki.org/ImapTest In the long run, mailbox-integration-tests could be enhanced. Tks, - Eric On 11/06/11 12:53, Norman Maurer wrote: Hi there, first of its 0.2 and 0.2.1 ;) For the rest see inside Am Samstag, 11. Juni 2011 schrieb Eric Charles: Hi, This weekend, I will test server-beta1 (ok so far), imap-2.0.1 and will update documentation for the releases. Is the following correct (Norman was so fast I could even not follow him :) IMAP4rev1 2.0 0.2 LITERAL+ 2.0 0.2 CHILDREN 0.2 I18NLEVEL=1 2.0.1 0.2.1 WITHIN 2.0.1 0.2 ESEARCH 2.0.1 0.2.1 SEARCHRES 2.0.1 0.2.1 IDLE 2.0 0.2 NAMESPACE 2.0 0.2 UIDPLUS 2.0 0.2 UNSELECT 2.0.1 0.2 AUTH=PLAIN 2.0.1 0.2.1 SASL-IR 2.0.1 0.2.1 ENABLE 2.0.1 0.2.1 Also, are there specific tests for all these imap extensions (what is the test coverage ?). You can most of them test with dovecot's imaptest. I will write an email later and explain how Tks, - Eric - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org bye norman - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1266) Found an exception when sending a mail
[ https://issues.apache.org/jira/browse/JAMES-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048254#comment-13048254 ] Eric Charles commented on JAMES-1266: - I think I've got a scenario for the PersistenceException giving the NPE. If the database holds for 8 hours, JPA will finally give the PersistenceException, but in the meantime, the socket has timed-out, and the protocols sessions is expired, as all it attached fields instances, giving the NPE. We probably should better log the exceptions in the JPA layer. > Found an exception when sending a mail > -- > > Key: JAMES-1266 > URL: https://issues.apache.org/jira/browse/JAMES-1266 > Project: JAMES Server > Issue Type: Bug > Components: Build System >Reporter: Barry > > DEBUG 09:02:08,281 | james.smtpserver | Unable to process request > > org.apache.openjpa.persistence.InvalidStateException: This operation cannot > be performed while a Transaction is active. > at org.apache.openjpa.kernel.BrokerImpl.close(BrokerImpl.java:4304) > at > org.apache.openjpa.kernel.DelegatingBroker.close(DelegatingBroker.java:1346) > at > org.apache.openjpa.persistence.EntityManagerImpl.close(EntityManagerImpl.java:1284) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > at java.lang.reflect.Method.invoke(Unknown Source) > at > org.springframework.orm.jpa.ExtendedEntityManagerCreator$ExtendedEntityManagerInvocationHandler.invoke(ExtendedEntityManagerCreator.java:365) > at $Proxy55.close(Unknown Source) > at > org.apache.james.domainlist.jpa.JPADomainList.containsDomain(JPADomainList.java:119) > at > org.apache.james.smtpserver.fastfail.ValidRcptHandler.isLocalDomain(ValidRcptHandler.java:152) > at > org.apache.james.protocols.smtp.core.fastfail.AbstractValidRcptHandler.doRcpt(AbstractValidRcptHandler.java:49) > at > org.apache.james.protocols.smtp.core.RcptCmdHandler.callHook(RcptCmdHandler.java:249) > at > org.apache.james.protocols.smtp.core.RcptCmdHandler.callHook(RcptCmdHandler.java:39) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.processHooks(AbstractHookableCmdHandler.java:92) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.onCommand(AbstractHookableCmdHandler.java:59) > at > org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler.onCommand(AbstractHookableCmdHandler.java:40) > at > org.apache.james.protocols.api.AbstractCommandDispatcher.onLine(AbstractCommandDispatcher.java:150) > at > org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.messageReceived(AbstractChannelUpstreamHandler.java:122) > at > org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69) > at > org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:316) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown > Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > DEBUG 09:02:08,453 | james.smtpserver | Unable to process request > java.lang.NullPointerException > at > org.apache.james.protocols.api.AbstractCommandDispatcher.onLine(AbstractCommandDispatcher.java:140) > at > org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.messageReceived(AbstractChannelUpstreamHandler.java:122) > at > org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69) > at > org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:316) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown > Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JAMES-1268) Better log PersistenceException
Better log PersistenceException --- Key: JAMES-1268 URL: https://issues.apache.org/jira/browse/JAMES-1268 Project: JAMES Server Issue Type: Improvement Reporter: Eric Charles We could log the "cause" of the PersistenceException. See discussions on https://issues.apache.org/jira/browse/JAMES-1266 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Imap status
Thats right. I included the not yet released imap version in the beta to speed up things. thats why I said that we first need to release the imap version . bye Norman Am Sonntag, 12. Juni 2011 schrieb Eric Charles : > Hi, > > I'm a bit lost... > > The vote for imap-0.2.1 is open wich is coherent with [1] (only 0.2 is > release) > > However, the beta1 proposal (I'm running fine now btw) refers and contains a > imap-0.2.1 which is not yet released. > > I must miss something... > Tks, > - Eric > > [1] > https://repository.apache.org/content/repositories/releases/org/apache/james/apache-james-imap-api/ > > > On 11/06/11 13:01, Eric Charles wrote: > > 0.2.x, of course :) > I will add a table on the imap web site with the supported extension per > version. > > Sure, we can rely for now on dovecot testsuite. For the "how to test", > we can simply link for now to http://www.imapwiki.org/ImapTest > In the long run, mailbox-integration-tests could be enhanced. > > Tks, > - Eric > > > On 11/06/11 12:53, Norman Maurer wrote: > > Hi there, > > first of its 0.2 and 0.2.1 ;) For the rest see inside > > Am Samstag, 11. Juni 2011 schrieb Eric Charles: > > Hi, > > This weekend, I will test server-beta1 (ok so far), imap-2.0.1 and > will update documentation for the releases. > > Is the following correct (Norman was so fast I could even not follow > him :) > > IMAP4rev1 2.0 > > 0.2 > > > LITERAL+ 2.0 > > 0.2 > > > CHILDREN > > 0.2 > > > I18NLEVEL=1 2.0.1 > > 0.2.1 > > > WITHIN 2.0.1 > > 0.2 > > > ESEARCH 2.0.1 > > 0.2.1 > > > SEARCHRES 2.0.1 > > 0.2.1 > > > IDLE 2.0 > > 0.2 > > > NAMESPACE 2.0 > > 0.2 > > > UIDPLUS 2.0 > > 0.2 > > > UNSELECT 2.0.1 > > 0.2 > > > AUTH=PLAIN 2.0.1 > > 0.2.1 > > > SASL-IR 2.0.1 > > 0.2.1 > > > ENABLE 2.0.1 > > 0.2.1 > > > > Also, are there specific tests for all these imap extensions (what is > the test coverage ?). > > > > You can most of them test with dovecot's imaptest. I will write an > email later and explain how > > > Tks, > - Eric > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > > > > > bye > norman > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > > > > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > > > > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
