Re: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
Noel,
thank you for noticing this.
I added a testcase and fixed it.
Should we add another try/catch level for the second mx so that an
exception to the second lookup would result in the A record? (otherwise
null)
Stefano
Noel J. Bergman wrote:
I was just looking over the fix ...
Shouldn't the return of the CNAME's MX records follow the pattern, and be:
return Collections.unmodifiableCollection(cnameMXrecords);
Have we discussed this before? The try { return } finally { return } code
there is an ugly pattern, and I seem to recall us discussing that pattern
previously.
--- Noel
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
I was just looking over the fix ...
Shouldn't the return of the CNAME's MX records follow the pattern, and be:
return Collections.unmodifiableCollection(cnameMXrecords);
Have we discussed this before? The try { return } finally { return } code
there is an ugly pattern, and I seem to recall us discussing that pattern
previously.
--- Noel
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
FYI, I compared our codes and while functionally equivalent, I must admit that your fix was cleaner and simpler ;-( So let us stick to that. --Søren On Wednesday 07 September 2005 09:25, Stefano Bagnara wrote: You move fast Stefano! I was about to commit my fix for it, when I ran into the SpoolManager issues. I will compare our fixes :-) Feel free to overwrite my changes with yours! Mine has been a really fast fix. I will run my test against your code, eventually! Stefano PS: sorry, I've seen you have the bug assigned but I was not sure you were working on it so I gave it a try. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Søren Hilmer, M.Sc. RD manager Phone: +45 72 30 64 00 TietoEnator IT+ A/S Fax:+45 72 30 64 02 Ved Lunden 12 Direct: +45 72 30 64 57 DK-8230 Åbyhøj Email: soren.hilmer at tietoenator.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
You move fast Stefano! I was about to commit my fix for it, when I ran into the SpoolManager issues. I will compare our fixes :-) --Søren On Wednesday 07 September 2005 00:34, Stefano Bagnara (JIRA) wrote: [ http://issues.apache.org/jira/browse/JAMES-413?page=all ] Stefano Bagnara resolved JAMES-413: --- Resolution: Fixed I was working on DNSServer so I fixed this: Soren, please review the patch. James does not resolve CNAME DNS registrations -- Key: JAMES-413 URL: http://issues.apache.org/jira/browse/JAMES-413 Project: James Type: Bug Components: DNSServer Versions: 2.2.0 Reporter: Soren Hilmer Assignee: Stefano Bagnara Fix For: 2.3.0 Attachments: DNSServerTest.java James does not resolve CNAME DNS entries as required by RFC-2821 sections 3.6 and 5 -- Søren Hilmer, M.Sc. RD manager Phone: +45 72 30 64 00 TietoEnator IT+ A/S Fax:+45 72 30 64 02 Ved Lunden 12 Direct: +45 72 30 64 57 DK-8230 Åbyhøj Email: soren.hilmer at tietoenator.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
You move fast Stefano! I was about to commit my fix for it, when I ran into the SpoolManager issues. I will compare our fixes :-) Feel free to overwrite my changes with yours! Mine has been a really fast fix. I will run my test against your code, eventually! Stefano PS: sorry, I've seen you have the bug assigned but I was not sure you were working on it so I gave it a try. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
[ http://issues.apache.org/jira/browse/JAMES-413?page=all ] Stefano Bagnara resolved JAMES-413: --- Resolution: Fixed I was working on DNSServer so I fixed this: Soren, please review the patch. James does not resolve CNAME DNS registrations -- Key: JAMES-413 URL: http://issues.apache.org/jira/browse/JAMES-413 Project: James Type: Bug Components: DNSServer Versions: 2.2.0 Reporter: Soren Hilmer Assignee: Stefano Bagnara Fix For: 2.3.0 Attachments: DNSServerTest.java James does not resolve CNAME DNS entries as required by RFC-2821 sections 3.6 and 5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
