Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Hi Fairoz, I can push them. Please share the patch if you have not yet found sponsor. Thanks, Yasumasa On 2020/01/06 16:57, Fairoz Matte wrote: Hi, I have created patches for jdk8u-dev and jdk11u-dev and attached to the bug report. As I am not a committer for both the projects, could some one please sponsor this push? Thanks, Fairoz -Original Message- From: Chris Plummer Sent: Tuesday, December 17, 2019 12:42 AM To: Kevin Walls ; Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled +1 On 12/16/19 8:35 AM, Kevin Walls wrote: Great! 8-) On 16/12/2019 15:36, Fairoz Matte wrote: Oh yes, Thanks Kevin for the review. Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02 Thanks, Fairoz
RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Hi, I have created patches for jdk8u-dev and jdk11u-dev and attached to the bug report. As I am not a committer for both the projects, could some one please sponsor this push? Thanks, Fairoz -Original Message- From: Chris Plummer Sent: Tuesday, December 17, 2019 12:42 AM To: Kevin Walls ; Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled +1 On 12/16/19 8:35 AM, Kevin Walls wrote: > Great! 8-) > > On 16/12/2019 15:36, Fairoz Matte wrote: >> Oh yes, >> Thanks Kevin for the review. >> >> Corrected the same - >> http://cr.openjdk.java.net/~fmatte/8235637/webrev.02 >> >> Thanks, >> Fairoz >>
Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
+1 On 12/16/19 8:35 AM, Kevin Walls wrote: Great! 8-) On 16/12/2019 15:36, Fairoz Matte wrote: Oh yes, Thanks Kevin for the review. Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02 Thanks, Fairoz
Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Great! 8-) On 16/12/2019 15:36, Fairoz Matte wrote: Oh yes, Thanks Kevin for the review. Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02 Thanks, Fairoz
RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Oh yes, Thanks Kevin for the review. Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02 Thanks, Fairoz -Original Message- From: Kevin Walls Sent: Monday, December 16, 2019 8:44 PM To: Fairoz Matte ; Chris Plummer ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Nice to know the difference between something that is zero, and something that has failed. 8-) ...oops, that says INAVLID_LOAD_ADDRESS ..not INVALID, so other that the typo yes it looks good. --- Kevin On 13/12/2019 13:02, Fairoz Matte wrote: > Hi Chris, > > Thanks for the review, > > Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro for -1L. > I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L. > http://cr.openjdk.java.net/~fmatte/8235637/webrev.01/ > > Thanks, > Fairoz > > -Original Message- > From: Chris Plummer > Sent: Thursday, December 12, 2019 9:48 PM > To: Fairoz Matte ; > serviceability-dev@openjdk.java.net > Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work > if prelink is enabled > > Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. > > Chris > > On 12/11/19 7:10 PM, Fairoz Matte wrote: >> Hi, >> >> Please review this small change, >> Updating error handling, to make sure "lib_base_diff = 0" is still a valid >> scenario even after calc_prelinked_load_address() call. >> >> JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 >> Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ >> >> This patch is provided by Yasumasa Suenaga >> >> Thanks, >> Fairoz
Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Nice to know the difference between something that is zero, and something that has failed. 8-) ...oops, that says INAVLID_LOAD_ADDRESS ..not INVALID, so other that the typo yes it looks good. --- Kevin On 13/12/2019 13:02, Fairoz Matte wrote: Hi Chris, Thanks for the review, Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro for -1L. I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L. http://cr.openjdk.java.net/~fmatte/8235637/webrev.01/ Thanks, Fairoz -Original Message- From: Chris Plummer Sent: Thursday, December 12, 2019 9:48 PM To: Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. Chris On 12/11/19 7:10 PM, Fairoz Matte wrote: Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after calc_prelinked_load_address() call. JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ This patch is provided by Yasumasa Suenaga Thanks, Fairoz
RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Thanks Chris, > -Original Message- > From: Chris Plummer > Sent: Friday, December 13, 2019 11:09 PM > To: Fairoz Matte ; serviceability- > d...@openjdk.java.net > Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if > prelink is enabled > > Looks good. > > thanks, > > Chris > > On 12/13/19 5:02 AM, Fairoz Matte wrote: > > Hi Chris, > > > > Thanks for the review, > > > > Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro > for -1L. > > I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L. > > http://cr.openjdk.java.net/~fmatte/8235637/webrev.01/ > > > > Thanks, > > Fairoz > > > > -Original Message- > > From: Chris Plummer > > Sent: Thursday, December 12, 2019 9:48 PM > > To: Fairoz Matte ; serviceability- > d...@openjdk.java.net > > Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if > prelink is enabled > > > > Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or > LOAD_ADDRESS_ERROR. > > > > Chris > > > > On 12/11/19 7:10 PM, Fairoz Matte wrote: > >> Hi, > >> > >> Please review this small change, > >> Updating error handling, to make sure "lib_base_diff = 0" is still a valid > scenario even after calc_prelinked_load_address() call. > >> > >> JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 > >> Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ > >> > >> This patch is provided by Yasumasa Suenaga > >> > >> Thanks, > >> Fairoz >
Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Looks good. thanks, Chris On 12/13/19 5:02 AM, Fairoz Matte wrote: Hi Chris, Thanks for the review, Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro for -1L. I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L. http://cr.openjdk.java.net/~fmatte/8235637/webrev.01/ Thanks, Fairoz -Original Message- From: Chris Plummer Sent: Thursday, December 12, 2019 9:48 PM To: Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. Chris On 12/11/19 7:10 PM, Fairoz Matte wrote: Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after calc_prelinked_load_address() call. JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ This patch is provided by Yasumasa Suenaga Thanks, Fairoz
RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Hi Chris, Thanks for the review, Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro for -1L. I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L. http://cr.openjdk.java.net/~fmatte/8235637/webrev.01/ Thanks, Fairoz -Original Message- From: Chris Plummer Sent: Thursday, December 12, 2019 9:48 PM To: Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. Chris On 12/11/19 7:10 PM, Fairoz Matte wrote: > Hi, > > Please review this small change, > Updating error handling, to make sure "lib_base_diff = 0" is still a valid > scenario even after calc_prelinked_load_address() call. > > JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 > Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ > > This patch is provided by Yasumasa Suenaga > > Thanks, > Fairoz
Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. Chris On 12/11/19 7:10 PM, Fairoz Matte wrote: Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after calc_prelinked_load_address() call. JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ This patch is provided by Yasumasa Suenaga Thanks, Fairoz
RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Hi Yasumasa, Thanks for the review. Sure, I will get them on 8u and 11u. Thanks, Fairoz > -Original Message- > From: Yasumasa Suenaga > Sent: Thursday, December 12, 2019 9:14 AM > To: Fairoz Matte ; serviceability- > d...@openjdk.java.net > Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if > prelink is enabled > > Hi Fairoz, > > Looks good! > I want you to backport this change to both jdk11u and 8u. > > > Thanks, > > Yasumasa > > > On 2019/12/12 12:10, Fairoz Matte wrote: > > Hi, > > > > Please review this small change, > > Updating error handling, to make sure "lib_base_diff = 0" is still a valid > scenario even after calc_prelinked_load_address() call. > > > > JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 > > Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ > > > > This patch is provided by Yasumasa Suenaga > > > > Thanks, > > Fairoz > >
Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Hi Fairoz, Looks good! I want you to backport this change to both jdk11u and 8u. Thanks, Yasumasa On 2019/12/12 12:10, Fairoz Matte wrote: Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after calc_prelinked_load_address() call. JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ This patch is provided by Yasumasa Suenaga Thanks, Fairoz
RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled
Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after calc_prelinked_load_address() call. JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ This patch is provided by Yasumasa Suenaga Thanks, Fairoz
