Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v2]

2024-01-14 Thread Tom Rodriguez 
On Fri, 12 Jan 2024 21:46:13 GMT, Vladimir Kozlov  wrote:

>> Tom Rodriguez has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix problem list and correct jtreg arguments
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbTestAllocationMerge.java line 36:
> 
>> 34:  * @requires vm.hasSA
>> 35:  * @library /test/lib
>> 36:  * @run main/othervm -XX:CompileThresholdScaling=0.01 
>> -XX:CompileCommand=compileonly,compiler.c2.HeapDumper::testIt 
>> -XX:CompileCommand=exclude,compiler.c2.HeapDumper::dummy 
>> ClhsdbTestAllocationMerge
> 
> `LingeredAppWithAllocationMerge` instead of `compiler.c2.HeapDumper`

Those options are actually in the wrong place since they actually need to be 
passed to the lingered app but it also seems like they are wrong.  I'd 
confirmed that the the test as written actually failed without the SA changes 
but when I added these arguments to the launch of the lingered app it no longer 
failed.  So since it properly detects the problem without any arguments I'm 
just going to drop them from the @run directive.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/17407#discussion_r1451932539

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v2]

2024-01-14 Thread Tom Rodriguez 
> The changes for JDK-8287061 didn't update the SA decoding logic and there are 
> other places where the decoding has gotten out of sync with HotSpot.  Some of 
> them can't be tested because they are part of JVMCI but I've added a directed 
> test for the JDK-8287061 code and a more brute force test that tries to 
> decode everything.

Tom Rodriguez has updated the pull request incrementally with one additional 
commit since the last revision:

  Fix problem list and correct jtreg arguments

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17407/files
  - new: https://git.openjdk.org/jdk/pull/17407/files/c0618b46..278377fd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=17407=01
 - incr: https://webrevs.openjdk.org/?repo=jdk=17407=00-01

  Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17407.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17407/head:pull/17407

PR: https://git.openjdk.org/jdk/pull/17407