On Fri, 12 Jan 2024 21:46:13 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:
>> Tom Rodriguez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix problem list and correct jtreg arguments > > test/hotspot/jtreg/serviceability/sa/ClhsdbTestAllocationMerge.java line 36: > >> 34: * @requires vm.hasSA >> 35: * @library /test/lib >> 36: * @run main/othervm -XX:CompileThresholdScaling=0.01 >> -XX:CompileCommand=compileonly,compiler.c2.HeapDumper::testIt >> -XX:CompileCommand=exclude,compiler.c2.HeapDumper::dummy >> ClhsdbTestAllocationMerge > > `LingeredAppWithAllocationMerge` instead of `compiler.c2.HeapDumper` Those options are actually in the wrong place since they actually need to be passed to the lingered app but it also seems like they are wrong. I'd confirmed that the the test as written actually failed without the SA changes but when I added these arguments to the launch of the lingered app it no longer failed. So since it properly detects the problem without any arguments I'm just going to drop them from the @run directive. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17407#discussion_r1451932539
