[jira] Assigned: (SLING-646) jcrinstall - take two
[ https://issues.apache.org/jira/browse/SLING-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-646: - Assignee: Bertrand Delacretaz > jcrinstall - take two > - > > Key: SLING-646 > URL: https://issues.apache.org/jira/browse/SLING-646 > Project: Sling > Issue Type: New Feature > Components: OSGi >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > Based on the jcrinstall [1] and jcrbundles [2][SLiNG-587] experiments, and > after playing a bit with these modules and talking to (our) Felix, I'll start > re-implementing the jcrinstall module under sling/extensions/jcrinstall, > based on a mix of both codebases (jcrbundles was based on the existing > jcrinstall anyway, so it's a mix already). > Here's a quick specification. > The jcrinstall module looks for OSGi resources (bundles in jar files, > configurations in text (.cfg) files, deployment packages in .dp files) under > a configurable set of paths in the repository. > Those resources are "installed" in the OSGi framework when detected: bundles, > deployment packages and configurations are installed, updated or removed as > needed. > The jcrinstall module is considered as another "user interface" to the OSGi > framework, besides the existing OSGi console, and as such aims to play well > with the console, and avoid any inconsistencies when both user interfaces are > used. That's only a best effort, though, as we'll probably find edge cases > when using both can cause problems. > The module is split in two components: > = OSGi controller component = > Receives notifications of new, updated or deleted OSGi resources from the JCR > observation component. > Does not use any JCR interfaces, so as to be reusable independently. > Manages the required queues and retries to ensure that received bundles, > configurations and deployment packages are eventually activated, even if > their dependencies are made available later. > Provides permanent storage (based on BundleContext.getDataFile()) for the JCR > component to store Properties for the resources that it detects. > Uses handlers based on a common interface for the various types of resources > (bundles, configs, deployment packages). > = JCR observation component = > Observes a number of folders in the JCR repository, based on configurable > regular expressions for their paths. The default regexp causes folders named > "install" to be observed. > Limited to a configurable list of root paths, by default /libs and /apps. > Detects added or modified files in those folders and notifies the OSGi > controller of these events, providing the file's InputStream with the event, > along with an event type. > Uses the permanent storage provided by the OSGi controller to store > information that allows for detecting updates and deletes of OSGi resources. > = coda = > Splitting the module in two well-separated components should also help > automated testing - as described above, both components should be readily > testable without requiring complicated setups. > [1] http://svn.apache.org/repos/asf/incubator/sling/whiteboard/jcrinstall/ > [2] http://svn.apache.org/repos/asf/incubator/sling/whiteboard/jcrbundles/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-646) jcrinstall - take two
jcrinstall - take two - Key: SLING-646 URL: https://issues.apache.org/jira/browse/SLING-646 Project: Sling Issue Type: New Feature Components: OSGi Reporter: Bertrand Delacretaz Based on the jcrinstall [1] and jcrbundles [2][SLiNG-587] experiments, and after playing a bit with these modules and talking to (our) Felix, I'll start re-implementing the jcrinstall module under sling/extensions/jcrinstall, based on a mix of both codebases (jcrbundles was based on the existing jcrinstall anyway, so it's a mix already). Here's a quick specification. The jcrinstall module looks for OSGi resources (bundles in jar files, configurations in text (.cfg) files, deployment packages in .dp files) under a configurable set of paths in the repository. Those resources are "installed" in the OSGi framework when detected: bundles, deployment packages and configurations are installed, updated or removed as needed. The jcrinstall module is considered as another "user interface" to the OSGi framework, besides the existing OSGi console, and as such aims to play well with the console, and avoid any inconsistencies when both user interfaces are used. That's only a best effort, though, as we'll probably find edge cases when using both can cause problems. The module is split in two components: = OSGi controller component = Receives notifications of new, updated or deleted OSGi resources from the JCR observation component. Does not use any JCR interfaces, so as to be reusable independently. Manages the required queues and retries to ensure that received bundles, configurations and deployment packages are eventually activated, even if their dependencies are made available later. Provides permanent storage (based on BundleContext.getDataFile()) for the JCR component to store Properties for the resources that it detects. Uses handlers based on a common interface for the various types of resources (bundles, configs, deployment packages). = JCR observation component = Observes a number of folders in the JCR repository, based on configurable regular expressions for their paths. The default regexp causes folders named "install" to be observed. Limited to a configurable list of root paths, by default /libs and /apps. Detects added or modified files in those folders and notifies the OSGi controller of these events, providing the file's InputStream with the event, along with an event type. Uses the permanent storage provided by the OSGi controller to store information that allows for detecting updates and deletes of OSGi resources. = coda = Splitting the module in two well-separated components should also help automated testing - as described above, both components should be readily testable without requiring complicated setups. [1] http://svn.apache.org/repos/asf/incubator/sling/whiteboard/jcrinstall/ [2] http://svn.apache.org/repos/asf/incubator/sling/whiteboard/jcrbundles/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-645) sling:superResourceType not taken into account for StarResource
sling:superResourceType not taken into account for StarResource --- Key: SLING-645 URL: https://issues.apache.org/jira/browse/SLING-645 Project: Sling Issue Type: Bug Components: Engine Reporter: Bertrand Delacretaz Priority: Minor Given: 1) Rendering scripts at /apps/foo/foo.esp, /apps/bar/bar.esp, /apps/bar/ta.esp 2) /apps/foo having sling:resourceSuperType=bar 3) /realfoo having sling:resourceType=foo Rendering results: a) http://localhost:/content/bar/*.html is rendered by bar.esp -> ok b) http://localhost:/content/bar/*.ta.html is rendered by ta.esp -> ok c) http://localhost:/realfoo.ta.html is rendered by ta.esp -> ok d) http://localhost:/content/foo/*.ta.html is rendered by foo.esp -> should be ta.esp It seems like 2) is not taken into account for a StarResource. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-490) SlingStatusServlet - find out whether a Sling application is ready after startup
[ https://issues.apache.org/jira/browse/SLING-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627628#action_12627628 ] Bertrand Delacretaz commented on SLING-490: --- Resetting the flag on any "bundle stopped" or "bundle updated" event might be useful during development, to have Sling return a 503 status while updates are in progress. > SlingStatusServlet - find out whether a Sling application is ready after > startup > > > Key: SLING-490 > URL: https://issues.apache.org/jira/browse/SLING-490 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Bertrand Delacretaz >Priority: Minor > > Being discussed in http://markmail.org/message/jtdnqneoudxbmb6k -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-638) JcrResourceResolver needs more tests (mappings, virtual URLs, regexps, ...)
JcrResourceResolver needs more tests (mappings, virtual URLs, regexps, ...) --- Key: SLING-638 URL: https://issues.apache.org/jira/browse/SLING-638 Project: Sling Issue Type: Test Components: JCR Resource Affects Versions: JCR Resource 2.0.2 Reporter: Bertrand Delacretaz Priority: Minor The virtual URLs, mappings, regexps (and maybe some other features) are currently not verified by the automated tests. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-636) Log more info about script engine extension mappings
[ https://issues.apache.org/jira/browse/SLING-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627423#action_12627423 ] Bertrand Delacretaz commented on SLING-636: --- A web console plugin would be better, of course! > Log more info about script engine extension mappings > > > Key: SLING-636 > URL: https://issues.apache.org/jira/browse/SLING-636 > Project: Sling > Issue Type: Improvement >Affects Versions: Scripting Core 2.0.2 >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: Scripting Core 2.0.4 > > > Logging exactly which script extensions are handled by which ScriptEngine > would help troubleshooting new ScriptEngines. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-636) Log more info about script engine extension mappings
[ https://issues.apache.org/jira/browse/SLING-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-636. --- Resolution: Fixed In revision 690922, script extension mapping info is logged at the INFO level for each extension found in any valid ScriptEngine provided by a bundle or service. This happens every time the ScriptEngineManager is reinitialized, for example if a new bundle with a META-INF/services/javax.script.ScriptEngineFactory entry. Note that the ScriptEngineManager is initialized on demand, when a ScriptEngine needs to be found for a script, so after installing a new ScriptEngine bundle one needs to make a request that uses a script (for example request content/foo/*.html and put a script a /apps/foo/foo.xyz) to see those log messages. Example log message: Script extension 'ecma' is now handled by ScriptEngine 'Sling - Scripting - JavaScript Support (Rhino 1.6 release 6 2007 07 26)', version='2.0.3-incubator-SNAPSHOT', class='org.apache.sling.scripting.javascript.RhinoJavaScriptEngine' > Log more info about script engine extension mappings > > > Key: SLING-636 > URL: https://issues.apache.org/jira/browse/SLING-636 > Project: Sling > Issue Type: Improvement >Affects Versions: Scripting Core 2.0.2 >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: Scripting Core 2.0.4 > > > Logging exactly which script extensions are handled by which ScriptEngine > would help troubleshooting new ScriptEngines. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-636) Log more info about script engine extension mappings
Log more info about script engine extension mappings Key: SLING-636 URL: https://issues.apache.org/jira/browse/SLING-636 Project: Sling Issue Type: Improvement Affects Versions: Scripting Core 2.0.2 Reporter: Bertrand Delacretaz Priority: Minor Fix For: Scripting Core 2.0.4 Logging exactly which script extensions are handled by which ScriptEngine would help troubleshooting new ScriptEngines. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-490) SlingStatusServlet - find out whether a Sling application is ready after startup
[ https://issues.apache.org/jira/browse/SLING-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627403#action_12627403 ] Bertrand Delacretaz commented on SLING-490: --- As discussed in http://markmail.org/message/4qf7hc6vufzpcsnv it might be useful to allow the "readyness flag" to be reset, to cause the readyness to be evaluated from scratch again. This would be useful in development: resetting the flag after a bundle update (assuming the OSGi console or whatever is doing the update generates an event when that happens) would cause Sling to return a 503 code until the update is complete. > SlingStatusServlet - find out whether a Sling application is ready after > startup > > > Key: SLING-490 > URL: https://issues.apache.org/jira/browse/SLING-490 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Bertrand Delacretaz >Priority: Minor > > Being discussed in http://markmail.org/message/jtdnqneoudxbmb6k -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-428) [Javascript] allow Server-side inclusion of Javascript files
[ https://issues.apache.org/jira/browse/SLING-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-428. - Assignee: Bertrand Delacretaz (was: Felix Meschberger) Integration tests for the load() and print() functions added in revisions 690209 and 690210 > [Javascript] allow Server-side inclusion of Javascript files > > > Key: SLING-428 > URL: https://issues.apache.org/jira/browse/SLING-428 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Lars Trieloff >Assignee: Bertrand Delacretaz > Fix For: 2.0.0 > > Attachments: SLING-428.patch > > > For the sake of modularizing server-side Javascript libraries, it is > advisable to have an inclusion mechanism. Javascript does not have an > standardized way of handling inclusions, so I propose to use the conventions > established by the Rhino Javascript Shell > (http://www.mozilla.org/rhino/shell.html) which is introducing a load() > function in the global scope, loading and evaluating a Javascript file in the > current scope. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-632) Ruby script engine does not start due to missing dependencies
[ https://issues.apache.org/jira/browse/SLING-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-632. - Resolution: Fixed Thanks for the hint Felix, with this I could go back to the latest jruby 1.1.3, in revision 689741. Tested with the erb script shown above. > Ruby script engine does not start due to missing dependencies > - > > Key: SLING-632 > URL: https://issues.apache.org/jira/browse/SLING-632 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > In revision 689730, the ruby script engine bundle does not start if loaded, > due to the following missing dependencies: > !! com.sun.mirror.apt,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.declaration,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.type,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.util,version=0.0.0 from -- Cannot be resolved > !! org.apache.bsf,version=0.0.0 from -- Cannot be resolved > !! org.apache.bsf.util,version=0.0.0 from -- Cannot be resolved > !! sun.misc,version=0.0.0 from -- Cannot be resolved > For now, I'll downgrade the jruby dependency to 1.0, as that used to work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-632) Ruby script engine does not start due to missing dependencies
[ https://issues.apache.org/jira/browse/SLING-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reopened SLING-632: --- Not all of them: javax.swing.*; org.apache.bsf.*; sun.misc; resolution:=optional I'll try as you suggest, with jruby 1.1.1 > Ruby script engine does not start due to missing dependencies > - > > Key: SLING-632 > URL: https://issues.apache.org/jira/browse/SLING-632 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > In revision 689730, the ruby script engine bundle does not start if loaded, > due to the following missing dependencies: > !! com.sun.mirror.apt,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.declaration,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.type,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.util,version=0.0.0 from -- Cannot be resolved > !! org.apache.bsf,version=0.0.0 from -- Cannot be resolved > !! org.apache.bsf.util,version=0.0.0 from -- Cannot be resolved > !! sun.misc,version=0.0.0 from -- Cannot be resolved > For now, I'll downgrade the jruby dependency to 1.0, as that used to work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-632) Ruby script engine does not start due to missing dependencies
[ https://issues.apache.org/jira/browse/SLING-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-632. - Resolution: Fixed "Fixed" in revision 689731, the scripting.ruby bundle now loads correctly using the launchpad/testing module, and the following script at apps/foo/foo.erb displays the correct path when requesting http://localhost:/content/foo/*.html currentNode path = <%= currentNode.getPath() %>. > Ruby script engine does not start due to missing dependencies > - > > Key: SLING-632 > URL: https://issues.apache.org/jira/browse/SLING-632 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > In revision 689730, the ruby script engine bundle does not start if loaded, > due to the following missing dependencies: > !! com.sun.mirror.apt,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.declaration,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.type,version=0.0.0 from -- Cannot be resolved > !! com.sun.mirror.util,version=0.0.0 from -- Cannot be resolved > !! org.apache.bsf,version=0.0.0 from -- Cannot be resolved > !! org.apache.bsf.util,version=0.0.0 from -- Cannot be resolved > !! sun.misc,version=0.0.0 from -- Cannot be resolved > For now, I'll downgrade the jruby dependency to 1.0, as that used to work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-632) Ruby script engine does not start due to missing dependencies
Ruby script engine does not start due to missing dependencies - Key: SLING-632 URL: https://issues.apache.org/jira/browse/SLING-632 Project: Sling Issue Type: Bug Components: Scripting Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor In revision 689730, the ruby script engine bundle does not start if loaded, due to the following missing dependencies: !! com.sun.mirror.apt,version=0.0.0 from -- Cannot be resolved !! com.sun.mirror.declaration,version=0.0.0 from -- Cannot be resolved !! com.sun.mirror.type,version=0.0.0 from -- Cannot be resolved !! com.sun.mirror.util,version=0.0.0 from -- Cannot be resolved !! org.apache.bsf,version=0.0.0 from -- Cannot be resolved !! org.apache.bsf.util,version=0.0.0 from -- Cannot be resolved !! sun.misc,version=0.0.0 from -- Cannot be resolved For now, I'll downgrade the jruby dependency to 1.0, as that used to work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-630) StarResource does not set correct ResourceMetadata
[ https://issues.apache.org/jira/browse/SLING-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-630: -- Summary: StarResource does not set correct ResourceMetadata (was: StarResource does not adapt to a Map or String) > StarResource does not set correct ResourceMetadata > -- > > Key: SLING-630 > URL: https://issues.apache.org/jira/browse/SLING-630 > Project: Sling > Issue Type: Bug >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: JCR Resource 2.0.4 > > > In revision 689422, requesting http://localhost:/*.txt causes the > Exception shown below. > As a result, the > org.apache.sling.launchpad.webapp.integrationtest.GetStarTest fails. > javax.servlet.ServletException: Resource StarResource, > type=sling:syntheticStarResource, path=/* does not adapt to a map or string. > at > org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.renderResource(PlainTextRendererServlet.java:71) > at > org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.doGet(PlainTextRendererServlet.java:58) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-630) StarResource does not adapt to a Map or String
[ https://issues.apache.org/jira/browse/SLING-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-630. - Resolution: Fixed Fix Version/s: JCR Resource 2.0.4 Fixed in revision 689439, the problem was that StarResource did not initialize the ResourceMetadata correctly after SLING-627 changes. > StarResource does not adapt to a Map or String > -- > > Key: SLING-630 > URL: https://issues.apache.org/jira/browse/SLING-630 > Project: Sling > Issue Type: Bug >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: JCR Resource 2.0.4 > > > In revision 689422, requesting http://localhost:/*.txt causes the > Exception shown below. > As a result, the > org.apache.sling.launchpad.webapp.integrationtest.GetStarTest fails. > javax.servlet.ServletException: Resource StarResource, > type=sling:syntheticStarResource, path=/* does not adapt to a map or string. > at > org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.renderResource(PlainTextRendererServlet.java:71) > at > org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.doGet(PlainTextRendererServlet.java:58) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-630) StarResource does not adapt to a Map or String
[ https://issues.apache.org/jira/browse/SLING-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-630: - Assignee: Bertrand Delacretaz > StarResource does not adapt to a Map or String > -- > > Key: SLING-630 > URL: https://issues.apache.org/jira/browse/SLING-630 > Project: Sling > Issue Type: Bug >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > In revision 689422, requesting http://localhost:/*.txt causes the > Exception shown below. > As a result, the > org.apache.sling.launchpad.webapp.integrationtest.GetStarTest fails. > javax.servlet.ServletException: Resource StarResource, > type=sling:syntheticStarResource, path=/* does not adapt to a map or string. > at > org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.renderResource(PlainTextRendererServlet.java:71) > at > org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.doGet(PlainTextRendererServlet.java:58) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-630) StarResource does not adapt to a Map or String
StarResource does not adapt to a Map or String -- Key: SLING-630 URL: https://issues.apache.org/jira/browse/SLING-630 Project: Sling Issue Type: Bug Reporter: Bertrand Delacretaz Priority: Minor In revision 689422, requesting http://localhost:/*.txt causes the Exception shown below. As a result, the org.apache.sling.launchpad.webapp.integrationtest.GetStarTest fails. javax.servlet.ServletException: Resource StarResource, type=sling:syntheticStarResource, path=/* does not adapt to a map or string. at org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.renderResource(PlainTextRendererServlet.java:71) at org.apache.sling.servlets.get.helpers.PlainTextRendererServlet.doGet(PlainTextRendererServlet.java:58) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-447) Schedule jobs n times
[ https://issues.apache.org/jira/browse/SLING-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625731#action_12625731 ] Bertrand Delacretaz commented on SLING-447: --- Oops, sorry about that - I was fooled by the identical description ;-) > Schedule jobs n times > - > > Key: SLING-447 > URL: https://issues.apache.org/jira/browse/SLING-447 > Project: Sling > Issue Type: Improvement > Components: Commons Scheduler >Affects Versions: 2.0.0 >Reporter: Carsten Ziegeler >Priority: Minor > > Currently its only possible to schedule a job either ones or forever; it > would be nice to schedule a job n times perhaps also starting at a given time > etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-447) Schedule jobs n times
[ https://issues.apache.org/jira/browse/SLING-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-447. - Resolution: Duplicate Duplicate of SLING-448 > Schedule jobs n times > - > > Key: SLING-447 > URL: https://issues.apache.org/jira/browse/SLING-447 > Project: Sling > Issue Type: Improvement > Components: Commons Scheduler >Affects Versions: 2.0.0 >Reporter: Carsten Ziegeler >Priority: Minor > > Currently its only possible to schedule a job either ones or forever; it > would be nice to schedule a job n times perhaps also starting at a given time > etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-615) Some jst's do not work on Mac
[
https://issues.apache.org/jira/browse/SLING-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-615.
---
Resolution: Fixed
Fixed in revision 689056, the servlet that generates the client-side javascript
uses regular expressions to find the in the jst scripts, and those
expressions were wrong.
The problem was visible by looking at the generated js code, for example
http://localhost:/apps/tss/post.jst.jst.js (which is generated from
/apps/tss/post.jst) contained just "out=document;", indicating that the code
generator didn't find a tag.
I have no idea why this could work on some platforms, as the code was clearly
broken ;-)
This simplistic parsing could be problematic, for example including in
an html comment before the actual body breaks it.
Please cross-check and close this issue if ok.
> Some jst's do not work on Mac
> -
>
> Key: SLING-615
> URL: https://issues.apache.org/jira/browse/SLING-615
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Felix Meschberger
>Assignee: Bertrand Delacretaz
> Attachments: tss.zip
>
>
> Michael Marth reported on some JSTs not working on Mac OS X:
> "I saw this problem during a presales training, but thought it is with a
> particular machine only. Now Kathy has sent the mail below where the problem
> with jst's on Macs is described in detail.
> The problem does not occur on Windows
> --
> For some reason, on the mac, Phil and I have had to name some of the files
> that
> you use as jst to esp. (Bertrand suggested this solution while we were in for
> training.) The two problem files are post.jst/esp and html.jst/esp. Naming
> these two files with the .jst extension just returns an empty page. (None of
> our XP buddies are having this problem, only us mac users.) For some reason,
> admin.jst works just fine...(and, yes, I am moving the files up to the tss
> directory as described in the errata)
> Once renamed, post.esp also works just fine.
> However, html.esp is throwing a '"Sling" is not defined' error for the
> following
> statement:
> posts=Sling.getContent("/content/tss/posts", 2);
> I saw in a PDF file on the wiki that I might have to include sling.js as a
> script in the file. And the notes say that I also have to sling-551.js. So I
> included both files in the following fashion, as suggested by the Non CMS Web
> App.pdf document:
>
>
> (and yes, both of those files are in /system)
> However, it is throwing the same error. So I have two questions:
> 1) Why is jst working only intermittently on the mac?
> 2) If we have to rename the files to esp, how can I get html.esp to recognize
> the sling library? Do I have to put sling.js in a different place?"
> I do not have an assessment for this issue. Maybe someone else here ?
> In addition, I also asked for the sample files and logs etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-615) Some jst's do not work on Mac
[
https://issues.apache.org/jira/browse/SLING-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-615:
-
Assignee: Bertrand Delacretaz
> Some jst's do not work on Mac
> -
>
> Key: SLING-615
> URL: https://issues.apache.org/jira/browse/SLING-615
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Felix Meschberger
>Assignee: Bertrand Delacretaz
> Attachments: tss.zip
>
>
> Michael Marth reported on some JSTs not working on Mac OS X:
> "I saw this problem during a presales training, but thought it is with a
> particular machine only. Now Kathy has sent the mail below where the problem
> with jst's on Macs is described in detail.
> The problem does not occur on Windows
> --
> For some reason, on the mac, Phil and I have had to name some of the files
> that
> you use as jst to esp. (Bertrand suggested this solution while we were in for
> training.) The two problem files are post.jst/esp and html.jst/esp. Naming
> these two files with the .jst extension just returns an empty page. (None of
> our XP buddies are having this problem, only us mac users.) For some reason,
> admin.jst works just fine...(and, yes, I am moving the files up to the tss
> directory as described in the errata)
> Once renamed, post.esp also works just fine.
> However, html.esp is throwing a '"Sling" is not defined' error for the
> following
> statement:
> posts=Sling.getContent("/content/tss/posts", 2);
> I saw in a PDF file on the wiki that I might have to include sling.js as a
> script in the file. And the notes say that I also have to sling-551.js. So I
> included both files in the following fashion, as suggested by the Non CMS Web
> App.pdf document:
>
>
> (and yes, both of those files are in /system)
> However, it is throwing the same error. So I have two questions:
> 1) Why is jst working only intermittently on the mac?
> 2) If we have to rename the files to esp, how can I get html.esp to recognize
> the sling library? Do I have to put sling.js in a different place?"
> I do not have an assessment for this issue. Maybe someone else here ?
> In addition, I also asked for the sample files and logs etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-506) RepositoryPinger pings too often
[ https://issues.apache.org/jira/browse/SLING-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-506: -- Fix Version/s: JCR Jackrabbit Server 2.0.4 Affects Version/s: JCR Jackrabbit Server 2.0.2 > RepositoryPinger pings too often > > > Key: SLING-506 > URL: https://issues.apache.org/jira/browse/SLING-506 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Jackrabbit Server 2.0.2 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: JCR Jackrabbit Server 2.0.4 > > > SLING-505 reminds me that I've seen the RepositoryPinger ping way too often, > and a colleague reports seeing two active RepositoryPinger threads in his > system. > We need to test this again, and maybe restructure the code to allow for > automated testing of the ping cycle times. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-506) RepositoryPinger pings too often
[ https://issues.apache.org/jira/browse/SLING-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-506. - Resolution: Fixed Fixed in revision 689045, the ping interval logic was broken. Ping intervals are now set between the configured min and max values, and ramped up if the repository is not available, to avoid pinging too often. Changes to the ping interval are logged at the DEBUG level. If the repository is available immediately at startup, this is logged: Repository Pinger interval set to 1 msec, repository is available If the repository becomes available about 5 seconds after startup, the interval sequence is: 14:19:40.865 Repository Pinger interval set to 200 msec, repository is NOT available 14:19:41.153 Repository Pinger interval set to 400 msec, repository is NOT available 14:19:41.555 Repository Pinger interval set to 800 msec, repository is NOT available 14:19:42.356 Repository Pinger interval set to 1600 msec, repository is NOT available 14:19:43.958 Repository Pinger interval set to 3200 msec, repository is NOT available 14:19:48.013 Repository Pinger interval set to 1 msec, repository is available > RepositoryPinger pings too often > > > Key: SLING-506 > URL: https://issues.apache.org/jira/browse/SLING-506 > Project: Sling > Issue Type: Bug > Components: JCR >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > SLING-505 reminds me that I've seen the RepositoryPinger ping way too often, > and a colleague reports seeing two active RepositoryPinger threads in his > system. > We need to test this again, and maybe restructure the code to allow for > automated testing of the ping cycle times. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-506) RepositoryPinger pings too often
[ https://issues.apache.org/jira/browse/SLING-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-506: - Assignee: Bertrand Delacretaz > RepositoryPinger pings too often > > > Key: SLING-506 > URL: https://issues.apache.org/jira/browse/SLING-506 > Project: Sling > Issue Type: Bug > Components: JCR >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > SLING-505 reminds me that I've seen the RepositoryPinger ping way too often, > and a colleague reports seeing two active RepositoryPinger threads in his > system. > We need to test this again, and maybe restructure the code to allow for > automated testing of the ping cycle times. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-629) Engine builds errors - wrong path to parent pom?
[ https://issues.apache.org/jira/browse/SLING-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-629. - Resolution: Fixed Fixed in revision 689035, thanks for reporting! > Engine builds errors - wrong path to parent pom? > > > Key: SLING-629 > URL: https://issues.apache.org/jira/browse/SLING-629 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.0.4 > Environment: WinXP, Java 1.5.0_16 >Reporter: Moritz Havelock >Priority: Minor > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > The path to the parent pom in sling-enging/pom.xml is set to > "../../parent/pom.xml". > The build seems to work only if this is set to "../parent/pom.xml" -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-587) JcrBundlesManager
[ https://issues.apache.org/jira/browse/SLING-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625331#action_12625331 ] Bertrand Delacretaz commented on SLING-587: --- In revision 688702, BundleEvents are used to avoid processing the list of pending bundles if no bundles have changed since last time it was processed. > JcrBundlesManager > - > > Key: SLING-587 > URL: https://issues.apache.org/jira/browse/SLING-587 > Project: Sling > Issue Type: Improvement > Components: OSGi >Reporter: Bertrand Delacretaz > Attachments: jcr_bundles-r687661.patch > > > See http://markmail.org/message/wey5dod7cm7oalhr for a tentative spec -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-475) Create Integration tests for the sling:include tag
[
https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621443#action_12621443
]
Bertrand Delacretaz commented on SLING-475:
---
Thinking about this again, it would be cool to be able to use the automated
tests as documentation of the sling:include details.
For example, a test could look like
uploadSlingIncludeScript("",
"/apps/include/include.jsp");
final String content = getContent(testNodeUrl);
assertContains(content, "main resource type == bar");
assertContains(content, "included resource type == foo");
For this to work, the uploadSlingIncludeScript method must be created to take a
skeleton test script, insert the sling:include statement in it and upload the
result.
The test scripts (main and included, maybe based on the same skeleton) would
just output lots of info like "main resource type == bar", "main selectors ==
a4 print", etc. that can be checked by the automated test code to verify the
results while documenting the behavior.
> Create Integration tests for the sling:include tag
> --
>
> Key: SLING-475
> URL: https://issues.apache.org/jira/browse/SLING-475
> Project: Sling
> Issue Type: Sub-task
> Components: Scripting JSP
>Reporter: Felix Meschberger
> Attachments: PatchWithError.patch, SLING-475.patch, sling475.patch,
> sling475.patch, sling475.patch, Sling475_simple_patch.patch, working.patch
>
>
> Summary says it all ;-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-595) Webloader ui ROOT.json fails to create subnodes
[
https://issues.apache.org/jira/browse/SLING-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-595.
-
Resolution: Fixed
Fixed in revision 681368, using a bin.json file instead of ROOT.json
> Webloader ui ROOT.json fails to create subnodes
> ---
>
> Key: SLING-595
> URL: https://issues.apache.org/jira/browse/SLING-595
> Project: Sling
> Issue Type: Bug
> Components: Samples
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> This used to work, but I just noticed that the initial content loader fails
> to create the subnodes defined by the ROOT.json file of the
> samples/webloader/ui.
> Error in the logs:
> java.util.EmptyStackException
> at java.util.Stack.peek(Stack.java:79)
> at java.util.Stack.pop(Stack.java:61)
> at
> org.apache.sling.jcr.contentloader.internal.ContentLoader.finishNode(ContentLoader.java:367)
> at
> org.apache.sling.jcr.contentloader.internal.JsonReader.createNode(JsonReader.java:120)
> And the ROOT.json file is:
> {
> "bin" : {
> "jcr:primaryType" : "nt:unstructured",
> "sling" : {
> "jcr:primaryType" : "nt:unstructured",
> "webloader" : {
> "jcr:primaryType" : "nt:unstructured",
> "sling:resourceType" : "sling/webloader"
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-595) Webloader ui ROOT.json fails to create subnodes
Webloader ui ROOT.json fails to create subnodes
---
Key: SLING-595
URL: https://issues.apache.org/jira/browse/SLING-595
Project: Sling
Issue Type: Bug
Components: Samples
Reporter: Bertrand Delacretaz
Priority: Minor
This used to work, but I just noticed that the initial content loader fails to
create the subnodes defined by the ROOT.json file of the samples/webloader/ui.
Error in the logs:
java.util.EmptyStackException
at java.util.Stack.peek(Stack.java:79)
at java.util.Stack.pop(Stack.java:61)
at
org.apache.sling.jcr.contentloader.internal.ContentLoader.finishNode(ContentLoader.java:367)
at
org.apache.sling.jcr.contentloader.internal.JsonReader.createNode(JsonReader.java:120)
And the ROOT.json file is:
{
"bin" : {
"jcr:primaryType" : "nt:unstructured",
"sling" : {
"jcr:primaryType" : "nt:unstructured",
"webloader" : {
"jcr:primaryType" : "nt:unstructured",
"sling:resourceType" : "sling/webloader"
}
}
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-595) Webloader ui ROOT.json fails to create subnodes
[
https://issues.apache.org/jira/browse/SLING-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618676#action_12618676
]
Bertrand Delacretaz commented on SLING-595:
---
I think it is better to use ROOT.json only for setting properties on the root
node, so I'll just rename ROOT.json to bin.json and remove the "bin" level in
it.
> Webloader ui ROOT.json fails to create subnodes
> ---
>
> Key: SLING-595
> URL: https://issues.apache.org/jira/browse/SLING-595
> Project: Sling
> Issue Type: Bug
> Components: Samples
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> This used to work, but I just noticed that the initial content loader fails
> to create the subnodes defined by the ROOT.json file of the
> samples/webloader/ui.
> Error in the logs:
> java.util.EmptyStackException
> at java.util.Stack.peek(Stack.java:79)
> at java.util.Stack.pop(Stack.java:61)
> at
> org.apache.sling.jcr.contentloader.internal.ContentLoader.finishNode(ContentLoader.java:367)
> at
> org.apache.sling.jcr.contentloader.internal.JsonReader.createNode(JsonReader.java:120)
> And the ROOT.json file is:
> {
> "bin" : {
> "jcr:primaryType" : "nt:unstructured",
> "sling" : {
> "jcr:primaryType" : "nt:unstructured",
> "webloader" : {
> "jcr:primaryType" : "nt:unstructured",
> "sling:resourceType" : "sling/webloader"
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-562) Pretty print the json dump
[ https://issues.apache.org/jira/browse/SLING-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-562. --- Resolution: Fixed Patch committed in revision 681080 with some changes to use the tidy selector instead of a request parameter. Examples URLs: http://localhost:/sling-logo.png.tidy.infinity.json http://localhost:/sling-logo.png.tidy.json http://localhost:/sling-logo.png.infinity.json http://localhost:/sling-logo.png.json See also the tests at the end of http://svn.eu.apache.org/repos/asf/incubator/sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/JsonRenderingTest.java Please cross-check and close this issue, and maybe open another one to configure the tidy format as the default. > Pretty print the json dump > -- > > Key: SLING-562 > URL: https://issues.apache.org/jira/browse/SLING-562 > Project: Sling > Issue Type: Improvement > Components: Commons JSON >Affects Versions: Commons JSON 2.0.2, Servlets Get 2.0.2 >Reporter: Tobias Bocanegra >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: json_tidy.r673772.patch > > > the current json exports are using the JSONWriter which writes a very compact > for of json. > this is certainly good for performance, but a big pain when developping / > debugging. > It would be cool if a 'pretty print' flag can be passed to the export that > enables nice > formatted jsons. eg http://localhost/content/site/en.3.json?tidy=true > I patched the current JSONWriter and JsonItemWriter and added the respective > flag to the servlet. > WDYT? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-562) Pretty print the json dump
[ https://issues.apache.org/jira/browse/SLING-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-562: - Assignee: Bertrand Delacretaz > Pretty print the json dump > -- > > Key: SLING-562 > URL: https://issues.apache.org/jira/browse/SLING-562 > Project: Sling > Issue Type: Improvement > Components: Commons JSON >Affects Versions: Commons JSON 2.0.2, Servlets Get 2.0.2 >Reporter: Tobias Bocanegra >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: json_tidy.r673772.patch > > > the current json exports are using the JSONWriter which writes a very compact > for of json. > this is certainly good for performance, but a big pain when developping / > debugging. > It would be cool if a 'pretty print' flag can be passed to the export that > enables nice > formatted jsons. eg http://localhost/content/site/en.3.json?tidy=true > I patched the current JSONWriter and JsonItemWriter and added the respective > flag to the servlet. > WDYT? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-562) Pretty print the json dump
[ https://issues.apache.org/jira/browse/SLING-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618361#action_12618361 ] Bertrand Delacretaz commented on SLING-562: --- For now, I'll apply the patch but using a tidy selector instead of a request parameter > Pretty print the json dump > -- > > Key: SLING-562 > URL: https://issues.apache.org/jira/browse/SLING-562 > Project: Sling > Issue Type: Improvement > Components: Commons JSON >Affects Versions: Commons JSON 2.0.2, Servlets Get 2.0.2 >Reporter: Tobias Bocanegra >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: json_tidy.r673772.patch > > > the current json exports are using the JSONWriter which writes a very compact > for of json. > this is certainly good for performance, but a big pain when developping / > debugging. > It would be cool if a 'pretty print' flag can be passed to the export that > enables nice > formatted jsons. eg http://localhost/content/site/en.3.json?tidy=true > I patched the current JSONWriter and JsonItemWriter and added the respective > flag to the servlet. > WDYT? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-567) sling.include inclides fragments in the wrong order
[ https://issues.apache.org/jira/browse/SLING-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618354#action_12618354 ] Bertrand Delacretaz commented on SLING-567: --- Wouldn't it be less surprising to the user to flush by default? I see your reasoning, but from the user's point of view the default behavior is definitely not what you want. > sling.include inclides fragments in the wrong order > --- > > Key: SLING-567 > URL: https://issues.apache.org/jira/browse/SLING-567 > Project: Sling > Issue Type: Bug >Affects Versions: Scripting JSP 2.0.2 >Reporter: Michael Marth > > (This is observed in revision 670551) > consider a jsp "/apps/myapp/a.jsp" which contains: > aaa > <% sling.include(currentNode.getPath() + ".b.html"); %> > and another jsp "/apps/myapp/b.jsp" which contains > bbb > if i execute /content/myapp/mynode.a.html i get > bbb > aaa > expected result is: > aaa > bbb -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-582) scripting/jst JsCodeGeneratorTest broken under Cygwin on Windows
[ https://issues.apache.org/jira/browse/SLING-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-582. - Resolution: Fixed Patch applied in revision 681061, please cross-check and close this issue if ok. Thanks very much for your contribution! > scripting/jst JsCodeGeneratorTest broken under Cygwin on Windows > > > Key: SLING-582 > URL: https://issues.apache.org/jira/browse/SLING-582 > Project: Sling > Issue Type: Bug > Components: Testing > Environment: Maven version: 2.0.9 > Java version: 1.6.0_03 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" >Reporter: Craig L. Ching >Priority: Minor > Attachments: SLING-582.patch > > > This is probably not that important to too many people, but for me it is. I > use cygwin on Windows for development and CRLF issues are always a problem > here. So this is a fix to the JsCodeGeneratorTest that allows it to work on > Cygwin. > Basically, normal Windows uses CRLF for line-endings, but Cygwin uses just CR > if installed the way Cygwin recommends. There's a subtle problem where the > test generates code that has CRLF in it, but since the test's expected input > doesn't use CRLF, the test fails. There is already a helper that is supposed > to turn line-endings into '.', but, unfortunately it's broken as well. > Currently it simply turns '\n' into '.', but in the case of Windows this ends > up leaving the line-feeds in, which doesn't cause any problems, but the > intention of the code isn't met. So, not only is this a better > implementation that fixes a subtle issue, but it also makes it work on Cygwin. > Patch will be attached in my next post. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-572) "Notes" example application
[ https://issues.apache.org/jira/browse/SLING-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-572: -- Summary: "Notes" example application (was: example application) > "Notes" example application > --- > > Key: SLING-572 > URL: https://issues.apache.org/jira/browse/SLING-572 > Project: Sling > Issue Type: Improvement > Components: Documentation >Reporter: Michael Marth >Priority: Minor > Attachments: notes-sample.patch, notes.xml, notes.xml, notes.zip > > > As discussed with Bertrand I have written a Sling example app and suggest to > put it into svn so others can benefit. Attached is the code (to be put into > /apps/notes) and initial content in sysview format. > The code has room for improvement (see bottom of blog post > http://dev.day.com/microsling/content/blogs/main/anothersampleapp.html) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-587) JcrBundlesManager
[ https://issues.apache.org/jira/browse/SLING-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618334#action_12618334 ] Bertrand Delacretaz commented on SLING-587: --- In revision 681030, new 'bundles' folders are detected inside /libs and /apps, as long as those two folders exist when the service starts . > JcrBundlesManager > - > > Key: SLING-587 > URL: https://issues.apache.org/jira/browse/SLING-587 > Project: Sling > Issue Type: Improvement > Components: OSGi >Reporter: Bertrand Delacretaz > > See http://markmail.org/message/wey5dod7cm7oalhr for a tentative spec -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-576) Create new launchpad/testing module
[ https://issues.apache.org/jira/browse/SLING-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-576. - Resolution: Fixed Implemented in revision 681002, the new launchpad/testing contains the integration tests that were previously in launchpad/webapp, and uses the latest trunk versions of all bundles that it tests. > Create new launchpad/testing module > --- > > Key: SLING-576 > URL: https://issues.apache.org/jira/browse/SLING-576 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > Currently the launchpad/webapp tests depend on released versions of Sling > modules, so they do not test the current trunk. > In http://markmail.org/message/j44qkc4kg5cr33gg we have discussed creating a > new launchpad/integration-tests module, and moving the integration tests from > launchpad/webapp there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-576) Create new launchpad/testing module
[ https://issues.apache.org/jira/browse/SLING-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-576: -- Summary: Create new launchpad/testing module (was: Create new launchpad/integration-tests module) > Create new launchpad/testing module > --- > > Key: SLING-576 > URL: https://issues.apache.org/jira/browse/SLING-576 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > Currently the launchpad/webapp tests depend on released versions of Sling > modules, so they do not test the current trunk. > In http://markmail.org/message/j44qkc4kg5cr33gg we have discussed creating a > new launchpad/integration-tests module, and moving the integration tests from > launchpad/webapp there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-576) Create new launchpad/integration-tests module
[ https://issues.apache.org/jira/browse/SLING-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-576: - Assignee: Bertrand Delacretaz > Create new launchpad/integration-tests module > - > > Key: SLING-576 > URL: https://issues.apache.org/jira/browse/SLING-576 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > Currently the launchpad/webapp tests depend on released versions of Sling > modules, so they do not test the current trunk. > In http://markmail.org/message/j44qkc4kg5cr33gg we have discussed creating a > new launchpad/integration-tests module, and moving the integration tests from > launchpad/webapp there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-587) JcrBundlesManager
[
https://issues.apache.org/jira/browse/SLING-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617855#action_12617855
]
Bertrand Delacretaz commented on SLING-587:
---
Revision 680753 contains a first usable version, here's how to test it:
a) Installing and removing bundles
Create one or several folders named "bundles" somewhere under /libs or /apps in
the repository (WebDAV is fine for that). These folders must exist before the
jcrbundles service starts, as the service does not yet observe the creation of
new folders.
Install the jcrbundle service (currently found under
http://svn.eu.apache.org/repos/asf/incubator/sling/whiteboard/jcrbundles)
Copy an OSGi bundle jar file into a bundles folder, it should be installed
after a few seconds. Try
http://www.knopflerfish.org/releases/2.1.0/jars/desktop_awt/desktop_awt_all-2.0.0.jar
for example, which shows a nice GUI OSGi console.
Remove the bundle jar file to uninstall the bundle.
b) Creating configurations
To test the configuration feature, create a file named
org.apache.sling.commons.log.LogManager.cfg, with this content, in a bundles
folder:
org.apache.sling.commons.log.file=logs/error.log
org.apache.sling.commons.log.file.number=5
org.apache.sling.commons.log.file.size=10mb
org.apache.sling.commons.log.level=info
org.apache.sling.commons.log.pattern={0,date,dd.MM. HH:mm:ss.SSS} *{4}*
[{2}] {3} {5}
And watch the log level change in logs/error.log (under the Sling home
directory) when changing the level parameter between "info" and "debug".
Note that the same config can be edited from the Sling console, which will show
changes made in the cfg file, but the opposite is not true: changes made in the
Sling console are not visible in the cfg file, that's a problem that we'll need
to solve. Not to mention potential security implications - we might need to
restrict what can be done with jcrbundles, or make sure that it doesn't mess
with bundles and configs installed via other means.
Removing the cfg file causes the configuration to be deleted - in this case I
think the log service continues to work with default parameters.
Configurations that use OSGi factories must be named like
factoryName-instanceName.cfg
c) Debugging
jcrbundles logs lots of information about what it's doing, that can help
troubleshooting it if needed.
d) Resync at service startup
Note that jcrbundles will resynchronize the OSGi state with what's in the
bundles folders when the service starts: bundles and configs added, removed or
updated while the service is not active are taken into account at the next
restart.
> JcrBundlesManager
> -
>
> Key: SLING-587
> URL: https://issues.apache.org/jira/browse/SLING-587
> Project: Sling
> Issue Type: Improvement
> Components: OSGi
>Reporter: Bertrand Delacretaz
>
> See http://markmail.org/message/wey5dod7cm7oalhr for a tentative spec
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-587) JcrBundlesManager
JcrBundlesManager - Key: SLING-587 URL: https://issues.apache.org/jira/browse/SLING-587 Project: Sling Issue Type: Improvement Components: OSGi Reporter: Bertrand Delacretaz See http://markmail.org/message/wey5dod7cm7oalhr for a tentative spec -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-580) Improve SlingServletResolver logging to show how scripts and servlets are selected
[ https://issues.apache.org/jira/browse/SLING-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-580. - Resolution: Fixed Implemented in revision 679169, the SlingServletResolver debug log now indicates which scripts and servlets are candidates for selection. Example with an nt:unstructured resource where one script is available: SlingServletResolver resolveServlet called for Resource JcrNodeResource, type=nt:unstructured, path=/xxyz SlingServletResolver Ordered list of Servlet candidates follows SlingServletResolver Servlet candidate: /apps/nt/unstructured/html.esp SlingServletResolver Servlet candidate: /apps/sling/servlet/default/GET.servlet SlingServletResolver Servlet candidate: /apps/sling/servlet/default.servlet SlingServletResolver Checking if candidate Resource /apps/nt/unstructured/html.esp adapts to Servlet and accepts request SlingServletResolver getServlet returns Servlet /apps/nt/unstructured/html.esp SlingServletResolver Servlet /apps/nt/unstructured/html.esp found for Resource=JcrNodeResource, type=nt:unstructured, path=/xxyz Example with an resource of type foo where many scripts are available, this shows for example that the esp script has precedence over the jsp one (but does that depend on bundle loading order? didn't check): SlingServletResolver resolveServlet called for Resource JcrNodeResource, type=foo, path=/xx SlingServletResolver Ordered list of Servlet candidates follows SlingServletResolver Servlet candidate: /apps/foo/html.esp SlingServletResolver Servlet candidate: /apps/foo/html.jsp SlingServletResolver Servlet candidate: /apps/foo/foo.esp SlingServletResolver Servlet candidate: /apps/foo/GET.esp SlingServletResolver Servlet candidate: /apps/sling/servlet/default/GET.servlet SlingServletResolver Servlet candidate: /apps/sling/servlet/default.servlet SlingServletResolver Checking if candidate Resource /apps/foo/html.esp adapts to Servlet and accepts request SlingServletResolver getServlet returns Servlet /apps/foo/html.esp SlingServletResolver Servlet /apps/foo/html.esp found for Resource=JcrNodeResource, type=foo, path=/xx > Improve SlingServletResolver logging to show how scripts and servlets are > selected > -- > > Key: SLING-580 > URL: https://issues.apache.org/jira/browse/SLING-580 > Project: Sling > Issue Type: Improvement >Affects Versions: Servlets Resolver 2.0.4 >Reporter: Bertrand Delacretaz >Priority: Minor > > The SlingServletResolver log does not currently give much detail about how > scripts and servlets are selected, this can be improved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-580) Improve SlingServletResolver logging to show how scripts and servlets are selected
Improve SlingServletResolver logging to show how scripts and servlets are selected -- Key: SLING-580 URL: https://issues.apache.org/jira/browse/SLING-580 Project: Sling Issue Type: Improvement Affects Versions: Servlets Resolver 2.0.4 Reporter: Bertrand Delacretaz Priority: Minor The SlingServletResolver log does not currently give much detail about how scripts and servlets are selected, this can be improved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-475) Create Integration tests for the sling:include tag
[ https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615153#action_12615153 ] Bertrand Delacretaz commented on SLING-475: --- I tested the latest sling475.patch (2008-07-20 11:40 AM) and it does indeed test the sling:include tag with addSelector. It would be better to use node values in the included scripts (include.jsp and selector.jsp), i.e. output some currentNode.something properties and verify their values in the test case. This would verify that those scripts act on the expected nodes. Also, I would suggest storing the scripts under resources/integration-test/jsp/sling-include in the source code tree, to separate them from the others. > Create Integration tests for the sling:include tag > -- > > Key: SLING-475 > URL: https://issues.apache.org/jira/browse/SLING-475 > Project: Sling > Issue Type: Sub-task > Components: Scripting JSP >Reporter: Felix Meschberger > Attachments: PatchWithError.patch, SLING-475.patch, sling475.patch, > sling475.patch, Sling475_simple_patch.patch, working.patch > > > Summary says it all ;-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-576) Create new launchpad/integration-tests module
Create new launchpad/integration-tests module - Key: SLING-576 URL: https://issues.apache.org/jira/browse/SLING-576 Project: Sling Issue Type: Improvement Components: Testing Reporter: Bertrand Delacretaz Currently the launchpad/webapp tests depend on released versions of Sling modules, so they do not test the current trunk. In http://markmail.org/message/j44qkc4kg5cr33gg we have discussed creating a new launchpad/integration-tests module, and moving the integration tests from launchpad/webapp there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-475) Create Integration tests for the sling:include tag
[ https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612404#action_12612404 ] Bertrand Delacretaz commented on SLING-475: --- The new patches compiles and runs against Sling revision 675473, thanks! The test still fails: junit.framework.AssertionFailedError: JSP script executed as expected... As the "JSP rendering result" string is not produced by the script. And the test doesn't demonstrate that sling:include works, that's the next step I guess. > Create Integration tests for the sling:include tag > -- > > Key: SLING-475 > URL: https://issues.apache.org/jira/browse/SLING-475 > Project: Sling > Issue Type: Sub-task > Components: Scripting JSP >Reporter: Felix Meschberger > Attachments: SLING-475.patch, Sling475_simple_patch.patch > > > Summary says it all ;-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-475) Create Integration tests for the sling:include tag
[ https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611929#action_12611929 ] Bertrand Delacretaz commented on SLING-475: --- I had a look at the code (SLING475Test.java), and that cannot compile nor work: the code references UjaxPostServlet that's long gone. How did you test that code? Did it compile and work for you? The way we should be able to use it is to run "mvn clean install" in launchpad/webapp after adding the SLING475Test.java and src/test/resources/integration-test/include-test.jsp files. That must run all the integration tests, including the new one, with no test failures, and the new test must demonstrate that the sling:include jsp tag works. > Create Integration tests for the sling:include tag > -- > > Key: SLING-475 > URL: https://issues.apache.org/jira/browse/SLING-475 > Project: Sling > Issue Type: Sub-task > Components: Scripting JSP >Reporter: Felix Meschberger > Attachments: SLING-475.patch > > > Summary says it all ;-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-475) Create Integration tests for the sling:include tag
[ https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611927#action_12611927 ] Bertrand Delacretaz commented on SLING-475: --- Thanks for your patch - I had a look and it contains too many files: pom.xml launchpad/app/foo/image.JPG launchpad/app/foo/bar/html.jsp launchpad/app/foo/bar/header.jsp launchpad/app/foo/header/header.jsp launchpad/apps/foo/bar/html.jsp launchpad/apps/foo/header/header.jsp launchpad/webapp/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/SLING475Test.java launchpad/webapp/src/test/resources/integration-test/include-test.jsp launchpad/webapp/pom.xml scripting/velocity/pom.xml sling/threads/src/main/java/org/apache/sling/threads/impl/ExtendedThreadFactory.java I think you only meant to make changes to those two files: launchpad/webapp/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/SLING475Test.java launchpad/webapp/src/test/resources/integration-test/include-test.jsp For next time, please include only the required files in your patch, in this case you could for example create the patch using: cd sling svn diff launchpad/webapp > SLING-475.patch To only take the launchpad/webapp code subtree for the patch. I'll add another comment about the code. > Create Integration tests for the sling:include tag > -- > > Key: SLING-475 > URL: https://issues.apache.org/jira/browse/SLING-475 > Project: Sling > Issue Type: Sub-task > Components: Scripting JSP >Reporter: Felix Meschberger > Attachments: SLING-475.patch > > > Summary says it all ;-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-567) sling.include inclides fragments in the wrong order
[ https://issues.apache.org/jira/browse/SLING-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611178#action_12611178 ] Bertrand Delacretaz commented on SLING-567: --- Thanks for the additional info, so if there's a workaround this doesn't look too urgent, that's good. > sling.include inclides fragments in the wrong order > --- > > Key: SLING-567 > URL: https://issues.apache.org/jira/browse/SLING-567 > Project: Sling > Issue Type: Bug >Affects Versions: Scripting JSP 2.0.2 >Reporter: Michael Marth > > (This is observed in revision 670551) > consider a jsp "/apps/myapp/a.jsp" which contains: > aaa > <% sling.include(currentNode.getPath() + ".b.html"); %> > and another jsp "/apps/myapp/b.jsp" which contains > bbb > if i execute /content/myapp/mynode.a.html i get > bbb > aaa > expected result is: > aaa > bbb -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-475) Create Integration tests for the sling:include tag
[ https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611002#action_12611002 ] Bertrand Delacretaz commented on SLING-475: --- Adding some info to this for Janandith, our GSoC student, who will work on this as we're somewhat stuck with the scala stuff. The goal is to add (at least) one java class and one jsp test file to the launchpad/webapp tests, to verify that the sling:include JSP tag works correctly. Just testing the "resource" attribute of the sling:include tag is a good start, and then we'll need to test the other options of that tag. The rendering-test.jsp [1] can be used as an example of a jsp script that runs during the integration tests of the launchpad webapp. It is run by the org.apache.sling.launchpad.webapp.integrationtest.JspScriptingTest, a similar class will need to be created, suggest naming it JspIncludeTagTest. The sling:include JSP tag is implemented by the IncludeTagHandler class [3], its goal is to include the output of a Sling request in the output that's being generated by a JSP script. The basic syntax for this include tag is , and the IncludeTagHandler source code indicates which other options can be used (the "public set..." methods). Here's how to run a single of our integration tests (see "integration test" README [2] for details), example for the JspScriptingTest: 1) Start the launchpad with mvn jetty:run 2) In a second terminal, run the test: mvn -o test -Dtest=JspScriptingTest This avoids the Cargo and Sling setup times, makes it much more convenient to run a single integration test for debugging - and the first Sling instance can be started with remote debugging active, so as to connect to it from an IDE debugger if needed. To build the launchpad webapp, see [4] - once you have the right maven settings, running "mvn clean install" in the launchpad/webapp folder should be sufficient. [1] http://svn.apache.org/repos/asf/incubator/sling/trunk/launchpad/webapp/src/test/resources/integration-test/rendering-test.jsp [2] http://svn.apache.org/repos/asf/incubator/sling/trunk/launchpad/webapp/README.txt [3] https://svn.eu.apache.org/repos/asf/incubator/sling/trunk/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/IncludeTagHandler.java [4] http://incubator.apache.org/sling/site/getting-and-building-sling.html > Create Integration tests for the sling:include tag > -- > > Key: SLING-475 > URL: https://issues.apache.org/jira/browse/SLING-475 > Project: Sling > Issue Type: Sub-task > Components: Scripting JSP >Reporter: Felix Meschberger > > Summary says it all ;-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-549) Scala interpreter should use the current ClassLoader instead of rebuilding its own classpath
[ https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610818#action_12610818 ] Bertrand Delacretaz commented on SLING-549: --- In the scala eclipse plugin [1], the intializePaths() method sets the classpath for the scala compiler. That plugin looks like a good example of using the compiler, but it also uses a list of strings for the classpath (which makes sense in an IDE context). [1] http://lampsvn.epfl.ch/svn-repos/scala/scala-plugin/trunk/src/scala/tools/eclipse/ScalaPlugin.scala > Scala interpreter should use the current ClassLoader instead of rebuilding > its own classpath > > > Key: SLING-549 > URL: https://issues.apache.org/jira/browse/SLING-549 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Priority: Minor > > As the code at [1] demonstrates, the scala interpreter rebuilds its own > classpath from the current JVM classpath and user-supplied additions. > We should find a way for it to use the current classloader instead. > Note that the almost same test [2] works when run with "mvn test" without > setting the classpath explicitly, probably because in this case the JVM > classpath includes the scala jars. > [1] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java > [2] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-555) mvn install on svn checkout fails if sling-3-incubator is not available
[ https://issues.apache.org/jira/browse/SLING-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reopened SLING-555: --- Assignee: (was: Jukka Zitting) Reopening for Alex... > mvn install on svn checkout fails if sling-3-incubator is not available > --- > > Key: SLING-555 > URL: https://issues.apache.org/jira/browse/SLING-555 > Project: Sling > Issue Type: Bug > Components: General >Reporter: Jukka Zitting > Fix For: 2.1.0 > > > Carsten recently (revision 670566) added the incubating repository to the > parent POM in svn. But since many components refer to version 3-incubator > (instead of 4-incubator-SNAPSHOT) as the parent POM, this repository > reference is not picked up by the build. > And if the 3-incubator version of the parent POM is not available in the > local Maven repository, the build fails as Maven does not know where to > download it from (since the components don't refer to 4-incubator-SNAPSHOT > version of the parent POM...). > Moving the repository reference to the reactor POM also won't help. > The options I see are: > 1) Make components use 4-incubator-SNAPSHOT as the parent POM version > 2) Make the 3-incubator version of the parent POM explicitly available in > svn > 3) Add the incubator repository reference to all component POMs > 4) Publish the 3-incubator version of the parent POM to the standard Maven > repository -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-563) Allow non-bundle jars to be loaded as bundles using external metadata
[ https://issues.apache.org/jira/browse/SLING-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610499#action_12610499 ] Bertrand Delacretaz commented on SLING-563: --- I knew this was going to be controversial ;-) > Allow non-bundle jars to be loaded as bundles using external metadata > - > > Key: SLING-563 > URL: https://issues.apache.org/jira/browse/SLING-563 > Project: Sling > Issue Type: Wish > Components: OSGi >Reporter: Bertrand Delacretaz >Priority: Minor > > Just read Dan Diephouse's post at [1] and I like the idea of "bundleizing" > existing jar files using separate metadata files, to be able to load them > unmodified. > There are certainly security issues in doing this, but in a secure > environment it might make it much easier to use any jar as an OSGi bundle. > [1] http://netzooid.com/blog/2008/07/02/osgi-is-a-pita-bundles/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-563) Allow non-bundle jars to be loaded as bundles using external metadata
[ https://issues.apache.org/jira/browse/SLING-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610494#action_12610494 ] Bertrand Delacretaz commented on SLING-563: --- Agree that the implementation belongs in Felix, but as a feature it would be nice to have, so I suggest keeping this issue open as a feature wishlist item. > Allow non-bundle jars to be loaded as bundles using external metadata > - > > Key: SLING-563 > URL: https://issues.apache.org/jira/browse/SLING-563 > Project: Sling > Issue Type: Improvement > Components: OSGi >Reporter: Bertrand Delacretaz >Priority: Minor > > Just read Dan Diephouse's post at [1] and I like the idea of "bundleizing" > existing jar files using separate metadata files, to be able to load them > unmodified. > There are certainly security issues in doing this, but in a secure > environment it might make it much easier to use any jar as an OSGi bundle. > [1] http://netzooid.com/blog/2008/07/02/osgi-is-a-pita-bundles/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-563) Allow non-bundle jars to be loaded as bundles using external metadata
[ https://issues.apache.org/jira/browse/SLING-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-563: -- Issue Type: Wish (was: Improvement) > Allow non-bundle jars to be loaded as bundles using external metadata > - > > Key: SLING-563 > URL: https://issues.apache.org/jira/browse/SLING-563 > Project: Sling > Issue Type: Wish > Components: OSGi >Reporter: Bertrand Delacretaz >Priority: Minor > > Just read Dan Diephouse's post at [1] and I like the idea of "bundleizing" > existing jar files using separate metadata files, to be able to load them > unmodified. > There are certainly security issues in doing this, but in a secure > environment it might make it much easier to use any jar as an OSGi bundle. > [1] http://netzooid.com/blog/2008/07/02/osgi-is-a-pita-bundles/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-563) Allow non-bundle jars to be loaded as bundles using external metadata
Allow non-bundle jars to be loaded as bundles using external metadata - Key: SLING-563 URL: https://issues.apache.org/jira/browse/SLING-563 Project: Sling Issue Type: Improvement Components: OSGi Reporter: Bertrand Delacretaz Priority: Minor Just read Dan Diephouse's post at [1] and I like the idea of "bundleizing" existing jar files using separate metadata files, to be able to load them unmodified. There are certainly security issues in doing this, but in a secure environment it might make it much easier to use any jar as an OSGi bundle. [1] http://netzooid.com/blog/2008/07/02/osgi-is-a-pita-bundles/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-558) JST scripting: add breadcrumbs and child nodes navigation to default HTML rendering
[
https://issues.apache.org/jira/browse/SLING-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-558.
-
Resolution: Fixed
Implemented in revision 671596, rendering a node at /content/foo/bar/zz that
has a "xyzzy" child node now includes
foo
bar
and
xyzzy
in the default HTML rendering.
The rendering has also been improved to better expose the content, for a node
that has title="Hello, Swling world", the default rendering is now
Hello, Sling world
...
...
Hello, Sling world
Property with names starting with "jcr:" or "sling:" are omitted from this
rendering.
This if followed by javascript code to remove that if javascript (and thus the
JST template) is active:
var e = document.getElementById("JstDefaultRendering");
e.parentNode.removeChild(e);
We might want to include these improvements in Sling's default HTML rendering
eventually, but for now I'll experiment a bit more here.
> JST scripting: add breadcrumbs and child nodes navigation to default HTML
> rendering
> ---
>
> Key: SLING-558
> URL: https://issues.apache.org/jira/browse/SLING-558
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> The JST HTML rendering should be search-engine friendly: adding breadcrumbs
> (navigation to parent nodes) and links to child nodes will make the content
> discoverable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-558) JST scripting: add breadcrumbs and child nodes navigation to default HTML rendering
JST scripting: add breadcrumbs and child nodes navigation to default HTML rendering --- Key: SLING-558 URL: https://issues.apache.org/jira/browse/SLING-558 Project: Sling Issue Type: Improvement Components: Scripting Reporter: Bertrand Delacretaz Priority: Minor The JST HTML rendering should be search-engine friendly: adding breadcrumbs (navigation to parent nodes) and links to child nodes will make the content discoverable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties
[ https://issues.apache.org/jira/browse/SLING-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-556. --- Resolution: Fixed Patch applied in revision 671465, thanks very much! Please cross-check and close this issue if ok. Creating a new issue was the right thing to do, personally I prefer small focused issues. > Freemarker wrapper not correctly dereferencing multi value properties > - > > Key: SLING-556 > URL: https://issues.apache.org/jira/browse/SLING-556 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: 2.0.0 >Reporter: Bryce Ewing >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: freemarker.patch > > > When iterating through multi value properties of type Reference the NodeModel > was not dereferencing the node reference when the property was being treated > as a node list, i.e.: > ... > Correctly lists through all the reference properties as properties, but: > ... > Throws an exception. This should iterate over the property reference values, > find the node and make the node available as reference within the body of the > list markup. > Patch included to fix this, and tests included to test for both cases above. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties
[ https://issues.apache.org/jira/browse/SLING-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-556: - Assignee: Bertrand Delacretaz > Freemarker wrapper not correctly dereferencing multi value properties > - > > Key: SLING-556 > URL: https://issues.apache.org/jira/browse/SLING-556 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: 2.0.0 >Reporter: Bryce Ewing >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: freemarker.patch > > > When iterating through multi value properties of type Reference the NodeModel > was not dereferencing the node reference when the property was being treated > as a node list, i.e.: > ... > Correctly lists through all the reference properties as properties, but: > ... > Throws an exception. This should iterate over the property reference values, > find the node and make the node available as reference within the body of the > list markup. > Patch included to fix this, and tests included to test for both cases above. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-192) JST script engine
[ https://issues.apache.org/jira/browse/SLING-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607260#action_12607260 ] Bertrand Delacretaz commented on SLING-192: --- The above examples are out of sync with the current Sling trunk, see SLING-466 > JST script engine > - > > Key: SLING-192 > URL: https://issues.apache.org/jira/browse/SLING-192 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > The microsling-core JST script engine should be ported to sling/scripting -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-552) Improved Freemarker scripting support through adding wrappers for JCR Nodes and Properties
[ https://issues.apache.org/jira/browse/SLING-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-552. --- Resolution: Fixed Code and especially tests reviewed, patch applied in revision 670480, many thanks for your contribution! Please cross-check and close this issue if ok. > Improved Freemarker scripting support through adding wrappers for JCR Nodes > and Properties > -- > > Key: SLING-552 > URL: https://issues.apache.org/jira/browse/SLING-552 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bryce Ewing >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: freemarkerwrapper.patch, pom.xml > > > Add freemarker wrapper classes for JCR Node's and Property's, I will be > adding further support as I require it but thought I would put in an initial > version of this. > These wrappers provides freemarker support similar to what freemarker does > with XML nodes, e.g.: > * properties of a node can be accessed as @property_name, e.g. [EMAIL > PROTECTED] will output the title property of the current node > * child nodes can be accessed directly via "." e.g. [EMAIL PROTECTED] will > output the title property of the child node of the current node named > "section" > * child nodes can be iterated over, e.g. <#list currentNode as child>[EMAIL > PROTECTED] will iterate over the child nodes of current node > outputting the title property > * multi value property nodes can be iterated over, <#list [EMAIL PROTECTED] > as value> > I haven't tested this yet but processing nodes through macro's, as described > for xml here: > http://freemarker.sourceforge.net/docs/xgui_declarative_basics.html should > also work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-552) Improved Freemarker scripting support through adding wrappers for JCR Nodes and Properties
[ https://issues.apache.org/jira/browse/SLING-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-552: - Assignee: Bertrand Delacretaz > Improved Freemarker scripting support through adding wrappers for JCR Nodes > and Properties > -- > > Key: SLING-552 > URL: https://issues.apache.org/jira/browse/SLING-552 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bryce Ewing >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: freemarkerwrapper.patch, pom.xml > > > Add freemarker wrapper classes for JCR Node's and Property's, I will be > adding further support as I require it but thought I would put in an initial > version of this. > These wrappers provides freemarker support similar to what freemarker does > with XML nodes, e.g.: > * properties of a node can be accessed as @property_name, e.g. [EMAIL > PROTECTED] will output the title property of the current node > * child nodes can be accessed directly via "." e.g. [EMAIL PROTECTED] will > output the title property of the child node of the current node named > "section" > * child nodes can be iterated over, e.g. <#list currentNode as child>[EMAIL > PROTECTED] will iterate over the child nodes of current node > outputting the title property > * multi value property nodes can be iterated over, <#list [EMAIL PROTECTED] > as value> > I haven't tested this yet but processing nodes through macro's, as described > for xml here: > http://freemarker.sourceforge.net/docs/xgui_declarative_basics.html should > also work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-552) Improved Freemarker scripting support through adding wrappers for JCR Nodes and Properties
[ https://issues.apache.org/jira/browse/SLING-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606983#action_12606983 ] Bertrand Delacretaz commented on SLING-552: --- Thanks for this, looks interesting! I'm going to ask my usual question though: could we have tests with this? The scripting/javascript modules has good examples of how to write such tests, see for example the ScriptableNodeTest class [1]. [1] http://svn.apache.org/repos/asf/incubator/sling/trunk/scripting/javascript/src/test/java/org/apache/sling/scripting/wrapper/ScriptableNodeTest.java > Improved Freemarker scripting support through adding wrappers for JCR Nodes > and Properties > -- > > Key: SLING-552 > URL: https://issues.apache.org/jira/browse/SLING-552 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bryce Ewing >Priority: Minor > Attachments: freemarkerwrapper.patch, freemarkerwrappers.patch > > > Add freemarker wrapper classes for JCR Node's and Property's, I will be > adding further support as I require it but thought I would put in an initial > version of this. > These wrappers provides freemarker support similar to what freemarker does > with XML nodes, e.g.: > * properties of a node can be accessed as @property_name, e.g. [EMAIL > PROTECTED] will output the title property of the current node > * child nodes can be accessed directly via "." e.g. [EMAIL PROTECTED] will > output the title property of the child node of the current node named > "section" > * child nodes can be iterated over, e.g. <#list currentNode as child>[EMAIL > PROTECTED] will iterate over the child nodes of current node > outputting the title property > * multi value property nodes can be iterated over, <#list [EMAIL PROTECTED] > as value> > I haven't tested this yet but processing nodes through macro's, as described > for xml here: > http://freemarker.sourceforge.net/docs/xgui_declarative_basics.html should > also work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-551) Sling.removeContent does not work due to wrong operation name
[ https://issues.apache.org/jira/browse/SLING-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-551. - Resolution: Fixed Fix Version/s: Servlets Post 2.0.4 Fixed in revision 669948 > Sling.removeContent does not work due to wrong operation name > - > > Key: SLING-551 > URL: https://issues.apache.org/jira/browse/SLING-551 > Project: Sling > Issue Type: Bug >Affects Versions: Servlets Post 2.0.2 >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Post 2.0.4 > > > In sling.js, the Sling.removeContent() method should use ":operation=delete", > it is still using ":delete" which fails. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-550) nohup-like service for long-running scripts or servlets
[ https://issues.apache.org/jira/browse/SLING-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reopened SLING-550: --- Oops - not fixed at all, wrong issue ;-) > nohup-like service for long-running scripts or servlets > --- > > Key: SLING-550 > URL: https://issues.apache.org/jira/browse/SLING-550 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Bertrand Delacretaz >Priority: Minor > > In some cases (like the webloader example), long-running processes need to be > started, monitored and stopped. > The webloader implements this in a naive way, it might be useful to have a > more generic facility for this: a service that would: > 1) Start a script or servlet, probably passing it a fake request object that > gives access to parameters and output but is not a real HTTP request > 2) Display a status page where currently running jobs can be monitored, and > stopped if desired > 3) Collect the output of such jobs in the repository and give access to it > via a simple monitoring interface > The output of long-running jobs could be structured using html conventions > (like running step 3 of 12) to create overview > displays of all currently running jobs. > This is just an idea for now, I'm not going to work on this right away, but > it's probably good to keep in our wishlist. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-550) nohup-like service for long-running scripts or servlets
[ https://issues.apache.org/jira/browse/SLING-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-550. - Resolution: Fixed Fixed in revision 669948 > nohup-like service for long-running scripts or servlets > --- > > Key: SLING-550 > URL: https://issues.apache.org/jira/browse/SLING-550 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Bertrand Delacretaz >Priority: Minor > > In some cases (like the webloader example), long-running processes need to be > started, monitored and stopped. > The webloader implements this in a naive way, it might be useful to have a > more generic facility for this: a service that would: > 1) Start a script or servlet, probably passing it a fake request object that > gives access to parameters and output but is not a real HTTP request > 2) Display a status page where currently running jobs can be monitored, and > stopped if desired > 3) Collect the output of such jobs in the repository and give access to it > via a simple monitoring interface > The output of long-running jobs could be structured using html conventions > (like running step 3 of 12) to create overview > displays of all currently running jobs. > This is just an idea for now, I'm not going to work on this right away, but > it's probably good to keep in our wishlist. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-551) Sling.removeContent does not work due to wrong operation name
Sling.removeContent does not work due to wrong operation name - Key: SLING-551 URL: https://issues.apache.org/jira/browse/SLING-551 Project: Sling Issue Type: Bug Affects Versions: Servlets Post 2.0.2 Reporter: Bertrand Delacretaz Priority: Minor In sling.js, the Sling.removeContent() method should use ":operation=delete", it is still using ":delete" which fails. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-322) Sling client library tests require setting Allow Anonymous Access = false
[ https://issues.apache.org/jira/browse/SLING-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-322: -- Attachment: auth-config.jpg Screenshot of configuration panel (Sling revision 669215) > Sling client library tests require setting Allow Anonymous Access = false > - > > Key: SLING-322 > URL: https://issues.apache.org/jira/browse/SLING-322 > Project: Sling > Issue Type: Bug > Components: Servlets Post >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: auth-config.jpg > > > The tests at http://localhost:/sling-test/sling/sling-test.html require > setting Allow Anonymous Access to false on the Sling Request Authenticator > configuration page, this should not be needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-322) Sling client library tests require setting Allow Anonymous Access = false
[ https://issues.apache.org/jira/browse/SLING-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-322: -- Description: The tests at http://localhost:/sling-test/sling/sling-test.html require setting Allow Anonymous Access to false on the Sling Request Authenticator configuration page, this should not be needed. (was: Running the launchpad/content/src/main/resources/content/sling-test/ujax/ujax-test.html tests requires setting Allow Anonymous Access to false on the Sling Authentication Filter configuration page, this should not be needed.) Summary: Sling client library tests require setting Allow Anonymous Access = false (was: ujax tests require Allow Anonymous Access = false) > Sling client library tests require setting Allow Anonymous Access = false > - > > Key: SLING-322 > URL: https://issues.apache.org/jira/browse/SLING-322 > Project: Sling > Issue Type: Bug > Components: Servlets Post >Reporter: Bertrand Delacretaz >Priority: Minor > > The tests at http://localhost:/sling-test/sling/sling-test.html require > setting Allow Anonymous Access to false on the Sling Request Authenticator > configuration page, this should not be needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-549) Scala interpreter should use the current ClassLoader instead of rebuilding its own classpath
[ https://issues.apache.org/jira/browse/SLING-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606703#action_12606703 ] Bertrand Delacretaz commented on SLING-549: --- Asked on scala-user, see http://www.nabble.com/How-to-compile-Scala-code-from-java-using-the-current-ClassLoader-instead-of-a-string-based-classpath--tt18026672.html > Scala interpreter should use the current ClassLoader instead of rebuilding > its own classpath > > > Key: SLING-549 > URL: https://issues.apache.org/jira/browse/SLING-549 > Project: Sling > Issue Type: Bug > Components: Scripting >Reporter: Bertrand Delacretaz >Priority: Minor > > As the code at [1] demonstrates, the scala interpreter rebuilds its own > classpath from the current JVM classpath and user-supplied additions. > We should find a way for it to use the current classloader instead. > Note that the almost same test [2] works when run with "mvn test" without > setting the classpath explicitly, probably because in this case the JVM > classpath includes the scala jars. > [1] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java > [2] > http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-550) nohup-like service for long-running scripts or servlets
nohup-like service for long-running scripts or servlets --- Key: SLING-550 URL: https://issues.apache.org/jira/browse/SLING-550 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Bertrand Delacretaz Priority: Minor In some cases (like the webloader example), long-running processes need to be started, monitored and stopped. The webloader implements this in a naive way, it might be useful to have a more generic facility for this: a service that would: 1) Start a script or servlet, probably passing it a fake request object that gives access to parameters and output but is not a real HTTP request 2) Display a status page where currently running jobs can be monitored, and stopped if desired 3) Collect the output of such jobs in the repository and give access to it via a simple monitoring interface The output of long-running jobs could be structured using html conventions (like running step 3 of 12) to create overview displays of all currently running jobs. This is just an idea for now, I'm not going to work on this right away, but it's probably good to keep in our wishlist. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-549) Scala interpreter should use the current ClassLoader instead of rebuilding its own classpath
Scala interpreter should use the current ClassLoader instead of rebuilding its own classpath Key: SLING-549 URL: https://issues.apache.org/jira/browse/SLING-549 Project: Sling Issue Type: Bug Components: Scripting Reporter: Bertrand Delacretaz Priority: Minor As the code at [1] demonstrates, the scala interpreter rebuilds its own classpath from the current JVM classpath and user-supplied additions. We should find a way for it to use the current classloader instead. Note that the almost same test [2] works when run with "mvn test" without setting the classpath explicitly, probably because in this case the JVM classpath includes the scala jars. [1] http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/main/java/org/apache/sling/scripting/scala/minbundle/ScalaCompileServlet.java [2] http://code.google.com/p/sling-scala/source/browse/trunk/scala-min-bundle/src/test/java/org/apache/sling/scripting/scala/minbundle/ScalaCompilerTest.java?r=38 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-466) JST scripting engine: render indexable HTML and separate javascript code
[ https://issues.apache.org/jira/browse/SLING-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-466. --- Resolution: Fixed Unit tests added in r669182, closing this for now. > JST scripting engine: render indexable HTML and separate javascript code > > > Key: SLING-466 > URL: https://issues.apache.org/jira/browse/SLING-466 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bertrand Delacretaz >Priority: Minor > > The JST scripting engine should output a default HTML rendering, meant to be > indexed by search engines, with a
[jira] Updated: (SLING-544) RAT report for sling-3-incubator-source-release
[ https://issues.apache.org/jira/browse/SLING-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-544: -- Attachment: rat-missing-headers.txt This attachment contains the lines that contain in the rat report. Apart from the commons/json code, where we kept the original headers, those are small test or utility files with no creative content. The only files that could arguably be considered creative are IMO: launchpad/content/src/main/resources/content/sling.css launchpad/content/src/main/resources/content/index.html To which I added the Apache License header in revision 669136 - I don't think that's a blocker for the current release. > RAT report for sling-3-incubator-source-release > --- > > Key: SLING-544 > URL: https://issues.apache.org/jira/browse/SLING-544 > Project: Sling > Issue Type: Task >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: 2.0.0 > > Attachments: rat-missing-headers.txt, > sling-3-incubator-source-release.txt > > > I'll attach the RAT report for > http://svn.apache.org/repos/asf/incubator/sling/tags/sling-3-incubator-source-release > to this issue, with comments -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-544) RAT report for sling-3-incubator-source-release
[ https://issues.apache.org/jira/browse/SLING-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-544. - Resolution: Fixed Sorry about the duplicate with SLING-543 - as this issue has the complete RAT report that might be useful for the Incubator release vote, let's keep it as is, and use SLING-543 to work on the remaining missing headers. Closing this issue now. > RAT report for sling-3-incubator-source-release > --- > > Key: SLING-544 > URL: https://issues.apache.org/jira/browse/SLING-544 > Project: Sling > Issue Type: Task >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: 2.0.0 > > Attachments: rat-missing-headers.txt, > sling-3-incubator-source-release.txt > > > I'll attach the RAT report for > http://svn.apache.org/repos/asf/incubator/sling/tags/sling-3-incubator-source-release > to this issue, with comments -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-544) RAT report for sling-3-incubator-source-release
[ https://issues.apache.org/jira/browse/SLING-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-544: -- Attachment: sling-3-incubator-source-release.txt Here's the RAT report, generated using java -jar rat-app-0.6-SNAPSHOT.jar . After building rat from its revision 669133. > RAT report for sling-3-incubator-source-release > --- > > Key: SLING-544 > URL: https://issues.apache.org/jira/browse/SLING-544 > Project: Sling > Issue Type: Task >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: 2.0.0 > > Attachments: sling-3-incubator-source-release.txt > > > I'll attach the RAT report for > http://svn.apache.org/repos/asf/incubator/sling/tags/sling-3-incubator-source-release > to this issue, with comments -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-544) RAT report for sling-3-incubator-source-release
RAT report for sling-3-incubator-source-release --- Key: SLING-544 URL: https://issues.apache.org/jira/browse/SLING-544 Project: Sling Issue Type: Task Reporter: Bertrand Delacretaz Priority: Minor Fix For: 2.0.0 I'll attach the RAT report for http://svn.apache.org/repos/asf/incubator/sling/tags/sling-3-incubator-source-release to this issue, with comments -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-466) JST scripting engine: render indexable HTML and separate javascript code
[ https://issues.apache.org/jira/browse/SLING-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605326#action_12605326 ] bdelacretaz edited comment on SLING-466 at 6/17/08 8:47 AM: Revision 668200 renders the HTML and javascript separately, using the JsCodeGeneratorServlet, mapped to the jst selector and js extension, to generate the javascript code. The page title is the value of the first of these properties that's set on the node being rendered, if they are present: title, name, description. If not, the title is the node path, relative from the root. was (Author: bdelacretaz): Revision 668200 renders the HTML and javascript separately, using the JsCodeGeneratorServlet, mapped to the jst selector and js extension, to generate the javascript code. The page title is the value of the first of these properties that's set on the node being rendered, if they are present: title, name, description. If not, the title is the node path, relative from the root. I'm thinking of allowing additional elements to be defined by the JST script, maybe something like Where everything between the comments would be added to the generated html element. And maybe also use something like To set class=foo and id=bar on the generated element. > JST scripting engine: render indexable HTML and separate javascript code > > > Key: SLING-466 > URL: https://issues.apache.org/jira/browse/SLING-466 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bertrand Delacretaz >Priority: Minor > > The JST scripting engine should output a default HTML rendering, meant to be > indexed by search engines, with a
[jira] Commented: (SLING-466) JST scripting engine: render indexable HTML and separate javascript code
[ https://issues.apache.org/jira/browse/SLING-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605639#action_12605639 ] Bertrand Delacretaz commented on SLING-466: --- Note that in the above template, <%= currentNode.title %> could as well be , the contents of the title tag are ignored and replaced by the value computed by HtmlCodeGenerator.getTitle(). > JST scripting engine: render indexable HTML and separate javascript code > > > Key: SLING-466 > URL: https://issues.apache.org/jira/browse/SLING-466 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bertrand Delacretaz >Priority: Minor > > The JST scripting engine should output a default HTML rendering, meant to be > indexed by search engines, with a
[jira] Issue Comment Edited: (SLING-466) JST scripting engine: render indexable HTML and separate javascript code
[
https://issues.apache.org/jira/browse/SLING-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605638#action_12605638
]
bdelacretaz edited comment on SLING-466 at 6/17/08 8:47 AM:
The JST engine is much improved in revision 668714, with separate processing of
the template's head and body elements.
Given a node with these properties:
sling:resourceType: foo
description: Hello, Sling world
title: Sling JST test
And this JST template stored at /apps/foo/foo.jst:
currentNode test
Changed 1
This is html.jst, path=<%= currentNode.description %>.
Sling client library test
root resource type=
<% out.write(Sling.getContent("/")["sling:resourceType"]); %>.
Requesting the node with an html extension outputs this:
Sling JST test
var
currentNode={"description":"Hello, Sling
world","sling:resourceType":"foo","testInfiniteLoop":"true","jcr:primaryType":"nt:unstructured","title":"Sling
JST test"};
Node dumped by HtmlRendererServlet
Node path: /xx
Resource metadata: {sling.resolutionPath=/xx}
Node properties
description: Hello, Sling worldsling:resourceType:
footestInfiniteLoop: truejcr:primaryType:
nt:unstructuredtitle: Sling JST test
var e = document.getElementById("JstDefaultRendering");
e.parentNode.removeChild(e);
And the /apps/foo/foo.jst.jst.js script that's referred to above is generated
to be:
out=document;
out.write("currentNode test\n");
out.write("Changed 1\n");
out.write("\n");
out.write("This is html.jst, path=");out.write( currentNode.description
);out.write(".\n");
out.write("\n");
out.write("\n");
out.write("\n");
out.write("Sling client library test\n");
out.write("root resource type=\n");
out.write(""); out.write(Sling.getContent("/")["sling:resourceType"]);
out.write(".\n");
out.write(" \n");
was (Author: bdelacretaz):
The JST engine is much improved in revision 668714, with separate
processing of the template's head and body elements.
Given a node with these properties:
sling:resourceType: foo
description: Hello, Sling world
title: Sling JST test
And this JST template stored at /apps/foo/foo.jst:
<%= currentNode.title %>
currentNode test
Changed 1
This is html.jst, path=<%= currentNode.description %>.
Sling client library test
root resource type=
<% out.write(Sling.getContent("/")["sling:resourceType"]); %>.
Requesting the node with an html extension outputs this:
Sling JST test
var
currentNode={"description":"Hello, Sling
world","sling:resourceType":"foo","testInfiniteLoop":"true","jcr:primaryType":"nt:unstructured","title":"Sling
JST test"};
Node dumped by HtmlRendererServlet
Node path: /xx
Resource metadata: {sling.resolutionPath=/xx}
Node properties
description: Hello, Sling worldsling:resourceType:
footestInfiniteLoop: truejcr:primaryType:
nt:unstructuredtitle: Sling JST test
var e = document.getElementById("JstDefaultRendering");
e.parentNode.removeChild(e);
And the /apps/foo/foo.jst.jst.js script that's referred to above is generated
to be:
out=document;
out.write("currentNode test\n");
out.write("Changed 1\n");
out.write("\n");
out.write("This is html.jst, path=");out.write( currentNode.description
);out.write(".\n");
out.write("\n");
out.write("\n");
out.write("\n");
out.write("Sling client library test\n");
out.write("root resource type=\n");
out.write(""); out.write(Sling.getContent("/")["sling:resourceType"]);
out.write(".\n");
out.write(" \n");
> JST scripting engine: render indexable HTML and separate javascript code
>
>
> Key: SLING-466
> URL: https://issues.apache.org/jira/browse/SLING-466
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> The JST scripting engine should output a default HTML rendering, meant to be
> indexed by search engines, with a
[jira] Updated: (SLING-466) JST scripting engine: render indexable HTML and separate javascript code
[ https://issues.apache.org/jira/browse/SLING-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-466: -- Comment: was deleted > JST scripting engine: render indexable HTML and separate javascript code > > > Key: SLING-466 > URL: https://issues.apache.org/jira/browse/SLING-466 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bertrand Delacretaz >Priority: Minor > > The JST scripting engine should output a default HTML rendering, meant to be > indexed by search engines, with a
[jira] Commented: (SLING-466) JST scripting engine: render indexable HTML and separate javascript code
[
https://issues.apache.org/jira/browse/SLING-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605638#action_12605638
]
Bertrand Delacretaz commented on SLING-466:
---
The JST engine is much improved in revision 668714, with separate processing of
the template's head and body elements.
Given a node with these properties:
sling:resourceType: foo
description: Hello, Sling world
title: Sling JST test
And this JST template stored at /apps/foo/foo.jst:
<%= currentNode.title %>
currentNode test
Changed 1
This is html.jst, path=<%= currentNode.description %>.
Sling client library test
root resource type=
<% out.write(Sling.getContent("/")["sling:resourceType"]); %>.
Requesting the node with an html extension outputs this:
Sling JST test
var
currentNode={"description":"Hello, Sling
world","sling:resourceType":"foo","testInfiniteLoop":"true","jcr:primaryType":"nt:unstructured","title":"Sling
JST test"};
Node dumped by HtmlRendererServlet
Node path: /xx
Resource metadata: {sling.resolutionPath=/xx}
Node properties
description: Hello, Sling worldsling:resourceType:
footestInfiniteLoop: truejcr:primaryType:
nt:unstructuredtitle: Sling JST test
var e = document.getElementById("JstDefaultRendering");
e.parentNode.removeChild(e);
And the /apps/foo/foo.jst.jst.js script that's referred to above is generated
to be:
out=document;
out.write("currentNode test\n");
out.write("Changed 1\n");
out.write("\n");
out.write("This is html.jst, path=");out.write( currentNode.description
);out.write(".\n");
out.write("\n");
out.write("\n");
out.write("\n");
out.write("Sling client library test\n");
out.write("root resource type=\n");
out.write(""); out.write(Sling.getContent("/")["sling:resourceType"]);
out.write(".\n");
out.write(" \n");
> JST scripting engine: render indexable HTML and separate javascript code
>
>
> Key: SLING-466
> URL: https://issues.apache.org/jira/browse/SLING-466
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> The JST scripting engine should output a default HTML rendering, meant to be
> indexed by search engines, with a
[jira] Commented: (SLING-466) JST scripting engine: render indexable HTML and separate javascript code
[ https://issues.apache.org/jira/browse/SLING-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605326#action_12605326 ] Bertrand Delacretaz commented on SLING-466: --- Revision 668200 renders the HTML and javascript separately, using the JsCodeGeneratorServlet, mapped to the jst selector and js extension, to generate the javascript code. The page title is the value of the first of these properties that's set on the node being rendered, if they are present: title, name, description. If not, the title is the node path, relative from the root. I'm thinking of allowing additional elements to be defined by the JST script, maybe something like Where everything between the comments would be added to the generated html element. And maybe also use something like To set class=foo and id=bar on the generated element. > JST scripting engine: render indexable HTML and separate javascript code > > > Key: SLING-466 > URL: https://issues.apache.org/jira/browse/SLING-466 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Bertrand Delacretaz >Priority: Minor > > The JST scripting engine should output a default HTML rendering, meant to be > indexed by search engines, with a
[jira] Closed: (SLING-515) IncludeTest fails when run against another Sling instance
[ https://issues.apache.org/jira/browse/SLING-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-515. - Resolution: Fixed Fixed in revision 668150, DefaultErrorHandlerServlet outputs error info even if response is already committed, without changing response status. For some reason, the behavior is different when running the integration tests as part of the Maven build (response was not committed in this case) and when running them against a Sling webapp that was already started with mvn jetty:run. Different Jetty versions are used in both cases, that might explain the difference. Anyway, I think it's good for the DefaultErrorHandlerServlet to at least output error info even if it's too late to change the HTTP response status, instead of being silent in this case as before. > IncludeTest fails when run against another Sling instance > - > > Key: SLING-515 > URL: https://issues.apache.org/jira/browse/SLING-515 > Project: Sling > Issue Type: Bug > Components: Launchpad >Affects Versions: 2.0.0 >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: 2.0.0 > > > Running the IncludeTest against a separate Sling instance like this: > mvn -o -s /dev/null test -Dhttp.port=8080 -Dtest=IncludeTest > -Dhttp.base.path=sling -Dwebdav.workspace.path=sling > whereas it passes when run as part of the full build, where Sling runs in the > same process and on / as opposed to /sling in the above example. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-515) IncludeTest fails when run against another Sling instance
[ https://issues.apache.org/jira/browse/SLING-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-515: -- Fix Version/s: 2.0.0 > IncludeTest fails when run against another Sling instance > - > > Key: SLING-515 > URL: https://issues.apache.org/jira/browse/SLING-515 > Project: Sling > Issue Type: Bug > Components: Launchpad >Affects Versions: 2.0.0 >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: 2.0.0 > > > Running the IncludeTest against a separate Sling instance like this: > mvn -o -s /dev/null test -Dhttp.port=8080 -Dtest=IncludeTest > -Dhttp.base.path=sling -Dwebdav.workspace.path=sling > whereas it passes when run as part of the full build, where Sling runs in the > same process and on / as opposed to /sling in the above example. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-537) WebDAV module processes zip and xml files, should not happen
[ https://issues.apache.org/jira/browse/SLING-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz closed SLING-537. - Resolution: Fixed Fixed in revision 668136, including tests which upload and check various types of files > WebDAV module processes zip and xml files, should not happen > > > Key: SLING-537 > URL: https://issues.apache.org/jira/browse/SLING-537 > Project: Sling > Issue Type: Bug > Components: JCR >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: 2.0.0 > > > The jcr/webdav/src/main/resources/webdav-resource-config.xml activates > Jackrabbit's ZipHandler and XmlHandler, which means zip and xml files copied > into the repository via WebDAV are expanded. > This is not useful in the general case, and people do not expect it in the > general case. I'll disable those configs in the jcr/webdav bundle. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-537) WebDAV module processes zip and xml files, should not happen
WebDAV module processes zip and xml files, should not happen Key: SLING-537 URL: https://issues.apache.org/jira/browse/SLING-537 Project: Sling Issue Type: Bug Components: JCR Reporter: Bertrand Delacretaz Priority: Minor Fix For: 2.0.0 The jcr/webdav/src/main/resources/webdav-resource-config.xml activates Jackrabbit's ZipHandler and XmlHandler, which means zip and xml files copied into the repository via WebDAV are expanded. This is not useful in the general case, and people do not expect it in the general case. I'll disable those configs in the jcr/webdav bundle. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-534) Multi-Value Reference properties are not exposed to scripting the same way as single-value reference properties
[ https://issues.apache.org/jira/browse/SLING-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605217#action_12605217 ] Bertrand Delacretaz commented on SLING-534: --- Could you provide some automated tests for your patch? See https://svn.apache.org/repos/asf/incubator/sling/trunk/scripting/javascript/src/test/java/org/apache/sling/scripting/wrapper/ScriptableNodeTest.java for examples, the framework provides everything to make it very easy to add automated tests. Or let us know if something's missing, and we'll fix it. > Multi-Value Reference properties are not exposed to scripting the same way as > single-value reference properties > --- > > Key: SLING-534 > URL: https://issues.apache.org/jira/browse/SLING-534 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: 2.0.0 >Reporter: Eric Norman > Attachments: multival_refprops_lookup.diff > > > If a node contains a multi-valued reference property, it is exposed to > scripts as an array of UUID strings. For single-value reference properties > the value is resolved to the referenced node. I'd expect the multi-value > reference properties to be resolved the same way and exposed to scripting as > an array of nodes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-533) Support multi-value type hints (eg. @TypeHint=String[])
[ https://issues.apache.org/jira/browse/SLING-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605216#action_12605216 ] Bertrand Delacretaz commented on SLING-533: --- I don't think this new behavior is tested, Alex could you maybe write some tests when you verify this feature? If you don't, please leave this issue open so that we don't forget to write tests when we find some time. > Support multi-value type hints (eg. @TypeHint=String[]) > --- > > Key: SLING-533 > URL: https://issues.apache.org/jira/browse/SLING-533 > Project: Sling > Issue Type: New Feature > Components: Servlets Post >Reporter: Alexander Klimetschek >Assignee: Carsten Ziegeler > Fix For: 2.0.1 > > > As discussed in SLING-522, when posting a single value to a property that > should be multi-valued, an extension to the @TypeHint is needed that allows > the explicit definition of a multi-value type. For example, for Strings this > would be @TypeHint=String[]. > Based on a quick look at the code, it should happen in > o.a.s.servlets.post.impl.helper.SlingPropertyValueHandler.setPropertyAsIs(). > First of all the parsing of the getTypeHint() must be changed to look for an > ending [] first, and then this "isMultiValued" information must be used to > call the multi-value version of setProperty() in all cases (values.length >= > 0). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-508) Parameter decoding uses wrong default charset
[ https://issues.apache.org/jira/browse/SLING-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602939#action_12602939 ] Bertrand Delacretaz commented on SLING-508: --- One thing that might help (though I'm not sure if it fits people's use cases) is for Sling to provide a value that can be added as a hidden parameter in forms, and allows the encoding to be recognized when processing the parameters. As a simplified example, if Sling provides "âêîôûäëïöü" as the reference value that must be submitted with a predefined parameter name, we could check that this value decodes correctly with a few possible encodings, to select the encoding to use for the other parameters. Not an ideal solution, but that should work. Maybe in addition (optional, provided by a separate bundle) to what Felix suggests. > Parameter decoding uses wrong default charset > - > > Key: SLING-508 > URL: https://issues.apache.org/jira/browse/SLING-508 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: 2.0.0 >Reporter: Tobias Bocanegra >Assignee: Felix Meschberger >Priority: Blocker > > As of SLING-152 the request paremeters are re-encoded if a _charset_ > parameter is present. it assumes that the default encoding is > UTF-8 which is not the case for servlet spec compliant containers (eg. > tomcat). > change the default encoding to ISO-8851-1 or make it configurable. > see: > http://svn.apache.org/viewvc/incubator/sling/trunk/engine/src/main/java/org/apache/sling/engine/impl/parameters/Util.java?view=markup -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-513) How to run the JCR Explorer with Sling?
How to run the JCR Explorer with Sling? --- Key: SLING-513 URL: https://issues.apache.org/jira/browse/SLING-513 Project: Sling Issue Type: Improvement Components: Documentation Reporter: Bertrand Delacretaz Priority: Minor It would be good to have a How-To document about using the JCR Explorer (http://www.jcr-explorer.org/, or another one?) with the Sling Launchpad. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-512) APT servlet takes over requests that do not have the aptml extension
APT servlet takes over requests that do not have the aptml extension Key: SLING-512 URL: https://issues.apache.org/jira/browse/SLING-512 Project: Sling Issue Type: Bug Components: Engine Affects Versions: 2.0.0 Reporter: Bertrand Delacretaz I downloaded http://people.apache.org/~cziegeler/releases/sling/maven/org.apache.sling.launchpad.app-2.0.0-incubator.jar and started it with java -jar ... Going to http://localhost:8080/index.html shows the page with no css and no logo, and http://localhost:8080/sling-logo.png gives an "Exception while parsing APT content" error. After stopping the APT servlet bundle, everything's back to normal. Same problem in the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-509) Run RAT and add missing license headers
[ https://issues.apache.org/jira/browse/SLING-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-509: -- Attachment: rat.txt RAT report from revision 663156 - fixed license headers since the last report. For some file types, RAT reports missing license headers because the license is not exactly as it expects it. > Run RAT and add missing license headers > --- > > Key: SLING-509 > URL: https://issues.apache.org/jira/browse/SLING-509 > Project: Sling > Issue Type: Test >Reporter: Bertrand Delacretaz > Fix For: 2.0.0 > > Attachments: rat.txt, rat.txt > > > We should run RAT (http://incubator.apache.org/rat/) and fix license headers > where needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-509) Run RAT and add missing license headers
[ https://issues.apache.org/jira/browse/SLING-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-509. --- Resolution: Fixed > Run RAT and add missing license headers > --- > > Key: SLING-509 > URL: https://issues.apache.org/jira/browse/SLING-509 > Project: Sling > Issue Type: Test >Reporter: Bertrand Delacretaz > Fix For: 2.0.0 > > Attachments: rat.txt, rat.txt > > > We should run RAT (http://incubator.apache.org/rat/) and fix license headers > where needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-509) Run RAT and add missing license headers
[ https://issues.apache.org/jira/browse/SLING-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-509: -- Fix Version/s: 2.0.0 > Run RAT and add missing license headers > --- > > Key: SLING-509 > URL: https://issues.apache.org/jira/browse/SLING-509 > Project: Sling > Issue Type: Test >Reporter: Bertrand Delacretaz > Fix For: 2.0.0 > > Attachments: rat.txt > > > We should run RAT (http://incubator.apache.org/rat/) and fix license headers > where needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-509) Run RAT and add missing license headers
[ https://issues.apache.org/jira/browse/SLING-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-509: -- Attachment: rat.txt RAT report for revision 663126 > Run RAT and add missing license headers > --- > > Key: SLING-509 > URL: https://issues.apache.org/jira/browse/SLING-509 > Project: Sling > Issue Type: Test >Reporter: Bertrand Delacretaz > Fix For: 2.0.0 > > Attachments: rat.txt > > > We should run RAT (http://incubator.apache.org/rat/) and fix license headers > where needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SLING-509) Run RAT and add missing license headers
Run RAT and add missing license headers --- Key: SLING-509 URL: https://issues.apache.org/jira/browse/SLING-509 Project: Sling Issue Type: Test Reporter: Bertrand Delacretaz We should run RAT (http://incubator.apache.org/rat/) and fix license headers where needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
