Re: SLING-857 patch
On Mon, Mar 2, 2009 at 11:22 AM, Vidar Ramdal wrote: > ...I have attached a patch for the testcase to the JIRA issue Fantastic, thanks! Patch applied. -Bertrand
Re: SLING-857 patch
On Mon, Mar 2, 2009 at 8:51 AM, Bertrand Delacretaz wrote: > Hi Vidar, > > On Fri, Feb 27, 2009 at 2:43 PM, Vidar Ramdal wrote: >> Any change of having the SLING-857 patch (reviewed and possibly) >> commited any day soon? Pretty-please-with-sugar-on-top?... > > I had a look now that Felix committed that patch, and IIUC there are > no automated tests for that feature, could you add some? D'oh, I had a test (no, really :), but I forgot to svn add before svn diff, so it was not included in the original patch. I have attached a patch for the testcase to the JIRA issue. -- Vidar S. Ramdal - http://www.idium.no Akersgata 16, N-0158 Oslo, Norway
Re: SLING-857 patch
Hi Vidar, On Fri, Feb 27, 2009 at 2:43 PM, Vidar Ramdal wrote: > Any change of having the SLING-857 patch (reviewed and possibly) > commited any day soon? Pretty-please-with-sugar-on-top?... I had a look now that Felix committed that patch, and IIUC there are no automated tests for that feature, could you add some? The easiest might be to add some initial content that uses his XSLT transform feature to the launchpad/testing module, and add some checks in InitialContentTest [1]. Just some simple smoke tests would be good enough IMHO, mainly to avoid regressions. -Bertrand [1] http://svn.apache.org/repos/asf/incubator/sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/InitialContentTest.java
Re: SLING-857 patch
Hi Torgeir, Torgeir Veimo schrieb: > > On 27 Feb 2009, at 19:44, Torgeir Veimo wrote: > >> >> On 27 Feb 2009, at 16:24, Vidar Ramdal wrote: >> >>> As for Torgeir's request [1] for a custom entity resolver, I haven't >>> had time to look at it for now, but I believe it should be doable. >> >> >> This would just be a simple dependency injection? Aren't there >> standard ways of doing this in osgi? > > > It's not so much a generic entity resolver that I'm in need of, more a > way to include files which would also be inside a bundle. But the > possibility to resolve eg html style entities would be very useful. > I have applied the patch as is. I think we may still extend the XML import functionality, but we should do this with separate issues. Dependency Injection: I would think, that we could support adding custom entity resolvers by leveraging the OSGi Service Registry: Resolvers are registered as services and consumed by the content loader. Regarding "include files": Not exactly sure, what you mean here... Regards Felix
Re: SLING-857 patch
Hi Vidar, Vidar Ramdal schrieb: > On Fri, Feb 27, 2009 at 3:47 PM, Felix Meschberger wrote: >> Hi Vidar, >> >> Vidar Ramdal schrieb: >>> Any change of having the SLING-857 patch (reviewed and possibly) >>> commited any day soon? Pretty-please-with-sugar-on-top? >>> We're preparing an internal release of our product, and it would make >>> it easier for us to be able to run on a non-modified Sling base. >> Yes, I planned it for today -- or this weekend. Would this suite your >> needs ? > > Absolutely. I was just afraid it was lost in the system somewhere. > Thanks, and have a great weekend! I have applied the patch as you might have seen in the issue mail. Regards and a great weekend to you, too Felix
Re: SLING-857 patch
On 27 Feb 2009, at 19:44, Torgeir Veimo wrote: On 27 Feb 2009, at 16:24, Vidar Ramdal wrote: As for Torgeir's request [1] for a custom entity resolver, I haven't had time to look at it for now, but I believe it should be doable. This would just be a simple dependency injection? Aren't there standard ways of doing this in osgi? It's not so much a generic entity resolver that I'm in need of, more a way to include files which would also be inside a bundle. But the possibility to resolve eg html style entities would be very useful. -- Torgeir Veimo torg...@pobox.com
Re: SLING-857 patch
On 27 Feb 2009, at 16:24, Vidar Ramdal wrote: As for Torgeir's request [1] for a custom entity resolver, I haven't had time to look at it for now, but I believe it should be doable. This would just be a simple dependency injection? Aren't there standard ways of doing this in osgi? -- Torgeir Veimo torg...@pobox.com
Re: SLING-857 patch
As for Torgeir's request [1] for a custom entity resolver, I haven't had time to look at it for now, but I believe it should be doable. Maybe Torgeir would open a new issue for it? >> Vidar Ramdal schrieb: >>> Any change of having the SLING-857 patch [...] > On Fri, Feb 27, 2009 at 3:47 PM, Felix Meschberger wrote: >> Yes, I planned it for today -- or this weekend. Would this suite your >> needs ? On Fri, Feb 27, 2009 at 4:18 PM, Vidar Ramdal wrote: > Absolutely. I was just afraid it was lost in the system somewhere. > Thanks, and have a great weekend! [1] https://issues.apache.org/jira/browse/SLING-857?focusedCommentId=12676298#action_12676298 -- Vidar S. Ramdal - http://www.idium.no Akersgata 16, N-0158 Oslo, Norway
Re: SLING-857 patch
On Fri, Feb 27, 2009 at 3:47 PM, Felix Meschberger wrote: > Hi Vidar, > > Vidar Ramdal schrieb: >> Any change of having the SLING-857 patch (reviewed and possibly) >> commited any day soon? Pretty-please-with-sugar-on-top? >> We're preparing an internal release of our product, and it would make >> it easier for us to be able to run on a non-modified Sling base. > > Yes, I planned it for today -- or this weekend. Would this suite your > needs ? Absolutely. I was just afraid it was lost in the system somewhere. Thanks, and have a great weekend! -- Vidar S. Ramdal - http://www.idium.no Akersgata 16, N-0158 Oslo, Norway
Re: SLING-857 patch
Hi Vidar, Vidar Ramdal schrieb: > Any change of having the SLING-857 patch (reviewed and possibly) > commited any day soon? Pretty-please-with-sugar-on-top? > We're preparing an internal release of our product, and it would make > it easier for us to be able to run on a non-modified Sling base. Yes, I planned it for today -- or this weekend. Would this suite your needs ? Regards Felix
