RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file
i'll have another go at the patch tomorrow morning; testing the raw-schema.jsp (even if it's not used) and put back the test. - will From: Chris Hostetter [mailto:[EMAIL PROTECTED] Sent: Thu 5/24/2007 6:02 PM To: solr-dev@lucene.apache.org Subject: RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file : 2) why did you remove testDynamicCopy() from IndexSchemaTest ? : : becuase it had nothing to do with testing the index schema. as far as i : could tell it was a ctrl-c / ctrl-v error. that or i'm really blind and : happy to put it back. idon't see a test with that name defined anywhere. it's testing that you can declare dynamic fields and copy them using copyField ... that sounds like an IndexSchemaTest to me (lots of other schema related tests may be in BasicFunctionalityTest or ConvertedLegacyTest, but we should try to use the class specific test classes when the test is very narrow) : 3) raw-schema.jsp on the trunk appears to be completely broken (multiple : <%@ page contentType="..."%> declarations), and not linked to from the : my patch worked but i also saw that it wasn't linked anywhere. i thought your patch left the multiple contentType declarations, but i don't rememebr for certain now ... it's a trivial issue either way. -Hoss
RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file
: 2) why did you remove testDynamicCopy() from IndexSchemaTest ? : : becuase it had nothing to do with testing the index schema. as far as i : could tell it was a ctrl-c / ctrl-v error. that or i'm really blind and : happy to put it back. idon't see a test with that name defined anywhere. it's testing that you can declare dynamic fields and copy them using copyField ... that sounds like an IndexSchemaTest to me (lots of other schema related tests may be in BasicFunctionalityTest or ConvertedLegacyTest, but we should try to use the class specific test classes when the test is very narrow) : 3) raw-schema.jsp on the trunk appears to be completely broken (multiple : <%@ page contentType="..."%> declarations), and not linked to from the : my patch worked but i also saw that it wasn't linked anywhere. i thought your patch left the multiple contentType declarations, but i don't rememebr for certain now ... it's a trivial issue either way. -Hoss
RE: [jira] Commented: (SOLR-239) Read IndexSchema from InputStream instead of Config file
1) there is a public API change here by removing the getIputStream() method from IndexSearcher. probably not a big deal but important that we consider it. true, that called wasn't used anywhere else in the solr trunk code. also after a lot of thought i realized that it's in general a poor idea to rely on getting an input stream in any reliable fashion other than when it's first opened. (many don't support reset) i can put it back easily if people are that worried about breaking compatibility but in general it seems like it's asking for trouble without knowing the implemntation. 2) why did you remove testDynamicCopy() from IndexSchemaTest ? becuase it had nothing to do with testing the index schema. as far as i could tell it was a ctrl-c / ctrl-v error. that or i'm really blind and happy to put it back. 3) raw-schema.jsp on the trunk appears to be completely broken (multiple <%@ page contentType="..."%> declarations), and not linked to from the admin screen anyway ... we might want to just remove it completely and make a note in the CHANGES in case people have the old URL bookmarked. my patch worked but i also saw that it wasn't linked anywhere. - will > Read IndexSchema from InputStream instead of Config file > > > Key: SOLR-239 > URL: https://issues.apache.org/jira/browse/SOLR-239 > Project: Solr > Issue Type: Improvement >Affects Versions: 1.2 > Environment: all >Reporter: Will Johnson >Priority: Minor > Fix For: 1.2 > > Attachments: IndexSchemaStream.patch, IndexSchemaStream2.patch, > IndexSchemaStream2.patch > > > Soon to follow patch adds a constructor to IndexSchema to allow them to be > created directly from InputStreams. The overall logic for the Core's use of > the IndexSchema creation/use does not change however this allows java clients > like those in SOLR-20 to be able to parse an IndexSchema. Once a schema is > parsed, the client can inspect an index's capabilities which is useful for > building generic search UI's. ie provide a drop down list of fields to > search/sort by. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
