Re: CVS: cvs.openbsd.org: src

2023-06-07 Thread hrvoje 
On 1.6.2023. 20:57, Klemens Nanni wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   k...@cvs.openbsd.org2023/06/01 12:57:54
> 
> Modified files:
>   sys/net: if_wg.c if_wg.h 
>   sbin/ifconfig  : ifconfig.8 ifconfig.c 
> 
> Log message:
> Add support for wireguard peer descriptions
> 
> "wgdescr[iption] foo" to label one peer (amongst many) on a wg(4) interface,
> "-wgdescr[iption]" or "wgdescr ''" to remove the label, completely analogous
> to existing interface discriptions.
> 
> Idea/initial diff from Mikolaj Kucharski (OK sthen)
> Tests/prodded by Hrvoje Popovski
> Tweaks/manual bits from me
> Feedback deraadt sthen mvs claudio
> OK claudio
> 
> 

Thank you

Re: CVS: cvs.openbsd.org: src

2023-04-29 Thread hrvoje 
On 28.4.2023. 17:50, Alexandr Nedvedicky wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   sas...@cvs.openbsd.org  2023/04/28 09:50:05
> 
> Modified files:
>   sys/net: if_pfsync.c 
> 
> Log message:
> remove superfluous/invalid KASSERT() in pfsync_q_del().
> 
> pointed and OK bluhm@
> 
> 

I thought that this diff would repair this panic


r620-2# uvm_fault(0x825c8000, 0x17, 0, 2) -> e
kernel: page fault trap, code=2
Stopped at  pfsync_q_del+0x8d:  movq%rdx,0x8(%rax)
TIDPIDUID PRFLAGS PFLAGS  CPU  COMMAND
*461341  27834  0 0x14000  0x2005K softnet
pfsync_q_del(fd832ba5d320) at pfsync_q_del+0x8d
pf_remove_state(fd832ba5d320) at pf_remove_state+0x156
pfsync_in_del_c(fd8002ce6738,c,79,0) at pfsync_in_del_c+0x6f
pfsync_input(800022d60a98,800022d60aa4,f0,2) at pfsync_input+0x34c
ip_deliver(800022d60a98,800022d60aa4,f0,2) at ip_deliver+0x113
ipintr() at ipintr+0x69
if_netisr(0) at if_netisr+0xe0
taskq_thread(8003) at taskq_thread+0x100
end trace frame: 0x0, count: 7
https://www.openbsd.org/ddb.html describes the minimum info required in
bug reports.  Insufficient info makes it difficult to find and fix bugs.


but it didn't :)

Re: CVS: cvs.openbsd.org: src

2022-04-14 Thread Hrvoje Popovski 
On 14.4.2022. 20:55, hrvoje wrote:
> On 13.4.2022. 19:22, Alexander Bluhm wrote:
>> On Fri, Apr 08, 2022 at 07:49:43PM -0600, Dave Voutila wrote:
>>> CVSROOT:/cvs
>>> Module name:src
>>> Changes by: d...@cvs.openbsd.org2022/04/08 19:49:43
>>>
>>> Modified files:
>>> sys/arch/amd64/amd64: vmm_support.S
>>>
>>> Log message:
>>> Simplify vmx instruction error handling.
>>>
>>> Removes jumps and shortens the code while keeping functionality the
>>> same.
>>>
>>> ok mlarkin@
>>
>> This commit breaks vmm on my ThinkPad T430s.
>>
>> cpu1: failed to enter VMM mode
>> cpu0: failed to enter VMM mode
>>
>> cpu0: Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz, 2893.83 MHz, 06-3a-09
>> cpu0: 
>> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
>> cpu0: 256KB 64b/line 8-way L2 cache
>>
>> I think the problem is that XOR affects the zero flag.  Does it?
>> This diff fixes it.
>>
> 
> Hi,
> 
> I don't know if this commit broke things but i'm having same errors as
> bluhm@ and vm's doesn't come up .
> 
> login: cpu9: failed to enter VMM mode
> cpu8: failed to enter VMM mode
> cpu7: failed to enter VMM mode
> cpu6: failed to enter VMM mode
> cpu5: failed to enter VMM mode
> cpu4: failed to enter VMM mode
> cpu3: failed to enter VMM mode
> cpu1: failed to enter VMM mode
> cpu2: failed to enter VMM mode
> cpu11: failed to enter VMM mode
> cpu10: failed to enter VMM mode
> cpu9: failed to enter VMM mode
> cpu8: failed to enter VMM mode
> cpu7: failed to enter VMM mode
> cpu6: failed to enter VMM mode
> cpu5: failed to enter VMM mode
> cpu4: failed to enter VMM mode
> cpu3: failed to enter VMM mode
> cpu2: failed to enter VMM mode
> cpu1: failed to enter VMM mode
> cpu0: failed to enter VMM mode
> smr: dispatch took 11.170215s
> cpu0: failed to enter VMM mode
> cpu11: failed to enter VMM mode
> cpu10: failed to enter VMM mode
> cpu9: failed to enter VMM mode
> cpu8: failed to enter VMM mode
> cpu7: failed to enter VMM mode
> cpu6: failed to enter VMM mode
> cpu5: failed to enter VMM mode
> cpu3: failed to enter VMM mode
> cpu2: failed to enter VMM mode
> cpu1: failed to enter VMM mode
> cpu4: failed to enter VMM mode
> cpu0: failed to enter VMM mode
> cpu11: failed to enter VMM mode
> cpu10: failed to enter VMM mode
> cpu9: failed to enter VMM mode
> cpu8: failed to enter VMM mode
> cpu7: failed to enter VMM mode
> cpu6: failed to enter VMM mode
> cpu4: failed to enter VMM mode
> cpu3: failed to enter VMM mode
> cpu2: failed to enter VMM mode
> cpu1: failed to enter VMM mode
> cpu5: failed to enter VMM mode
> 
> 

with bluhm@ diff vmm seems good as before ..


dmesg
OpenBSD 7.1-current (GENERIC.MP) #22: Thu Apr 14 21:15:30 CEST 2022
hrv...@x3550m4.srce.hr:/sys/arch/amd64/compile/GENERIC.MP
real mem = 34297651200 (32708MB)
avail mem = 33240903680 (31700MB)
random: good seed from bootblocks
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.7 @ 0x7e67b000 (84 entries)
bios0: vendor IBM version "-[D7E174BUS-3.20]-" date 06/15/2020
bios0: IBM IBM System x3550 M4 -[791425Z]-
acpi0 at bios0: ACPI 4.0
acpi0: sleep states S0 S5
acpi0: tables DSDT FACP TCPA ERST HEST HPET APIC MCFG OEM1 SLIT SLIC
SSDT SSDT SSDT SSDT DMAR
acpi0: wakeup devices MRP1(S4) DCC0(S4) MRP3(S4) MRP5(S4) EHC2(S5)
PEX0(S5) PEX7(S5) EHC1(S5) IP2P(S3) MRPB(S4) MRPC(S4) MRPD(S4) MRPF(S4)
MRPG(S4) MRPH(S4) MRPI(S4) [...]
acpitimer0 at acpi0: 3579545 Hz, 24 bits
acpihpet0 at acpi0: 14318179 Hz
acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: Intel(R) Xeon(R) CPU E5-2620 v2 @ 2.10GHz, 2400.39 MHz, 06-3e-04
cpu0:
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,DCA,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu0: 256KB 64b/line 8-way L2 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges
cpu0: apic clock running at 100MHz
cpu0: mwait min=64, max=64, C-substates=0.2.1.1, IBE
cpu1 at mainbus0: apid 2 (application processor)
cpu

Re: CVS: cvs.openbsd.org: src

2022-04-14 Thread hrvoje 
On 13.4.2022. 19:22, Alexander Bluhm wrote:
> On Fri, Apr 08, 2022 at 07:49:43PM -0600, Dave Voutila wrote:
>> CVSROOT: /cvs
>> Module name: src
>> Changes by:  d...@cvs.openbsd.org2022/04/08 19:49:43
>>
>> Modified files:
>>  sys/arch/amd64/amd64: vmm_support.S
>>
>> Log message:
>> Simplify vmx instruction error handling.
>>
>> Removes jumps and shortens the code while keeping functionality the
>> same.
>>
>> ok mlarkin@
> 
> This commit breaks vmm on my ThinkPad T430s.
> 
> cpu1: failed to enter VMM mode
> cpu0: failed to enter VMM mode
> 
> cpu0: Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz, 2893.83 MHz, 06-3a-09
> cpu0: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
> cpu0: 256KB 64b/line 8-way L2 cache
> 
> I think the problem is that XOR affects the zero flag.  Does it?
> This diff fixes it.
> 

Hi,

I don't know if this commit broke things but i'm having same errors as
bluhm@ and vm's doesn't come up .

login: cpu9: failed to enter VMM mode
cpu8: failed to enter VMM mode
cpu7: failed to enter VMM mode
cpu6: failed to enter VMM mode
cpu5: failed to enter VMM mode
cpu4: failed to enter VMM mode
cpu3: failed to enter VMM mode
cpu1: failed to enter VMM mode
cpu2: failed to enter VMM mode
cpu11: failed to enter VMM mode
cpu10: failed to enter VMM mode
cpu9: failed to enter VMM mode
cpu8: failed to enter VMM mode
cpu7: failed to enter VMM mode
cpu6: failed to enter VMM mode
cpu5: failed to enter VMM mode
cpu4: failed to enter VMM mode
cpu3: failed to enter VMM mode
cpu2: failed to enter VMM mode
cpu1: failed to enter VMM mode
cpu0: failed to enter VMM mode
smr: dispatch took 11.170215s
cpu0: failed to enter VMM mode
cpu11: failed to enter VMM mode
cpu10: failed to enter VMM mode
cpu9: failed to enter VMM mode
cpu8: failed to enter VMM mode
cpu7: failed to enter VMM mode
cpu6: failed to enter VMM mode
cpu5: failed to enter VMM mode
cpu3: failed to enter VMM mode
cpu2: failed to enter VMM mode
cpu1: failed to enter VMM mode
cpu4: failed to enter VMM mode
cpu0: failed to enter VMM mode
cpu11: failed to enter VMM mode
cpu10: failed to enter VMM mode
cpu9: failed to enter VMM mode
cpu8: failed to enter VMM mode
cpu7: failed to enter VMM mode
cpu6: failed to enter VMM mode
cpu4: failed to enter VMM mode
cpu3: failed to enter VMM mode
cpu2: failed to enter VMM mode
cpu1: failed to enter VMM mode
cpu5: failed to enter VMM mode