Re: CVS commit: [netbsd-6-0] src/sys
Hi, Erik. (2014/06/23 7:15), Manuel Bouyer wrote: On Sun, Jun 22, 2014 at 02:30:42PM -0700, Erik Fair wrote: It appears that these changes were applied to "netbsd-6-0" and "netbsd-6-1" but not to "netbsd-6" (which is a problem for those of us following "netbsd-6"). AFAIK it was pulled up on Jun 3 on -6. As it's a bit invasive I suggested to wait a bit before pulling up to 6-0 and 6-1. Right. I used netbsd-6 kernel with that patch for two weeks and I had not gotten any problem, so I pulled up the change to netbsd-6-1 and netbsd-6-0. You can see the discussion in: http://releng.netbsd.org/cgi-bin/req-6.cgi?show=1067 Thanks. -- --- SAITOH Masanobu (msai...@execsw.org msai...@netbsd.org)
Re: CVS commit: src/external/bsd/cron/dist
On Jun 22, 8:58pm, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/external/bsd/cron/dist | On Sun, Jun 22, 2014 at 04:53:50PM -0400, Christos Zoulas wrote: | > | > >Modified Files: | > | > > src/external/bsd/cron/dist: do_command.c | > | > > | > | > >Log Message: | > | > >Log some actual information on various failures, so you can tell | > | > >what happened. | > | > | > | > ??? This code is not used. We are using the LOGIN_CAP code. What are you | > | > trying to fix? | > | | > | Isn't it? (All of it?) I had a problem at one point (a few months | > | back, I think, it took me a while to remember to fetch the patch out | > | and commit it) that was printing a useless message, and I added some | > | extra information to diagnose it, and in the course of found a lot of | > | similar diagnostics and patched them all for completeness. | > | > All of it :-) | | The chdir one is outside of LOGIN_CAP. That's the one I hit, I think | because of nfs/nis issues, and I fixed the rest because they're all | the same. That's the only one. I would have fixed them by also printing the string that failed not just the user info. But that's better than before. | I think I was contemplating sending the patch upstream. (is that | worthwhile?) Go for it. We have a *lot* of other patches that should be sent upstream too. christos
Re: CVS commit: [netbsd-6-0] src/sys
On Sun, Jun 22, 2014 at 02:30:42PM -0700, Erik Fair wrote: > It appears that these changes were applied to "netbsd-6-0" and "netbsd-6-1" > but not to "netbsd-6" (which is a problem for those of us following > "netbsd-6"). AFAIK it was pulled up on Jun 3 on -6. As it's a bit invasive I suggested to wait a bit before pulling up to 6-0 and 6-1. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --
Re: CVS commit: [netbsd-6-0] src/sys
It appears that these changes were applied to "netbsd-6-0" and "netbsd-6-1" but not to "netbsd-6" (which is a problem for those of us following "netbsd-6"). Erik On Jun 18, 2014, at 02:35 , SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Wed Jun 18 09:35:40 UTC 2014 > > Modified Files: > src/sys/dist/ipf/netinet [netbsd-6-0]: ip_fil_netbsd.c > src/sys/net [netbsd-6-0]: if_ethersubr.c if_loop.c if_vlan.c > src/sys/netinet [netbsd-6-0]: if_arp.c ip_carp.c > src/sys/netinet6 [netbsd-6-0]: ip6_flow.c nd6.c > src/sys/rump/librump/rumpkern [netbsd-6-0]: klock.c > > Log Message: > Pull up following revision(s) (requested by bouyer in ticket #1067): > sys/dist/ipf/netinet/ip_fil_netbsd.c1.9 via patch > sys/net/if_ethersubr.c 1.197 via patch > sys/net/if_loop.c 1.77 via patch > sys/net/if_vlan.c 1.70 via patch > sys/netinet/if_arp.c1.158 > sys/netinet/ip_carp.c 1.54 via patch > sys/netinet6/ip6_flow.c 1.23 via patch > sys/netinet6/nd6.c 1.150 via patch > sys/rump/librump/rumpkern/klock.c 1.4 > > Make sure *(if_output)() is called with KERNEL_LOCK held to avoid mbuf leak. > See http://mail-index.netbsd.org/tech-net/2014/04/09/msg004511.html > for details. For netinet6, the problem report, fix and test were done > by njoly@ on current-users@ > > > To generate a diff of this commit: > cvs rdiff -u -r1.61.6.1 -r1.61.6.2 src/sys/dist/ipf/netinet/ip_fil_netbsd.c > cvs rdiff -u -r1.188.8.2 -r1.188.8.2.4.1 src/sys/net/if_ethersubr.c > cvs rdiff -u -r1.75 -r1.75.14.1 src/sys/net/if_loop.c > cvs rdiff -u -r1.69 -r1.69.14.1 src/sys/net/if_vlan.c > cvs rdiff -u -r1.154 -r1.154.8.1 src/sys/netinet/if_arp.c > cvs rdiff -u -r1.47.4.1 -r1.47.4.1.4.1 src/sys/netinet/ip_carp.c > cvs rdiff -u -r1.19 -r1.19.8.1 src/sys/netinet6/ip6_flow.c > cvs rdiff -u -r1.141.6.2 -r1.141.6.3 src/sys/netinet6/nd6.c > cvs rdiff -u -r1.3 -r1.3.18.1 src/sys/rump/librump/rumpkern/klock.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
Re: CVS commit: src/external/bsd/cron/dist
On Sun, Jun 22, 2014 at 04:53:50PM -0400, Christos Zoulas wrote: > | > >Modified Files: > | > > src/external/bsd/cron/dist: do_command.c > | > > > | > >Log Message: > | > >Log some actual information on various failures, so you can tell > | > >what happened. > | > > | > ??? This code is not used. We are using the LOGIN_CAP code. What are you > | > trying to fix? > | > | Isn't it? (All of it?) I had a problem at one point (a few months > | back, I think, it took me a while to remember to fetch the patch out > | and commit it) that was printing a useless message, and I added some > | extra information to diagnose it, and in the course of found a lot of > | similar diagnostics and patched them all for completeness. > > All of it :-) The chdir one is outside of LOGIN_CAP. That's the one I hit, I think because of nfs/nis issues, and I fixed the rest because they're all the same. I think I was contemplating sending the patch upstream. (is that worthwhile?) -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/external/bsd/cron/dist
On Jun 22, 4:50pm, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/external/bsd/cron/dist | On Sat, Jun 21, 2014 at 02:20:59PM +, Christos Zoulas wrote: | > >Modified Files: | > > src/external/bsd/cron/dist: do_command.c | > > | > >Log Message: | > >Log some actual information on various failures, so you can tell | > >what happened. | > | > ??? This code is not used. We are using the LOGIN_CAP code. What are you | > trying to fix? | | Isn't it? (All of it?) I had a problem at one point (a few months | back, I think, it took me a while to remember to fetch the patch out | and commit it) that was printing a useless message, and I added some | extra information to diagnose it, and in the course of found a lot of | similar diagnostics and patched them all for completeness. All of it :-) christos
Re: CVS commit: src/external/bsd/cron/dist
On Sat, Jun 21, 2014 at 02:20:59PM +, Christos Zoulas wrote: > >Modified Files: > >src/external/bsd/cron/dist: do_command.c > > > >Log Message: > >Log some actual information on various failures, so you can tell > >what happened. > > ??? This code is not used. We are using the LOGIN_CAP code. What are you > trying to fix? Isn't it? (All of it?) I had a problem at one point (a few months back, I think, it took me a while to remember to fetch the patch out and commit it) that was printing a useless message, and I added some extra information to diagnose it, and in the course of found a lot of similar diagnostics and patched them all for completeness. -- David A. Holland dholl...@netbsd.org
