Re: CVS commit: src/sbin/gpt

2015-12-02 Thread Robert Elz 
Date:Wed, 2 Dec 2015 07:36:53 -0500
From:"Christos Zoulas" 
Message-ID:  <20151202123653.7531...@cvs.netbsd.org>

  | Modified Files:
  | src/sbin/gpt: backup.c gpt.8 restore.c
  | 
  | Log Message:
  | Allow backup and restore to operate on files.

Will that modified code still (really) support writing to stdout?
The man page suggests it should, but I don't see how the code can.

kre

Re: CVS commit: src/sbin/gpt

2015-12-02 Thread Christos Zoulas 
In article <28433.1449088...@andromeda.noi.kre.to>,
Robert Elz   wrote:
>Date:Wed, 2 Dec 2015 07:36:53 -0500
>From:"Christos Zoulas" 
>Message-ID:  <20151202123653.7531...@cvs.netbsd.org>
>
>  | Modified Files:
>  |src/sbin/gpt: backup.c gpt.8 restore.c
>  | 
>  | Log Message:
>  | Allow backup and restore to operate on files.
>
>Will that modified code still (really) support writing to stdout?
>The man page suggests it should, but I don't see how the code can.

"/dev/stdout".

christos

Re: CVS commit: src/sbin/gpt

2015-12-02 Thread Christos Zoulas 
On Dec 3,  5:37am, k...@munnari.oz.au (Robert Elz) wrote:
-- Subject: Re: CVS commit: src/sbin/gpt

| Sure, but "how do write to stdout" wasn't what I asked ...
| 
|  gpt backup [-o outfile]
|  The backup command dumps the MBR or (PMBR) and GPT partition
|  tables to standard output or to a file specified by the outfile
|  argument in a format to be used by the restore command.  The
|  format is a plist.  It should not be modified.
| 
| What I meant was, if the "-o outfile" is not there, and the dump is
| "tables to standard output" and not "or to a file specified" ...
| 
| How does that work now?
| 
| Of, if you like, take your new version, and just try "gpt backup XXXn"
| (or whatever device is relevant) and observe.

I observe data going to stdout because:

static const char *outfile = "/dev/stdout";

It does not work for you?

christos

Re: CVS commit: src/sbin/gpt

2015-12-02 Thread Robert Elz 
Date:Wed, 2 Dec 2015 17:41:08 -0500
From:chris...@zoulas.com (Christos Zoulas)
Message-ID:  <20151202224108.9064b17f...@rebar.astron.com>

  | I observe data going to stdout because:
  | static const char *outfile = "/dev/stdout";

Oh yes, OK, sorry - missed that.It isn't a style I would use, so
I wasn't expecting that.   I dislike assigning to a gobal var from a
source that might come from anywhere ... in current invocation it is
from the arg list, so isstable, but someone might add an interactive
gpt mode, and then this method would break badly.

kre

Re: CVS commit: src/sbin/gpt

2015-12-02 Thread Christos Zoulas 
On Dec 3,  6:54am, k...@munnari.oz.au (Robert Elz) wrote:
-- Subject: Re: CVS commit: src/sbin/gpt

| Date:Wed, 2 Dec 2015 17:41:08 -0500
| From:chris...@zoulas.com (Christos Zoulas)
| Message-ID:  <20151202224108.9064b17f...@rebar.astron.com>
| 
|   | I observe data going to stdout because:
|   | static const char *outfile = "/dev/stdout";
| 
| Oh yes, OK, sorry - missed that.It isn't a style I would use, so
| I wasn't expecting that.   I dislike assigning to a gobal var from a
| source that might come from anywhere ... in current invocation it is
| from the arg list, so isstable, but someone might add an interactive
| gpt mode, and then this method would break badly.

Yes, I am fixing those in the next pass (no static globals).

christos

Re: CVS commit: src/distrib/sets/lists/modules

2015-12-02 Thread Paul Goyette 


On Tue, 1 Dec 2015, Paul Goyette wrote:


Module Name:src
Committed By:   pgoyette
Date:   Tue Dec  1 09:15:58 UTC 2015

Modified Files:
src/distrib/sets/lists/modules: ad.arm ad.mips md.amd64

Log Message:
Finish up with the new compat_netbsd32_nfssrv module by adding it to
the sets lists.

This set of commits together should address PRs kern/50410 and kern/50486.


This should be "kern/50410 and kern/50468"


This is also the first of several new modules to be created in response to
PR kern/50489


Looks like this got logged in gnats only for the last-mentioned PR, so
I'll manually add to the audit trails.



To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/distrib/sets/lists/modules/ad.arm \
   src/distrib/sets/lists/modules/ad.mips
cvs rdiff -u -r1.63 -r1.64 src/distrib/sets/lists/modules/md.amd64

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+--+--++