CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Thu May 23 06:35:45 UTC 2024 Modified Files: src/share/man/man9: versioningsyscalls.9 Log Message: s/and/an/ To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/share/man/man9/versioningsyscalls.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/share/man/man9/versioningsyscalls.9 diff -u src/share/man/man9/versioningsyscalls.9:1.6 src/share/man/man9/versioningsyscalls.9:1.7 --- src/share/man/man9/versioningsyscalls.9:1.6 Mon May 20 17:12:41 2024 +++ src/share/man/man9/versioningsyscalls.9 Thu May 23 06:35:45 2024 @@ -1,4 +1,4 @@ -.\" $NetBSD: versioningsyscalls.9,v 1.6 2024/05/20 17:12:41 christos Exp $ +.\" $NetBSD: versioningsyscalls.9,v 1.7 2024/05/23 06:35:45 pgoyette Exp $ .\" .\" Copyright (c) 2023 The NetBSD Foundation, Inc. .\" All rights reserved. @@ -224,7 +224,7 @@ variable. .Ss Regenerating the system calls If versioning structs, then modify .Pa sys/kern/makesyscalls.sh -by adding and entry for +by adding an entry for .Ft struct my_structCNUM type to .Va uncompattypes .
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Thu May 23 06:35:45 UTC 2024 Modified Files: src/share/man/man9: versioningsyscalls.9 Log Message: s/and/an/ To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/share/man/man9/versioningsyscalls.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules/ffs
Module Name:src Committed By: pgoyette Date: Thu May 23 06:10:04 UTC 2024 Modified Files: src/sys/modules/ffs: Makefile Log Message: Get the case right when reverting local changes To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/sys/modules/ffs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/modules/ffs/Makefile diff -u src/sys/modules/ffs/Makefile:1.26 src/sys/modules/ffs/Makefile:1.27 --- src/sys/modules/ffs/Makefile:1.26 Wed May 22 17:20:45 2024 +++ src/sys/modules/ffs/Makefile Thu May 23 06:10:03 2024 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.26 2024/05/22 17:20:45 pgoyette Exp $ +# $NetBSD: Makefile,v 1.27 2024/05/23 06:10:03 pgoyette Exp $ .include "../Makefile.inc" @@ -6,7 +6,7 @@ KMOD= ffs CPPFLAGS+= -DFFS_EI -DWAPBL -DAPPLE_UFS -DQUOTA -DQUOTA2 -CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACl -DUFS_DIRHASH +CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -DUFS_DIRHASH CWARNFLAGS.clang= -Wno-conversion COPTS.ffs_appleufs.c+= ${CC_WNO_ADDRESS_OF_PACKED_MEMBER}
CVS commit: src/sys/modules/ffs
Module Name:src Committed By: pgoyette Date: Thu May 23 06:10:04 UTC 2024 Modified Files: src/sys/modules/ffs: Makefile Log Message: Get the case right when reverting local changes To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/sys/modules/ffs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Wed May 22 17:20:45 UTC 2024 Modified Files: src/sys/modules/ffs: Makefile src/sys/modules/ufs: Makefile Log Message: Remove some more accidental local changes To generate a diff of this commit: cvs rdiff -u -r1.25 -r1.26 src/sys/modules/ffs/Makefile cvs rdiff -u -r1.9 -r1.10 src/sys/modules/ufs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Wed May 22 17:20:45 UTC 2024 Modified Files: src/sys/modules/ffs: Makefile src/sys/modules/ufs: Makefile Log Message: Remove some more accidental local changes To generate a diff of this commit: cvs rdiff -u -r1.25 -r1.26 src/sys/modules/ffs/Makefile cvs rdiff -u -r1.9 -r1.10 src/sys/modules/ufs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/modules/ffs/Makefile diff -u src/sys/modules/ffs/Makefile:1.25 src/sys/modules/ffs/Makefile:1.26 --- src/sys/modules/ffs/Makefile:1.25 Mon May 20 18:14:38 2024 +++ src/sys/modules/ffs/Makefile Wed May 22 17:20:45 2024 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.25 2024/05/20 18:14:38 pgoyette Exp $ +# $NetBSD: Makefile,v 1.26 2024/05/22 17:20:45 pgoyette Exp $ .include "../Makefile.inc" @@ -6,21 +6,15 @@ KMOD= ffs CPPFLAGS+= -DFFS_EI -DWAPBL -DAPPLE_UFS -DQUOTA -DQUOTA2 -CPPFLAGS+= -DUFS_DIRHASH +CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACl -DUFS_DIRHASH CWARNFLAGS.clang= -Wno-conversion COPTS.ffs_appleufs.c+= ${CC_WNO_ADDRESS_OF_PACKED_MEMBER} SRCS+= ffs_alloc.c ffs_balloc.c ffs_inode.c ffs_subr.c ffs_tables.c \ - ffs_vfsops.c ffs_vnops.c ffs_snapshot.c \ + ffs_vfsops.c ffs_vnops.c ffs_snapshot.c ffs_extattr.c \ ffs_bswap.c ffs_wapbl.c ffs_appleufs.c ffs_quota2.c -#CPPFLAGS+= -DUFS_EXTATTR -#SRCS+= ffs_extattr.c - -#CPPFLAGS+= -DUFS_ACL -#SRCS+= ufs_acl.c - WARNS= 3 .include Index: src/sys/modules/ufs/Makefile diff -u src/sys/modules/ufs/Makefile:1.9 src/sys/modules/ufs/Makefile:1.10 --- src/sys/modules/ufs/Makefile:1.9 Mon May 20 18:14:38 2024 +++ src/sys/modules/ufs/Makefile Wed May 22 17:20:45 2024 @@ -1,25 +1,19 @@ -# $NetBSD: Makefile,v 1.9 2024/05/20 18:14:38 pgoyette Exp $ +# $NetBSD: Makefile,v 1.10 2024/05/22 17:20:45 pgoyette Exp $ .include "../Makefile.inc" KMOD= ufs CPPFLAGS+= -DFFS_EI -DWAPBL -DAPPLE_UFS -DQUOTA -DQUOTA2 -CPPFLAGS+= -DUFS_DIRHASH +CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -DUFS_DIRHASH CWARNFLAGS.clang= -Wno-conversion .PATH: ${S}/ufs/ufs -SRCS+= ufs_bmap.c ufs_dirhash.c ufs_inode.c \ +SRCS+= ufs_acl.c ufs_bmap.c ufs_dirhash.c ufs_extattr.c ufs_inode.c \ ufs_lookup.c ufs_quota.c ufs_quota1.c ufs_quota2.c ufs_rename.c \ ufs_vfsops.c ufs_vnops.c quota1_subr.c quota2_subr.c -#CPPFLAGS+= -DUFS_ACL -#SRCS+= ufs_acl.c - -#CPPFLAGS+= -DUFS_EXTATTR -#SRCS+= ufs_extattr.c - WARNS= 3 .include
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Mon May 20 18:14:38 UTC 2024 Modified Files: src/sys/modules: Makefile src/sys/modules/ffs: Makefile src/sys/modules/ufs: Makefile Log Message: Oooppss remove some local change that was accidentally committed To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290 src/sys/modules/Makefile cvs rdiff -u -r1.24 -r1.25 src/sys/modules/ffs/Makefile cvs rdiff -u -r1.8 -r1.9 src/sys/modules/ufs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/modules/Makefile diff -u src/sys/modules/Makefile:1.289 src/sys/modules/Makefile:1.290 --- src/sys/modules/Makefile:1.289 Mon May 20 17:32:51 2024 +++ src/sys/modules/Makefile Mon May 20 18:14:38 2024 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.289 2024/05/20 17:32:51 pgoyette Exp $ +# $NetBSD: Makefile,v 1.290 2024/05/20 18:14:38 pgoyette Exp $ .include @@ -513,14 +513,6 @@ SUBDIR+= virtio_pci SUBDIR+= vioscsi .endif -# We need these four locally XXX-PRG -.if ${MACHINE_ARCH} == "x86_64" -SUBDIR+= ld -SUBDIR+= ld_nvme -SUBDIR+= nvme -SUBDIR+= ksem -.endif - SUBDIR+= examples # build these regularly to avoid bit-rot .endif Index: src/sys/modules/ffs/Makefile diff -u src/sys/modules/ffs/Makefile:1.24 src/sys/modules/ffs/Makefile:1.25 --- src/sys/modules/ffs/Makefile:1.24 Sat Jun 3 08:52:58 2023 +++ src/sys/modules/ffs/Makefile Mon May 20 18:14:38 2024 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.24 2023/06/03 08:52:58 lukem Exp $ +# $NetBSD: Makefile,v 1.25 2024/05/20 18:14:38 pgoyette Exp $ .include "../Makefile.inc" @@ -6,15 +6,21 @@ KMOD= ffs CPPFLAGS+= -DFFS_EI -DWAPBL -DAPPLE_UFS -DQUOTA -DQUOTA2 -CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -DUFS_DIRHASH +CPPFLAGS+= -DUFS_DIRHASH CWARNFLAGS.clang= -Wno-conversion COPTS.ffs_appleufs.c+= ${CC_WNO_ADDRESS_OF_PACKED_MEMBER} SRCS+= ffs_alloc.c ffs_balloc.c ffs_inode.c ffs_subr.c ffs_tables.c \ - ffs_vfsops.c ffs_vnops.c ffs_snapshot.c ffs_extattr.c \ + ffs_vfsops.c ffs_vnops.c ffs_snapshot.c \ ffs_bswap.c ffs_wapbl.c ffs_appleufs.c ffs_quota2.c +#CPPFLAGS+= -DUFS_EXTATTR +#SRCS+= ffs_extattr.c + +#CPPFLAGS+= -DUFS_ACL +#SRCS+= ufs_acl.c + WARNS= 3 .include Index: src/sys/modules/ufs/Makefile diff -u src/sys/modules/ufs/Makefile:1.8 src/sys/modules/ufs/Makefile:1.9 --- src/sys/modules/ufs/Makefile:1.8 Tue Aug 9 20:05:14 2022 +++ src/sys/modules/ufs/Makefile Mon May 20 18:14:38 2024 @@ -1,19 +1,25 @@ -# $NetBSD: Makefile,v 1.8 2022/08/09 20:05:14 pgoyette Exp $ +# $NetBSD: Makefile,v 1.9 2024/05/20 18:14:38 pgoyette Exp $ .include "../Makefile.inc" KMOD= ufs CPPFLAGS+= -DFFS_EI -DWAPBL -DAPPLE_UFS -DQUOTA -DQUOTA2 -CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -DUFS_DIRHASH +CPPFLAGS+= -DUFS_DIRHASH CWARNFLAGS.clang= -Wno-conversion .PATH: ${S}/ufs/ufs -SRCS+= ufs_acl.c ufs_bmap.c ufs_dirhash.c ufs_extattr.c ufs_inode.c \ +SRCS+= ufs_bmap.c ufs_dirhash.c ufs_inode.c \ ufs_lookup.c ufs_quota.c ufs_quota1.c ufs_quota2.c ufs_rename.c \ ufs_vfsops.c ufs_vnops.c quota1_subr.c quota2_subr.c +#CPPFLAGS+= -DUFS_ACL +#SRCS+= ufs_acl.c + +#CPPFLAGS+= -DUFS_EXTATTR +#SRCS+= ufs_extattr.c + WARNS= 3 .include
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Mon May 20 18:14:38 UTC 2024 Modified Files: src/sys/modules: Makefile src/sys/modules/ffs: Makefile src/sys/modules/ufs: Makefile Log Message: Oooppss remove some local change that was accidentally committed To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290 src/sys/modules/Makefile cvs rdiff -u -r1.24 -r1.25 src/sys/modules/ffs/Makefile cvs rdiff -u -r1.8 -r1.9 src/sys/modules/ufs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Mon May 20 17:32:51 UTC 2024 Modified Files: src/sys/modules: Makefile Log Message: Don't build the compat_110 module yet - there's no release_110 with which we can be compatable. To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289 src/sys/modules/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/modules/Makefile diff -u src/sys/modules/Makefile:1.288 src/sys/modules/Makefile:1.289 --- src/sys/modules/Makefile:1.288 Mon May 20 13:34:12 2024 +++ src/sys/modules/Makefile Mon May 20 17:32:51 2024 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.288 2024/05/20 13:34:12 riastradh Exp $ +# $NetBSD: Makefile,v 1.289 2024/05/20 17:32:51 pgoyette Exp $ .include @@ -322,7 +322,6 @@ SUBDIR+= compat_netbsd32_20 compat_netbs SUBDIR+= compat_netbsd32_40 compat_netbsd32_50 SUBDIR+= compat_netbsd32_60 compat_netbsd32_80 SUBDIR+= compat_netbsd32_90 compat_netbsd32_100 -SUBDIR+= compat_netbsd32_110 SUBDIR+= compat_netbsd32_43 SUBDIR+= compat_netbsd32_coredump SUBDIR+= compat_netbsd32_mqueue @@ -514,6 +513,14 @@ SUBDIR+= virtio_pci SUBDIR+= vioscsi .endif +# We need these four locally XXX-PRG +.if ${MACHINE_ARCH} == "x86_64" +SUBDIR+= ld +SUBDIR+= ld_nvme +SUBDIR+= nvme +SUBDIR+= ksem +.endif + SUBDIR+= examples # build these regularly to avoid bit-rot .endif
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Mon May 20 17:32:51 UTC 2024 Modified Files: src/sys/modules: Makefile Log Message: Don't build the compat_110 module yet - there's no release_110 with which we can be compatable. To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289 src/sys/modules/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev
Module Name:src Committed By: pgoyette Date: Fri Apr 12 05:04:02 UTC 2024 Modified Files: src/sys/dev: ccd.c Log Message: Repair handling of ccd sysctls to not use newp as an index. This is a work-around for kern/58051. It is not a complete fix. To generate a diff of this commit: cvs rdiff -u -r1.190 -r1.191 src/sys/dev/ccd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/ccd.c diff -u src/sys/dev/ccd.c:1.190 src/sys/dev/ccd.c:1.191 --- src/sys/dev/ccd.c:1.190 Sun Mar 31 14:56:41 2024 +++ src/sys/dev/ccd.c Fri Apr 12 05:04:02 2024 @@ -1,4 +1,4 @@ -/* $NetBSD: ccd.c,v 1.190 2024/03/31 14:56:41 hannken Exp $ */ +/* $NetBSD: ccd.c,v 1.191 2024/04/12 05:04:02 pgoyette Exp $ */ /*- * Copyright (c) 1996, 1997, 1998, 1999, 2007, 2009 The NetBSD Foundation, Inc. @@ -88,7 +88,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: ccd.c,v 1.190 2024/03/31 14:56:41 hannken Exp $"); +__KERNEL_RCSID(0, "$NetBSD: ccd.c,v 1.191 2024/04/12 05:04:02 pgoyette Exp $"); #include #include @@ -1774,13 +1774,14 @@ ccd_info_sysctl(SYSCTLFN_ARGS) struct sysctlnode node; struct ccddiskinfo ccd; struct ccd_softc *sc; - int unit; + int unit, error; if (newp == NULL || newlen != sizeof(int)) return EINVAL; - unit = *(const int *)newp; - newp = NULL; + error = sysctl_copyin(l, newp, , sizeof unit); + if (error) + return error; newlen = 0; ccd.ccd_ndisks = ~0; mutex_enter(_lock); @@ -1818,8 +1819,9 @@ ccd_components_sysctl(SYSCTLFN_ARGS) return EINVAL; size = 0; - unit = *(const int *)newp; - newp = NULL; + error = sysctl_copyin(l, newp, , sizeof unit); + if (error) + return error; newlen = 0; mutex_enter(_lock); LIST_FOREACH(sc, , sc_link)
CVS commit: src/sys/dev
Module Name:src Committed By: pgoyette Date: Fri Apr 12 05:04:02 UTC 2024 Modified Files: src/sys/dev: ccd.c Log Message: Repair handling of ccd sysctls to not use newp as an index. This is a work-around for kern/58051. It is not a complete fix. To generate a diff of this commit: cvs rdiff -u -r1.190 -r1.191 src/sys/dev/ccd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man4
Module Name:src Committed By: pgoyette Date: Thu Mar 14 15:19:03 UTC 2024 Modified Files: src/share/man/man4: ihidev.4 Log Message: Be a bit more clear about which devices are being handled. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/share/man/man4/ihidev.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/share/man/man4/ihidev.4 diff -u src/share/man/man4/ihidev.4:1.3 src/share/man/man4/ihidev.4:1.4 --- src/share/man/man4/ihidev.4:1.3 Sat Oct 5 06:28:50 2019 +++ src/share/man/man4/ihidev.4 Thu Mar 14 15:19:03 2024 @@ -1,4 +1,4 @@ -.\" $NetBSD: ihidev.4,v 1.3 2019/10/05 06:28:50 ryoon Exp $ +.\" $NetBSD: ihidev.4,v 1.4 2024/03/14 15:19:03 pgoyette Exp $ .\" .\" Copyright (c) 2001,2017 The NetBSD Foundation, Inc. .\" All rights reserved. @@ -39,7 +39,7 @@ .Sh DESCRIPTION The .Nm -driver handles all Human Interface Devices. +driver handles all Human Interface Devices attached via I2C bus. Each HID device can have several components, e.g., a keyboard and a mouse. These components use different report identifiers (a byte)
CVS commit: src/share/man/man4
Module Name:src Committed By: pgoyette Date: Thu Mar 14 15:19:03 UTC 2024 Modified Files: src/share/man/man4: ihidev.4 Log Message: Be a bit more clear about which devices are being handled. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/share/man/man4/ihidev.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: pgoyette Date: Sun Jan 7 00:38:18 UTC 2024 Modified Files: src/distrib/sets/lists/comp: mi src/share/man/man9: Makefile Log Message: Install securelevel.9 as an alias of secmodel_securelevel.9 According to submitter, this should be sufficient to address misc/57824. To generate a diff of this commit: cvs rdiff -u -r1.2451 -r1.2452 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.468 -r1.469 src/share/man/man9/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/comp/mi diff -u src/distrib/sets/lists/comp/mi:1.2451 src/distrib/sets/lists/comp/mi:1.2452 --- src/distrib/sets/lists/comp/mi:1.2451 Sat Dec 2 21:02:12 2023 +++ src/distrib/sets/lists/comp/mi Sun Jan 7 00:38:18 2024 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.2451 2023/12/02 21:02:12 thorpej Exp $ +# $NetBSD: mi,v 1.2452 2024/01/07 00:38:18 pgoyette Exp $ # # Note: don't delete entries from here - mark them as "obsolete" instead. ./etc/mtree/set.compcomp-sys-root @@ -12729,6 +12729,7 @@ ./usr/share/man/cat9/secmodel_register.0 comp-sys-catman .cat ./usr/share/man/cat9/secmodel_securelevel.0 comp-sys-catman .cat ./usr/share/man/cat9/secmodel_suser.0 comp-sys-catman .cat +./usr/share/man/cat9/securelevel.0 comp-sys-catman .cat ./usr/share/man/cat9/seldestroy.0 comp-sys-catman .cat ./usr/share/man/cat9/select.0 comp-sys-catman .cat ./usr/share/man/cat9/selinit.0 comp-sys-catman .cat @@ -21093,6 +21094,7 @@ ./usr/share/man/html9/secmodel_register.html comp-sys-htmlman html ./usr/share/man/html9/secmodel_securelevel.html comp-sys-htmlman html ./usr/share/man/html9/secmodel_suser.html comp-sys-htmlman html +./usr/share/man/html9/securelevel.html comp-sys-htmlman html ./usr/share/man/html9/seldestroy.html comp-sys-htmlman html ./usr/share/man/html9/select.html comp-sys-htmlman html ./usr/share/man/html9/selinit.html comp-sys-htmlman html @@ -29646,6 +29648,7 @@ ./usr/share/man/man9/secmodel_register.9 comp-sys-man .man ./usr/share/man/man9/secmodel_securelevel.9 comp-sys-man .man ./usr/share/man/man9/secmodel_suser.9 comp-sys-man .man +./usr/share/man/man9/securelevel.9 comp-sys-man .man ./usr/share/man/man9/seldestroy.9 comp-sys-man .man ./usr/share/man/man9/select.9 comp-sys-man .man ./usr/share/man/man9/selinit.9 comp-sys-man .man Index: src/share/man/man9/Makefile diff -u src/share/man/man9/Makefile:1.468 src/share/man/man9/Makefile:1.469 --- src/share/man/man9/Makefile:1.468 Sat Dec 2 21:02:12 2023 +++ src/share/man/man9/Makefile Sun Jan 7 00:38:18 2024 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.468 2023/12/02 21:02:12 thorpej Exp $ +# $NetBSD: Makefile,v 1.469 2024/01/07 00:38:18 pgoyette Exp $ # Makefile for section 9 (kernel function and variable) manual pages. @@ -51,7 +51,10 @@ MAN= accept_filter.9 accf_data.9 accf_ht scanc.9 \ sched_4bsd.9 sched_m2.9 scsipi.9 \ secmodel_bsd44.9 secmodel_extensions.9 \ - secmodel_overlay.9 secmodel_securelevel.9 secmodel_suser.9 \ + secmodel_overlay.9 +MAN+= secmodel_securelevel.9 +MLINKS+=secmodel_securelevel.9 securelevel.9 +MAN+= secmodel_suser.9 \ SET.9 setbit.9 setjmp.9 shutdownhook_establish.9 \ signal.9 skpc.9 sockopt.9 softintr.9 spl.9 specificdata.9 \ spi.9 splraiseipl.9 \
CVS commit: src
Module Name:src Committed By: pgoyette Date: Sun Jan 7 00:38:18 UTC 2024 Modified Files: src/distrib/sets/lists/comp: mi src/share/man/man9: Makefile Log Message: Install securelevel.9 as an alias of secmodel_securelevel.9 According to submitter, this should be sufficient to address misc/57824. To generate a diff of this commit: cvs rdiff -u -r1.2451 -r1.2452 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.468 -r1.469 src/share/man/man9/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: pgoyette Date: Tue Dec 26 16:20:02 UTC 2023 Modified Files: src/distrib/sets/lists/debug: module.md.i386 src/distrib/sets/lists/modules: md.i386 src/sys/modules: Makefile Log Message: Unhook radeondrm module from the build; it doesn't work, and it's just tempting someone to try it. Leave the files around in case someone wants to pursue making this work. Should address kern/57793 XXX Related modules from the same legacy era should probably be XXX removed, too, but so far only radeondrm has been reported XXX as an issue. Kep an eye out for sisdrm, savagedrm, tdfxdrm, XXX and r128drm. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/distrib/sets/lists/debug/module.md.i386 cvs rdiff -u -r1.96 -r1.97 src/distrib/sets/lists/modules/md.i386 cvs rdiff -u -r1.280 -r1.281 src/sys/modules/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/module.md.i386 diff -u src/distrib/sets/lists/debug/module.md.i386:1.7 src/distrib/sets/lists/debug/module.md.i386:1.8 --- src/distrib/sets/lists/debug/module.md.i386:1.7 Thu Jul 28 22:00:23 2022 +++ src/distrib/sets/lists/debug/module.md.i386 Tue Dec 26 16:20:01 2023 @@ -1,4 +1,4 @@ -# $NetBSD: module.md.i386,v 1.7 2022/07/28 22:00:23 riastradh Exp $ +# $NetBSD: module.md.i386,v 1.8 2023/12/26 16:20:01 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/acpiacadmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpiacad/acpiacad.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpibatmodules-base-kernel kmod,debug @@ -149,8 +149,8 @@ ./usr/libdata/debug/@MODULEDIR@/pwdog/pwdog.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/r128drmmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/r128drm/r128drm.kmod.debug modules-base-kernel kmod,debug -./usr/libdata/debug/@MODULEDIR@/radeondrmmodules-base-kernel kmod,debug -./usr/libdata/debug/@MODULEDIR@/radeondrm/radeondrm.kmod.debug modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/radeondrmbase-obsolete obsolete +./usr/libdata/debug/@MODULEDIR@/radeondrm/radeondrm.kmod.debug base-obsolete obsolete ./usr/libdata/debug/@MODULEDIR@/savagedrmmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/savagedrm/savagedrm.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/sisdrmmodules-base-kernel kmod,debug Index: src/distrib/sets/lists/modules/md.i386 diff -u src/distrib/sets/lists/modules/md.i386:1.96 src/distrib/sets/lists/modules/md.i386:1.97 --- src/distrib/sets/lists/modules/md.i386:1.96 Wed Sep 7 11:37:25 2022 +++ src/distrib/sets/lists/modules/md.i386 Tue Dec 26 16:20:01 2023 @@ -1,4 +1,4 @@ -# $NetBSD: md.i386,v 1.96 2022/09/07 11:37:25 martin Exp $ +# $NetBSD: md.i386,v 1.97 2023/12/26 16:20:01 pgoyette Exp $ # ./@MODULEDIR@/acpiacadmodules-base-kernel kmod ./@MODULEDIR@/acpiacad/acpiacad.kmod modules-base-kernel kmod @@ -166,8 +166,8 @@ ./@MODULEDIR@/pwdog/pwdog.kmod modules-base-kernel kmod ./@MODULEDIR@/r128drmmodules-base-kernel kmod ./@MODULEDIR@/r128drm/r128drm.kmod modules-base-kernel kmod -./@MODULEDIR@/radeondrmmodules-base-kernel kmod -./@MODULEDIR@/radeondrm/radeondrm.kmod modules-base-kernel kmod +./@MODULEDIR@/radeondrmbase-obsolete obsolete +./@MODULEDIR@/radeondrm/radeondrm.kmod base-obsolete obsolete ./@MODULEDIR@/savagedrmmodules-base-kernel kmod ./@MODULEDIR@/savagedrm/savagedrm.kmod modules-base-kernel kmod ./@MODULEDIR@/sisdrmmodules-base-kernel kmod Index: src/sys/modules/Makefile diff -u src/sys/modules/Makefile:1.280 src/sys/modules/Makefile:1.281 --- src/sys/modules/Makefile:1.280 Sun Aug 27 13:20:09 2023 +++ src/sys/modules/Makefile Tue Dec 26 16:20:01 2023 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.280 2023/08/27 13:20:09 kardel Exp $ +# $NetBSD: Makefile,v 1.281 2023/12/26 16:20:01 pgoyette Exp $ .include @@ -343,7 +343,7 @@ SUBDIR+= mgadrm SUBDIR+= nsclpcsio SUBDIR+= padlock SUBDIR+= r128drm -SUBDIR+= radeondrm +#SUBDIR+= radeondrm SUBDIR+= savagedrm SUBDIR+= sisdrm SUBDIR+= tdfxdrm
CVS commit: src
Module Name:src Committed By: pgoyette Date: Tue Dec 26 16:20:02 UTC 2023 Modified Files: src/distrib/sets/lists/debug: module.md.i386 src/distrib/sets/lists/modules: md.i386 src/sys/modules: Makefile Log Message: Unhook radeondrm module from the build; it doesn't work, and it's just tempting someone to try it. Leave the files around in case someone wants to pursue making this work. Should address kern/57793 XXX Related modules from the same legacy era should probably be XXX removed, too, but so far only radeondrm has been reported XXX as an issue. Kep an eye out for sisdrm, savagedrm, tdfxdrm, XXX and r128drm. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/distrib/sets/lists/debug/module.md.i386 cvs rdiff -u -r1.96 -r1.97 src/distrib/sets/lists/modules/md.i386 cvs rdiff -u -r1.280 -r1.281 src/sys/modules/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules/compat_90
Module Name:src Committed By: pgoyette Date: Sun Dec 10 00:29:25 UTC 2023 Modified Files: src/sys/modules/compat_90: Makefile Log Message: Default the build of compat_90 module to include IPv6, as is done for other INET6-sensitive modules (see if_lagg). XXX Pullup to -10 (will add to existing ticket) To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/modules/compat_90/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/modules/compat_90/Makefile diff -u src/sys/modules/compat_90/Makefile:1.2 src/sys/modules/compat_90/Makefile:1.3 --- src/sys/modules/compat_90/Makefile:1.2 Sat Dec 9 15:21:01 2023 +++ src/sys/modules/compat_90/Makefile Sun Dec 10 00:29:24 2023 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.2 2023/12/09 15:21:01 pgoyette Exp $ +# $NetBSD: Makefile,v 1.3 2023/12/10 00:29:24 pgoyette Exp $ .include "../Makefile.inc" @@ -7,6 +7,12 @@ KMOD= compat_90 CPPFLAGS+= -DCOMPAT_90 +CPPFLAGS+= -DINET + +# Remove/comment the following if the target kernel on which the +# module may be loaded doesn't have IPv6. Enable this by default. + +CPPFLAGS+= -DINET6 SRCS+= compat_90_mod.c SRCS+= net_inet6_nd_90.c
CVS commit: src/sys/modules/compat_90
Module Name:src Committed By: pgoyette Date: Sun Dec 10 00:29:25 UTC 2023 Modified Files: src/sys/modules/compat_90: Makefile Log Message: Default the build of compat_90 module to include IPv6, as is done for other INET6-sensitive modules (see if_lagg). XXX Pullup to -10 (will add to existing ticket) To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/modules/compat_90/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
Module Name:src Committed By: pgoyette Date: Sat Dec 9 15:21:02 UTC 2023 Modified Files: src/sys/compat/common: compat_90_mod.c compat_mod.h files.common src/sys/kern: compat_stub.c src/sys/modules/compat_90: Makefile src/sys/netinet6: icmp6.c in6.c nd6.c src/sys/sys: compat_stub.h Added Files: src/sys/compat/common: net_inet6_nd_90.c Log Message: Modularize the COMPAT_90 code that resulted from the removal of netinet6/nd6 from the kernel. Now, the minimal compat code can be successfully loaded and unloaded along with the rest of the COMPAT_90 code. XXX pullup-10 - hopefully before RC2 To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/compat/common/compat_90_mod.c cvs rdiff -u -r1.9 -r1.10 src/sys/compat/common/compat_mod.h cvs rdiff -u -r1.10 -r1.11 src/sys/compat/common/files.common cvs rdiff -u -r0 -r1.1 src/sys/compat/common/net_inet6_nd_90.c cvs rdiff -u -r1.22 -r1.23 src/sys/kern/compat_stub.c cvs rdiff -u -r1.1 -r1.2 src/sys/modules/compat_90/Makefile cvs rdiff -u -r1.254 -r1.255 src/sys/netinet6/icmp6.c cvs rdiff -u -r1.290 -r1.291 src/sys/netinet6/in6.c cvs rdiff -u -r1.280 -r1.281 src/sys/netinet6/nd6.c cvs rdiff -u -r1.26 -r1.27 src/sys/sys/compat_stub.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/compat/common/compat_90_mod.c diff -u src/sys/compat/common/compat_90_mod.c:1.4 src/sys/compat/common/compat_90_mod.c:1.5 --- src/sys/compat/common/compat_90_mod.c:1.4 Mon Dec 19 23:19:51 2022 +++ src/sys/compat/common/compat_90_mod.c Sat Dec 9 15:21:01 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: compat_90_mod.c,v 1.4 2022/12/19 23:19:51 pgoyette Exp $ */ +/* $NetBSD: compat_90_mod.c,v 1.5 2023/12/09 15:21:01 pgoyette Exp $ */ /*- * Copyright (c) 2019 The NetBSD Foundation, Inc. @@ -38,7 +38,7 @@ #endif #include -__KERNEL_RCSID(0, "$NetBSD: compat_90_mod.c,v 1.4 2022/12/19 23:19:51 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: compat_90_mod.c,v 1.5 2023/12/09 15:21:01 pgoyette Exp $"); #include #include @@ -50,14 +50,21 @@ int compat_90_init(void) { + net_inet6_nd_90_init(); return vfs_syscalls_90_init(); } int compat_90_fini(void) { + int error; - return vfs_syscalls_90_fini(); + error = vfs_syscalls_90_fini(); + if (error != 0) + return error; + + net_inet6_nd_90_fini(); + return error; } MODULE(MODULE_CLASS_EXEC, compat_90, "compat_100"); Index: src/sys/compat/common/compat_mod.h diff -u src/sys/compat/common/compat_mod.h:1.9 src/sys/compat/common/compat_mod.h:1.10 --- src/sys/compat/common/compat_mod.h:1.9 Fri Aug 18 19:41:18 2023 +++ src/sys/compat/common/compat_mod.h Sat Dec 9 15:21:01 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: compat_mod.h,v 1.9 2023/08/18 19:41:18 christos Exp $ */ +/* $NetBSD: compat_mod.h,v 1.10 2023/12/09 15:21:01 pgoyette Exp $ */ /*- * Copyright (c) 2013, 2019 The NetBSD Foundation, Inc. @@ -46,6 +46,8 @@ int compat_90_init(void); int compat_90_fini(void); int vfs_syscalls_90_init(void); int vfs_syscalls_90_fini(void); +int net_inet6_nd_90_init(void); +int net_inet6_nd_90_fini(void); #endif #ifdef COMPAT_80 Index: src/sys/compat/common/files.common diff -u src/sys/compat/common/files.common:1.10 src/sys/compat/common/files.common:1.11 --- src/sys/compat/common/files.common:1.10 Fri Aug 18 19:41:18 2023 +++ src/sys/compat/common/files.common Sat Dec 9 15:21:01 2023 @@ -1,4 +1,4 @@ -# $NetBSD: files.common,v 1.10 2023/08/18 19:41:18 christos Exp $ +# $NetBSD: files.common,v 1.11 2023/12/09 15:21:01 pgoyette Exp $ # # Generic utility files, used by various compat options. @@ -109,6 +109,7 @@ file compat/common/if_media_80.c compat # Compatibility code for NetBSD 9.0 file compat/common/compat_90_mod.c compat_90 file compat/common/vfs_syscalls_90.c compat_90 +file compat/common/net_inet6_nd_90.c compat_90 # Compatibility code for NetBSD 10.0 file compat/common/compat_100_mod.c compat_100 Index: src/sys/kern/compat_stub.c diff -u src/sys/kern/compat_stub.c:1.22 src/sys/kern/compat_stub.c:1.23 --- src/sys/kern/compat_stub.c:1.22 Mon Aug 9 20:49:10 2021 +++ src/sys/kern/compat_stub.c Sat Dec 9 15:21:01 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: compat_stub.c,v 1.22 2021/08/09 20:49:10 andvar Exp $ */ +/* $NetBSD: compat_stub.c,v 1.23 2023/12/09 15:21:01 pgoyette Exp $ */ /*- * Copyright (c) 2018 The NetBSD Foundation, Inc. @@ -286,4 +286,8 @@ struct coredump_elf64_hook_t coredump_el struct uvm_coredump_walkmap_hook_t uvm_coredump_walkmap_hook; struct uvm_coredump_count_segs_hook_t uvm_coredump_count_segs_hook; +/* + * Hooks for interacting with remnants of netinet6/nd6 removal + */ +struct net_inet6_nd_90_hook_t net_inet6_nd_90_hook; Index: src/sys/modules/compat_90/Makefile diff -u src/sys/modules/compat_90/Makefile:1.1 src/sys/modules/compat_90/Makefile:1.2 --- src/sys/modules/compat_90/Makefile:1.1 Sun Sep 22 22:59:39 2019 +++
CVS commit: src/sys
Module Name:src Committed By: pgoyette Date: Sat Dec 9 15:21:02 UTC 2023 Modified Files: src/sys/compat/common: compat_90_mod.c compat_mod.h files.common src/sys/kern: compat_stub.c src/sys/modules/compat_90: Makefile src/sys/netinet6: icmp6.c in6.c nd6.c src/sys/sys: compat_stub.h Added Files: src/sys/compat/common: net_inet6_nd_90.c Log Message: Modularize the COMPAT_90 code that resulted from the removal of netinet6/nd6 from the kernel. Now, the minimal compat code can be successfully loaded and unloaded along with the rest of the COMPAT_90 code. XXX pullup-10 - hopefully before RC2 To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/compat/common/compat_90_mod.c cvs rdiff -u -r1.9 -r1.10 src/sys/compat/common/compat_mod.h cvs rdiff -u -r1.10 -r1.11 src/sys/compat/common/files.common cvs rdiff -u -r0 -r1.1 src/sys/compat/common/net_inet6_nd_90.c cvs rdiff -u -r1.22 -r1.23 src/sys/kern/compat_stub.c cvs rdiff -u -r1.1 -r1.2 src/sys/modules/compat_90/Makefile cvs rdiff -u -r1.254 -r1.255 src/sys/netinet6/icmp6.c cvs rdiff -u -r1.290 -r1.291 src/sys/netinet6/in6.c cvs rdiff -u -r1.280 -r1.281 src/sys/netinet6/nd6.c cvs rdiff -u -r1.26 -r1.27 src/sys/sys/compat_stub.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/netinet6
Module Name:src Committed By: pgoyette Date: Thu Dec 7 16:47:44 UTC 2023 Modified Files: src/sys/netinet6: in6.c Log Message: Identify the need to rework the COMPAT_* code to be more module-aware. This is an XXX comment block only, NFCI. To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290 src/sys/netinet6/in6.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/netinet6/in6.c diff -u src/sys/netinet6/in6.c:1.289 src/sys/netinet6/in6.c:1.290 --- src/sys/netinet6/in6.c:1.289 Thu Aug 3 05:44:22 2023 +++ src/sys/netinet6/in6.c Thu Dec 7 16:47:44 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: in6.c,v 1.289 2023/08/03 05:44:22 ozaki-r Exp $ */ +/* $NetBSD: in6.c,v 1.290 2023/12/07 16:47:44 pgoyette Exp $ */ /* $KAME: in6.c,v 1.198 2001/07/18 09:12:38 itojun Exp $ */ /* @@ -62,7 +62,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: in6.c,v 1.289 2023/08/03 05:44:22 ozaki-r Exp $"); +__KERNEL_RCSID(0, "$NetBSD: in6.c,v 1.290 2023/12/07 16:47:44 pgoyette Exp $"); #ifdef _KERNEL_OPT #include "opt_inet.h" @@ -105,6 +105,17 @@ __KERNEL_RCSID(0, "$NetBSD: in6.c,v 1.28 #include #include +/* XXX + * + * The COMPAT_* code here, along with call-sites in nd6.c and + * icmp6.c, needs to be reworked to use compat hooks. As it + * stands right now, the compat code only gets built if it is + * iincluded in the kernel at build time; building and loading + * compat_* modules will not include this compat code! + * + * XXX + */ + #ifdef COMPAT_50 #include #endif
CVS commit: src/sys/netinet6
Module Name:src Committed By: pgoyette Date: Thu Dec 7 16:47:44 UTC 2023 Modified Files: src/sys/netinet6: in6.c Log Message: Identify the need to rework the COMPAT_* code to be more module-aware. This is an XXX comment block only, NFCI. To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290 src/sys/netinet6/in6.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/kern
Module Name:src Committed By: pgoyette Date: Thu Dec 7 09:00:32 UTC 2023 Modified Files: src/sys/kern: tty.c Log Message: There's no COMPAT_60 code left here, so no need for conditional inclusion of header file. To generate a diff of this commit: cvs rdiff -u -r1.311 -r1.312 src/sys/kern/tty.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/kern/tty.c diff -u src/sys/kern/tty.c:1.311 src/sys/kern/tty.c:1.312 --- src/sys/kern/tty.c:1.311 Mon May 22 14:07:37 2023 +++ src/sys/kern/tty.c Thu Dec 7 09:00:32 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: tty.c,v 1.311 2023/05/22 14:07:37 riastradh Exp $ */ +/* $NetBSD: tty.c,v 1.312 2023/12/07 09:00:32 pgoyette Exp $ */ /*- * Copyright (c) 2008, 2020 The NetBSD Foundation, Inc. @@ -63,7 +63,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: tty.c,v 1.311 2023/05/22 14:07:37 riastradh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: tty.c,v 1.312 2023/12/07 09:00:32 pgoyette Exp $"); #ifdef _KERNEL_OPT #include "opt_compat_netbsd.h" @@ -103,10 +103,6 @@ __KERNEL_RCSID(0, "$NetBSD: tty.c,v 1.31 #include #include -#ifdef COMPAT_60 -#include -#endif /* COMPAT_60 */ - static int ttnread(struct tty *); static void ttyblock(struct tty *); static void ttyecho(int, struct tty *);
CVS commit: src/sys/kern
Module Name:src Committed By: pgoyette Date: Thu Dec 7 09:00:32 UTC 2023 Modified Files: src/sys/kern: tty.c Log Message: There's no COMPAT_60 code left here, so no need for conditional inclusion of header file. To generate a diff of this commit: cvs rdiff -u -r1.311 -r1.312 src/sys/kern/tty.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/comp
Module Name:src Committed By: pgoyette Date: Thu Aug 10 04:55:13 UTC 2023 Modified Files: src/distrib/sets/lists/comp: mi Log Message: at suggestion from phone@ (via irc/icb) make this file depend on any version of gdb, not just gdb=1100 XXX I really don't know what I'm doing here, so if anyone has a XXX better idea, go for it. To generate a diff of this commit: cvs rdiff -u -r1.2445 -r1.2446 src/distrib/sets/lists/comp/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/comp/mi diff -u src/distrib/sets/lists/comp/mi:1.2445 src/distrib/sets/lists/comp/mi:1.2446 --- src/distrib/sets/lists/comp/mi:1.2445 Sat Aug 5 08:15:40 2023 +++ src/distrib/sets/lists/comp/mi Thu Aug 10 04:55:13 2023 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.2445 2023/08/05 08:15:40 riastradh Exp $ +# $NetBSD: mi,v 1.2446 2023/08/10 04:55:13 pgoyette Exp $ # # Note: don't delete entries from here - mark them as "obsolete" instead. ./etc/mtree/set.compcomp-sys-root @@ -4542,7 +4542,7 @@ ./usr/sbin/gspahextoccomp-obsolete obsolete ./usr/sbin/kgmoncomp-debug-sbin ./usr/share/examples/openssl/CA.sh comp-obsolete obsolete -./usr/share/gdb/syscalls/netbsd.xml comp-debug-bin gdb=1100 +./usr/share/gdb/syscalls/netbsd.xml comp-debug-bin gdb ./usr/share/ldscripts/elf32_sparc.x comp-obsolete obsolete ./usr/share/ldscripts/elf32_sparc.xbn comp-obsolete obsolete ./usr/share/ldscripts/elf32_sparc.xn comp-obsolete obsolete
CVS commit: src/distrib/sets/lists/comp
Module Name:src Committed By: pgoyette Date: Thu Aug 10 04:55:13 UTC 2023 Modified Files: src/distrib/sets/lists/comp: mi Log Message: at suggestion from phone@ (via irc/icb) make this file depend on any version of gdb, not just gdb=1100 XXX I really don't know what I'm doing here, so if anyone has a XXX better idea, go for it. To generate a diff of this commit: cvs rdiff -u -r1.2445 -r1.2446 src/distrib/sets/lists/comp/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Sat Aug 5 03:13:57 UTC 2023 Modified Files: src/distrib/sets/lists/debug: ad.aarch64 md.amd64 Log Message: revert debug data for libtsan to previous version, too. XXX Perhaps this should be done by obsoleting the 2.0 file? For now XXX this will require manual cleaning of the no-longer-used 2.0 file. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/distrib/sets/lists/debug/ad.aarch64 cvs rdiff -u -r1.117 -r1.118 src/distrib/sets/lists/debug/md.amd64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/ad.aarch64 diff -u src/distrib/sets/lists/debug/ad.aarch64:1.34 src/distrib/sets/lists/debug/ad.aarch64:1.35 --- src/distrib/sets/lists/debug/ad.aarch64:1.34 Fri Aug 4 08:54:00 2023 +++ src/distrib/sets/lists/debug/ad.aarch64 Sat Aug 5 03:13:57 2023 @@ -1,4 +1,4 @@ -# $NetBSD: ad.aarch64,v 1.34 2023/08/04 08:54:00 mrg Exp $ +# $NetBSD: ad.aarch64,v 1.35 2023/08/05 03:13:57 pgoyette Exp $ ./usr/lib/eabi/libarm_g.a comp-sys-debug debuglib,compat,llvm ./usr/lib/eabi/libc_vfp_g.a comp-sys-debug debuglib,compat,llvm ./usr/lib/eabihf/libarm_g.a comp-sys-debug debuglib,compat,llvm @@ -20,7 +20,7 @@ ./usr/libdata/debug/usr/lib/eabi/libc_vfp.so.0.0.debug comp-sys-debug debug,compat,pic,llvm ./usr/libdata/debug/usr/lib/eabi/libproc.so.1.0.debug comp-sys-debug debug,compat,pic,llvm,dtrace ./usr/libdata/debug/usr/lib/eabi/librtld_db.so.0.0.debug comp-sys-debug debug,compat,pic,llvm,dtrace -./usr/libdata/debug/usr/lib/libtsan.so.2.0.debug comp-sys-debug debug,cxx,gcc=12 +./usr/libdata/debug/usr/lib/libtsan.so.1.0.debug comp-sys-debug debug,cxx,gcc=12 ./usr/libdata/debug/usr/lib/eabihfcomp-sys-debug compat,llvm ./usr/libdata/debug/usr/lib/eabihf/i18ncomp-sys-debug compat,llvm ./usr/libdata/debug/usr/lib/eabihf/libarm.so.0.0.debug comp-sys-debug debug,compat,pic,llvm Index: src/distrib/sets/lists/debug/md.amd64 diff -u src/distrib/sets/lists/debug/md.amd64:1.117 src/distrib/sets/lists/debug/md.amd64:1.118 --- src/distrib/sets/lists/debug/md.amd64:1.117 Fri Aug 4 08:54:00 2023 +++ src/distrib/sets/lists/debug/md.amd64 Sat Aug 5 03:13:57 2023 @@ -1,4 +1,4 @@ -# $NetBSD: md.amd64,v 1.117 2023/08/04 08:54:00 mrg Exp $ +# $NetBSD: md.amd64,v 1.118 2023/08/05 03:13:57 pgoyette Exp $ ./usr/libdata/debug/usr/bin/gdbserver.debug base-util-debug gdb,debug ./usr/lib/i386/12.202++_g.a comp-c-debuglib debuglib,compat,12.202xx ./usr/lib/i386/libi386_g.a comp-c-debuglib debuglib,compat @@ -12,7 +12,7 @@ ./usr/libdata/debug/usr/lib/i386/libpam.so.4.1.debug comp-compat-shlib compat,pic,debug,pam ./usr/libdata/debug/usr/lib/i386/libproc.so.1.0.debug comp-compat-shlib compat,pic,debug,dtrace ./usr/libdata/debug/usr/lib/i386/librtld_db.so.0.0.debug comp-compat-shlib compat,pic,debug,dtrace -./usr/libdata/debug/usr/lib/libtsan.so.2.0.debug comp-sys-debug debug,cxx,gcc +./usr/libdata/debug/usr/lib/libtsan.so.1.0.debug comp-sys-debug debug,cxx,gcc ./usr/libdata/debug/usr/lib/libx86_64.so.0.0.debug comp-sys-shlib pic,debug ./usr/libdata/debug/usr/libexec/ld.elf_so-i386 comp-obsolete obsolete ./usr/libdata/debug/usr/libexec/ld.elf_so-i386.debug comp-sys-debug debug,compat
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Sat Aug 5 03:13:57 UTC 2023 Modified Files: src/distrib/sets/lists/debug: ad.aarch64 md.amd64 Log Message: revert debug data for libtsan to previous version, too. XXX Perhaps this should be done by obsoleting the 2.0 file? For now XXX this will require manual cleaning of the no-longer-used 2.0 file. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/distrib/sets/lists/debug/ad.aarch64 cvs rdiff -u -r1.117 -r1.118 src/distrib/sets/lists/debug/md.amd64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/compat/netbsd32
Module Name:src Committed By: pgoyette Date: Sat Jul 29 13:57:28 UTC 2023 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_80.c netbsd32_compat_90.c Log Message: Don't skip compat_netbsd32_90 in the dependency chain. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/compat/netbsd32/netbsd32_compat_80.c cvs rdiff -u -r1.1 -r1.2 src/sys/compat/netbsd32/netbsd32_compat_90.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/compat/netbsd32/netbsd32_compat_80.c diff -u src/sys/compat/netbsd32/netbsd32_compat_80.c:1.7 src/sys/compat/netbsd32/netbsd32_compat_80.c:1.8 --- src/sys/compat/netbsd32/netbsd32_compat_80.c:1.7 Sat Jul 29 13:40:51 2023 +++ src/sys/compat/netbsd32/netbsd32_compat_80.c Sat Jul 29 13:57:28 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: netbsd32_compat_80.c,v 1.7 2023/07/29 13:40:51 rin Exp $ */ +/* $NetBSD: netbsd32_compat_80.c,v 1.8 2023/07/29 13:57:28 pgoyette Exp $ */ /*- * Copyright (c) 2008 The NetBSD Foundation, Inc. @@ -29,7 +29,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: netbsd32_compat_80.c,v 1.7 2023/07/29 13:40:51 rin Exp $"); +__KERNEL_RCSID(0, "$NetBSD: netbsd32_compat_80.c,v 1.8 2023/07/29 13:57:28 pgoyette Exp $"); #include #include @@ -175,7 +175,7 @@ netbsd32_80_modctl(struct lwp *lwp, cons return error; } -MODULE(MODULE_CLASS_EXEC, compat_netbsd32_80, "compat_netbsd32_100,compat_80"); +MODULE(MODULE_CLASS_EXEC, compat_netbsd32_80, "compat_netbsd32_90,compat_80"); static int compat_netbsd32_80_modcmd(modcmd_t cmd, void *arg) Index: src/sys/compat/netbsd32/netbsd32_compat_90.c diff -u src/sys/compat/netbsd32/netbsd32_compat_90.c:1.1 src/sys/compat/netbsd32/netbsd32_compat_90.c:1.2 --- src/sys/compat/netbsd32/netbsd32_compat_90.c:1.1 Sun Sep 22 22:59:38 2019 +++ src/sys/compat/netbsd32/netbsd32_compat_90.c Sat Jul 29 13:57:28 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: netbsd32_compat_90.c,v 1.1 2019/09/22 22:59:38 christos Exp $ */ +/* $NetBSD: netbsd32_compat_90.c,v 1.2 2023/07/29 13:57:28 pgoyette Exp $ */ /*- * Copyright (c) 2019 The NetBSD Foundation, Inc. @@ -30,7 +30,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: netbsd32_compat_90.c,v 1.1 2019/09/22 22:59:38 christos Exp $"); +__KERNEL_RCSID(0, "$NetBSD: netbsd32_compat_90.c,v 1.2 2023/07/29 13:57:28 pgoyette Exp $"); #include #include @@ -152,7 +152,8 @@ static struct syscall_package compat_net { 0, 0, NULL } }; -MODULE(MODULE_CLASS_EXEC, compat_netbsd32_90, "compat_netbsd32,compat_90"); +MODULE(MODULE_CLASS_EXEC, compat_netbsd32_90, "compat_netbsd32_100,compat_90"); + static int compat_netbsd32_90_modcmd(modcmd_t cmd, void *arg)
CVS commit: src/sys/compat/netbsd32
Module Name:src Committed By: pgoyette Date: Sat Jul 29 13:57:28 UTC 2023 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_80.c netbsd32_compat_90.c Log Message: Don't skip compat_netbsd32_90 in the dependency chain. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/compat/netbsd32/netbsd32_compat_80.c cvs rdiff -u -r1.1 -r1.2 src/sys/compat/netbsd32/netbsd32_compat_90.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/kern
Module Name:src Committed By: pgoyette Date: Sat Jul 29 04:06:32 UTC 2023 Modified Files: src/sys/kern: sys_epoll.c Log Message: remove extra `_' to fix debug build To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/sys/kern/sys_epoll.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/kern/sys_epoll.c diff -u src/sys/kern/sys_epoll.c:1.1 src/sys/kern/sys_epoll.c:1.2 --- src/sys/kern/sys_epoll.c:1.1 Fri Jul 28 18:19:01 2023 +++ src/sys/kern/sys_epoll.c Sat Jul 29 04:06:32 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: sys_epoll.c,v 1.1 2023/07/28 18:19:01 christos Exp $ */ +/* $NetBSD: sys_epoll.c,v 1.2 2023/07/29 04:06:32 pgoyette Exp $ */ /*- * SPDX-License-Identifier: BSD-2-Clause @@ -28,7 +28,7 @@ * SUCH DAMAGE. */ #include -__KERNEL_RCSID(0, "$NetBSD: sys_epoll.c,v 1.1 2023/07/28 18:19:01 christos Exp $"); +__KERNEL_RCSID(0, "$NetBSD: sys_epoll.c,v 1.2 2023/07/29 04:06:32 pgoyette Exp $"); #include @@ -325,7 +325,7 @@ epoll_ctl_common(struct lwp *l, register return epoll_delete_all_events(retval, epfd, fd); default: - DPRINTF(("%s: invalid op %d\n", ___func__, op)); + DPRINTF(("%s: invalid op %d\n", __func__, op)); return EINVAL; }
CVS commit: src/sys/kern
Module Name:src Committed By: pgoyette Date: Sat Jul 29 04:06:32 UTC 2023 Modified Files: src/sys/kern: sys_epoll.c Log Message: remove extra `_' to fix debug build To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/sys/kern/sys_epoll.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Wed Jun 21 02:48:49 UTC 2023 Modified Files: src/distrib/sets/lists/debug: mi Log Message: Looks like this debug library disappeared with the new heimdal. Mark it obsolete to fix the MKDEBUGLIB build. To generate a diff of this commit: cvs rdiff -u -r1.404 -r1.405 src/distrib/sets/lists/debug/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/mi diff -u src/distrib/sets/lists/debug/mi:1.404 src/distrib/sets/lists/debug/mi:1.405 --- src/distrib/sets/lists/debug/mi:1.404 Fri Jun 16 20:38:19 2023 +++ src/distrib/sets/lists/debug/mi Wed Jun 21 02:48:49 2023 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.404 2023/06/16 20:38:19 wiz Exp $ +# $NetBSD: mi,v 1.405 2023/06/21 02:48:49 pgoyette Exp $ ./etc/mtree/set.debug comp-sys-root ./usr/lib comp-sys-usr compatdir ./usr/lib/i18n/libBIG5_g.a comp-c-debuglib debuglib,compatfile @@ -277,7 +277,7 @@ ./usr/lib/libutil_g.acomp-c-debuglib debuglib,compatfile ./usr/lib/libuutil_g.acomp-c-debuglib debuglib,compatfile,zfs ./usr/lib/libuv_g.acomp-obsolete obsolete,compatfile -./usr/lib/libvers_g.acomp-c-debuglib debuglib,compatfile,kerberos +./usr/lib/libvers_g.acomp-obsolete debuglib,compatfile,kerberos,obsolete ./usr/lib/libwind_g.acomp-c-debuglib debuglib,compatfile,kerberos ./usr/lib/libwrap_g.acomp-c-debuglib debuglib,compatfile ./usr/lib/liby_g.acomp-c-debuglib debuglib,compatfile
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Wed Jun 21 02:48:49 UTC 2023 Modified Files: src/distrib/sets/lists/debug: mi Log Message: Looks like this debug library disappeared with the new heimdal. Mark it obsolete to fix the MKDEBUGLIB build. To generate a diff of this commit: cvs rdiff -u -r1.404 -r1.405 src/distrib/sets/lists/debug/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Tue Jun 6 06:51:00 UTC 2023 Modified Files: src/distrib/sets/lists/debug: mi Log Message: Fix MKDEBUGLIB build by adding these installed files to the debug set list. XXX One could argue that these files are not of any use, so why install them? I don't have a good argument either way, and this is (for now) a simple work-around for PR bin/57455 Please feel free to commit a different fix to avoid installing these files at all. To generate a diff of this commit: cvs rdiff -u -r1.401 -r1.402 src/distrib/sets/lists/debug/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/mi diff -u src/distrib/sets/lists/debug/mi:1.401 src/distrib/sets/lists/debug/mi:1.402 --- src/distrib/sets/lists/debug/mi:1.401 Fri Jun 2 11:09:39 2023 +++ src/distrib/sets/lists/debug/mi Tue Jun 6 06:51:00 2023 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.401 2023/06/02 11:09:39 martin Exp $ +# $NetBSD: mi,v 1.402 2023/06/06 06:51:00 pgoyette Exp $ ./etc/mtree/set.debug comp-sys-root ./usr/lib comp-sys-usr compatdir ./usr/lib/i18n/libBIG5_g.a comp-c-debuglib debuglib,compatfile @@ -2529,4 +2529,14 @@ ./usr/libdata/debug/usr/tests/util/id/h_id.debug tests-obsolete obsolete,compattestfile ./usr/libdata/debug/usr/tests/util/systrace/h_have_systrace.debug tests-obsolete obsolete,compattestfile ./usr/tests/lib/libc/tls/libh_tls_dynamic_g.a comp-c-debuglib atf,debuglib,compattestfile +./usr/tests/libexec/ld.elf_so/libh_abuse_dynamic_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_abuse_static_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_def_dynamic_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_def_static_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_onlyctor_dynamic_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_onlydef_g.atests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_onlyuse_dynamic_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_onlyuse_static_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_use_dynamic_g.a tests-libexec-debug debug,atf,pic,compattestfile +./usr/tests/libexec/ld.elf_so/libh_use_static_g.a tests-libexec-debug debug,atf,pic,compattestfile ./var/db/obsolete/debugbase-sys-root debug
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Tue Jun 6 06:51:00 UTC 2023 Modified Files: src/distrib/sets/lists/debug: mi Log Message: Fix MKDEBUGLIB build by adding these installed files to the debug set list. XXX One could argue that these files are not of any use, so why install them? I don't have a good argument either way, and this is (for now) a simple work-around for PR bin/57455 Please feel free to commit a different fix to avoid installing these files at all. To generate a diff of this commit: cvs rdiff -u -r1.401 -r1.402 src/distrib/sets/lists/debug/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/amd64/conf
Module Name:src Committed By: pgoyette Date: Mon Jun 5 13:59:55 UTC 2023 Modified Files: src/sys/arch/amd64/conf: NOCOMPAT Log Message: Un-comment the ident line To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/arch/amd64/conf/NOCOMPAT Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/arch/amd64/conf/NOCOMPAT diff -u src/sys/arch/amd64/conf/NOCOMPAT:1.6 src/sys/arch/amd64/conf/NOCOMPAT:1.7 --- src/sys/arch/amd64/conf/NOCOMPAT:1.6 Wed Jan 20 21:38:44 2021 +++ src/sys/arch/amd64/conf/NOCOMPAT Mon Jun 5 13:59:54 2023 @@ -1,6 +1,6 @@ include "arch/amd64/conf/GENERIC" -#ident "NOCOMPAT-$Revision: 1.6 $" +ident "NOCOMPAT-$Revision: 1.7 $" no options SYSVMSG # System V-like message queues no options SYSVSEM # System V-like semaphores
CVS commit: src/sys/arch/amd64/conf
Module Name:src Committed By: pgoyette Date: Mon Jun 5 13:59:55 UTC 2023 Modified Files: src/sys/arch/amd64/conf: NOCOMPAT Log Message: Un-comment the ident line To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/arch/amd64/conf/NOCOMPAT Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Sat May 20 09:41:34 UTC 2023 Modified Files: src/sbin/chown: chgrp.1 Log Message: ALso fix chgrp Synopsis to include -d option To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sbin/chown/chgrp.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Sat May 20 09:41:34 UTC 2023 Modified Files: src/sbin/chown: chgrp.1 Log Message: ALso fix chgrp Synopsis to include -d option To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sbin/chown/chgrp.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sbin/chown/chgrp.1 diff -u src/sbin/chown/chgrp.1:1.9 src/sbin/chown/chgrp.1:1.10 --- src/sbin/chown/chgrp.1:1.9 Thu May 4 17:07:56 2023 +++ src/sbin/chown/chgrp.1 Sat May 20 09:41:34 2023 @@ -29,9 +29,9 @@ .\" SUCH DAMAGE. .\" .\" from: @(#)chgrp.1 8.3 (Berkeley) 3/31/94 -.\" $NetBSD: chgrp.1,v 1.9 2023/05/04 17:07:56 pgoyette Exp $ +.\" $NetBSD: chgrp.1,v 1.10 2023/05/20 09:41:34 pgoyette Exp $ .\" -.Dd May 1, 2023 +.Dd May 19, 2023 .Dt CHGRP 1 .Os .Sh NAME @@ -43,7 +43,7 @@ .Fl R .Op Fl H | Fl L | Fl P .Oc -.Op Fl fhv +.Op Fl dfhv .Ar group .Ar .Nm @@ -51,7 +51,7 @@ .Fl R .Op Fl H | Fl L | Fl P .Oc -.Op Fl fhv +.Op Fl dfhv .Fl Fl reference=rfile .Ar .Sh DESCRIPTION
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Sat May 20 00:54:15 UTC 2023 Modified Files: src/sbin/chown: chown.8 Log Message: dd -d to the Synopsis To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sbin/chown/chown.8 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Sat May 20 00:54:15 UTC 2023 Modified Files: src/sbin/chown: chown.8 Log Message: dd -d to the Synopsis To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sbin/chown/chown.8 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sbin/chown/chown.8 diff -u src/sbin/chown/chown.8:1.13 src/sbin/chown/chown.8:1.14 --- src/sbin/chown/chown.8:1.13 Thu May 4 17:07:56 2023 +++ src/sbin/chown/chown.8 Sat May 20 00:54:15 2023 @@ -26,9 +26,9 @@ .\" SUCH DAMAGE. .\" .\" from: @(#)chown.8 8.3 (Berkeley) 3/31/94 -.\" $NetBSD: chown.8,v 1.13 2023/05/04 17:07:56 pgoyette Exp $ +.\" $NetBSD: chown.8,v 1.14 2023/05/20 00:54:15 pgoyette Exp $ .\" -.Dd May 1, 2023 +.Dd May 19, 2023 .Dt CHOWN 8 .Os .Sh NAME @@ -40,7 +40,7 @@ .Fl R .Op Fl H | Fl L | Fl P .Oc -.Op Fl fhv +.Op Fl dfhv .Ar owner Ns Op Ar :group .Ar .Nm @@ -48,7 +48,7 @@ .Fl R .Op Fl H | Fl L | Fl P .Oc -.Op Fl fhv +.Op Fl dfhv .Ar :group .Ar .Nm @@ -56,7 +56,7 @@ .Fl R .Op Fl H | Fl L | Fl P .Oc -.Op Fl fhv +.Op Fl dfhv .Fl Fl reference=rfile .Ar .Sh DESCRIPTION
CVS commit: src/sys/dev/usb
Module Name:src Committed By: pgoyette Date: Sun May 14 23:58:35 UTC 2023 Modified Files: src/sys/dev/usb: usb_quirks.c Log Message: fix typq To generate a diff of this commit: cvs rdiff -u -r1.106 -r1.107 src/sys/dev/usb/usb_quirks.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/usb/usb_quirks.c diff -u src/sys/dev/usb/usb_quirks.c:1.106 src/sys/dev/usb/usb_quirks.c:1.107 --- src/sys/dev/usb/usb_quirks.c:1.106 Sun May 14 22:30:13 2023 +++ src/sys/dev/usb/usb_quirks.c Sun May 14 23:58:35 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: usb_quirks.c,v 1.106 2023/05/14 22:30:13 pgoyette Exp $ */ +/* $NetBSD: usb_quirks.c,v 1.107 2023/05/14 23:58:35 pgoyette Exp $ */ /* $FreeBSD: src/sys/dev/usb/usb_quirks.c,v 1.30 2003/01/02 04:15:55 imp Exp $ */ /* @@ -32,7 +32,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: usb_quirks.c,v 1.106 2023/05/14 22:30:13 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: usb_quirks.c,v 1.107 2023/05/14 23:58:35 pgoyette Exp $"); #ifdef _KERNEL_OPT #include "opt_usb.h" @@ -401,7 +401,7 @@ Static const struct usbd_quirk_entry { { UQ_ALWAYS_ON, NULL }}, { USB_VENDOR_LOGITECH, USB_PRODUCT_LOGITECH_B100, ANY, { UQ_ALWAYS_ON, NULL }}, - { USB_VENDOR_LENOVO, USB_PRODUCT_LENOVO_OPTUSBMOUSE, ANY, { UQ_ALQAYS_ON, NULL }}, + { USB_VENDOR_LENOVO, USB_PRODUCT_LENOVO_OPTUSBMOUSE, ANY, { UQ_ALWAYS_ON, NULL }}, /* * The HAILUCK USB Keyboard has a built-in touchpad, which * needs to be active for the keyboard to function properly.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: pgoyette Date: Sun May 14 23:58:35 UTC 2023 Modified Files: src/sys/dev/usb: usb_quirks.c Log Message: fix typq To generate a diff of this commit: cvs rdiff -u -r1.106 -r1.107 src/sys/dev/usb/usb_quirks.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: pgoyette Date: Sun May 14 22:38:07 UTC 2023 Modified Files: src/sys/dev/usb: usbdevs.h usbdevs_data.h Log Message: Regen To generate a diff of this commit: cvs rdiff -u -r1.799 -r1.800 src/sys/dev/usb/usbdevs.h \ src/sys/dev/usb/usbdevs_data.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/usb/usbdevs.h diff -u src/sys/dev/usb/usbdevs.h:1.799 src/sys/dev/usb/usbdevs.h:1.800 --- src/sys/dev/usb/usbdevs.h:1.799 Sat Feb 11 22:41:37 2023 +++ src/sys/dev/usb/usbdevs.h Sun May 14 22:38:07 2023 @@ -1,10 +1,10 @@ -/* $NetBSD: usbdevs.h,v 1.799 2023/02/11 22:41:37 nia Exp $ */ +/* $NetBSD: usbdevs.h,v 1.800 2023/05/14 22:38:07 pgoyette Exp $ */ /* * THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT. * * generated from: - * NetBSD: usbdevs,v 1.806 2022/06/29 19:43:04 macallan Exp + * NetBSD: usbdevs,v 1.808 2023/05/14 22:30:13 pgoyette Exp */ /*- @@ -2736,6 +2736,7 @@ /* PixArt */ #define USB_PRODUCT_PIXART_RPIMOUSE 0x2510 /* Raspberry Pi Mouse */ +#define USB_PRODUCT_LENOVO_OPTUSBMOUSE 0x600e /* Lenovo USB Optical Mouse */ /* Planex Communications products */ #define USB_PRODUCT_PLANEX_GW_US11H 0x14ea /* GW-US11H WLAN */ Index: src/sys/dev/usb/usbdevs_data.h diff -u src/sys/dev/usb/usbdevs_data.h:1.799 src/sys/dev/usb/usbdevs_data.h:1.800 --- src/sys/dev/usb/usbdevs_data.h:1.799 Sat Feb 11 22:41:37 2023 +++ src/sys/dev/usb/usbdevs_data.h Sun May 14 22:38:07 2023 @@ -1,10 +1,10 @@ -/* $NetBSD: usbdevs_data.h,v 1.799 2023/02/11 22:41:37 nia Exp $ */ +/* $NetBSD: usbdevs_data.h,v 1.800 2023/05/14 22:38:07 pgoyette Exp $ */ /* * THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT. * * generated from: - * NetBSD: usbdevs,v 1.806 2022/06/29 19:43:04 macallan Exp + * NetBSD: usbdevs,v 1.808 2023/05/14 22:30:13 pgoyette Exp */ /*- @@ -3675,6 +3675,8 @@ static const uint32_t usb_products[] = { 4633, 16338, 16352, 0, USB_VENDOR_PIXART, USB_PRODUCT_PIXART_RPIMOUSE, 16356, 16366, 6473, 0, + USB_VENDOR_LENOVO, USB_PRODUCT_LENOVO_OPTUSBMOUSE, + 4445, 4947, 3370, 6473, 0, USB_VENDOR_PLANEX, USB_PRODUCT_PLANEX_GW_US11H, 16369, 5354, 0, USB_VENDOR_PLANEX2, USB_PRODUCT_PLANEX2_RTL8188CUS, @@ -5505,7 +5507,7 @@ static const char usb_words[] = { "." "Cambridge\0" /* 1 refs @ 3349 */ "Radio\0" /* 8 refs @ 3359 */ "Trek\0" /* 1 refs @ 3365 */ - "Optical\0" /* 8 refs @ 3370 */ + "Optical\0" /* 9 refs @ 3370 */ "ShanTou\0" /* 1 refs @ 3378 */ "MediaGear\0" /* 1 refs @ 3386 */ "Broadcom\0" /* 2 refs @ 3396 */ @@ -5648,7 +5650,7 @@ static const char usb_words[] = { "." "Misc\0" /* 1 refs @ 4420 */ "Vendors\0" /* 1 refs @ 4425 */ "DisplayLink\0" /* 5 refs @ 4433 */ - "Lenovo\0" /* 3 refs @ 4445 */ + "Lenovo\0" /* 4 refs @ 4445 */ "E3C\0" /* 1 refs @ 4452 */ "Qcom\0" /* 1 refs @ 4456 */ "Meinberg\0" /* 1 refs @ 4461 */ @@ -5716,7 +5718,7 @@ static const char usb_words[] = { "." "GNU\0" /* 1 refs @ 4926 */ "USRP\0" /* 2 refs @ 4930 */ "HomeConnect\0" /* 4 refs @ 4935 */ - "USB\0" /* 211 refs @ 4947 */ + "USB\0" /* 212 refs @ 4947 */ "Bluetooth\0" /* 26 refs @ 4951 */ "Adapter\0" /* 79 refs @ 4961 */ "3C19250\0" /* 1 refs @ 4969 */ @@ -5909,7 +5911,7 @@ static const char usb_words[] = { "." "(Wellspring2/JIS)\0" /* 1 refs @ 6442 */ "mouse\0" /* 16 refs @ 6460 */ "Mighty\0" /* 2 refs @ 6466 */ - "Mouse\0" /* 17 refs @ 6473 */ + "Mouse\0" /* 18 refs @ 6473 */ "Trackpad\0" /* 3 refs @ 6479 */ "(Fountain)\0" /* 1 refs @ 6488 */ "(Geyser)\0" /* 1 refs @ 6499 */
CVS commit: src/sys/dev/usb
Module Name:src Committed By: pgoyette Date: Sun May 14 22:38:07 UTC 2023 Modified Files: src/sys/dev/usb: usbdevs.h usbdevs_data.h Log Message: Regen To generate a diff of this commit: cvs rdiff -u -r1.799 -r1.800 src/sys/dev/usb/usbdevs.h \ src/sys/dev/usb/usbdevs_data.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/usb
Module Name:src Committed By: pgoyette Date: Sun May 14 22:30:13 UTC 2023 Modified Files: src/sys/dev/usb: usb_quirks.c usbdevs Log Message: Add a Lenovo mouse so we can set the ALWAYS_ON quirk. To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106 src/sys/dev/usb/usb_quirks.c cvs rdiff -u -r1.807 -r1.808 src/sys/dev/usb/usbdevs Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/usb/usb_quirks.c diff -u src/sys/dev/usb/usb_quirks.c:1.105 src/sys/dev/usb/usb_quirks.c:1.106 --- src/sys/dev/usb/usb_quirks.c:1.105 Sun Mar 6 23:36:50 2022 +++ src/sys/dev/usb/usb_quirks.c Sun May 14 22:30:13 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: usb_quirks.c,v 1.105 2022/03/06 23:36:50 andvar Exp $ */ +/* $NetBSD: usb_quirks.c,v 1.106 2023/05/14 22:30:13 pgoyette Exp $ */ /* $FreeBSD: src/sys/dev/usb/usb_quirks.c,v 1.30 2003/01/02 04:15:55 imp Exp $ */ /* @@ -32,7 +32,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: usb_quirks.c,v 1.105 2022/03/06 23:36:50 andvar Exp $"); +__KERNEL_RCSID(0, "$NetBSD: usb_quirks.c,v 1.106 2023/05/14 22:30:13 pgoyette Exp $"); #ifdef _KERNEL_OPT #include "opt_usb.h" @@ -401,6 +401,7 @@ Static const struct usbd_quirk_entry { { UQ_ALWAYS_ON, NULL }}, { USB_VENDOR_LOGITECH, USB_PRODUCT_LOGITECH_B100, ANY, { UQ_ALWAYS_ON, NULL }}, + { USB_VENDOR_LENOVO, USB_PRODUCT_LENOVO_OPTUSBMOUSE, ANY, { UQ_ALQAYS_ON, NULL }}, /* * The HAILUCK USB Keyboard has a built-in touchpad, which * needs to be active for the keyboard to function properly. Index: src/sys/dev/usb/usbdevs diff -u src/sys/dev/usb/usbdevs:1.807 src/sys/dev/usb/usbdevs:1.808 --- src/sys/dev/usb/usbdevs:1.807 Sat Feb 11 22:41:15 2023 +++ src/sys/dev/usb/usbdevs Sun May 14 22:30:13 2023 @@ -1,4 +1,4 @@ -$NetBSD: usbdevs,v 1.807 2023/02/11 22:41:15 nia Exp $ +$NetBSD: usbdevs,v 1.808 2023/05/14 22:30:13 pgoyette Exp $ /*- * Copyright (c) 1998-2004 The NetBSD Foundation, Inc. @@ -2729,6 +2729,7 @@ product PINNACLE PCTV73E 0x0237 Pinnacle /* PixArt */ product PIXART RPIMOUSE 0x2510 Raspberry Pi Mouse +product LENOVO OPTUSBMOUSE 0x600e Lenovo USB Optical Mouse /* Planex Communications products */ product PLANEX GW_US11H 0x14ea GW-US11H WLAN
CVS commit: src/sys/dev/usb
Module Name:src Committed By: pgoyette Date: Sun May 14 22:30:13 UTC 2023 Modified Files: src/sys/dev/usb: usb_quirks.c usbdevs Log Message: Add a Lenovo mouse so we can set the ALWAYS_ON quirk. To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106 src/sys/dev/usb/usb_quirks.c cvs rdiff -u -r1.807 -r1.808 src/sys/dev/usb/usbdevs Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Thu May 4 17:07:57 UTC 2023 Modified Files: src/sbin/chown: chgrp.1 chown.8 chown.c Log Message: Add a -d flag to avoid changing a file's owner/group to the current value. This avoids some unnecessary operations on the file. As discussed on tech-userlevel@ To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sbin/chown/chgrp.1 cvs rdiff -u -r1.12 -r1.13 src/sbin/chown/chown.8 cvs rdiff -u -r1.9 -r1.10 src/sbin/chown/chown.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sbin/chown/chgrp.1 diff -u src/sbin/chown/chgrp.1:1.8 src/sbin/chown/chgrp.1:1.9 --- src/sbin/chown/chgrp.1:1.8 Tue Jul 4 06:52:20 2017 +++ src/sbin/chown/chgrp.1 Thu May 4 17:07:56 2023 @@ -29,9 +29,9 @@ .\" SUCH DAMAGE. .\" .\" from: @(#)chgrp.1 8.3 (Berkeley) 3/31/94 -.\" $NetBSD: chgrp.1,v 1.8 2017/07/04 06:52:20 wiz Exp $ +.\" $NetBSD: chgrp.1,v 1.9 2023/05/04 17:07:56 pgoyette Exp $ .\" -.Dd October 22, 2012 +.Dd May 1, 2023 .Dt CHGRP 1 .Os .Sh NAME @@ -86,6 +86,10 @@ option is specified, no symbolic links a .It Fl R Change the group ID for the file hierarchies rooted in the files instead of just the files themselves. +.It Fl d +Do not attempt to update a file's group, nor update the file's +set-user-id or set-group-id bits if they are already set to the +desired values. .It Fl f The force option ignores errors, except for usage errors and doesn't query about strange modes (unless the user does not have proper permissions). @@ -164,6 +168,8 @@ utility is expected to be POSIX 1003.2 c .Pp The .Fl v -option and the use of ``#'' to force a numeric group ID +and +.Fl d +options and the use of ``#'' to force a numeric group ID are extensions to .St -p1003.2 . Index: src/sbin/chown/chown.8 diff -u src/sbin/chown/chown.8:1.12 src/sbin/chown/chown.8:1.13 --- src/sbin/chown/chown.8:1.12 Tue Jul 4 06:53:12 2017 +++ src/sbin/chown/chown.8 Thu May 4 17:07:56 2023 @@ -26,9 +26,9 @@ .\" SUCH DAMAGE. .\" .\" from: @(#)chown.8 8.3 (Berkeley) 3/31/94 -.\" $NetBSD: chown.8,v 1.12 2017/07/04 06:53:12 wiz Exp $ +.\" $NetBSD: chown.8,v 1.13 2023/05/04 17:07:56 pgoyette Exp $ .\" -.Dd September 11, 2016 +.Dd May 1, 2023 .Dt CHOWN 8 .Os .Sh NAME @@ -84,6 +84,9 @@ option is specified, no symbolic links a .It Fl R Change the user ID and/or the group ID for the file hierarchies rooted in the files instead of just the files themselves. +.It Fl d +Do not attempt to update a file's owner or group or its set-user-id +and set-group-id bits if they are all already set to the desired values. .It Fl f Do not report any failure to change file owner or group, nor modify the exit status to reflect such failures. @@ -174,7 +177,9 @@ command is expected to be POSIX 1003.2 c .Pp The .Fl v -option and the use of ``#'' to force a numeric lookup +and +.Fl d +options and the use of ``#'' to force a numeric lookup are extensions to .St -p1003.2 . .Sh HISTORY Index: src/sbin/chown/chown.c diff -u src/sbin/chown/chown.c:1.9 src/sbin/chown/chown.c:1.10 --- src/sbin/chown/chown.c:1.9 Fri Apr 28 09:56:45 2023 +++ src/sbin/chown/chown.c Thu May 4 17:07:56 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: chown.c,v 1.9 2023/04/28 09:56:45 pgoyette Exp $ */ +/* $NetBSD: chown.c,v 1.10 2023/05/04 17:07:56 pgoyette Exp $ */ /* * Copyright (c) 1988, 1993, 1994, 2003 @@ -39,7 +39,7 @@ __COPYRIGHT("@(#) Copyright (c) 1988, 19 #if 0 static char sccsid[] = "@(#)chown.c 8.8 (Berkeley) 4/4/94"; #else -__RCSID("$NetBSD: chown.c,v 1.9 2023/04/28 09:56:45 pgoyette Exp $"); +__RCSID("$NetBSD: chown.c,v 1.10 2023/05/04 17:07:56 pgoyette Exp $"); #endif #endif /* not lint */ @@ -82,7 +82,7 @@ main(int argc, char **argv) { FTS *ftsp; FTSENT *p; - int Hflag, Lflag, Rflag, ch, fflag, fts_options, hflag, rval, vflag; + int Hflag, Lflag, Rflag, ch, fflag, fts_options, hflag, rval, vflag, dflag; char *cp, *reference; int (*change_owner)(const char *, uid_t, gid_t); @@ -94,13 +94,16 @@ main(int argc, char **argv) ischown = (myname[2] == 'o'); reference = NULL; - Hflag = Lflag = Rflag = fflag = hflag = vflag = 0; - while ((ch = getopt_long(argc, argv, "HLPRfhv", + Hflag = Lflag = Rflag = fflag = hflag = vflag = dflag = 0; + while ((ch = getopt_long(argc, argv, "HLPRdfhv", chown_longopts, NULL)) != -1) switch (ch) { case 1: reference = optarg; break; + case 'd': + dflag = 1; + break; case 'H': Hflag = 1; Lflag = 0; @@ -232,6 +235,18 @@ main(int argc, char **argv) break; } + /* + * If dflag was set, and the owner and group are already + * set to the right values and the set-user-id and + * set-group-id bits are both already clear, skip any + * attempt to update. + */ + if (dflag && + ( -1 == uid || p->fts_statp->st_uid == uid ) && + ( -1 == gid || p->fts_statp->st_gid == gid ) && + (
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Thu May 4 17:07:57 UTC 2023 Modified Files: src/sbin/chown: chgrp.1 chown.8 chown.c Log Message: Add a -d flag to avoid changing a file's owner/group to the current value. This avoids some unnecessary operations on the file. As discussed on tech-userlevel@ To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sbin/chown/chgrp.1 cvs rdiff -u -r1.12 -r1.13 src/sbin/chown/chown.8 cvs rdiff -u -r1.9 -r1.10 src/sbin/chown/chown.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Fri Apr 28 09:56:45 UTC 2023 Modified Files: src/sbin/chown: chown.c Log Message: Fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sbin/chown/chown.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sbin/chown/chown.c diff -u src/sbin/chown/chown.c:1.8 src/sbin/chown/chown.c:1.9 --- src/sbin/chown/chown.c:1.8 Wed Oct 24 01:12:51 2012 +++ src/sbin/chown/chown.c Fri Apr 28 09:56:45 2023 @@ -1,4 +1,4 @@ -/* $NetBSD: chown.c,v 1.8 2012/10/24 01:12:51 enami Exp $ */ +/* $NetBSD: chown.c,v 1.9 2023/04/28 09:56:45 pgoyette Exp $ */ /* * Copyright (c) 1988, 1993, 1994, 2003 @@ -39,7 +39,7 @@ __COPYRIGHT("@(#) Copyright (c) 1988, 19 #if 0 static char sccsid[] = "@(#)chown.c 8.8 (Berkeley) 4/4/94"; #else -__RCSID("$NetBSD: chown.c,v 1.8 2012/10/24 01:12:51 enami Exp $"); +__RCSID("$NetBSD: chown.c,v 1.9 2023/04/28 09:56:45 pgoyette Exp $"); #endif #endif /* not lint */ @@ -224,7 +224,7 @@ main(int argc, char **argv) /* * The only symlinks that end up here are ones that * don't point to anything. Note that if we are - * doing a phisycal walk, we never reach here unless + * doing a physical walk, we never reach here unless * we asked to follow explicitly. */ continue;
CVS commit: src/sbin/chown
Module Name:src Committed By: pgoyette Date: Fri Apr 28 09:56:45 UTC 2023 Modified Files: src/sbin/chown: chown.c Log Message: Fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sbin/chown/chown.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Thu Feb 16 04:58:21 UTC 2023 Modified Files: src/share/man/man9: vnfileops.9 Log Message: Add a period at the end of a sentence. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/share/man/man9/vnfileops.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/share/man/man9/vnfileops.9 diff -u src/share/man/man9/vnfileops.9:1.16 src/share/man/man9/vnfileops.9:1.17 --- src/share/man/man9/vnfileops.9:1.16 Thu Dec 2 12:54:13 2010 +++ src/share/man/man9/vnfileops.9 Thu Feb 16 04:58:21 2023 @@ -1,4 +1,4 @@ -.\" $NetBSD: vnfileops.9,v 1.16 2010/12/02 12:54:13 wiz Exp $ +.\" $NetBSD: vnfileops.9,v 1.17 2023/02/16 04:58:21 pgoyette Exp $ .\" .\" Copyright (c) 2001, 2005, 2006 The NetBSD Foundation, Inc. .\" All rights reserved. @@ -27,7 +27,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.Dd April 9, 2008 +.Dd February 16, 2023 .Dt VNFILEOPS 9 .Os .Sh NAME @@ -103,7 +103,7 @@ The file is specified by .Fa fp . The argument .Fa l -is the calling lwp +is the calling lwp. .Fn vn_ioctl simply locks the vnode and invokes the vnode operation .Xr VOP_IOCTL 9
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Thu Feb 16 04:58:21 UTC 2023 Modified Files: src/share/man/man9: vnfileops.9 Log Message: Add a period at the end of a sentence. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/share/man/man9/vnfileops.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Thu Feb 2 13:25:41 UTC 2023 Modified Files: src/share/man/man9: devsw_attach.9 Log Message: Fix markup. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/share/man/man9/devsw_attach.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/share/man/man9/devsw_attach.9 diff -u src/share/man/man9/devsw_attach.9:1.4 src/share/man/man9/devsw_attach.9:1.5 --- src/share/man/man9/devsw_attach.9:1.4 Mon Mar 28 12:33:20 2022 +++ src/share/man/man9/devsw_attach.9 Thu Feb 2 13:25:41 2023 @@ -1,4 +1,4 @@ -.\" $NetBSD: devsw_attach.9,v 1.4 2022/03/28 12:33:20 riastradh Exp $ +.\" $NetBSD: devsw_attach.9,v 1.5 2023/02/02 13:25:41 pgoyette Exp $ .\" .\" Copyright (c) 2015 The NetBSD Foundation, Inc. .\" All rights reserved. @@ -27,7 +27,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.Dd January 11, 2022 +.Dd February 2, 2023 .Dt DEVSW 9 .Os .Sh NAME @@ -133,8 +133,8 @@ should be called before a loaded device The caller must ensure that there are no open instances of the device, and that the device's .Fn d_open -function will fail, before calling. -Fn devsw_detach . +function will fail, before calling +.Fn devsw_detach . .Pp The .Fn bdevsw_lookup
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Thu Feb 2 13:25:41 UTC 2023 Modified Files: src/share/man/man9: devsw_attach.9 Log Message: Fix markup. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/share/man/man9/devsw_attach.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/sys
Module Name:src Committed By: pgoyette Date: Wed Dec 21 18:03:48 UTC 2022 Modified Files: src/sys/sys: param.h Log Message: Bump version to keep modules and kernelin sync following the creation of compat_100 stuff. Welcome to 10.99.2 To generate a diff of this commit: cvs rdiff -u -r1.723 -r1.724 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/sys/param.h diff -u src/sys/sys/param.h:1.723 src/sys/sys/param.h:1.724 --- src/sys/sys/param.h:1.723 Fri Dec 16 17:35:44 2022 +++ src/sys/sys/param.h Wed Dec 21 18:03:48 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: param.h,v 1.723 2022/12/16 17:35:44 martin Exp $ */ +/* $NetBSD: param.h,v 1.724 2022/12/21 18:03:48 pgoyette Exp $ */ /*- * Copyright (c) 1982, 1986, 1989, 1993 @@ -67,7 +67,7 @@ * 2.99.9 (299000900) */ -#define __NetBSD_Version__ 1099000100 /* NetBSD 10.99.1 */ +#define __NetBSD_Version__ 1099000200 /* NetBSD 10.99.2 */ #define __NetBSD_Prereq__(M,m,p) (M) * 1) + \ (m) * 100) + (p) * 100) <= __NetBSD_Version__)
CVS commit: src/sys/sys
Module Name:src Committed By: pgoyette Date: Wed Dec 21 18:03:48 UTC 2022 Modified Files: src/sys/sys: param.h Log Message: Bump version to keep modules and kernelin sync following the creation of compat_100 stuff. Welcome to 10.99.2 To generate a diff of this commit: cvs rdiff -u -r1.723 -r1.724 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists
Module Name:src Committed By: pgoyette Date: Tue Dec 20 04:10:11 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.ad.aarch64 module.ad.arm module.ad.mips module.md.amd64 module.md.sparc64 src/distrib/sets/lists/modules: ad.aarch64 ad.arm ad.mips md.amd64 md.sparc64 Log Message: Missed the compat_netbsd32_100 stuff in previous commit To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/distrib/sets/lists/debug/module.ad.aarch64 cvs rdiff -u -r1.2 -r1.3 src/distrib/sets/lists/debug/module.ad.arm \ src/distrib/sets/lists/debug/module.ad.mips \ src/distrib/sets/lists/debug/module.md.sparc64 cvs rdiff -u -r1.12 -r1.13 src/distrib/sets/lists/debug/module.md.amd64 cvs rdiff -u -r1.10 -r1.11 src/distrib/sets/lists/modules/ad.aarch64 cvs rdiff -u -r1.18 -r1.19 src/distrib/sets/lists/modules/ad.arm \ src/distrib/sets/lists/modules/ad.mips cvs rdiff -u -r1.98 -r1.99 src/distrib/sets/lists/modules/md.amd64 cvs rdiff -u -r1.12 -r1.13 src/distrib/sets/lists/modules/md.sparc64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/module.ad.aarch64 diff -u src/distrib/sets/lists/debug/module.ad.aarch64:1.4 src/distrib/sets/lists/debug/module.ad.aarch64:1.5 --- src/distrib/sets/lists/debug/module.ad.aarch64:1.4 Thu Nov 25 03:08:03 2021 +++ src/distrib/sets/lists/debug/module.ad.aarch64 Tue Dec 20 04:10:11 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.ad.aarch64,v 1.4 2021/11/25 03:08:03 ryo Exp $ +# $NetBSD: module.ad.aarch64,v 1.5 2022/12/20 04:10:11 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/bpfjitmodules-base-kernel kmod,sljit,debug ./usr/libdata/debug/@MODULEDIR@/bpfjit/bpfjit.kmod.debug modules-base-kernel kmod,sljit,debug ./usr/libdata/debug/@MODULEDIR@/compat_linux modules-base-kernel kmod,debug @@ -31,6 +31,8 @@ ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_80/compat_netbsd32_80.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90 modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90/compat_netbsd32_90.kmod.debug modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100 modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100/compat_netbsd32_100.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump/compat_netbsd32_coredump.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_mqueue modules-base-kernel kmod,debug Index: src/distrib/sets/lists/debug/module.ad.arm diff -u src/distrib/sets/lists/debug/module.ad.arm:1.2 src/distrib/sets/lists/debug/module.ad.arm:1.3 --- src/distrib/sets/lists/debug/module.ad.arm:1.2 Sun Nov 1 18:51:34 2020 +++ src/distrib/sets/lists/debug/module.ad.arm Tue Dec 20 04:10:11 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.ad.arm,v 1.2 2020/11/01 18:51:34 pgoyette Exp $ +# $NetBSD: module.ad.arm,v 1.3 2022/12/20 04:10:11 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32 modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32/compat_netbsd32.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_09 modules-base-kernel kmod,debug @@ -25,6 +25,8 @@ ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_80/compat_netbsd32_80.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90 modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90/compat_netbsd32_90.kmod.debug modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100 modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100/compat_netbsd32_100.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump/compat_netbsd32_coredump.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_mqueue modules-base-kernel kmod,debug Index: src/distrib/sets/lists/debug/module.ad.mips diff -u src/distrib/sets/lists/debug/module.ad.mips:1.2 src/distrib/sets/lists/debug/module.ad.mips:1.3 --- src/distrib/sets/lists/debug/module.ad.mips:1.2 Sun Nov 1 18:51:34 2020 +++ src/distrib/sets/lists/debug/module.ad.mips Tue Dec 20 04:10:11 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.ad.mips,v 1.2 2020/11/01 18:51:34 pgoyette Exp $ +# $NetBSD: module.ad.mips,v 1.3 2022/12/20 04:10:11 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32 modules-base-kernel kmod,arch64,nocompatmodules,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32/compat_netbsd32.kmod.debug modules-base-kernel
CVS commit: src/distrib/sets/lists
Module Name:src Committed By: pgoyette Date: Tue Dec 20 04:10:11 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.ad.aarch64 module.ad.arm module.ad.mips module.md.amd64 module.md.sparc64 src/distrib/sets/lists/modules: ad.aarch64 ad.arm ad.mips md.amd64 md.sparc64 Log Message: Missed the compat_netbsd32_100 stuff in previous commit To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/distrib/sets/lists/debug/module.ad.aarch64 cvs rdiff -u -r1.2 -r1.3 src/distrib/sets/lists/debug/module.ad.arm \ src/distrib/sets/lists/debug/module.ad.mips \ src/distrib/sets/lists/debug/module.md.sparc64 cvs rdiff -u -r1.12 -r1.13 src/distrib/sets/lists/debug/module.md.amd64 cvs rdiff -u -r1.10 -r1.11 src/distrib/sets/lists/modules/ad.aarch64 cvs rdiff -u -r1.18 -r1.19 src/distrib/sets/lists/modules/ad.arm \ src/distrib/sets/lists/modules/ad.mips cvs rdiff -u -r1.98 -r1.99 src/distrib/sets/lists/modules/md.amd64 cvs rdiff -u -r1.12 -r1.13 src/distrib/sets/lists/modules/md.sparc64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys
/syscalls.conf diff -u src/sys/compat/netbsd32/syscalls.conf:1.17 src/sys/compat/netbsd32/syscalls.conf:1.18 --- src/sys/compat/netbsd32/syscalls.conf:1.17 Sun Sep 22 22:59:38 2019 +++ src/sys/compat/netbsd32/syscalls.conf Mon Dec 19 23:19:51 2022 @@ -1,4 +1,4 @@ -# $NetBSD: syscalls.conf,v 1.17 2019/09/22 22:59:38 christos Exp $ +# $NetBSD: syscalls.conf,v 1.18 2022/12/19 23:19:51 pgoyette Exp $ sysnames="netbsd32_syscalls.c" sysnumhdr="netbsd32_syscall.h" @@ -6,7 +6,7 @@ syssw="netbsd32_sysent.c" sysarghdr="netbsd32_syscallargs.h" systrace="netbsd32_systrace_args.c" sysautoload="netbsd32_syscalls_autoload.c" -compatopts="compat_43 compat_09 compat_10 compat_11 compat_12 compat_13 compat_14 compat_15 compat_16 compat_20 compat_30 compat_40 compat_50 compat_60 compat_70 compat_80 compat_90" +compatopts="compat_43 compat_09 compat_10 compat_11 compat_12 compat_13 compat_14 compat_15 compat_16 compat_20 compat_30 compat_40 compat_50 compat_60 compat_70 compat_80 compat_90 compat_100" libcompatopts="" switchname="netbsd32_sysent" Index: src/sys/conf/files diff -u src/sys/conf/files:1.1304 src/sys/conf/files:1.1305 --- src/sys/conf/files:1.1304 Sat Dec 3 01:04:42 2022 +++ src/sys/conf/files Mon Dec 19 23:19:51 2022 @@ -1,4 +1,4 @@ -# $NetBSD: files,v 1.1304 2022/12/03 01:04:42 brad Exp $ +# $NetBSD: files,v 1.1305 2022/12/19 23:19:51 pgoyette Exp $ # @(#)files.newconf 7.5 (Berkeley) 5/10/93 version 20171118 @@ -149,7 +149,8 @@ defflag opt_efi.h EFI_RUNTIME # compatibility options # defflag opt_compat_netbsd.h COMPAT_NETBSD -defflag opt_compat_netbsd.h COMPAT_90: COMPAT_NETBSD +defflag opt_compat_netbsd.h COMPAT_100: COMPAT_NETBSD +defflag opt_compat_netbsd.h COMPAT_90: COMPAT_100, COMPAT_NETBSD defflag opt_compat_netbsd.h COMPAT_80: COMPAT_90, COMPAT_NETBSD defflag opt_compat_netbsd.h COMPAT_70: COMPAT_80, COMPAT_NETBSD defflag opt_compat_netbsd.h COMPAT_60: COMPAT_70, COMPAT_NETBSD Index: src/sys/modules/Makefile diff -u src/sys/modules/Makefile:1.274 src/sys/modules/Makefile:1.275 --- src/sys/modules/Makefile:1.274 Sat Dec 3 01:04:42 2022 +++ src/sys/modules/Makefile Mon Dec 19 23:19:51 2022 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.274 2022/12/03 01:04:42 brad Exp $ +# $NetBSD: Makefile,v 1.275 2022/12/19 23:19:51 pgoyette Exp $ .include @@ -10,7 +10,7 @@ SUBDIR+= compat_util SUBDIR+= compat_43 compat_sysctl_09_43 SUBDIR+= compat_09 compat_10 compat_12 compat_13 compat_14 SUBDIR+= compat_16 compat_20 compat_30 compat_40 compat_50 -SUBDIR+= compat_60 compat_70 compat_80 compat_90 +SUBDIR+= compat_60 compat_70 compat_80 compat_90 compat_100 SUBDIR+= compat_sysv_10 compat_sysv_14 compat_sysv_50 @@ -313,7 +313,7 @@ SUBDIR+= compat_netbsd32_13 compat_netbs SUBDIR+= compat_netbsd32_20 compat_netbsd32_30 SUBDIR+= compat_netbsd32_40 compat_netbsd32_50 SUBDIR+= compat_netbsd32_60 compat_netbsd32_80 -SUBDIR+= compat_netbsd32_90 +SUBDIR+= compat_netbsd32_90 compat_netbsd32_100 SUBDIR+= compat_netbsd32_43 SUBDIR+= compat_netbsd32_coredump SUBDIR+= compat_netbsd32_mqueue Added files: Index: src/sys/compat/common/compat_100_mod.c diff -u /dev/null src/sys/compat/common/compat_100_mod.c:1.1 --- /dev/null Mon Dec 19 23:19:52 2022 +++ src/sys/compat/common/compat_100_mod.c Mon Dec 19 23:19:51 2022 @@ -0,0 +1,79 @@ +/* $NetBSD: compat_100_mod.c,v 1.1 2022/12/19 23:19:51 pgoyette Exp $ */ + +/*- + * Copyright (c) 2019 The NetBSD Foundation, Inc. + * All rights reserved. + * + * This code is derived from software developed for The NetBSD Foundation + * by Paul Goyette + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS + * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED + * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY
CVS commit: src/sys
Module Name:src Committed By: pgoyette Date: Mon Dec 19 23:19:52 UTC 2022 Modified Files: src/sys/compat/common: compat_90_mod.c compat_mod.h files.common src/sys/compat/netbsd32: files.netbsd32 syscalls.conf src/sys/conf: files src/sys/modules: Makefile Added Files: src/sys/compat/common: compat_100_mod.c src/sys/compat/netbsd32: netbsd32_compat_100.c src/sys/conf: compat_netbsd100.config src/sys/modules/compat_100: Makefile src/sys/modules/compat_netbsd32_100: Makefile Log Message: Create compat_100 module infrastructure now that we have branched for NetBSD-10 To generate a diff of this commit: cvs rdiff -u -r0 -r1.1 src/sys/compat/common/compat_100_mod.c cvs rdiff -u -r1.3 -r1.4 src/sys/compat/common/compat_90_mod.c cvs rdiff -u -r1.6 -r1.7 src/sys/compat/common/compat_mod.h cvs rdiff -u -r1.7 -r1.8 src/sys/compat/common/files.common cvs rdiff -u -r1.53 -r1.54 src/sys/compat/netbsd32/files.netbsd32 cvs rdiff -u -r0 -r1.1 src/sys/compat/netbsd32/netbsd32_compat_100.c cvs rdiff -u -r1.17 -r1.18 src/sys/compat/netbsd32/syscalls.conf cvs rdiff -u -r0 -r1.1 src/sys/conf/compat_netbsd100.config cvs rdiff -u -r1.1304 -r1.1305 src/sys/conf/files cvs rdiff -u -r1.274 -r1.275 src/sys/modules/Makefile cvs rdiff -u -r0 -r1.1 src/sys/modules/compat_100/Makefile cvs rdiff -u -r0 -r1.1 src/sys/modules/compat_netbsd32_100/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/kern
On Sat, 1 Oct 2022, Robert Elz wrote: Currently fd_affix (I mistakenly made it fp_affix in the last message...) doesn't have a flags parameter, so to do it the way you suggest, we'd need to alter its signature, bump to 9.99.101 ... and add some COMPAT_09 goop for backward compability :) ... (and I haven't yet gotten around to making my kernel be 98.99.100 which I'm kind of planning to do ...) and go alter all the calls everywhere, mostly just filling in an extra arg with a 0. kre !DSPAM:63376773211686829812153! ++--+--+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+
CVS commit: src/share/misc
Module Name:src Committed By: pgoyette Date: Fri Sep 9 14:16:16 UTC 2022 Modified Files: src/share/misc: acronyms Log Message: Add YMMD To generate a diff of this commit: cvs rdiff -u -r1.312 -r1.313 src/share/misc/acronyms Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/share/misc/acronyms diff -u src/share/misc/acronyms:1.312 src/share/misc/acronyms:1.313 --- src/share/misc/acronyms:1.312 Thu Sep 16 08:33:24 2021 +++ src/share/misc/acronyms Fri Sep 9 14:16:16 2022 @@ -1,4 +1,4 @@ -$NetBSD: acronyms,v 1.312 2021/09/16 08:33:24 leot Exp $ +$NetBSD: acronyms,v 1.313 2022/09/09 14:16:16 pgoyette Exp $ 10Q thank you 10X thanks 1337 elite ("leet") @@ -651,6 +651,7 @@ YHBT you have been trolled YHL you have lost YKWIM you know what I mean YMMV your mileage may vary +YMMD you made my day YOLO you only live once YW you're welcome YWSYLS you win some, you lose some
CVS commit: src/share/misc
Module Name:src Committed By: pgoyette Date: Fri Sep 9 14:16:16 UTC 2022 Modified Files: src/share/misc: acronyms Log Message: Add YMMD To generate a diff of this commit: cvs rdiff -u -r1.312 -r1.313 src/share/misc/acronyms Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Wed Sep 7 01:18:33 UTC 2022 Modified Files: src/share/man/man9: sysctl.9 Log Message: Update to match recent changes in implementation. To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/share/man/man9/sysctl.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/share/man/man9/sysctl.9 diff -u src/share/man/man9/sysctl.9:1.23 src/share/man/man9/sysctl.9:1.24 --- src/share/man/man9/sysctl.9:1.23 Wed Aug 7 19:58:50 2019 +++ src/share/man/man9/sysctl.9 Wed Sep 7 01:18:32 2022 @@ -1,4 +1,4 @@ -.\" $NetBSD: sysctl.9,v 1.23 2019/08/07 19:58:50 wiz Exp $ +.\" $NetBSD: sysctl.9,v 1.24 2022/09/07 01:18:32 pgoyette Exp $ .\" .\" Copyright (c) 2004 The NetBSD Foundation, Inc. .\" All rights reserved. @@ -27,7 +27,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.Dd August 7, 2019 +.Dd September 6, 2022 .Dt SYSCTL 9 .Os .Sh NAME @@ -546,7 +546,8 @@ specifically ignores any arguments given to zero, and returns success. .Sh SETUP FUNCTIONS Although nodes can be added to the SYSCTL tree at any time, in order to -add nodes during the kernel bootstrap phase, a proper +add nodes during the kernel bootstrap phase (and during loadable module +initialization), a proper .Dq setup function must be used. Setup functions are declared using the @@ -565,11 +566,11 @@ The address of the function is added to traverses during initialization. For loadable kernel modules (see .Xr module 9 ) , -the list of functions is called from the module loader after the module's +the list of functions is called from the module loader before the module's initialization routine. Any sysctl nodes created for the loadable module are removed using .Fn sysctl_teardown -before calling the module's termination code. +after calling the module's termination code. .Pp Setup functions do not have to add nodes to the main tree, but can set up their own trees for emulation or other purposes.
CVS commit: src/share/man/man9
Module Name:src Committed By: pgoyette Date: Wed Sep 7 01:18:33 UTC 2022 Modified Files: src/share/man/man9: sysctl.9 Log Message: Update to match recent changes in implementation. To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/share/man/man9/sysctl.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/kern
Module Name:src Committed By: pgoyette Date: Tue Sep 6 13:31:09 UTC 2022 Modified Files: src/sys/kern: kern_module.c Log Message: Resequence the sysctl_setup and evcnt stuff so that they always occur _before_ the module's MODULE_CMD_INIT call. Also update the unload code to invoke the sysctl_setup and evcnt stuff _after_ the module's MODULE_CMD_FINI call. This makes the behaviour and order consistent whether the module is built-in or loaded at run-time. As reported by riastradh@ To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159 src/sys/kern/kern_module.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/kern
Module Name:src Committed By: pgoyette Date: Tue Sep 6 13:31:09 UTC 2022 Modified Files: src/sys/kern: kern_module.c Log Message: Resequence the sysctl_setup and evcnt stuff so that they always occur _before_ the module's MODULE_CMD_INIT call. Also update the unload code to invoke the sysctl_setup and evcnt stuff _after_ the module's MODULE_CMD_FINI call. This makes the behaviour and order consistent whether the module is built-in or loaded at run-time. As reported by riastradh@ To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159 src/sys/kern/kern_module.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/kern/kern_module.c diff -u src/sys/kern/kern_module.c:1.158 src/sys/kern/kern_module.c:1.159 --- src/sys/kern/kern_module.c:1.158 Fri Aug 12 15:17:10 2022 +++ src/sys/kern/kern_module.c Tue Sep 6 13:31:09 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: kern_module.c,v 1.158 2022/08/12 15:17:10 riastradh Exp $ */ +/* $NetBSD: kern_module.c,v 1.159 2022/09/06 13:31:09 pgoyette Exp $ */ /*- * Copyright (c) 2008 The NetBSD Foundation, Inc. @@ -34,7 +34,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: kern_module.c,v 1.158 2022/08/12 15:17:10 riastradh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: kern_module.c,v 1.159 2022/09/06 13:31:09 pgoyette Exp $"); #define _MODULE_INTERNAL @@ -1371,6 +1371,17 @@ module_do_load(const char *name, bool is prev_active = module_active; module_active = mod; + + /* + * Note that we handle sysctl and evcnt setup _before_ we + * initialize the module itself. This maintains a consistent + * order between built-in and run-time-loaded modules. If + * initialization then fails, we'll need to undo these, too. + */ + module_load_sysctl(mod); /* Set-up module's sysctl if any */ + module_load_evcnt(mod); /* Attach any static evcnt needed */ + + error = (*mi->mi_modcmd)(MODULE_CMD_INIT, filedict ? filedict : props); module_active = prev_active; if (filedict) { @@ -1380,7 +1391,7 @@ module_do_load(const char *name, bool is if (error != 0) { module_error("modcmd(CMD_INIT) failed for `%s', error %d", mi->mi_name, error); - goto fail; + goto fail3; } /* @@ -1395,9 +1406,6 @@ module_do_load(const char *name, bool is goto fail1; } - module_load_sysctl(mod); /* Set-up module's sysctl if any */ - module_load_evcnt(mod); /* Attach any static evcnt needed */ - /* * Good, the module loaded successfully. Put it onto the * list and add references to its requisite modules. @@ -1423,6 +1431,16 @@ module_do_load(const char *name, bool is fail1: (*mi->mi_modcmd)(MODULE_CMD_FINI, NULL); + fail3: + /* + * If there were any registered SYSCTL_SETUP funcs, make sure + * we release the sysctl entries + */ + if (mod->mod_sysctllog) { + sysctl_teardown(>mod_sysctllog); + } + /* Also detach any static evcnt's */ + module_unload_evcnt(mod); fail: kobj_unload(mod->mod_kobj); fail2: @@ -1478,20 +1496,22 @@ module_do_unload(const char *name, bool module_active = mod; module_callback_unload(mod); + /* let the module clean up after itself */ + error = (*mod->mod_info->mi_modcmd)(MODULE_CMD_FINI, NULL); + /* * If there were any registered SYSCTL_SETUP funcs, make sure - * we release the sysctl entries + * we release the sysctl entries. Same for static evcnt. */ - if (mod->mod_sysctllog) { - sysctl_teardown(>mod_sysctllog); + if (error == 0) { + if (mod->mod_sysctllog) { + sysctl_teardown(>mod_sysctllog); + } + module_unload_evcnt(mod); } - module_unload_evcnt(mod); - error = (*mod->mod_info->mi_modcmd)(MODULE_CMD_FINI, NULL); module_active = prev_active; if (error != 0) { - module_load_sysctl(mod); /* re-enable sysctl stuff */ - module_load_evcnt(mod); /* and reenable evcnts */ - module_print("cannot unload module `%s' error=%d", name, + module_print("could not unload module `%s' error=%d", name, error); return error; }
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Mon Aug 15 18:06:04 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Remove stray debug line (already commented out) To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/pci/nvme_pci.c diff -u src/sys/dev/pci/nvme_pci.c:1.36 src/sys/dev/pci/nvme_pci.c:1.37 --- src/sys/dev/pci/nvme_pci.c:1.36 Sat Jul 9 01:24:32 2022 +++ src/sys/dev/pci/nvme_pci.c Mon Aug 15 18:06:04 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: nvme_pci.c,v 1.36 2022/07/09 01:24:32 pgoyette Exp $ */ +/* $NetBSD: nvme_pci.c,v 1.37 2022/08/15 18:06:04 pgoyette Exp $ */ /* $OpenBSD: nvme_pci.c,v 1.3 2016/04/14 11:18:32 dlg Exp $ */ /* @@ -43,7 +43,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.36 2022/07/09 01:24:32 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.37 2022/08/15 18:06:04 pgoyette Exp $"); #include #include @@ -506,7 +506,6 @@ nvme_modcmd(modcmd_t cmd, void *opaque) error = devsw_attach(nvme_cd.cd_name, NULL, , _cdevsw, ); if (error) { - /*XXXPRG devsw_ok = false;*/ aprint_error("%s: unable to register devsw, err %d\n", nvme_cd.cd_name, error); /* do not abort, just /dev/nvme* will not work */
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Mon Aug 15 18:06:04 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Remove stray debug line (already commented out) To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.37 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Tue Aug 9 20:05:14 UTC 2022 Modified Files: src/sys/modules/ffs: Makefile src/sys/modules/ufs: Makefile Log Message: Now that UFS_DIRHASH is default for biuilt-in file system modules, we need to update the loadable module builds, too. To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/sys/modules/ffs/Makefile cvs rdiff -u -r1.7 -r1.8 src/sys/modules/ufs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules
Module Name:src Committed By: pgoyette Date: Tue Aug 9 20:05:14 UTC 2022 Modified Files: src/sys/modules/ffs: Makefile src/sys/modules/ufs: Makefile Log Message: Now that UFS_DIRHASH is default for biuilt-in file system modules, we need to update the loadable module builds, too. To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/sys/modules/ffs/Makefile cvs rdiff -u -r1.7 -r1.8 src/sys/modules/ufs/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/modules/ffs/Makefile diff -u src/sys/modules/ffs/Makefile:1.21 src/sys/modules/ffs/Makefile:1.22 --- src/sys/modules/ffs/Makefile:1.21 Sat Jan 8 01:58:16 2022 +++ src/sys/modules/ffs/Makefile Tue Aug 9 20:05:14 2022 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.21 2022/01/08 01:58:16 pgoyette Exp $ +# $NetBSD: Makefile,v 1.22 2022/08/09 20:05:14 pgoyette Exp $ .include "../Makefile.inc" @@ -6,8 +6,7 @@ KMOD= ffs CPPFLAGS+= -DFFS_EI -DWAPBL -DAPPLE_UFS -DQUOTA -DQUOTA2 -CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -#CPPFLAGS+= -DUFS_DIRHASH # disabled - suspected of corrupting memory +CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -DUFS_DIRHASH CWARNFLAGS.clang= -Wno-conversion COPTS.ffs_appleufs.c+= ${NO_ADDR_OF_PACKED_MEMBER} Index: src/sys/modules/ufs/Makefile diff -u src/sys/modules/ufs/Makefile:1.7 src/sys/modules/ufs/Makefile:1.8 --- src/sys/modules/ufs/Makefile:1.7 Sat Jan 8 02:00:49 2022 +++ src/sys/modules/ufs/Makefile Tue Aug 9 20:05:14 2022 @@ -1,12 +1,11 @@ -# $NetBSD: Makefile,v 1.7 2022/01/08 02:00:49 pgoyette Exp $ +# $NetBSD: Makefile,v 1.8 2022/08/09 20:05:14 pgoyette Exp $ .include "../Makefile.inc" KMOD= ufs CPPFLAGS+= -DFFS_EI -DWAPBL -DAPPLE_UFS -DQUOTA -DQUOTA2 -CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -#CPPFLAGS+= -DUFS_DIRHASH # disabled - suspected of corrupting memory +CPPFLAGS+= -DUFS_EXTATTR -DUFS_ACL -DUFS_DIRHASH CWARNFLAGS.clang= -Wno-conversion
Re: CVS commit: src/sys/kern
On Sun, 7 Aug 2022, Paul Goyette wrote: On Sun, 7 Aug 2022, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Sun Aug 7 21:17:18 UTC 2022 Modified Files: src/sys/kern: kern_module.c Log Message: module(9): Disable module autounload by default. I don't know why this was ever enabled by default; many modules are still not safe to unload, let alone autounload. If any autounload is to happen by default, it should only be for modules that have opted into it in some way after audit. One reason for the current behavior involves the modules used for various emulations. When a file is executed, and none of the currently-loaded modules can "deal" with it, we load _all_ of the available emulation modules with the hope that one of them will "deal with" the new executable, and with the expectation that the remaining emulation modules will just "go away". Modules that are known to be unsafe to unload should declare that in their modcmd() unload (by returning EBUSY). After all, one might well expect that the module itself is the most likely place that the unloadable status would be known. Making no-autounload as the default seems like using a 20-pound sledge hammer on a carpet tack. I might also note that making such a fundamental behavior change when we're so close to the -10 release, without actually providing the suggested "opt-in" mechanism to retain current behavior, is not very user friendly. :-) At least this should be discussed (on tech-kern@, perhaps) before being unilaterally decided and committed. IIRC, we had this discussion some time ago, and the decision at that time was to retain current behavior. Unfortunately, I didn't save any pointer to that old discussion. :-( ++------+--+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+ !DSPAM:62f0321a29502088639869! ++------+--+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+
Re: CVS commit: src/sys/kern
On Sun, 7 Aug 2022, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Sun Aug 7 21:17:18 UTC 2022 Modified Files: src/sys/kern: kern_module.c Log Message: module(9): Disable module autounload by default. I don't know why this was ever enabled by default; many modules are still not safe to unload, let alone autounload. If any autounload is to happen by default, it should only be for modules that have opted into it in some way after audit. One reason for the current behavior involves the modules used for various emulations. When a file is executed, and none of the currently-loaded modules can "deal" with it, we load _all_ of the available emulation modules with the hope that one of them will "deal with" the new executable, and with the expectation that the remaining emulation modules will just "go away". Modules that are known to be unsafe to unload should declare that in their modcmd() unload (by returning EBUSY). After all, one might well expect that the module itself is the most likely place that the unloadable status would be known. Making no-autounload as the default seems like using a 20-pound sledge hammer on a carpet tack. ++------+------+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+
CVS commit: src/distrib/amd64/installimage
Module Name:src Committed By: pgoyette Date: Sat Jul 30 00:55:38 UTC 2022 Modified Files: src/distrib/amd64/installimage: installimage.mk Log Message: The new drm modules made the image file grow again! Bump the size limit a bit. XXX Other $ARCH might also need this. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/distrib/amd64/installimage/installimage.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/amd64/installimage
Module Name:src Committed By: pgoyette Date: Sat Jul 30 00:55:38 UTC 2022 Modified Files: src/distrib/amd64/installimage: installimage.mk Log Message: The new drm modules made the image file grow again! Bump the size limit a bit. XXX Other $ARCH might also need this. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/distrib/amd64/installimage/installimage.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/amd64/installimage/installimage.mk diff -u src/distrib/amd64/installimage/installimage.mk:1.2 src/distrib/amd64/installimage/installimage.mk:1.3 --- src/distrib/amd64/installimage/installimage.mk:1.2 Sun May 22 19:32:41 2022 +++ src/distrib/amd64/installimage/installimage.mk Sat Jul 30 00:55:38 2022 @@ -1,12 +1,12 @@ -# $NetBSD: installimage.mk,v 1.2 2022/05/22 19:32:41 jmcneill Exp $ +# $NetBSD: installimage.mk,v 1.3 2022/07/30 00:55:38 pgoyette Exp $ # common code between distrib/amd64/installimage/Makefile and # distrib/amd64/installimage-bios/Makefile. .if ${USE_XZ_SETS:Uno} != "no" -INSTIMAGEMB?= 2250 # for all installation binaries +INSTIMAGEMB?= 2500 # for all installation binaries .else -INSTIMAGEMB?= 3500 # for all installation binaries +INSTIMAGEMB?= 4000 # for all installation binaries .endif PRIMARY_BOOT= bootxx_ffsv1
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Thu Jul 28 00:33:57 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 Log Message: And, we're not ready for 10.0 yet, so remove a couple premature lines! Thanks, Rin! To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/distrib/sets/lists/debug/module.md.amd64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/module.md.amd64 diff -u src/distrib/sets/lists/debug/module.md.amd64:1.9 src/distrib/sets/lists/debug/module.md.amd64:1.10 --- src/distrib/sets/lists/debug/module.md.amd64:1.9 Thu Jul 28 00:14:40 2022 +++ src/distrib/sets/lists/debug/module.md.amd64 Thu Jul 28 00:33:57 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.md.amd64,v 1.9 2022/07/28 00:14:40 pgoyette Exp $ +# $NetBSD: module.md.amd64,v 1.10 2022/07/28 00:33:57 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/acpiacadmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpiacad/acpiacad.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpibatmodules-base-kernel kmod,debug @@ -75,10 +75,6 @@ ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_80/compat_netbsd32_80.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90 modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90/compat_netbsd32_90.kmod.debug modules-base-kernel kmod,debug -./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100 modules-base-kernel kmod,debug -./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100/compat_netbsd32_100.kmod.debug modules-base-kernel kmod,debug -./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump modules-base-kernel kmod,debug -./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump/compat_netbsd32_coredump.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_mqueue modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_mqueue/compat_netbsd32_mqueue.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_nfssrv modules-base-kernel kmod,debug
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Thu Jul 28 00:33:57 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 Log Message: And, we're not ready for 10.0 yet, so remove a couple premature lines! Thanks, Rin! To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/distrib/sets/lists/debug/module.md.amd64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Thu Jul 28 00:14:40 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 Log Message: remove duplicate entry and blank line that crept in from somewhere. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/distrib/sets/lists/debug/module.md.amd64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Thu Jul 28 00:14:40 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 Log Message: remove duplicate entry and blank line that crept in from somewhere. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/distrib/sets/lists/debug/module.md.amd64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/module.md.amd64 diff -u src/distrib/sets/lists/debug/module.md.amd64:1.8 src/distrib/sets/lists/debug/module.md.amd64:1.9 --- src/distrib/sets/lists/debug/module.md.amd64:1.8 Wed Jul 27 20:34:30 2022 +++ src/distrib/sets/lists/debug/module.md.amd64 Thu Jul 28 00:14:40 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.md.amd64,v 1.8 2022/07/27 20:34:30 pgoyette Exp $ +# $NetBSD: module.md.amd64,v 1.9 2022/07/28 00:14:40 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/acpiacadmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpiacad/acpiacad.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpibatmodules-base-kernel kmod,debug @@ -29,8 +29,6 @@ ./usr/libdata/debug/@MODULEDIR@/aibs/aibs.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdgpumodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod,debug - ./usr/libdata/debug/@MODULEDIR@/amdsmn modules-base-kernel kmod,debug - ./usr/libdata/debug/@MODULEDIR@/amdsmnmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmn/amdsmn.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdtempmodules-base-kernel kmod,debug @@ -77,6 +75,8 @@ ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_80/compat_netbsd32_80.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90 modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_90/compat_netbsd32_90.kmod.debug modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100 modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_100/compat_netbsd32_100.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_coredump/compat_netbsd32_coredump.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/compat_netbsd32_mqueue modules-base-kernel kmod,debug
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Wed Jul 27 20:34:30 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 module.md.i386 Log Message: Oopppss, /usr has no `e' :) To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/distrib/sets/lists/debug/module.md.amd64 cvs rdiff -u -r1.5 -r1.6 src/distrib/sets/lists/debug/module.md.i386 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Wed Jul 27 20:34:30 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 module.md.i386 Log Message: Oopppss, /usr has no `e' :) To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/distrib/sets/lists/debug/module.md.amd64 cvs rdiff -u -r1.5 -r1.6 src/distrib/sets/lists/debug/module.md.i386 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/module.md.amd64 diff -u src/distrib/sets/lists/debug/module.md.amd64:1.7 src/distrib/sets/lists/debug/module.md.amd64:1.8 --- src/distrib/sets/lists/debug/module.md.amd64:1.7 Wed Jul 27 20:28:41 2022 +++ src/distrib/sets/lists/debug/module.md.amd64 Wed Jul 27 20:34:30 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.md.amd64,v 1.7 2022/07/27 20:28:41 pgoyette Exp $ +# $NetBSD: module.md.amd64,v 1.8 2022/07/27 20:34:30 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/acpiacadmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpiacad/acpiacad.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpibatmodules-base-kernel kmod,debug @@ -27,8 +27,8 @@ ./usr/libdata/debug/@MODULEDIR@/acpiwmi/acpiwmi.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibsmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs/aibs.kmod.debug modules-base-kernel kmod,debug -./user/libdata/debug/@MODULEDIR@/amdgpumodules-base-kernel kmod,debug -./user/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/amdgpumodules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmn modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmnmodules-base-kernel kmod,debug Index: src/distrib/sets/lists/debug/module.md.i386 diff -u src/distrib/sets/lists/debug/module.md.i386:1.5 src/distrib/sets/lists/debug/module.md.i386:1.6 --- src/distrib/sets/lists/debug/module.md.i386:1.5 Wed Jul 27 20:28:41 2022 +++ src/distrib/sets/lists/debug/module.md.i386 Wed Jul 27 20:34:30 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.md.i386,v 1.5 2022/07/27 20:28:41 pgoyette Exp $ +# $NetBSD: module.md.i386,v 1.6 2022/07/27 20:34:30 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/acpiacadmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpiacad/acpiacad.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpibatmodules-base-kernel kmod,debug @@ -27,8 +27,8 @@ ./usr/libdata/debug/@MODULEDIR@/acpiwmi/acpiwmi.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibsmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs/aibs.kmod.debug modules-base-kernel kmod,debug -./user/libdata/debug/@MODULEDIR@/amdgpumodules-base-kernel kmod,debug -./user/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/amdgpumodules-base-kernel kmod,debug +./usr/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmnmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmn/amdsmn.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdtempmodules-base-kernel kmod,debug
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Wed Jul 27 20:28:41 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 module.md.i386 Log Message: Include debug files for new amdgpu modules To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/distrib/sets/lists/debug/module.md.amd64 cvs rdiff -u -r1.4 -r1.5 src/distrib/sets/lists/debug/module.md.i386 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/debug/module.md.amd64 diff -u src/distrib/sets/lists/debug/module.md.amd64:1.6 src/distrib/sets/lists/debug/module.md.amd64:1.7 --- src/distrib/sets/lists/debug/module.md.amd64:1.6 Sat Sep 25 17:55:37 2021 +++ src/distrib/sets/lists/debug/module.md.amd64 Wed Jul 27 20:28:41 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.md.amd64,v 1.6 2021/09/25 17:55:37 maya Exp $ +# $NetBSD: module.md.amd64,v 1.7 2022/07/27 20:28:41 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/acpiacadmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpiacad/acpiacad.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpibatmodules-base-kernel kmod,debug @@ -27,6 +27,10 @@ ./usr/libdata/debug/@MODULEDIR@/acpiwmi/acpiwmi.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibsmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs/aibs.kmod.debug modules-base-kernel kmod,debug +./user/libdata/debug/@MODULEDIR@/amdgpumodules-base-kernel kmod,debug +./user/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod,debug + ./usr/libdata/debug/@MODULEDIR@/amdsmn modules-base-kernel kmod,debug + ./usr/libdata/debug/@MODULEDIR@/amdsmnmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmn/amdsmn.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdtempmodules-base-kernel kmod,debug Index: src/distrib/sets/lists/debug/module.md.i386 diff -u src/distrib/sets/lists/debug/module.md.i386:1.4 src/distrib/sets/lists/debug/module.md.i386:1.5 --- src/distrib/sets/lists/debug/module.md.i386:1.4 Sat Sep 25 17:55:37 2021 +++ src/distrib/sets/lists/debug/module.md.i386 Wed Jul 27 20:28:41 2022 @@ -1,4 +1,4 @@ -# $NetBSD: module.md.i386,v 1.4 2021/09/25 17:55:37 maya Exp $ +# $NetBSD: module.md.i386,v 1.5 2022/07/27 20:28:41 pgoyette Exp $ ./usr/libdata/debug/@MODULEDIR@/acpiacadmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpiacad/acpiacad.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/acpibatmodules-base-kernel kmod,debug @@ -27,6 +27,8 @@ ./usr/libdata/debug/@MODULEDIR@/acpiwmi/acpiwmi.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibsmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs/aibs.kmod.debug modules-base-kernel kmod,debug +./user/libdata/debug/@MODULEDIR@/amdgpumodules-base-kernel kmod,debug +./user/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmnmodules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmn/amdsmn.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdtempmodules-base-kernel kmod,debug
CVS commit: src/distrib/sets/lists/debug
Module Name:src Committed By: pgoyette Date: Wed Jul 27 20:28:41 UTC 2022 Modified Files: src/distrib/sets/lists/debug: module.md.amd64 module.md.i386 Log Message: Include debug files for new amdgpu modules To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/distrib/sets/lists/debug/module.md.amd64 cvs rdiff -u -r1.4 -r1.5 src/distrib/sets/lists/debug/module.md.i386 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
On Wed, 27 Jul 2022, Paul Goyette wrote: If you're going to add new modules, please also update the debug-module sets info! :) The following should work (watch out for spaces-vs-tabs) Index: module.md.i386 === RCS file: /cvsroot/src/distrib/sets/lists/debug/module.md.i386,v retrieving revision 1.4 diff -u -p -r1.4 module.md.i386 --- module.md.i386 25 Sep 2021 17:55:37 - 1.4 +++ module.md.i386 27 Jul 2022 19:51:40 - @@ -27,6 +27,8 @@ ./usr/libdata/debug/@MODULEDIR@/acpiwmi/acpiwmi.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs/aibs.kmod.debug modules-base-kernel kmod,debug +./user/libdata/debug/@MODULEDIR@/amdgpu modules-base-kernel kmod +./user/libdata/debug/@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod ./usr/libdata/debug/@MODULEDIR@/amdsmn modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmn/amdsmn.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdtemp modules-base-kernel kmod,debug Index: module.md.amd64 === RCS file: /cvsroot/src/distrib/sets/lists/debug/module.md.amd64,v retrieving revision 1.6 diff -u -p -r1.6 module.md.amd64 --- module.md.amd64 25 Sep 2021 17:55:37 - 1.6 +++ module.md.amd64 27 Jul 2022 19:51:40 - @@ -27,6 +27,8 @@ ./usr/libdata/debug/@MODULEDIR@/acpiwmi/acpiwmi.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/aibs/aibs.kmod.debug modules-base-kernel kmod,debug +./user/libdata/debug/@MODULEDIR@/amdgpu modules-base-kernel kmod +.user/libdata/debug//@MODULEDIR@/amdgpu/amdgpu.kmod.debug modules-base-kernel kmod ./usr/libdata/debug/@MODULEDIR@/amdsmn modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdsmn/amdsmn.kmod.debug modules-base-kernel kmod,debug ./usr/libdata/debug/@MODULEDIR@/amdtemp modules-base-kernel kmod,debug @@ -163,6 +165,10 @@ On Wed, 27 Jul 2022, Maya Rashish wrote: Module Name:src Committed By: maya Date: Wed Jul 27 18:29:35 UTC 2022 Modified Files: src/distrib/sets/lists/modules: md.amd64 md.i386 src/share/mk: bsd.own.mk src/sys/modules: Makefile Log Message: Enable amdgpu module & firmware on x86 Make it easier to test this one out, add `load amdgpu` before boot netbsd. XXX there should probably be a drm block in sys/modules/Makefile which includes aarch64. To generate a diff of this commit: cvs rdiff -u -r1.93 -r1.94 src/distrib/sets/lists/modules/md.amd64 cvs rdiff -u -r1.91 -r1.92 src/distrib/sets/lists/modules/md.i386 cvs rdiff -u -r1.1286 -r1.1287 src/share/mk/bsd.own.mk cvs rdiff -u -r1.267 -r1.268 src/sys/modules/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. ++--+--+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+ !DSPAM:62e18f4e100851469358365! ++--+--+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+
Re: CVS commit: src
If you're going to add new modules, please also update the debug-module sets info! :) On Wed, 27 Jul 2022, Maya Rashish wrote: Module Name:src Committed By: maya Date: Wed Jul 27 18:29:35 UTC 2022 Modified Files: src/distrib/sets/lists/modules: md.amd64 md.i386 src/share/mk: bsd.own.mk src/sys/modules: Makefile Log Message: Enable amdgpu module & firmware on x86 Make it easier to test this one out, add `load amdgpu` before boot netbsd. XXX there should probably be a drm block in sys/modules/Makefile which includes aarch64. To generate a diff of this commit: cvs rdiff -u -r1.93 -r1.94 src/distrib/sets/lists/modules/md.amd64 cvs rdiff -u -r1.91 -r1.92 src/distrib/sets/lists/modules/md.i386 cvs rdiff -u -r1.1286 -r1.1287 src/share/mk/bsd.own.mk cvs rdiff -u -r1.267 -r1.268 src/sys/modules/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. !DSPAM:62e1843519657999028606! ++--+--+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+
CVS commit: src/share/man/man7
Module Name:src Committed By: pgoyette Date: Mon Jul 25 14:46:53 UTC 2022 Modified Files: src/share/man/man7: sysctl.7 Log Message: kern.maxvnodes _can_ be lowered, but not below the number of currently active vnodes. To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/share/man/man7/sysctl.7 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/share/man/man7/sysctl.7 diff -u src/share/man/man7/sysctl.7:1.156 src/share/man/man7/sysctl.7:1.157 --- src/share/man/man7/sysctl.7:1.156 Sun Dec 5 07:35:17 2021 +++ src/share/man/man7/sysctl.7 Mon Jul 25 14:46:53 2022 @@ -1,4 +1,4 @@ -.\" $NetBSD: sysctl.7,v 1.156 2021/12/05 07:35:17 msaitoh Exp $ +.\" $NetBSD: sysctl.7,v 1.157 2022/07/25 14:46:53 pgoyette Exp $ .\" .\" Copyright (c) 1993 .\" The Regents of the University of California. All rights reserved. @@ -29,7 +29,7 @@ .\" .\" @(#)sysctl.3 8.4 (Berkeley) 5/9/95 .\" -.Dd December 5, 2021 +.Dd July 25, 2022 .Dt SYSCTL 7 .Os .Sh NAME @@ -778,7 +778,7 @@ See also .Xr pty 4 . .It Li kern.maxvnodes ( Dv KERN_MAXVNODES ) The maximum number of vnodes available on the system. -This can only be raised. +This cannot be lowered below the number of currently active vnodes. .It Li kern.mbuf ( Dv KERN_MBUF ) Return information about the mbuf control variables. Mbufs are data structures which store network packets and other data
CVS commit: src/share/man/man7
Module Name:src Committed By: pgoyette Date: Mon Jul 25 14:46:53 UTC 2022 Modified Files: src/share/man/man7: sysctl.7 Log Message: kern.maxvnodes _can_ be lowered, but not below the number of currently active vnodes. To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/share/man/man7/sysctl.7 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Sat Jul 9 01:24:32 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Remove redundant ``devsw_ok = false;'' Thanks mrg@ To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/pci/nvme_pci.c diff -u src/sys/dev/pci/nvme_pci.c:1.35 src/sys/dev/pci/nvme_pci.c:1.36 --- src/sys/dev/pci/nvme_pci.c:1.35 Fri Jul 8 17:32:19 2022 +++ src/sys/dev/pci/nvme_pci.c Sat Jul 9 01:24:32 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: nvme_pci.c,v 1.35 2022/07/08 17:32:19 pgoyette Exp $ */ +/* $NetBSD: nvme_pci.c,v 1.36 2022/07/09 01:24:32 pgoyette Exp $ */ /* $OpenBSD: nvme_pci.c,v 1.3 2016/04/14 11:18:32 dlg Exp $ */ /* @@ -43,7 +43,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.35 2022/07/08 17:32:19 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.36 2022/07/09 01:24:32 pgoyette Exp $"); #include #include @@ -506,7 +506,7 @@ nvme_modcmd(modcmd_t cmd, void *opaque) error = devsw_attach(nvme_cd.cd_name, NULL, , _cdevsw, ); if (error) { - devsw_ok = false; + /*XXXPRG devsw_ok = false;*/ aprint_error("%s: unable to register devsw, err %d\n", nvme_cd.cd_name, error); /* do not abort, just /dev/nvme* will not work */
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Sat Jul 9 01:24:32 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Remove redundant ``devsw_ok = false;'' Thanks mrg@ To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
re: CVS commit: src/sys/dev/pci
On Sat, 9 Jul 2022, matthew green wrote: "Paul Goyette" writes: Module Name:src Committed By: pgoyette Date: Fri Jul 8 17:32:19 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: devsw_ok needs to survive across invocations of nvme_modcmd() so allocate it statically. Should address remaining issues with kern/56914 if (error) { + devsw_ok = false; shouldn't devsw_ok be "false" here already? seems more like something to ASSERT() than assign. Yeah, this is likely unnecessary now. It got there during a debug iteration. I will remove. ++--+------+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Fri Jul 8 17:32:19 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: devsw_ok needs to survive across invocations of nvme_modcmd() so allocate it statically. Should address remaining issues with kern/56914 To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Fri Jul 8 17:32:19 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: devsw_ok needs to survive across invocations of nvme_modcmd() so allocate it statically. Should address remaining issues with kern/56914 To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/pci/nvme_pci.c diff -u src/sys/dev/pci/nvme_pci.c:1.34 src/sys/dev/pci/nvme_pci.c:1.35 --- src/sys/dev/pci/nvme_pci.c:1.34 Fri Jul 8 16:10:34 2022 +++ src/sys/dev/pci/nvme_pci.c Fri Jul 8 17:32:19 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: nvme_pci.c,v 1.34 2022/07/08 16:10:34 pgoyette Exp $ */ +/* $NetBSD: nvme_pci.c,v 1.35 2022/07/08 17:32:19 pgoyette Exp $ */ /* $OpenBSD: nvme_pci.c,v 1.3 2016/04/14 11:18:32 dlg Exp $ */ /* @@ -43,7 +43,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.34 2022/07/08 16:10:34 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.35 2022/07/08 17:32:19 pgoyette Exp $"); #include #include @@ -495,7 +495,7 @@ nvme_modcmd(modcmd_t cmd, void *opaque) #ifdef _MODULE devmajor_t cmajor, bmajor; extern const struct cdevsw nvme_cdevsw; - bool devsw_ok = false; + static bool devsw_ok; #endif int error = 0; @@ -506,6 +506,7 @@ nvme_modcmd(modcmd_t cmd, void *opaque) error = devsw_attach(nvme_cd.cd_name, NULL, , _cdevsw, ); if (error) { + devsw_ok = false; aprint_error("%s: unable to register devsw, err %d\n", nvme_cd.cd_name, error); /* do not abort, just /dev/nvme* will not work */ @@ -516,16 +517,20 @@ nvme_modcmd(modcmd_t cmd, void *opaque) error = config_init_component(cfdriver_ioconf_nvme_pci, cfattach_ioconf_nvme_pci, cfdata_ioconf_nvme_pci); if (error) { - if (devsw_ok) + if (devsw_ok) { devsw_detach(NULL, _cdevsw); +devsw_ok = false; + } break; } break; case MODULE_CMD_FINI: error = config_fini_component(cfdriver_ioconf_nvme_pci, cfattach_ioconf_nvme_pci, cfdata_ioconf_nvme_pci); - if (devsw_ok) + if (devsw_ok) { devsw_detach(NULL, _cdevsw); + devsw_ok = false; + } break; default: break;
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Fri Jul 8 16:10:34 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Initialize cmajor & bmajor so the devsw_attach() has a chance of succeeding. Record the success of devsw_attach(), and do not try later to devsw_detach() unless the attach succeeded. Partial fix for kern/56914 To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/pci/nvme_pci.c diff -u src/sys/dev/pci/nvme_pci.c:1.33 src/sys/dev/pci/nvme_pci.c:1.34 --- src/sys/dev/pci/nvme_pci.c:1.33 Thu Jul 7 23:54:17 2022 +++ src/sys/dev/pci/nvme_pci.c Fri Jul 8 16:10:34 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: nvme_pci.c,v 1.33 2022/07/07 23:54:17 pgoyette Exp $ */ +/* $NetBSD: nvme_pci.c,v 1.34 2022/07/08 16:10:34 pgoyette Exp $ */ /* $OpenBSD: nvme_pci.c,v 1.3 2016/04/14 11:18:32 dlg Exp $ */ /* @@ -43,7 +43,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.33 2022/07/07 23:54:17 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.34 2022/07/08 16:10:34 pgoyette Exp $"); #include #include @@ -495,12 +495,14 @@ nvme_modcmd(modcmd_t cmd, void *opaque) #ifdef _MODULE devmajor_t cmajor, bmajor; extern const struct cdevsw nvme_cdevsw; + bool devsw_ok = false; #endif int error = 0; #ifdef _MODULE switch (cmd) { case MODULE_CMD_INIT: + bmajor = cmajor = NODEVMAJOR; error = devsw_attach(nvme_cd.cd_name, NULL, , _cdevsw, ); if (error) { @@ -508,18 +510,22 @@ nvme_modcmd(modcmd_t cmd, void *opaque) nvme_cd.cd_name, error); /* do not abort, just /dev/nvme* will not work */ } + else + devsw_ok = true; + error = config_init_component(cfdriver_ioconf_nvme_pci, cfattach_ioconf_nvme_pci, cfdata_ioconf_nvme_pci); if (error) { - devsw_detach(NULL, _cdevsw); + if (devsw_ok) +devsw_detach(NULL, _cdevsw); break; } - bmajor = cmajor = NODEVMAJOR; break; case MODULE_CMD_FINI: error = config_fini_component(cfdriver_ioconf_nvme_pci, cfattach_ioconf_nvme_pci, cfdata_ioconf_nvme_pci); - devsw_detach(NULL, _cdevsw); + if (devsw_ok) + devsw_detach(NULL, _cdevsw); break; default: break;
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Fri Jul 8 16:10:34 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Initialize cmajor & bmajor so the devsw_attach() has a chance of succeeding. Record the success of devsw_attach(), and do not try later to devsw_detach() unless the attach succeeded. Partial fix for kern/56914 To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Thu Jul 7 23:54:17 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Add errno tto message when fail to attach the devsw To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/dev/pci/nvme_pci.c diff -u src/sys/dev/pci/nvme_pci.c:1.32 src/sys/dev/pci/nvme_pci.c:1.33 --- src/sys/dev/pci/nvme_pci.c:1.32 Thu Mar 31 19:30:16 2022 +++ src/sys/dev/pci/nvme_pci.c Thu Jul 7 23:54:17 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: nvme_pci.c,v 1.32 2022/03/31 19:30:16 pgoyette Exp $ */ +/* $NetBSD: nvme_pci.c,v 1.33 2022/07/07 23:54:17 pgoyette Exp $ */ /* $OpenBSD: nvme_pci.c,v 1.3 2016/04/14 11:18:32 dlg Exp $ */ /* @@ -43,7 +43,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.32 2022/03/31 19:30:16 pgoyette Exp $"); +__KERNEL_RCSID(0, "$NetBSD: nvme_pci.c,v 1.33 2022/07/07 23:54:17 pgoyette Exp $"); #include #include @@ -504,8 +504,8 @@ nvme_modcmd(modcmd_t cmd, void *opaque) error = devsw_attach(nvme_cd.cd_name, NULL, , _cdevsw, ); if (error) { - aprint_error("%s: unable to register devsw\n", - nvme_cd.cd_name); + aprint_error("%s: unable to register devsw, err %d\n", + nvme_cd.cd_name, error); /* do not abort, just /dev/nvme* will not work */ } error = config_init_component(cfdriver_ioconf_nvme_pci,
CVS commit: src/sys/dev/pci
Module Name:src Committed By: pgoyette Date: Thu Jul 7 23:54:17 UTC 2022 Modified Files: src/sys/dev/pci: nvme_pci.c Log Message: Add errno tto message when fail to attach the devsw To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/sys/dev/pci/nvme_pci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.