Re: Patch for the getpwnam_auth helper

2006-07-30 Thread Henrik Nordstrom
mån 2006-07-03 klockan 21:33 -0300 skrev Giancarlo Razzolini:

> Here it is. Please send any comments, critics or suggestions. Did the
> patch against the getpwnam.c from 2.6.STABLE1. Also i've started today
> writing the documentation for it.

Applied to Squid-3.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel


Re: Any takers on Bug #1703? (diskd stuck at 100% CPU)

2006-07-30 Thread Henrik Nordstrom
sön 2006-07-30 klockan 23:55 +0200 skrev Henrik Nordstrom:

> Thinking. Why are we using sysv ipc for diskd? Why not the normal ipc
> channel created by ipcCreate? But we should at least monitor it for
> close...

monitor part done..

still a bit doubtful if sysv ipc really is good here, or if we would be
better off switching to using a normal STREAM IPC like for most other
helpers. (a DGRAM IPC channel could also work, but delivery is not
guaranteed on all platforms)

One benefit of switching to using a normal IPC channel is that the need
for comm_quick_poll_required() would go away, also getting rid of the
related 400KB/s cache hits issue under low loads.. (4KB reads, 10ms poll
interval)

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel


Re: Any takers on Bug #1703? (diskd stuck at 100% CPU)

2006-07-30 Thread Henrik Nordstrom
sön 2006-07-30 klockan 09:56 +0200 skrev Guido Serassio:

> 2006/07/26 16:52:21| ipcCreate: /usr/lib/squid/diskd_daemon: (2) No 
> such file or directory

A quite large but nonintrusive patch applied to detect this early,
refusing to start at all.

> The problem seems to be into ipcCreate():

Yes and no.

Helpers existence are supposed to be verified early in the startup to
alert on stupid errors. But ipcCreate() could do better..

> Currently only the child can know if the program to be launched exist.
> What about about to add a check of the existence of the program before fork() 
> ?

Did a similar thing like you proposed in the patch, but as a fatal
error.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel


Re: ntlm_auth Negotiate support

2006-07-30 Thread Andrew Bartlett
On Sun, 2006-07-30 at 21:03 +0200, Guido Serassio wrote:
> Hi Andrew,
> 
> I have a question for the Samba team.
> 
> The current STABLE Squid version (2.6) supports the Negotiate 
> authentication schema, but for now it can be used only when running 
> on native Windows, because Samba 3 ntlm_auth doesn't provide such support.
> 
> There is any expectation about adding this support to Samba 3, or we 
> need to long wait for Samba 4 ?
> 
> They are already many requests about from Squid users.

Actually, the Samba3 code may well work, if it can read the keytab or
secrets.tdb.

Andrew Bartlett

-- 
Andrew Bartletthttp://samba.org/~abartlet/
Authentication Developer, Samba Team   http://samba.org
Samba Developer, Red Hat Inc.  http://redhat.com


signature.asc
Description: This is a digitally signed message part


Re: COSS Crash + WCCP while rebuilding

2006-07-30 Thread Henrik Nordstrom
tor 2006-07-27 klockan 16:00 +0800 skrev Steven Wilton:

> The first is a config option for wccp2 to make squid wait until all
> cache_dirs have finished rebuilding before squid will register itself with
> WCCP.  This will allow the rebuild to happen quickly, and avoid slow web
> requests while the cache rebuilds.

Applied.

> The second is a trivial patch to the storeSwapMetaUnpack() function to make
> it initialise a variable.  This was causing crashes with COSS when the first
> object in the buffer was broken.

Got applied a few days ago as Bug #1685

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel


Re: How test HTCP ?

2006-07-30 Thread Henrik Nordstrom
sön 2006-07-30 klockan 19:12 +0200 skrev Guido Serassio:

> Any suggestion on the peering setup ?,  excluding the "htcp" option ... :-)

Nothing else particular I can think of..

> >The CLR support need a HTCP client. Unfortunately we don't have any..
> >Perhaps one should be written for HTCP and ICP.
> 
> Yes, something like squidclient.

Actually shouldn't be hard to extend squidclient I think.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel


Re: Any takers on Bug #1703? (diskd stuck at 100% CPU)

2006-07-30 Thread Henrik Nordstrom
sön 2006-07-30 klockan 09:56 +0200 skrev Guido Serassio:

> I think that likely you have found the problem
>
> look the log attached 
> to this Squid bug on Debian opened by the same people:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=380020
> 
> 2006/07/26 16:52:21| ipcCreate: /usr/lib/squid/diskd_daemon: (2) No 
> such file or directory

Ah, explains a bit...

> The problem seems to be into ipcCreate():
> Currently only the child can know if the program to be launched exist.
> What about about to add a check of the existence of the program before fork() 
> ?

Thinking. Why are we using sysv ipc for diskd? Why not the normal ipc
channel created by ipcCreate? But we should at least monitor it for
close...

The path check already exists for other directives.
requirePathnameExists(). 

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel


ntlm_auth Negotiate support

2006-07-30 Thread Guido Serassio

Hi Andrew,

I have a question for the Samba team.

The current STABLE Squid version (2.6) supports the Negotiate 
authentication schema, but for now it can be used only when running 
on native Windows, because Samba 3 ntlm_auth doesn't provide such support.


There is any expectation about adding this support to Samba 3, or we 
need to long wait for Samba 4 ?


They are already many requests about from Squid users.

Regards

Guido



-

Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1   10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135  Fax. : +39.011.9781115
Email: [EMAIL PROTECTED]
WWW: http://www.acmeconsulting.it/



Re: How test HTCP ?

2006-07-30 Thread Guido Serassio

Hi Henrik,

At 17.58 30/07/2006, Henrik Nordstrom wrote:


lör 2006-07-29 klockan 19:45 +0200 skrev Guido Serassio:

> I want to test the forward port of HTCP changes from 2.6 to 3.0, but
> I don't know how to check al the HTCP functionality.

Most of the code is tested by peering with 2.5 and 2.6 in both
directions.


Any suggestion on the peering setup ?,  excluding the "htcp" option ... :-)


The CLR support need a HTCP client. Unfortunately we don't have any..
Perhaps one should be written for HTCP and ICP.


Yes, something like squidclient.

Regards

Guido



-

Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1   10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135  Fax. : +39.011.9781115
Email: [EMAIL PROTECTED]
WWW: http://www.acmeconsulting.it/



Re: How test HTCP ?

2006-07-30 Thread Henrik Nordstrom
lör 2006-07-29 klockan 19:45 +0200 skrev Guido Serassio:

> I want to test the forward port of HTCP changes from 2.6 to 3.0, but 
> I don't know how to check al the HTCP functionality.

Most of the code is tested by peering with 2.5 and 2.6 in both
directions.

The CLR support need a HTCP client. Unfortunately we don't have any..
Perhaps one should be written for HTCP and ICP.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel


Re: Patch for squid short expiration time

2006-07-30 Thread Guido Serassio

Hi,

At 12.26 30/07/2006, Michael Pye wrote:


Henrik Nordstrom wrote:

I am not very fond of the format. Would prefer
refresh_pattern min [unit] pct max [unit]


I was about to have a bash at this using strsep instead of strtok to 
parse the refresh_pattern as strsep allows you to test the next 
token as well as the current token. This way you can check for 
optional tokens like the units will be. strsep however is not as 
portable as strtok, it's not in solaris for example, so we would 
need to include a test for strsep and provide it if there is no 
system version. Does this seem reasonable ?


An own strsep() used when there is no system version is already 
available in Squid 2.6 and Squid 3.0, so don't worry about it.


Regards

Guido



-

Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1   10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135  Fax. : +39.011.9781115
Email: [EMAIL PROTECTED]
WWW: http://www.acmeconsulting.it/



Re: Patch for squid short expiration time

2006-07-30 Thread Michael Pye

Henrik Nordstrom wrote:

I am not very fond of the format. Would prefer

refresh_pattern min [unit] pct max [unit]


I was about to have a bash at this using strsep instead of strtok to 
parse the refresh_pattern as strsep allows you to test the next token as 
well as the current token. This way you can check for optional tokens 
like the units will be. strsep however is not as portable as strtok, 
it's not in solaris for example, so we would need to include a test for 
strsep and provide it if there is no system version. Does this seem 
reasonable ?


The code for calculating the seconds based on unit size is already in 
cache_cf.c function parseTimeUnits, so this bit should be fairly 
straight forward.


--
Michael


Re: Any takers on Bug #1703? (diskd stuck at 100% CPU)

2006-07-30 Thread Guido Serassio

Hi Steven,

At 07.21 30/07/2006, Steven wrote:


I have just found another bug.   I have ended up in the situation where
squid has not stared the diskd processes (because the binary is called
diskd-daemon not diskd_daemon).  Squid is not serving any web pages,
and will not stop because of this, but is is stuck in a loop doing the
following:

epoll_wait(3, {}, 256, 10)  = 0
gettimeofday({1154236711, 528040}, NULL) = 0
msgrcv(1409029, {0,
"\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"...}, 32, 0,
IPC_NOWAIT) = -1 ENOMSG (No message of desired type)
epoll_wait(3, {}, 256, 10)  = 0


I think that likely you have found the problem, look the log attached 
to this Squid bug on Debian opened by the same people:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=380020

2006/07/26 16:52:21| ipcCreate: /usr/lib/squid/diskd_daemon: (2) No 
such file or directory


The problem seems to be into ipcCreate():
Currently only the child can know if the program to be launched exist.
What about about to add a check of the existence of the program before fork() ?

Regards

Guido



-

Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1   10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135  Fax. : +39.011.9781115
Email: [EMAIL PROTECTED]
WWW: http://www.acmeconsulting.it/